- 04 Sep, 2020 38 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/66d4faca55b5..bef95be956d4 2020-09-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5fa575852a99ee3e63c82f0e05db09f52b784a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393134Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804516}
-
Hazem Ashmawy authored
Add basic UI espresso tests to make sure the correct UI elements and info are shown for different crash reports status. Fixed: 1106312 Test: run_webview_instrumentation_test_apk -f "*android_webview.devui*" Change-Id: Idf16e513133db7592887f2b881b1ffefe3792b43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376805 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#804515}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599134104-920143836f5d72550f74eec8979ce216d37b0d87.profdata to chrome-win64-master-1599155892-1c7afa3c86090c53f24aedb3e14a5f3170b93aea.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I5d9cba8e96801402738e1d72ab23bcecc1325b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393139Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I2f067b3b5ca733b26ea355cad8ae110e28e9f705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393516Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804513}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/53c397b6..9eb24f89 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9bb0ccced79f343a1b247b3942a9bc8a48f22353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391983Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804512}
-
Angela Yoeurng authored
Previously, stepping backwards into keyword mode was not supported. This meant that we were always on the "correct" suggestion before trying to enter keyword mode. This crash happens when we try to enter keyword mode before updating the selected line, so there would be no keyword associated with the selected line, causing a segfault or a check to fail. Changing the accept/clear/setselection order fixed the crash, but revealed some problems with the KEYWORD_MODE/FOCUSED_BUTTON_KEYWORD focus distinctions. These were combined into a singular KEYWORD_MODE state. Bug: 1122158 Change-Id: Ib346087e2ebe333c352de6c901ba8662597c849f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389160Reviewed-by:
Orin Jaworski <orinj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Cr-Commit-Position: refs/heads/master@{#804511}
-
Mike Dougherty authored
Navigator.share should not be added if the browser doesn't support it. Bug: 1122059 Change-Id: I1f768ca5013bed212d6f24afdab44926f3e3042e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391653 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#804510}
-
Matt Wolenetz authored
Before this change, the MSE SourceBuffer's coded frame eviction algorithm (run during the synchronous portion of appendBuffer() as part of the Prepare Append Algorithm) returned early without evicting anything if the media element had not yet reached HAVE_METADATA. In MSE, the only way for the media element to have reached HAVE_METADATA (at least in Chromium) is for all of the SourceBuffers currently in the MediaSource to have all had enough data appended to each of them such that at least one initialization segment each has been successfully processed. This has two problems: 1) It relies upon external state unnecessarily: the SourceBuffer knows if it has potentially buffered media frames already beyond the first init segment if its |first_initialization_segment_received_| flag is true. A (good) side effect of switching to using this flag instead of consulting the media element is a simplification of the dependency upon media element state in the current MSE-in-Workers feature work that is clarifying such dependencies into the MediaSourceAttachment interface. 2) Making eviction a noop when there is at least one other SourceBuffer that has not yet received an initialization segment lets an app append potentially too much without having to handle the pushback of a quota-exceeded-error earlier, limiting the effectiveness of MSE's automatic garbage collection of coded frames, especially when device memory is constrained. This change switches from using MediaElement.readyState < HAVE_METADATA to instead using !first_initialization_segment_received_ as the condition which would allow skipping coded frame eviction during an appendBuffer(). Note: This condition was always intended as a runtime performance optimization, and is part of the implementation area that is allowed flexibility by the MSE specification. BUG=878133 Change-Id: I1173fbdf8aec5e4521b0f73049aeeb7c56ab7ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393356Reviewed-by:
Will Cassella <cassew@google.com> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#804509}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599155892-629b4d0dfe6acef6eef58d4607669a58bfb33fb6.profdata to chrome-mac-master-1599177512-b01388e3af00195f29af1f849ccfb9a29d0804ad.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic4ff23a7d189c89961ca39da86377c91d4eb0a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393378Reviewed-by:
-
Daniel Hosseinian authored
FPDF_GetPageSizeByIndexF() is encouraged over the older FPDF_GetPageSizeByIndex(), which is will be deprecated in the future. Meanwhile, clean some surrounding code. Change-Id: Id315c67bec5361f23225e49a0fd1438fbcb92428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392947 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#804507}
-
Charlene Yan authored
Horizontal Scroll bar visibility is currently coupled with its functionality. Bug: 1122214 Change-Id: I9a0c3ffb0e7128c4444b175631b7cbaf2411f7af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393257 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#804506}
-
Evan Stade authored
The ui_utils_java target is not a suitable place for this code because it needs to use WindowAndroid instead of Context (for WebLayer's sake), and ui_utils_java can't depend on WindowAndroid. This glue code is moved to org.chromium.content_public.browser. Bug: 1117536,1016938 Change-Id: Ic18275e2f0eca0739b850418af6c71d2079c6da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380343Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#804505}
-
Devlin Cronin authored
Introduce a LegacyExtensionMessageBubbleViewBrowserTest class that disables the Extensions Menu UI. This allows us to migrate these tests to the new UI in a piecemeal fashion. This CL only introduces the class and makes all existing tests use it; follow-ups will migrate specific tests to run with the new UI. Bug: 1100412 Change-Id: I180ac73740a3576b467521d4b40d9ab4ec0cb9d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392748 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Daniel Hosseinian authored
FPDF_GetPage[Width|Height]F() are encouraged over FPDF_GetPage[Width|Height](), which will be deprecated in the future. Change-Id: I0445d7cb0a36249fc52d4ff60751543b787b2531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393246Reviewed-by:
-
Hung Vu authored
Bug: 1118207 Change-Id: Ia6930c99bf0dac607450ddf97ee57cd3e09b9c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391507Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Hung Vu <vuhung@google.com> Cr-Commit-Position: refs/heads/master@{#804502}
-
Matthew Mourgos authored
This change adds a syncable pref for app notification badging that can be toggled in the notification quick settings. When the pref is changed, all app badges in the shelf and app list are updated. The badges are hidden when the pref is disabled. Bug: 1080827, 1122723 Change-Id: Icd3ff5562e768cfc8e07c9173263c326f1e66d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366295 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#804501}
-
Devlin Cronin authored
The file contains a single test, InvokeUi_ExtensionBlockedActionsBubble, which exercised showing the blocked action bubble with the legacy toolbar UI. The new UI is tested in ExtensionsMenuViewBrowserTest.InvokeUi_ReloadPageBubble. Remove the file. Bug: 1100412 Change-Id: I72ba7ac8caa9923fe44305b05bc0d6f9ed823858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390868 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7592f9326fc9..5dba9c97fbc3 2020-09-03 sanfin@chromium.org Pass large -j value to ninja when use_rbe = true If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Test: Test: run on an out/ directory with use_rbe enabled Change-Id: I07b1081f9ad0c554b5942ef3c01b6a15fa247b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393137Reviewed-by:
-
Daniil Lunev authored
Bug: b:151176984 Change-Id: Ie9a8b76dffba24f464e058406bc95afe4359d31c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386946 Commit-Queue: Daniil Lunev <dlunev@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#804498}
-
Nnamdi Theodore Johnson-Kanu authored
- current UI https://imgur.com/97DpSem - UI spec https://docs.google.com/presentation/d/1Mfk5ZMEmeHwSbadUbyRU0Si5k6XDIvw-j4u7TUaCIGY/edit#slide=id.g6db8b414e1_4_32 Bug: 1093185 Change-Id: I751590c8a6868fe2bfb6ad8f367ec886729e3694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389231 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#804497}
-
Haiyang Pan authored
So that users add customized tags for the triggered swarming task. Change-Id: Iefbab2c67360ed09719571eca24074b91a28fa00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392864Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#804496}
-
Kartik Hegde authored
The HttpRequestManager class will be used by network diagnostics routines to make http/s requests. BUG=chromium:956783 TEST=unit_tests --gtest_filter=HttpRequestManagerTest* Change-Id: I2b2bd97cfb832fb4dc58ceb3b90da721497c9ee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377420Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#804495}
-
Harry Cutts authored
This barcode scanner (as with many others) works by pretending to be a keyboard and typing out the barcodes it scans. This prevents the on-screen keyboard from appearing on devices without an actual keyboard plugged in. Bug: 1004645, b:141515578 Test: check scanner works, and that VK appears when appropriate Change-Id: I0e983035e645b412955bed38307de43ce5ab2ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388347Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/master@{#804494}
-
Olivier Yiptong authored
Adds an UMA metric to time font enumeration time on Windows. Bug: 1043306 Change-Id: I6e8a3e51ee752f3e62388a08fd05b06456e7ccd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392992Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#804493}
-
Pranav Batra authored
The CUPS resolution field, represented as quality in the print preview dialog, was previously ignored on Chrome OS machines in favor of the advanced print quality setting. This commit changes that - when possible, Chrome will pass the selected resolution on to CUPS so that print filters can print at the correct resolution. Bug: 1001398 Test: ./printing_unittests Change-Id: I3666591da07022d3dd02b2fadaaaf4835ad453b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390967Reviewed-by:
-
Devlin Cronin authored
Currently, ExtensionMessageBubbleBrowserTest inherits from BrowserActionsBarBrowserTest. Unfortunately, this means that none of these tests run with the new Extensions Menu UI. Since the BrowserActionsBar-related tests are going away, we need to migrate these to be compatible with the new UI. Instead of inheriting from BrowserActionsBarBrowserTest, inherit from ExtensionBrowserTest directly. There were relatively few dependencies, and this paves the way to having these tests run with the new UI. Bug: 1100412 Change-Id: I43cd5852ddf2e04eaee7c55f1d0b4086e31c59fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392702 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Mei Liang authored
This CL adds the enable_launch_polish field trial and utility method for M86 FastPath. The utility method is added, so we can run the formal equivalence checking tool. Bug: 1124835 Change-Id: I7bb0152ebc4138f1023e8a8fe9715cf4524b5a1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392773 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#804490}
-
Maksim Ivanov authored
Fix the GN file to avoid the policy_fuzzer compilation errors, by removing the "proto_in_dir" parameter that was added in r803915. As per trybot results, it seems that this parameter isn't actually needed. The reason why this parameter was causing troubles in policy_fuzzer is that we're compiling chrome_device_policy.proto twice: (1) "gen/components/policy/proto/chrome_device_policy.pb.h", which is the standard compilation location used for compiling both normal Chrome and the fuzzer; (2) "gen/chrome/browser/chromeos/policy/fuzzer/chrome_device_policy.pb.h", which is compiled specifically for fuzzer, with the LITE_RUNTIME option suppressed. Previously, before "proto_in_dir" was introduced in r803915, both of these header files had the same preprocessor include guard that is based on the "chrome_device_policy" string: #ifndef GOOGLE_PROTOBUF_INCLUDED_chrome_5fdevice_5fpolicy_2eproto #define GOOGLE_PROTOBUF_INCLUDED_chrome_5fdevice_5fpolicy_2eproto The fact that the include guard was the same allowed to include both of these headers in the same .cc file without any compilation issues. With "proto_in_dir" introduced in r803915, the include guard for file #1 changed, because protoc started to consider the full path to the file: #ifndef GOOGLE_PROTOBUF_INCLUDED_components_2fpolicy_2fproto_2fchrome_5fdevice_5fpolicy_2eproto #define GOOGLE_PROTOBUF_INCLUDED_components_2fpolicy_2fproto_2fchrome_5fdevice_5fpolicy_2eproto This caused compilation issues of policy_fuzzer, since the include guards didn't protect from redefining the contents of chrome_device_policy.proto twice. The fix is to remove this "proto_in_dir" directive, which seems to be unnecessary. A future long-term fix (potentially also addressing other compilation issues that we saw in https://crbug.com/1093407) would be to get rid of double-compilation of the .proto files. Bug: 1124880,1094675 Change-Id: I3b1ba1c1591940a846a3ec323a9fa16aa01778e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392816 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:Zach Trudo <zatrudo@google.com> Commit-Queue: Zach Trudo <zatrudo@google.com> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#804489}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b6433401. With Chromium commits locally applied on WPT: 1d15ab1e "[css-pseudo] Don't inherit 'text-align' to ::marker" 82d112d0 "Fix cert errors on the official WPT test runner." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hbos@chromium.org, hta@chromium.org, guidou@chromium.org, philipp.hancke@googlemail.com: external/wpt/webrtc hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I59322e6751e18383e5c42ff7cecae06a4f86ecf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390807Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804488}
-
Mike Dougherty authored
This is a reland of c02e4409 These EarlGrey tests fail on iOS 12.4. (Presenting the iOS share sheet crashes the test even without any JS changes.) Update the tests to run only on iOS 13+. The feature works in Chrome even on iOS 12.4 without crashing. Original change's description: > Restrict web share feature to URLs with http/https protocols > > Bug: 1122059 > Change-Id: Id9644b9dff7e9854f20218f09750fbf191d5a318 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378274 > Commit-Queue: Mike Dougherty <michaeldo@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803970} Bug: 1122059 Change-Id: Ia7c94020287330c918a3a9d50c545fca52306d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392979 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
-
Leonid Baraz authored
Whenever certain record is written generation and its digest are stored in metadata file, and then all previous metadata file(s) are asynchronously deleted. When reopening the StorageQueue, metadata file matching the last sequencing number is used to restore generation and digest for future writes. The code does not handle errors yet - missing or corrupt metadata file, incomplete data file, etc. In the future we will add code to reset generation id and eliminate last digest. MockClient in tests makes sure generation_id is the same for all records. It also verify records own digest; last record digest is not verified yet, because the test expects some records to be duplicated. Bug: b:153364303 Bug: b:153659559 Change-Id: I80d8e7f03097bcc4a510f21e0a546876b3104960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388716 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
-
Josiah K authored
The Punctuation Echo Setting has three TTS verbosity levels for speaking punctuation: None, Some, and All. Before, the user could only change the Punctuation Echo Setting with the Cycle Punctuation Command. This change allows the user to change the Punctuation Echo Setting from the ChromeVox Options Page. Bug: 1124445 AX-Relnotes: Add Punctuation Echo Setting to ChromeVox Options Page Change-Id: I726e43b9dccf23fc12acd83e2430492b042d130d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388402 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#804485}
-
Joel Hockey authored
Check each of crostini and plugin VM before adding buttons on the notification, and update messages. Bug: b/150341671 Change-Id: Id9973c27c9355b85bfe5d168ca8828500a7d5156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389303 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#804484}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I5581788c390f8da454acb837e967dcc8bf9870fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392944Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#804483}
-
David Tseng authored
Formerly, the rate, pitch, and volume used a hybrid linear/exponential scale. Convert to linear, with a smaller step-size. Fixed: 987509 Change-Id: I6eaae207e6fffac08f098750e96d131d08d4217c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388342Reviewed-by:
-
Becca Hughes authored
It is currently cut off but we cannot shrink down our content any more so we need to increase the size a little bit. BUG=1121360 Change-Id: Icdd2ba460f727324c0f5c00426aeb637e4cad35e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393189 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#804481}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b6b9cffaf3bc..36b884e6ace1 2020-09-03 sugoi@google.com Fix undefined behavior in minifloat conversion If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1117433 Tbr: cwallez@google.com Change-Id: If9a7e9d7dada7756feedf60420b7857b41641634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393141Reviewed-by:
-
Thomas Guilbert authored
A lot of WebCodecs tests are using async_test, which lead to time outs when there is an error, and potentially missed test failures. Additionally, a lot of code verifying configs, and which calls are allowed in which codec state are common to many test files. This CL extracts some of common elements into its own utils file Bug: 1094096, 1094182 Change-Id: I7dd6c9ab76959ed6adb86fd2e6bf94d21610838a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389008 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#804479}
-
- 03 Sep, 2020 2 commits
-
-
Michael Montvelishsky authored
Raised cosine add less audible artifacts when used as volume slew curve, compared to linear one. Recurrent calculation of slew cosine is based on: https://basesandframes.files.wordpress.com/2016/05/rgreenfastermath_gdc02.pdf Bug: internal b/167251783 Change-Id: Ia9262700ecc0b9f4ee5e3895cc9864480eabab73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391894Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Auto-Submit: Michael Montvelishsky <mont@chromium.org> Cr-Commit-Position: refs/heads/master@{#804478}
-
Adrienne Walker authored
CopyFileContentsWithOffsetAndSize takes in a max size, but uses the wrong variable to consider how much is remaining to read, and so ends up reading the entire file (rather than limiting to size). Because of this, there's a size mismatch in the calling function and the blob fails with kInvalidBlob. This should fix some of the errors from issue 1114200. I also see out of memory errors, but those make more sense than this logic error. Bug: 1114200 Change-Id: I6d8f371655e38bdd02cc89e9d524de757e1c202a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392987 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#804477}
-
