- 27 Apr, 2019 21 commits
-
-
Chris Harrelson authored
DidBeginMainFrame can cause mutations to layer state, and the commit needs to be complete before doing so. Bug: 939342 Change-Id: I078a78879394f999cebe05a2804ac05617a31cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584498 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#654699}
-
John Rummell authored
Also adds a test to verify the behavior. BUG=957138 TEST=new base_unittest passes Change-Id: Ida1d0801f457e96dbf1d2ed299966a50aec05442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586220 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#654698}
-
rbpotter authored
Remove new/ folder, since the old UI code has been deleted, and move all contents to a new ui/ folder or the data/ folder, as appropriate. Bug: 888272 Change-Id: I57e7df9e96a12fce112d18a70c58889587fb6e7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586265Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#654697}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6841244fb6c0..c6130f7f5dc8 Created with: gclient setdep -r src-internal@c6130f7f5dc8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=andruud@chromium.org,alexmos@chromium.org,horo@chromium.org,adithyas@chromium.org Change-Id: I79ac08fe959d178a639b2e0b4a18027b9a64f357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586192Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654696}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6f691fbb59c7..1ad7a07212b2 git log 6f691fbb59c7..1ad7a07212b2 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 jonahr@google.com Clean up unexpected passed/failed test behavior for generate_stats Created with: gclient setdep -r src/third_party/angle@1ad7a07212b2 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I15ebacc6a43a0833d64e8235a8a1254be5256cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586245Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654695}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3349fb0195ff..e178c0586cd6 git log 3349fb0195ff..e178c0586cd6 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@e178c0586cd6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: I0f3b0522a4474dca262f6b4b91a52546271b0b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585331Reviewed-by:
-
John Budorick authored
Bug: 861983 Change-Id: I4265612b47bff2799a63cda4cc5c28952446a7ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586469 Auto-Submit: John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#654693}
-
Mounir Lamouri authored
Bug: 952090 Change-Id: I0abea411b1dfb60b5d4c6a37b9cd571d70fffa48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585347Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#654692}
-
PKH authored
This CL splits the webapk_java GN template into two targets: 1) webapk_java - Contains most of the source files of the old webapk_java template - Does not depend on compiled_in_runtime_library_java - shell_apk_javatests depends on webapk_java 2) webapk_with_service_java - depends on webapk_java and compiled_in_runtime_library_java BUG=817263 Change-Id: If234e939fc3ba5119dd9290256fab3a34c80b2fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585114 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#654691}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f5c8936c463e..3610ded5e409 git log f5c8936c463e..3610ded5e409 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 chrisforbes@google.com Adjust input attachment index when indexing into array of input descriptors Created with: gclient setdep -r src/third_party/swiftshader@3610ded5e409 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/131171141 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I31ed519038dadcb83b4b9fa650d9a35e970489c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586190Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5fb2ca3384f7..8bceb48c2222 git log 5fb2ca3384f7..8bceb48c2222 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 thestig@chromium.org Fix some nits in CFXJSE_FormCalcContext. Created with: gclient setdep -r src/third_party/pdfium@8bceb48c2222 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic327f49bfda5eb9f492a0cbce6216907e92f8da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586189Reviewed-by:
-
Nigel Tao authored
This commit is part 1 of 2, being a refactor with no change in behavior. There is an existing observer leak (an AddObserver call with no matching RemoveObserver call), but this commit keeps that leak. A follow-up commit will fix the leak. TBR=seantopping@chromium.org Change-Id: I73e9087540949c29bb76d6526362b5448452e182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585403 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#654688}
-
Nate Chapin authored
This centralizes as much of the same-document navigation logic as possible on DocumentLoader. This CL almost moves a helper, FrameLoader::LoadInSameDocument, and renames it to DocumentLoader::CommitSameDocumentNavigationInternal Change-Id: I4492160a4ac8b86cd41a3dd55dabf0aeed3c8d08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580323 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#654687}
-
Mason Freed authored
From profiling and Pinpoint tests, a decent percentage of PushPaintArtifactToCompositor() CPU time (possibly up to ~30%) is spent reallocating Vector<> objects. Specifically in two places: the chunks_ vector in PaintChunker, and the pending_layers vector in PaintArtifactCompositor. Previous to this CL, on each frame, both vectors were constructed from scratch, grown up to their final size (with many reallocations along the way), used, and then destroyed. This CL tries to reduce a bit of that overhead by keeping the vectors around, at their prior-frame capacity. This CL re-uses the pending_layers vector. The PaintChunker CL is at [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1586578 Bug: 954961 Change-Id: I496259f06835989d2e25b7ce1eb73ef2ab9cc788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585330 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#654686}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0e095532eff2..6837707f8009 git log 0e095532eff2..6837707f8009 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 dschuff@chromium.org Fix emscripten_releases directory name to match git repo name Created with: gclient setdep -r src/third_party/depot_tools@6837707f8009 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I62760e16a5abe1673e0b93580a7fc6fd451d0271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586188Reviewed-by:
-
Alexei Svitkine authored
Android.ResourceBundle.LoadLocaleFailure: Shows no data, removing in this CL. Since there was never any data logged for it, I'm removing it entirely from histograms.xml. UMA.LogUpload.Canceled.CellularConstraint: Still interesting, bumping expiry date, will also add monitoring. Variations.SeedProcessingTime: Still interesting, bumping expiry date, will also add monitoring. UMA.UnsentLogs.Dropped: Still interesting and there's active plans to do work on background uploads on Android, which may move this, so bumping expiry date. Bug: 948327, 948331, 948329, 945552, 914342 Change-Id: Iee2452969b5d3052b043235edf106d5dd0791589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586415Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: I26559ac3c7769845120341ab83181ea0dc4fc211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586471 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#654683}
-
Pavel Yatsuk authored
Touchless context menus should include icons for individual items. To support this I added a method to TouchlessContextMenuManager to map from item id to resource id of corresponding item. I've also added following VectorDrawable resources: - ic_remove_circle_outline_24dp - ic_help_outline_24dp Here are screenshots: - screen/pyyNGb0jLpX - screen/GDwXF9z7mvr BUG=937445 R=dewittj@chromium.org Change-Id: Ic46f4335f8a219bc6d2cc389b62457a9042415d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586261 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#654682}
-
Chris Lu authored
Calls FindInPageManager::StopFinding() if the Find in Page feature flag is turned on. Bug: 919685 Change-Id: I310c15d46049c24642bf6d0d25e4fb4a36711409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579025 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#654681}
-
Joe DeBlasio authored
This is a reland of ff13eb07 with a minor tweak to prevent a flaky test. Original change's description: > Update CCT to hide origin if requested by security interstitial. > > This CL modifies the behavior of CCTs such that they hide the > origin of a page and page info button if there is an active security > interstitial that requests it. This brings the behavior in line with > that of desktop and mobile. > > Bug: 939601 > Change-Id: I6c46cb4918871b9d2a760a72bee742fc7867e1b7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570415 > Reviewed-by: Jay Harris <harrisjay@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#653038} Bug: 939601 Change-Id: I9fd61d7689bcec23723ee2d7ecd6520ae2c201da TBR: harrisjay@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579915 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#654680}
-
Elly Fong-Jones authored
ccameron is going to be tackling this :) Bug: 716231 Change-Id: I56f04c4c8be9744eb0f8b4defc6dcd11cd3ec1aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586274 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#654679}
-
- 26 Apr, 2019 19 commits
-
-
Ben Pastene authored
This should let us parse some results even if something goes wrong and the final results.json doesn't get generated for some reason. Bug: 923426 Change-Id: I028896c9edc7aeb8b3ec6339b8867f0b29ae095f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575105Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#654678}
-
Sammie Quon authored
Originally I wanted to revert the dragging operation as well, but seems there is a test specifically to keep that functionality. Though it may be obsolete now as there isn't a way to enter overview while dragging as far as I can tell, but for now I will just hide the resize shadow. Test: added test Bug: 956184 Change-Id: I15ff202a52b779870c28047f455317796e8f8782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586263Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#654677}
-
Anastasia Helfinstein authored
Bug: 955783 Change-Id: Ica674d05503cbc96389b52d0fe554e9898b01e9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585549Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#654676}
-
Ian Wells authored
Sets the offline pages prefetching feature flag to be enabled by default. Bug: 881120 Change-Id: I735723193fbb19100e6962b8861d4fd04933e4c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562295Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#654675}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7232e2246072..6841244fb6c0 Created with: gclient setdep -r src-internal@6841244fb6c0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=andruud@chromium.org,alexmos@chromium.org,horo@chromium.org,adithyas@chromium.org Change-Id: I9db5a02bbc6a23b78ca9d4a3a5be44c5e2d74ddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586387Reviewed-by:
-
Gayane Petrosyan authored
This change is meant for forcing theme property recalculation in M75. Bug: 942135 Change-Id: Ie6c912234906702381ea5fc5fc5919eb1e14ad99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585321Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#654673}
-
Kehuang Li authored
The output sample rate of APM should be the same as the input to it. Cast platform is switching to the new behavior. Yet using Cast build flag to avoid affecting legacy usage. Bug: internal b/130197895. Test: On device, see the output sample rate is correct. Change-Id: I392a1490997057cb9fbfea1c1b60d1c689938a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572807 Commit-Queue: Kehuang Li <kehuangli@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#654672}
-
Chris Lu authored
Screenshot: https://drive.google.com/open?id=1yYp4LVAuevYbhrCS4vqmxztLxxAvmIjr Bug: 954624 Change-Id: Ia537f4bf6e997793c5ebff3dcdc473e83c738b75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585166 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#654671}
-
Sammie Quon authored
Test: manual Bug: 957151 Change-Id: I111826d8ecbb096ae696173b6369228249c77b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586256 Auto-Submit: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#654670}
-
Miyoung Shin authored
This is a part of moving manifest implementation to blink. This CL moves content::ManifestManager to blink and introduces WebManifestManager in blink/public/web to expose to //content, and removes WebManifestParser, WebManifestFetcher and ManifestError. Bug: 704441 Change-Id: I2de0dea6f4f4f269fd84a7df78e190586350b93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573520 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
-
Jesse Schettler authored
Limit enabling the print-spooler-experiment feature flag to the Canary and Dev channels. BUG=b:130798103 TEST=android-sh -c getprop | grep ro.boot.arc_print_spooler Change-Id: I7717801c570ff4cadd220a491deea85cc203bf2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586264Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#654668}
-
Xing Liu authored
This CL adds the notification shown metrics for update notification, which informs the user to update Chrome in play store. Bug: 952354 Change-Id: Id0a6c1a944ec2bdadfc782926591e8b51d9a616c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585233Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#654667}
-
Lukasz Anforowicz authored
The main benefit of the CL is that it takes away an ability to disable Site Isolation on desktop without triggering a "security/stability will suffer" butter bar. Most edits in the CL, hide processing of kDisableSiteIsolationForPolicy behind #if defined(OS_ANDROID). chrome/browser/chromeos/login/session/user_session_manager.cc can be substantially cleaned up in this CL because 1) it is CrOS-only (and the ability to disable Site Isolation after this CL is restricted to Android) and 2) IsolateOrigins policy is handled at runtime (see r644966). Bug: 910273 Tbr: sky@chromium.org Change-Id: Ie7c845e27c55b37a460050de07c3f44e8cee7b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576295 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#654666}
-
Gabriel Marin authored
Based on the gperftools' Makefile, emergency_malloc_for_stacktrace.cc is used only when ENABLE_EMERGENCY_MALLOC is defined. We don't define this flag in Chromium, so we should build only with fake_stacktrace_scope.cc, which provides dummy definitions of the same symbols. BUG=724399,b:70905156 Change-Id: I03404df00ef1d530bd04d35634f1c29fe8bb56db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586100Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#654665}
-
PKH authored
This CL renames WebappSplashScreenController and WebappSplashDelegate so that the classes can be used by TWAs. This CL also renames WebappSplashDelegate#isWebApkNetworkErrorDialogVisible() so that it is more appropriate for TWAs as TWAs do not have an offline dialog. BUG=817263 Change-Id: Ia94fd27d1d256e950c8dc500abbf7bd69194e4bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572097 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#654664}
-
Alexei Filippov authored
It has been replaced with --memlog* set of flags. BUG=923459 Change-Id: I539c514b3f25decd0dccb827d1757e133403e9d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586535Reviewed-by:
-
Caleb Rouleau authored
This automates the task of removing a benchmark from the shard maps, and thereby ensures that no mistakes can be made that later cause inconsistencies and make the resharding process harder. We can build on this later to add a PRESUBMIT test to ensure consistency. Bug: 936998, 954651 Change-Id: Idaa91c1c321a2fade28fb226eaf43de94beb1f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576029 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
-
Tommy Steimel authored
This CL adds CSS rules to only show the timeline and volume slider thumbs when the slider is hovered. On Android, we want the thumbs to always be visible. In order to make that work this CL adds a new modernMediaControls_Android.css file that is loaded on Android. Bug: 955806 Change-Id: Ic4ab9c34183ece52e22b37ff3bf0bf4dbb8839c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584167 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
-
Alexei Filippov authored
Fixes the following warning message when --memlog is used. "ERROR:settings.cc(119)] Unsupported value: "" passed to --memlog-stack-mode" Change-Id: I33d80a29ea117777e935199f1ab83827c7b3fbb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586539Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#654660}
-
