- 10 Sep, 2020 40 commits
-
-
Regan Hsu authored
When enabled, Wallpaper picker app will pull wallpaper collections from the alpha server instead of prod. Bug: b/168114365 Change-Id: I0fbfde5ff4d0043fb3e1a499a9f4261c7c9dba32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401948Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#805809}
-
Wenbin Zhang authored
The processors on FYI are for testing propose. We don't need them any more and we can shut them down the free up resources. Bug: chromium:1045256 Change-Id: I82fe460916a55768f1b5e3c053ac31dfc87f37ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402658 Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#805808}
-
K. Moon authored
Replaces all instances of scoped_refptr<UrlLoader> with std::unique_ptr<UrlLoader>. It turns out there's no need for multiple ownership of UrlLoader. Drops OutOfProcessInstance's embed_loader_ and embed_preview_loader_ fields in favor of binding to the result callback. This may cause behavioral changes in two cases: 1. The field is overwritten before the callback runs. 2. The field is not cleared after the callback runs. (1) would cause other problems, as the current code assumes only one load occurs at a time (as tracked by document_load_state_ and preview_document_load_state_). The extra fields are needed only to simulate bound parameters in the old pp::CompletionCallback implementation. (2) is the case currently, but this change simply ensures that the loader is cleaned up as soon as it's no longer needed, rather than "leaking" a lingering reference. Retains the form_loader_ field, rather than also binding to the result callback, as this loader is not handed off to PDFiumEngine. In general, we don't handle form submission correctly, but fixing this is more a matter for crbug.com/719344. Bug: 1099022 Change-Id: I012be0e65583940f08275d7ce3469e01fbf72dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402122Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#805807}
-
Matthias Körber authored
The usage of Java script in forms can result in unstable renderer ids and therefore cache misses. This is mitigated by using unique-only field signatures as a fallback. Change-Id: Icae0f719c8ad1ea4de9dd9ab142b0d6aa746b2ab Bug: 1087386, 1091401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396141Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#805806}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2f11d877efaa..12e6ff85f6e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC seblalancette@google.com,mstensho@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: seblalancette@google.com,mstensho@google.com Change-Id: I50c5ff97e056a743f232b2fca0d01de0cf5dd121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403628Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805805}
-
Daniel Rubery authored
Due to consolidating the two different configs currently applying to the CSD model version, we need the fieldtrial_testing_config to be kept in sync. Change-Id: I1adef41facd0d38d16e562561639ac1f5672ec07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399722Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#805804}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009100800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/ewmYZK3dZxBbgR06k6qpzdRqlikpeAfsd40KuNLCOSYC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: Ib17351e7cdda384ba536a73f0923b72d38b86ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403639Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/822283dbb736..fc83cdc8198b 2020-09-10 tommi@webrtc.org Avoid proxy thread hops for reading const properties. 2020-09-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6e37a7f7..b55cb19f (805451:805701) 2020-09-10 peah@webrtc.org Add explicit initialization for the FilterAnalyzer in AEC3 2020-09-10 mbonadei@webrtc.org Revert "Switch from "rtc_ios_xctest_test" to "test"." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I458b3528eb84e663de0c1523e2ed7c23e7903667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403638Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805802}
-
Mario Sanchez Prada authored
This is a follow-up CL for crrevc.com/c/2403260 to remove the methods SetMouseOverURL() and SetKeyboardFocusURL() from Blink::WebView, since they are no longer used from //content/renderer, but simply internally from Blink's chrome_client_impl.cc and WebViewImpl. Bug: 993189, 1047464 Change-Id: I377a03939773b276c0a94704fb36ebd230b121ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403264Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#805801}
-
Akihiro Ota authored
This is a first pass at a nudge system for the interactive tutorial. This is particularly important for the OOBE tutorial, where we block ChromeVox until an expected action is performed. The issue is that the user only receives instructions once; if they miss the instruction, they have no way of hearing it again. To fix this issue, periodically announce the current item after a time interval. After reading the current item a few times, give general hints about using ChromeVox. Finally, if enough nudges have been given, provide a hint to exit the tutorial. This change also ensures that the new behavior doesn't conflict with hints for the practice area. Note: The strings added in this change have not been localized yet. Localization for the tutorial will land in a following change: https://chromium-review.googlesource.com/c/chromium/src/+/2254345 Bug: 1124074 Change-Id: I8ad0ec963c2cabb7a3b145ca3713a7f0bc66c1b4 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390962Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#805800}
-
Alex Ilin authored
TBR=michaelbai@chromium.org Bug: 1126950 Change-Id: I624983b8f86f24180ed8200ddb0793d8a7af2c1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403562Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805799}
-
Fredrik Söderqvist authored
If the first animation in the sandwich does not depend on the underlying value we can avoid computing it - which for certain types can avoid flushing style. Bug: 981355 Change-Id: Ic15e863f03f8f7194eea9a453b980f416f1bff37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403263Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#805798}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1595370378-ba0a034250ef2251ee8fa7ce722cfaaf39079474.profdata to chrome-linux-master-1599738815-c7c05d9aad543471c0ca5060fdc90a37df9de6fc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:linux-chrome Tbr: liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I6e5a8685f9c50974b1b1b7bd3f4c0db5d898903a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403600Reviewed-by:
-
Christopher Cameron authored
This is a no-functional-change refactor that changes the function OnShimProcessConnectedForLaunch (which is used to launch the app when an app shim connects) to be more generically written. This is towards unifying four code paths: 1. OnShimProcessConnectedForLaunch, when the user launches an app shim 2. OnShimSelectedProfile, when the user selects a profile from the Profile menu 3. OnShimOpenedFiles, when the user opens files (e.g, by opening in Finder) 4. OnShimReopen, which is the *new* behavior in this bug, which will open a new window when the shim is running but has no active profiles. The next patch in this sequence will changes paths 2 and 3 to use this function. Bug: 1094419 Change-Id: I05265b9923db0f811bed239f2cd4db34e4c6553c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402164Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#805796}
-
cfredric authored
This component will receive a JSON object that encodes the First-Party sets that are to be preloaded as part of the MVP of the First-Party Sets prototype (https://github.com/privacycg/first-party-sets). This will allow sites to declare themselves as the same first-party; this information will be used to allow certain embedded contexts access to their own first-party state. Note: I've added the base::Feature enabling this functionality to //services/network/public/cpp as both the //chrome client and (in future cls) the Network Service implementation will need to use this Feature to gate their behavior. Change-Id: I20f2378fcee624169f6b57d6837998c92f7f0033 Bug: 1124904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392797 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#805795}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/84508b9666d5..65dcbe124508 2020-09-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 4ede8ee6e2ec to fcb7ecbe49c5 (5 revisions) 2020-09-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ce08265ba5b7 to b24900a1aa39 (1 revision) 2020-09-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from a715b1b40535 to 2de7d3af0c0e (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I9997cd2786e12c1e361cc29d2995f82c174a7b5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403621Reviewed-by:
-
Peter Boström authored
Replaces uses of it with PerformActionCallback (updated to pass the Combobox*) or base::RepeatingClosure. Bug: 772945 Change-Id: I7a54755016bebd628654ec3f18ccdcd012345cd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402326 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Egor Pasko authored
Allow 80 misordered symbols, instead of 20. The current pipeline reports about 60 misordered symbols, which increased recently. According to http://crbug.com/1117184#c14 it did not make the orderfile quality noticeably worse. Also print more examples of symbols. Bug: 1117184, 1126878 Change-Id: Ib5e1c3c8ad0ca70a16b8f6ffec21773617e594cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403365 Commit-Queue: Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Auto-Submit: Egor Pasko <pasko@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#805792}
-
Allen Bauer authored
Bug: 938501 Change-Id: Ic1c7569e35229d8d9b7ab36daff7fc800f4d97de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402133Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#805791}
-
Byoungchan Lee authored
- Decode the result of subprocess.Popen() so that the stdout/stderr result is str, not bytes. - Use dict.items() instead of dict.iteritems(). - If the return of map() needs to be a list, use list comprehension. - Use range() instead of xrange(). - Tuple parameter unpacking is removed on Python3, refactor its usage. - struct.pack() doesn't accept str, convert arguments as bytes. - plistlib has several API changes. Replace removed. functions (readPlistFromString). Still have some warnings like this: "The readPlist function is deprecated, use load() instead" - _GetOutputNoError() in tweak_info_plist.py has no usage. Removed. No intended behavior change. Bug: 941669 Change-Id: Ibc204fad8b56e864a083046559133403dcf99fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392289Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#805790}
-
Mohamed Amir Yosef authored
Bug: 1069376 Change-Id: Ied89b907d20859ea44ea4611f0705a9cd722a395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148602Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#805789}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b3f3e76c87ac..625eb197594e 2020-09-10 treehugger-gerrit@google.com Merge "tp: extract out tokenizing logic from ProtoTraceTokenizer" 2020-09-10 lalitm@google.com ui: don't throw exception for zero-duration instants If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:167442237 Tbr: perfetto-bugs@google.com Change-Id: Ia9acf8d435d673dce3fd2656e2c41ab3ec6b7a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403629Reviewed-by:
-
ckitagawa authored
These histograms are from the first experiment, but are still relevant for the current show-at-startup experiment. Update the expiry date to 6 months out. Bug: 1125844, 1125843, 1125842 Change-Id: Ib8f3bc2af02d89465ce879e2825a12f59c5e3afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398966Reviewed-by:
-
Mirko Bonadei authored
This should fix the current issue: test_runner.XcodeVersionNotFoundError: Xcode version not found: 12a8189n Bug: None Change-Id: I7444ed02b44225c7eb8fb83861dd082512c5f304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403241Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#805786}
-
Collin Baker authored
This metrics records the total time spent capturing a tab for thumbnails. It is emitted once per video capture on a given tab. Bug: 11261624 Change-Id: I9dfdd4168738d59e048aab2238c78db62f9af917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399127Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
It times out now and then. TBR=mek@chromium.org Bug: 1092048 Change-Id: I7416f6ee0279c00fa578a51e92e436e67562ac97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403483Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#805784}
-
Evan Stade authored
This one slipped through the cracks when the rest were updated in 63d5fba9 Bug: 1126716 Change-Id: Ia67f0f60a4f7bcc89c98a550f16dd31974e80f56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402208Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#805783}
-
Jesus David Garcia Gomez authored
This CL add new metrics enums to allow measuring when an issue in the issue panel is expanded and when a resource is opened. The corresponding DevTools CL is at https://crrev.com/c/2303882 Bug: 1100658 Change-Id: Ia85587441dd4d11063ac3d6ed9d722fd65ff714a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305018Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
John Emau <John.Emau@microsoft.com> Commit-Queue: Jesus David Garcia Gomez <jegarc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#805782}
-
Olivier Robin authored
Change-Id: Ic3b4511444a691de76537616be0f82193a953dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403561 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#805781}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f13b78ef. With Chromium commits locally applied on WPT: 5083fb9d "sensors: Rewrite the frequency hint test." 70d18388 "[COOP] reporting WPT > rename + update expectations." c42229d8 "Fix double zooming in StyleBuilderConverter::ConvertBorderWidth()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I238c39f825744eee810e79ce8bc7a6ca59c45f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403700Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805780}
-
Robbie McElrath authored
This CL changes the layout of the shell app so the main weblayer FrameLayout has the correct height. The incorrect height was messing with the positioning of the bottom bar when scrolling it. Change-Id: I81808ee10a4c3a46ce25c4e5755c086199da5743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402286Reviewed-by:
-
Tanmoy Mollik authored
This cl removes signin_promo_status_message string. This string was used in personalized sync promos. But this string is now hidden and no longer shown on the UI for sync promos. It is replaced by sync_error_card_title that is used in SyncErrorCards. Bug: 1124701 Change-Id: Id111d1df6fbee1b336b253867161cfb9b3c217fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391086Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#805778}
-
Jeff Yoon authored
linux-chrome is used by PGO to ensure validity of the profile being rolled and to warm up the goma cache. this trybot is currently not triggerable (ie/ crrev/c/2403600). Bug: 1105530 Change-Id: I9d8b8082d5817f9f7e7f97beae3faf0c2adf2088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403587 Auto-Submit: Jeff Yoon <jeffyoon@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#805777}
-
Olivier Robin authored
Change-Id: I98d66c0f0a0a21fe6aa99190c0248faad10dae35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403468 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
|is_control_group| param on PrerenderContents::StartPrerendering() was removed in: https://chromiumcodereview.appspot.com/11348357 Bug: n/a Change-Id: I4ee52257916e596dc8517c2b7421e7abb8de6c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400590 Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#805775}
-
David Tseng authored
R=jamescook@chromium.org AX-RelNotes: n/a Fixed: 1124714 Change-Id: Ibb84e2e76a5fb6e68b24151d5de747e6ef0a6dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401702Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#805774}
-
Eugene But authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios.git/+log/959e66d5aea0..58ae5f81390b Manual change: Remove tabs from components list $ git log 959e66d5a..58ae5f813 --date=short --no-merges --format='%ad %ae %s' 2020-09-09 andrewoverton [TextControls] Refactor sizing behavior + expose sizing delegate method 2020-09-09 bryanoltman [BottomNavigation] Remove supplemental directory from examples. 2020-09-09 afweiss Update Bottom Navigation Item View accessibility traits so that VoiceOver works correctly on iOS 14. 2020-09-09 afweiss Remove unused StringsConstant file from Tabs 2020-09-09 no-reply [Banner] Change the trailing padding constraint for textView on MDCBannerView to match the Material Banner specs (https://material.io/components/banners#specs). 2020-09-08 afweiss Remove now unused TabBar resources from Podspec 2020-09-08 randallli [MDCSnackbar] Example: Dismiss snackbars when push or popping the example VC. 2020-09-08 andrewoverton [TextControls] Add `containerRadius` to MDCBaseTextField 2020-09-08 afweiss Remove pre-iOS 10 handling for voiceover now that components support iOS 10+ 2020-09-08 bryanoltman Bumped version number to 115.0.0. 2020-09-08 bryanoltman Hand-modified CHANGELOG.md API diff. 2020-09-08 bryanoltman Automatic changelog preparation for release. 2020-09-08 bryanoltman Delete now-unused BottomNavigation resources from Podspec 2020-09-08 featherless [Slider] Expose thumbBorderWidth and thumbIsSmallerWhenDisabled. Created with: roll-dep src/ios/third_party/material_components_ios/src Change-Id: Id797db06ab92d8e159510db744412afc33b6375a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402439 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#805773}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/88a5d76f5f62..2b117e76f5dc 2020-09-10 tvanderlippe@chromium.org Implement GRD file check for devtools_pre_built 2020-09-10 jobay@google.com Move filterRegex from String prot to string-utilities.js 2020-09-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-09-10 jacktfranklin@chromium.org Revert "Add lit-html/directives/live.js to the grd" 2020-09-10 jacktfranklin@chromium.org Add lit-html/directives/live.js to the grd 2020-09-10 jacktfranklin@chromium.org Revert "Expose the live directive from LitHtml" 2020-09-10 szuend@chromium.org Migrate COEP issue descriptions to use Markdown 2020-09-10 patrick.brosset@microsoft.com Grid: Fix misplaced grid overlay labels on high DPI monitors 2020-09-10 kprokopenko@google.com Add elements component 2020-09-10 jacktfranklin@chromium.org Fix optional params in bridges function types 2020-09-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-09-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-09-09 andoli@chromium.org [ts] Typecheck css_overview/CSSOverviewUnusedDeclarations.js with TypeScript 2020-09-09 chrche@microsoft.com [Loc] Presubmit#3: LocV2 Checking the shape of localization API calls 2020-09-09 aerotwist@chromium.org Migrates theme patching to top-level ThemeSupport 2020-09-09 chrche@microsoft.com [Loc] Presubmit#2: prevent using of LocV1 APIs in migrated files 2020-09-09 jacktfranklin@chromium.org Persist the network filter text input. 2020-09-09 jacktfranklin@chromium.org Expose the live directive from LitHtml 2020-09-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1099162,chromium:1114694,chromium:1126348,chromium:1126630,chromium:941561 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8a1d1d6417827c6f55042ebdfab8bc114a3a9715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403627Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I6f6fb791f00075cffdb791d8297289cbea383a4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401047Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#805771}
-
ckitagawa authored
Improve test coverage for PaintPreviewTabService by covering auditing. Change-Id: I4482732105561f1576900a79f4d68479b90f4604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402161Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#805770}
-
