GitLab

The original CL was reverted because of a test failure that was since
then fixed in CL 1194509

This is a reland of 468ce86a

Original change's description:
> CrOS Shelf: add background over app list
>
> Currently the shelf is fully transparent when the app
> list is open. In thr new UI, we want to make it slightly
> darker to distinguish it from the app list.
>
> Bug: 878601
> Change-Id: I5167e684e174c2d48334f45fa9b1c66e79ba32b7
> Reviewed-on: https://chromium-review.googlesource.com/1194067
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Manu Cornet <manucornet@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587137}

TBR=xiyuan@chromium.org
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Bug: 878601
Change-Id: Ife5ed29f3c325de1665181cac2eb5fe1b39971fc
Reviewed-on: https://chromium-review.googlesource.com/1196144
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587358}

- Change CachedPathToId() to return base::Optional.
- Use more C++11 features.
- Use more early returns and mark things const when it makes sense.

Change-Id: I8f8cc6d5aac232d526b18abf6eea347a3161ee5d
Reviewed-on: https://chromium-review.googlesource.com/1193930Reviewed-by: Anand Mistry <amistry@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587357}

The SuggestAnswer fields in SuggestResult and AutocompleteMatch are
currently unique_ptr's to the actual answer, so that we don't have to
populate them if not present. This requires us to have custom copy
constructor and assignment methods. This CL changes the fields to
base::Optional<>. This allows copying and assignment to work
implicitly.

# For cocoa...unittest.mm tweak
TBR=ellyjones@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I5a42375fa855976aa0fab996be28a5ff44213e02
Reviewed-on: https://chromium-review.googlesource.com/1181165
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587356}

The first bug is that the WebAuthn dialog is never shown if caBLE is
enabled but the |cable_extension| is not provided in the GetAssertion
request.

It's because GetAssertionRequestHandler's constructor will not actually
create and start a FidoCableDiscovery if the request is missing the
|cable_extension| data, while FidoRequestHandlerBase's barrier closure
will still wait for the discovery to start the transport protocol is
marked available in |available_transports|.

The second bug is that caBLE will not be used for a GetAssertion request
if the same web page already issued a MakeCredential request before.

This is because AuthenticatorImpl::MakeCredential will remove caBLE
from |protocols_|. However, the same AuthenticatorImpl instance will be
used to service the GetAssertionRequest, which will already see a
trimmed list of |protocols_| without caBLE, and pass it to
GetAssertionRequestHandler.

Bug: 878877
Change-Id: I6b7c915fc0de63e6da29399825071734405e424c
Reviewed-on: https://chromium-review.googlesource.com/1194040Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587355}

This reverts commit 468ce86a.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 587137 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzQ2OGNlODZhMDEwY2U4MzEzZTZiOTJhNGZmYjhhNGEzODYxODkzNDIM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28784

Sample Failed Step: ash_unittests

Original change's description:
> CrOS Shelf: add background over app list
> 
> Currently the shelf is fully transparent when the app
> list is open. In thr new UI, we want to make it slightly
> darker to distinguish it from the app list.
> 
> Bug: 878601
> Change-Id: I5167e684e174c2d48334f45fa9b1c66e79ba32b7
> Reviewed-on: https://chromium-review.googlesource.com/1194067
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Manu Cornet <manucornet@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587137}

Change-Id: I92133a3f12ad29bd54f2d20f8f1bba53b7d1762a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 878601
Reviewed-on: https://chromium-review.googlesource.com/1196027
Cr-Commit-Position: refs/heads/master@{#587354}

This patch enables the just-in-time installation of a payment handler
when merchant website calls PaymentRequest.show() with a user gesture.

Bug: 866996
Change-Id: I38b1ae7f672201f19ebe4011e22323ec5a572f36
Reviewed-on: https://chromium-review.googlesource.com/1190406Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587353}

We misunderstood how authentication token works in the past. For one time request,
the token expiration time don't matter much.

Setting a high timeout expiration is making luci-auth fail flakily. Since we
generate a new token for every perf dashboard upload attempt, using the default
value of luci-auth should be fine

Bug:878916
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: Ie9025fb0fc2467dda02cd8aa0aa3e2136ca190a8

NOTRY=true # all tests passed, speed up landing to green up perf waterfall uploading

Change-Id: Ie9025fb0fc2467dda02cd8aa0aa3e2136ca190a8
Reviewed-on: https://chromium-review.googlesource.com/1195930
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587352}

Change-Id: I1e715390161876f72de0ad5c9496f81c0a6939ee
Reviewed-on: https://chromium-review.googlesource.com/1188890
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587351}

Fixes a future warning with -Wshorten-64-to-32.

../../components/history/core/common/thumbnail_score_unittest.cc(86,33):  warning: implicit conversion loses integer precision: 'const int64_t' (aka 'const long long') to 'int' [-Wshorten-64-to-32]
      base::TimeDelta::FromDays(ThumbnailScore::kUpdateThumbnailTimeDays);
      ~~~~                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Also, remove an unused definition and some minor cleanup.

BUG=588506

Change-Id: I447c758454d0868cf1d023772c05464bc6e40262
Reviewed-on: https://chromium-review.googlesource.com/1195656Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587350}

The previous attempt to land this CL was reverted because an early call
to PlatformThread::SetCurrentThreadPriority() in headless caused the
FeatureList to be accessed before it was initialized. This CL avoids
accessing an uninitialized FeatureList if the target priority is not
BACKGROUND.

Diff between ps 1 and 5 shows changes made since revert.

Previous attempts to land:
  https://chromium-review.googlesource.com/1171482
  https://chromium-review.googlesource.com/1185529
  https://chromium-review.googlesource.com/1190842

NOTE: If this causes new test failures, we'll add the value returned
by GetThreadPriority() to the switch/case of allowed values.

This CL adds a feature to use THREAD_MODE_BACKGROUND_BEGIN instead of
THREAD_PRIORITY_LOWEST for ThreadPriority::BACKGROUND threads. This
lowers the disk and network I/O priority of the thread in addition to
the CPU scheduling priority. MSDN recommends using this setting for
threads that perform background work.
https://docs.microsoft.com/en-us/windows/desktop/api/processthreadsapi/nf-processthreadsapi-setthreadpriority

Bug: 872820
Change-Id: I2c9f17390eaaba2f8f454faa29836bbc37e3d47c
Reviewed-on: https://chromium-review.googlesource.com/1195677
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587349}

This is probably some weird condition between submitting
change 1194067 (change shelf background over app list) and
change 1188848 (enable new shelf UI by default).

Bug: 878601
Change-Id: I0ffb0ef3e27f9b4412a7e75409d70c367e53326e
Reviewed-on: https://chromium-review.googlesource.com/1194509Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587348}

Bug:878944
Change-Id: I5a802921bc4de918811d011a246b1daa56c9cbfb

TBR=wutao@chromium.org

Change-Id: I5a802921bc4de918811d011a246b1daa56c9cbfb
Reviewed-on: https://chromium-review.googlesource.com/1195933Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#587347}

This adds a service implementing the Fuchsia net.oldhttp FIDL
interface as a discoverable service. This is achieved by making
use of the Chromium //net API, in particular net::URLRequest.

Change-Id: I7f548fff6bcaeb9f039e6d01afa32fe5bb3b552a
Bug: 874155
Test: Coming soon!
Reviewed-on: https://chromium-review.googlesource.com/1152542
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587346}

In Google Chrome builds, cast_toolbar_button.cc may be built in the same
unit as cast_dialog_sink_button.cc. The latter includes a Google
Chrome-only header that declares some vector icons in the
::media_router::vector_icons namespace. As a result, the icons used in
cast_toolbar_button.cc can't be found because the points of use are in
the ::media_router namespace. Fix this by explicitly looking in
::vector_icons for the desired icons. This has no change for non-jumbo
builds, and fixes the world for jumbo builds.

BUG=803406
R=ellyjones@chromium.org
CC=oscarj@opera.com

Change-Id: I6af8e2593b20e1b674e8045fc406f12b9664fcb4
Reviewed-on: https://chromium-review.googlesource.com/1195885
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587345}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9342ac02c1ce..cb32668137d0


git log 9342ac02c1ce..cb32668137d0 --date=short --no-merges --format='%ad %ae %s'
2018-08-29 martiniss@google.com git cl split: Don't cq dry run by default


Created with:
  gclient setdep -r src/third_party/depot_tools@cb32668137d0

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:878117
TBR=agable@chromium.org

Change-Id: I80a47ddeb83b5c4ed69399d695e97e078bcf2a3a
Reviewed-on: https://chromium-review.googlesource.com/1195868Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587344}

RulesRegistryService posts tasks to the IO thread which access
ExtensionWebRequestEventRouter::GetInstance().
ExtensionWebRequestEventRouter accesses ExtensionsAPIClient::Get(),
which used to be destroyed before the tasks could run in some
situations. This change moves destruction of ExtensionsAPIClient
to ShellBrowserMainParts::PostDestroyThreads(), which should be
safe since tasks will no longer run at that time.

Bug: 866904
Change-Id: I974d474d08ff9d7c0c727a7c95d26f04363ce7f0
Reviewed-on: https://chromium-review.googlesource.com/1194579
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587343}

https://skia.googlesource.com/skia.git/+log/a81c2be75adc..eb0bb732f43f


git log a81c2be75adc..eb0bb732f43f --date=short --no-merges --format='%ad %ae %s'
2018-08-29 herb@google.com Revert "Check that mask to path fallback happens"
2018-08-29 mtklein@google.com Revert "Use skcms_PrimariesToXYZD50 to implement SkColorSpacePrimaries::toXYZD50"
2018-08-29 robertphillips@google.com Revert "Always force GPU generated masks be top left"
2018-08-29 herb@google.com Managing the context was dropped. Adding back in.
2018-08-29 brianosman@google.com Use skcms_PrimariesToXYZD50 to implement SkColorSpacePrimaries::toXYZD50
2018-08-29 bsalomon@google.com Fix GrGLGpu::createTestingOnlyBackendRenderTarget()
2018-08-29 herb@google.com Check that mask to path fallback happens
2018-08-29 kjlubick@google.com [LottieWeb] Fix frames
2018-08-29 mtklein@google.com fix two 1-bit mismatches in sRGB transfer functions
2018-08-29 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 94d4660dd3f1..60f8662dc0ef (3 commits)
2018-08-29 robertphillips@google.com Always force GPU generated masks be top left
2018-08-29 herb@google.com Add an empty typeface for testing
2018-08-29 allanmac@google.com Update HotSort cl/vk.
2018-08-29 benjaminwagner@google.com [infra] Update Win Radeon drivers.
2018-08-29 benjaminwagner@google.com Update NVIDIA_Shield to Oreo.
2018-08-29 reed@google.com clean up for removing drawTextOnPath from canvas
2018-08-29 csmartdalton@google.com Add a tolerance to SkRemoteGlyphCache_DrawTextAsPath
2018-08-29 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms da25e1a6d412..6b324dbdf772 (1 commits)
2018-08-29 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 5f03dc9abfb1..da25e1a6d412 (1 commits)
2018-08-29 bsalomon@google.com Temporarily make SkTMultiMap::remove() safe for values not in map
2018-08-29 kjlubick@google.com Correct LottieWeb drawing params
2018-08-29 reed@google.com textonpath no longer in canvas
2018-08-29 michaelludwig@google.com Add setXi and setXiv in GrGLSLProgramDataManager.
2018-08-29 kjlubick@google.com [PathKit] Make pathops assertion a little more forgiving
2018-08-29 brianosman@google.com Remove unused onCanLazyGenerateOnGPU function
2018-08-29 reed@google.com Revert "fix g3 by adding legacy flag"


Created with:
  gclient setdep -r src/third_party/skia@eb0bb732f43f

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:876767,chromium:878195,chromium:877611,chromium:876767,chromium:878195,chromium:877915
TBR=stephana@chromium.org

Change-Id: I312b4a2f488d247a3d7d4bf79453855767290c47
Reviewed-on: https://chromium-review.googlesource.com/1195867Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587342}

isConnected() bit was not correctly cleared because of this.

Bug: 878696
Change-Id: I09d69c94eb5f9c9f4694a6ff1a473a112c895c8d
Reviewed-on: https://chromium-review.googlesource.com/1194225Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587341}

https://chromium.googlesource.com/webm/libvpx.git/+log/5de95cb09ff6..0bfab06084e4

$ git log 5de95cb09..0bfab0608 --date=short --no-merges --format='%ad %ae %s'
2018-08-28 johann.koenig rtcd: fix --required flag
2018-08-27 huisu Skip unnecessary motion search

Created with:
  roll-dep src/third_party/libvpx/source/libvpx

chromium has required sse2 since M35/2014:
https://support.google.com/chrome/a/answer/7100626

This reduces win32 size by over half a megabyte.

BUG=chromium:876548
R=jzern@chromium.org

Change-Id: I673b2f52280dc7df0cf86f7ace52a9a7a643ceef
Reviewed-on: https://chromium-review.googlesource.com/1195800Reviewed-by: James Zern <jzern@google.com>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#587340}

Bug: None
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ib69e3147dccd2ee7bbeedbd50c0f604240291bfb
Reviewed-on: https://chromium-review.googlesource.com/1192343
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587339}

This is the last step after moving all the code.
Sorry for the ginormous review. It would have been tedious to split
up.

BUG=876924
TEST=covered by tests
TBR=tsepez@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I237c4377115ad12fefb95a1bcf2eabe1cbef3414
Reviewed-on: https://chromium-review.googlesource.com/1195809Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587338}

Instead, combine the length check with the reading. This means we don't need
the iterator access to match CanConsume calls above it.

Bug: none
Change-Id: I541048c0f399d90650e87c3b995ac3a0ad9fccb6
Reviewed-on: https://chromium-review.googlesource.com/1195708
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587337}

Add weidongg@ and newcomer@ to ash/app_list OWNERS after talking to
xiyuan@.

Change-Id: Icee73a00b2354cd2a7b1d29475d1620dfe1fefbf
Reviewed-on: https://chromium-review.googlesource.com/1195893
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587336}

In this CL, we wire up the migration request and response. The workflow of issue request and parse response are executed in thie CL.

Bug: 852904
Change-Id: Ic58c11116c4cc90b44f555269a7a8f6c89483ed9
Reviewed-on: https://chromium-review.googlesource.com/1189169
Commit-Queue: Sujie Zhu <sujiezhu@google.com>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587335}

Much of this code is essentially identical. What remains different is just
a couple syscalls (of which there are many variations in threading_pthreads
already), and the implementations of mutexes and condition variables, which
we hope to remove soon (and so have been left where they are).

Bug: 856641
Change-Id: I7c658a0fe65fb6a3428ff4b215397da410d2233a
Reviewed-on: https://chromium-review.googlesource.com/1195713
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587334}

Bug: b:112925587
Test: locally build and test
Change-Id: I6f9385691196319b693cea98a874c7322c330e1a
Reviewed-on: https://chromium-review.googlesource.com/1192361Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587333}

Bug: None
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I004609fbdc2ca0a831f363448784254a34c47809
Reviewed-on: https://chromium-review.googlesource.com/1191093Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587332}

Adding an additional div container on top of the "customize this page"
dialog can make sure the dialog will close only when we click outside
the dialog. Also, clicking on the disabled option will no longer close
the dialog.

Bug: 874828
Change-Id: Ibe16d3e898feefa716cf09e49a52c8a788de254c
Reviewed-on: https://chromium-review.googlesource.com/1195716Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587331}

Implement Loading Journal for Journal storage, and initialize journal
Storage.

Bug: 877993

Change-Id: I08d08747675f1e17ceddd14572f7dbdd073cc64e
Reviewed-on: https://chromium-review.googlesource.com/1188940
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587330}

TBR=thestig@chromium.org (chrome-side changes to content things reviewed by nasko)

Bug: 560446
Change-Id: Ide985dde1d01949445b6c0d23ebdfbe0ad4330f8
Reviewed-on: https://chromium-review.googlesource.com/1194838
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587329}

+ Update grey 50, 100, 200, 300, 400, 600 to the new color
+ Update blue button corner radius to 4dp
+ Make affecting xml files to use pre-defined text styles

Bug: 849126
Change-Id: I44276c6539d2ac1f30a3bd8dcde1dcfc26b103f7
Reviewed-on: https://chromium-review.googlesource.com/1188456
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587328}

BUG=none
R=huangs@chromium.org
TBR=zmin@chromium.org

Change-Id: I40bbef9829a911fd7c4bece2aebb34a3cb74afb8
Reviewed-on: https://chromium-review.googlesource.com/1195088
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587327}

Bug: 872403
Change-Id: Idcaa05e31b7b039cb957d21b95e06d494727669e
Reviewed-on: https://chromium-review.googlesource.com/1195882
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Rahul Chaturvedi <rkc@chromium.org>
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587326}

This change fixes an issue when calling PostTaskWithTraitsAndReply with a
reply that has an unretained pointer to the member class. Because of a race in
tests, SmbService would be torn down and the reply would be run with a pointer
to SmbService resulting in a crash.

Bug: chromium:757625
Change-Id: Ide6b8dd4e05032c504152fafab88ec561d40e30a
Reviewed-on: https://chromium-review.googlesource.com/1195845Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587325}

Right now at TouchActionFilter::FilterGestureEvent, if there is a
GestureTapDown, we append an "O" into the debug string. This CL makes
it append "O1" if the |scrolling_touch_action_| has value, and "O2"
if it doesn't.

TBR=dtapuska@chromium.org

Bug: None
Change-Id: I71cd23cef21e73add2bb5c3f5ec9af0ca7acb4e6
Reviewed-on: https://chromium-review.googlesource.com/1195812Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587324}

The original metrics are deprecated, and new metrics are recorded according to
the WebAPK's distributor from where the WebAPK is installed. The distributor
could be:
- WebApk.ShellApkVersion2.Browser, WebApk.ShellApkVersion2.DevicePolicy, and
  WebApk.ShellApkVersion2.Other.

- WebApk.Session.TotalDuration2.Browser,
  WebApk.Session.TotalDuration2.DevicePolicy, and
  WebApk.Session.TotalDuration2.Other.

Also add the attribute of distributor in WebApkInfo.

Change-Id: I47bfaae24d0c44135de1eeab283b20fcd0d52f47
Reviewed-on: https://chromium-review.googlesource.com/1191702
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587323}

I ran the test locally a 100 times and could not repro, but I
found we weren't clearing out the dialog reference in the
dismiss calls (just the dialog on dismiss handler), so this
makes it happen always.  This also adds the logic to wait for the
dialog to be null to avoid any races in the android handling of
dialog dismissal.

BUG=878651

Change-Id: Id4ae17479b9e4ad29b67e6fd9da9673ddc8a7ee6
Reviewed-on: https://chromium-review.googlesource.com/1195744Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587322}

This function was only used in a single test which ensured that it was
called. Removing it.

TBR=sadrul for uninteresting chnage (removing unused interface fn) in power_event_observer.cc
TBR=thakis for uninteresting change (removing unused interface fn) in chrome/browser/*

Bug: 835353
Change-Id: Icdd8b073e84f54a43d31d2de1690ed6280c194bb
Reviewed-on: https://chromium-review.googlesource.com/1195671Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587321}

These DCHECK()s cause a crash on login when debug mode is enabled (see
https://crbug.com/878653).

Bug: 878653
Change-Id: Iae62dc0bd75018a175299efbae3cb616ae21bc5c
Reviewed-on: https://chromium-review.googlesource.com/1195931Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587320}

Changed the icon and action link text per spec.

Bug: 852577
Change-Id: I7d3a260ead0d1c0affcbde35a343bacd0f5b34c7
Reviewed-on: https://chromium-review.googlesource.com/1195923Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587319}