GitLab

Change-Id: I63883c00ba35e246f408f18456e5f1afcbc80ac5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062788
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742342}

This change is part of the post-launch cleanup of ZPS, Rich Entities
and Favicons bundle.

Bug: 1051551
Change-Id: I1e4799caea79d98a258ab891fd513fc4e659b37e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049833Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#742341}

This is a mechanical change to remove implicit conversions of
ScopedBstr to BSTR.

BUG=1034666

Change-Id: I4a143eb0babc4ed0be9e761ebd29531baf2916a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063528Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742340}

Add ProfileCardUtil.java.

Bug: 1051149
Change-Id: Ib27295d2b01c59f09a10b306f9f28cf6f4a34811
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062931
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742339}

When an ExecutionContext is abruptly/unexpectedly destroyed (e.g.
shutting down of document or iframe), an AudioContext can also
go away. This type of shutdown can be problematic because the render
thread still might be touching resources in the AudioContext allocated
by the main thread.

This CL introduces a self-referencing pointer to the AudioContext,
and it is cleared after the underlying render thread is stopped. In
that way, the destruction of AudioContext can be done safely.

Test: Locally confirmed the repro case doesn't crash (UAP) after 1hr.
Bug: 1043446
Change-Id: I2e40b7d58ca9d647eed8a5971fc69dc87ee3d1fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049912Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742338}

Non-foreground tabs were being reattached in the reverse order, but this
is unnecessary since the default add behavior adds the tabs to the end.

Bug: 1053388
Change-Id: Id768184cf3d02b679568eb3d0f72a262dacc522d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062686Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742337}

Forward a stop session request from CastSessionClientImpl to
CastMessageHandler.

Bug: 1040184
Change-Id: I74e16506bd7674ad21809982c0d7e7c7150936a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055560Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742336}

Register it in ChromePreferenceKeys and use SharedPreferencesManager
consistently instead of SharedPreferences directly.

Bug: 1022108
Change-Id: I4fc46ea16906ff673aff28b403ac3cd026fbb480
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037325
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742335}

A couple referrer-related histograms are expiring soon:
- Net.URLRequest.ReferrerPolicyForRequest logs the referrer policies of
outgoing requests
- Net.URLRequest.ReferrerHasInformativePath logs whether a referrer
contains more information than just its origin (this is used for
evaluating the usefulness of referrer policies that cap referrers to
requests' initiating origins)

This CL extends their lifetimes because these metrics will remain useful
for ongoing experimentation and post-rollout success tracking.

R=csharrison

Fixed: 1053277
Change-Id: I38e3f2cbf8b959a06aaf37795f7e9b9b75f98d7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062293Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742334}

events_referenceSpace_Reset_inline was always timing out because the
reset event was never sent. It turns out that this is because the
frame_data that was being used to process inline sessions was always
nullptr, rather than using the frame data associated with a particular
inline session. This change modifies the requesting_sessions_ map to
store the frame data rather than just the pose, and to process the frame
data for a particular session with that session.

Fixed: 1015195
Change-Id: I3a5d1b619869b57c270304f46bd19b43685869bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062897
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742333}

5a8c22864134 Add document for base94_encoder
07812f5bd615 android: fix the gyp build
faed21a28625 linux: Log register sizes on mismatch

Change-Id: I532f7090eb07f640917a37e929573bd4c8d45ac5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062936
Commit-Queue: Mark Mentovai <mark@chromium.org>
Auto-Submit: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742332}

|signinCompletion| has to be set by the owner of the SigninCoordinator
to track when the the sign-in is done, when the coordinator can be
released.
Adding DCHECK(self.signinCompletion) in -[SigninCoordinator start], to
enforce it.

Once the completion block is called, the property is set to nil.
Adding DCHECK(!self.signinCompletion) in -[SigninCoordinator stop], to
make sure the callback is called before stopping the coordinator.

Bug: 971989
Change-Id: I0bfcc2579a8824bc6e4b8345221542bcf5819359
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053129
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742331}

This CL adds an integration test for Maps Go WebAPK's first run
experience.

Bug: 689142
Change-Id: I3c86841b269d94c0a7c08704a9cb681ec9e4e03e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025917
Commit-Queue: Henry Jian <hzjian@google.com>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Andrew Luo <aluo@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742330}

The final response URL is calculated from the redirect chain, URLs
fetched by the service worker and the initial request URL.

The logic is mostly based on what
blink::ResourceResponse::ResponseUrl() does.

Bug: 986188, 1048332
Change-Id: I74dab2b68bbc7463114df25444658dcd0794fe77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036265
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742329}

Change-Id: Ib349e61075844d95458ed3b2d0fd313a888cd674
Bug: 1048862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056489Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742328}

Move MockHatsService to stand-alone files so it can be re-used in
other tests (it is expected to also be used in testing
Hats-related WebUI message handler.)

Bug: 1045348
Change-Id: If7f55fbeddb999c7dbfe184fe15be75785ceabb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044219
Commit-Queue: Huanzhong Huang <huanzhong@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742327}

RenderFrames could be reused for same-origin navigations. This causes
the hints from previous navigations to be used in next navigation
until the new hints fetch finishes and updates the hints. This CL clears
the hints.

Unfortunately this causes race conditions between the image fetch and
the hints update, which causes images to not redirected to compressed
versions. So the image fetches are delayed a bit to circumvent this.

Bug: 1051283
Change-Id: Ie9e5351e68c0081ab9dbfe23faed2c3c5e8e4d42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056207
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742326}

TBR=govind@chromium.org

Change-Id: I7acc0ab00daa28f53f2c2f1e0eda99d6356f43bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063249Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742325}

Change-Id: I6831f6b34bfa4891a17bc7dbb1145b436f6e5213
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062690
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742324}

These code path that isn't activated anymore. Pepper will always be
composited so remove the IsAcceleratedCompositingActive method from
WebWidget.

The is_accelerated_compsiting_active_ bool was never set on the
WebFrameWidgetImpl as well.

Change-Id: I52e561863c2258694282d3aee9737f91f8fd282b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062549Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742323}

This CL combines several block for the initial layout pass into a single
block.  Additionally, this CL updates the layout of the primary toolbar
layout so that it is behind the tab strip on iPad and in back of the
typing shield on iPhone.  This more explicitly describes the semantic
purpose of the previous |bottomView| logic.

Bug: none
Change-Id: I272882c4958afd2cdc25694a508bfe9119cb7db4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045212
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742322}

This reverts commit 388f1d99.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 742315 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzM4OGYxZDk5NzYyYzAzM2U0NzBhY2U0N2QxOGY5ZWU0NGU4NzRkN2QM

Sample Failed Build: https://ci.chromium.org/b/8888080110640214784

Sample Failed Step: compile

Original change's description:
> Reland "Enable ATK and Glib on Linux/Ozone"
> 
> This is a reland of 16c153e6
> 
> Original change's description:
> > Enable ATK and Glib on Linux/Ozone
> >
> > BUG=988094,1014934
> > R=sky
> > CC=nickdiego,msisov,adunaev
> >
> > Change-Id: I05b4bae5ccce53053ad4ae8269db849c2db9e569
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056570
> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> > Reviewed-by: Nick Yamane <nickdiego@igalia.com>
> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#742233}
> 
> TBR=sadrul,jamiewalch
> 
> Bug: 988094, 1014934
> Change-Id: Ide8b89767eddbdd6e6751db58c92d64e2d756fec
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062911
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#742315}


Change-Id: I06b8d6a675b1e862fb073345694639c0da024e0a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 988094, 1014934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063257
Cr-Commit-Position: refs/heads/master@{#742321}

This was added in [1] to deal with the login web page. I believe
this is no longer relevant.

[1] https://chromiumcodereview.appspot.com/10454017

Bug: None
Test: login/oobe screen works as is.
Change-Id: Ib6275fe7a4c934797631e00c1c4a29ed650b5502
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062672Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742320}

This is a reland of 11357e7b

Original change's description:
> Proof of concept for XPC service in the updater.
> 
> Continues https://chromium-review.googlesource.com/c/chromium/src/+/2045058
> 
> Rebased. Moved code to the new chrome/updater/server/mac/server.mm::LaunchServer, addressed more feedback.
> 
> Need to create a plist for the xpc service. It is not clear yet what executatble will be used.
> 
> Bug: 1048653
> Change-Id: Iadbbd7004afa39fcc902f2ec68297845c2f94571
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055284
> Commit-Queue: Mila Green <milagreen@chromium.org>
> Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
> Reviewed-by: Sorin Jianu <sorin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#742204}

Bug: 1048653
Change-Id: Ie6dbf13727627c9a448a1044bf059a82f33745cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062872Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Mila Green <milagreen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742319}

https://chromium.googlesource.com/angle/angle.git/+log/f87fac56d22f..4b7bac78a9ea

git log f87fac56d22f..4b7bac78a9ea --date=short --first-parent --format='%ad %ae %s'
2020-02-18 jmadill@chromium.org Vulkan: Throttle when way ahead of device.
2020-02-18 jmadill@chromium.org Vulkan: Command graph linearization for SemaphoreVk.
2020-02-18 lexa.knyazev@gmail.com Move sampleAlphaToCoverage out of blendState

Created with:
  gclient setdep -r src/third_party/angle@4b7bac78a9ea

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I9d353c87c0d620af2f276f806f7e70eb40d50191
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062799Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742318}

InstallServiceWorkItem is something that is useful to have outside Chrome Setup. So this work item is for moving it to installer/util.

Bug: 1051723
Change-Id: I442e9de86394099c9c67483020915d609c6a51f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053083
Commit-Queue: S. Ganesh <ganesh@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742317}

Bug: 982818
Change-Id: I49058c6b533e0f7355020b3c9bf7644d25bf5e56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052597Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#742316}

This is a reland of 16c153e6

Original change's description:
> Enable ATK and Glib on Linux/Ozone
>
> BUG=988094,1014934
> R=sky
> CC=nickdiego,msisov,adunaev
>
> Change-Id: I05b4bae5ccce53053ad4ae8269db849c2db9e569
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056570
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Reviewed-by: Nick Yamane <nickdiego@igalia.com>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#742233}

TBR=sadrul,jamiewalch

Bug: 988094, 1014934
Change-Id: Ide8b89767eddbdd6e6751db58c92d64e2d756fec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062911Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742315}

Using wpt-import in Chromium d97232ca.
With Chromium commits locally applied on WPT:
ec83d167 "Update performance.measureMemory to the latest proposal"
d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I05b667e8d26fe1ee172e129b72424d29ec3a3fd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063109Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742314}

views::ImageButton flips canvas by default.

Bug: b:149256457
Change-Id: I4399508956fb2c3a98c4edf2fbaa82df321178b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056941Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#742313}

This is a reland of [1], which was accidentally removed by [2].  The
only difference is the gethostname() check is removed to address [3].

> For remote connections, SHM doesn't work, but the MIT-SHM extension
> may still be available, so we need to do an explicit check before
> trying to use SHM.

[1] https://chromium.googlesource.com/chromium/src/+/633c011511bae4ff193ac007e3e8ba64287c1d89
[2] https://chromium.googlesource.com/chromium/src/+/12a86d61adf2520c177ed51aec6583f490e29f7d
[3] https://bugs.chromium.org/p/chromium/issues/detail?id=1035803#c12

R=nickdiego
BUG=1035803

Change-Id: I5b707de48a8c2991aaf73c347b29ef813a9c28b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062900
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Nick Yamane <nickdiego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#742312}

Right now, MenuScrollViewContainer claims to be an AXMenuBar, which
produces the following puzzling AX tree:

  AXGroup (menu root)
    AXMenuBar (scroll container)
      AXMenu (actual menu view)
        AXMenuItem ...

An AXMenuBar is something like the top system menu bar, at least on
macOS, not the "contents of a menu" or anything similar to that. After
this change, the AX tree is instead:

  AXGroup (menu root)
    AXMenu (actual menu view)
      AXMenuItem ...

which makes much more sense.

Bug: 954701
Change-Id: I00215874d75d9ee4870acd0e2101ef280dc2a199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962587
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742311}

The recommendation is to use IFACEMETHODIMP and STDMETHODIMP in the
declaration.

See discussion thread at
https://groups.google.com/a/chromium.org/g/cxx/c/h4bdRqbduNY/

Change-Id: I810cfdec17917d7b758f5a3f050a8dfc70aedcf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051200Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742310}

Display the deep scan request and response on chrome://safe-browsing for
debugging purposes

Screenshot: https://screenshot.googleplex.com/3Yk21T8p379.png
Bug: 1021945
Change-Id: I52c6a882069f014993fb50902d3c604c8c84b7d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055991Reviewed-by: Bettina Dea <bdea@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742309}

We originally disallowed same-document scroll to text navigations as a
security mitigation. We now have a better idea of the security concerns,
which are mitigated by ensuring the frame is not script accessible by
another frame, in which case it is safe to do a same-document scroll to
text navigation.

Even for same-document scroll to text navigations, we still require it
to be a browser navigation (e.g. same-document bookmark clicked).

Bug: 1041065 1023640
Change-Id: I2924ae9fc4bb01db4b75f184cc1fb70fae487b1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999000
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742308}

In r718454 we removed a magic constant from ScrollIntoView that
considered elements horizontally onscreen by more than 32px to be
fully-visible. This made it so that elements partially offscreen
horizontally would now be scrolled fully into view, just like in the
vertical axis. This was helpful as it makes ScrollIntoView more
predictable and interoperable with Gecko.

However, it caused issues for commonly occurring patterns. DevTools in
particular has several of these. It's common to have lists and similar
controls that are scrollable only vertically but may have some elements
that overflow (and are clipped) horizontally. In these cases, navigating
focus through the list should cause scrolling vertically but not
horizontally.

WebKit has this behavior as a result of the magic constant mentioned
above (from focus as well as scrollIntoView). Gecko has similar behavior
but only for focus and in both axes. More details in [1]

This CL makes it so that scroll into view coming from a focus() will
avoid scrolling partially visible elements in the horizontal axis. This
is close to what Gecko does but we still scroll in the vertical
direction. We keep the vertical axis because it's existing behavior and
likely desirable (if the last element in such a list isn't fully in view
it won't be able to be brought into view since there's no items to focus
below it).

We also rewrote the scroll-element-into-view web_test to make it more
modern and easier to manually test. In the process, the expectations are
updated since partially onscreen elements no longer scroll horizontally.
Prior to r718454, this test passed because the element was partially on
screen by less than the 32px threshold amount.

[1] https://github.com/w3c/csswg-drafts/issues/4778

Bug: 916631,1036817,1050868,1050979
Change-Id: Iff058123e368a6659a313ab3bb1a568187da1e23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056752Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742307}

This CL fixes the crash generated from
blink::scheduler::`anonymous namespace'::TaskTypesFromFieldTrialParam.

Refactors the code for InitializeTaskTypeQueueTraitsMap, lot of the code used
for testing the feature kThrottleAndFreezeTaskTypes is not being used any more.

Bug: 1049800
Change-Id: I8237981149b7518084d480cb79da047b876b8c3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057265
Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Scott Haseley <shaseley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742306}

A CL has been landed to fix software decode video path on vulkan -
https://chromium-review.googlesource.com/c/chromium/src/+/2045130.

So enabling the media tests now which are passing on pixel2 skia
vulkan bot.

TBR=ynovikov@chromium.org

Bug: 985387
Change-Id: Iac61d31ccb12e35586e238e6c7780011385d86e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057540Reviewed-by: vikas soni <vikassoni@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742305}

Adding default page break too early will cause the default page break
gets deleted immediately.

Now move the installation of default page break after ChromeOS settings
app is installed.

Bug: 1031410
Test: Manual

Change-Id: If8d6522993518ccc109ac0bf368cdd077a97f301
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056578Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Long Cheng <lgcheng@google.com>
Cr-Commit-Position: refs/heads/master@{#742304}

When returning to the NTP after native is initialized, the native init
observer registration has no effect. This adds a check to for this
and triggers the colorful mic behavior immediately if native is already
initialized.

Bug: 1052073
Change-Id: I229ddebb16ddeb418219275874552e54fb64646e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055389
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742303}