- 07 May, 2018 40 commits
-
-
Nicolas Pena authored
Change-Id: I8a7183bbd848f22a17888b60ed4475a87a64ec3d Reviewed-on: https://chromium-review.googlesource.com/1040776 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#556451}
-
Michael Lippautz authored
This reverts commit bd9ac13a. Reason for revert: Unfortunately there's another V8 CL close which massively affects speedometer. We need to reland to get a clear picture. Original change's description: > [oilpan] Enable incremental marking buildflag > > Includes incremental garbage collection infrastructure in regular > builds. Does not enable incremental marking at runtime! > > This CL may cause throughput regressions and is an attempt > to collect a broad range of potential performance issues. > > Bug: chromium:757440 > Change-Id: If4d91be2eb325417736a38e27c481ab23ce7a0e9 > Reviewed-on: https://chromium-review.googlesource.com/1041986 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555698} TBR=haraken@chromium.org,keishi@chromium.org,hpayer@chromium.org,mlippautz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:757440 Change-Id: I87dd96d9b9cd142503ff22534b8207da27b8c352 Reviewed-on: https://chromium-review.googlesource.com/1047265Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#556450}
-
Marc Treib authored
Instead, use GetAuthenticatedAccountInfo throughout ProfileSyncService. One more step on the way to eventually getting rid of SigninManagerWrapper. Bug: 825190 Change-Id: Icca7037b2f47f1bba3c549080f97ba3824ad9f77 Reviewed-on: https://chromium-review.googlesource.com/1046950 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#556449}
-
Mark Pilgrim authored
Bug: 773295 Change-Id: Ib6b33bb7ea7c8978a9ee43383b22e5ee2546ba4c Reviewed-on: https://chromium-review.googlesource.com/1044348Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Pam Greene (Please send IM for reviews) <pam@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#556448}
-
Mark Pilgrim authored
The previous attempt was reverted because it crashed. This attempt features a crash test which reproduces the crash when run against the previous CL, and confirms that this CL does not crash. The cause of the crash was a reference to simple_url_loader after it had been std:move'd. This CL instead gets a reference to the newly moved pointer. previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1025068 revert CL: https://chromium-review.googlesource.com/c/chromium/src/+/1030590 Bug: 773295 Test: ResetReportUploaderTest.NoCrash Change-Id: I7092ec501872dfa0019d37e8f9e10454458499db Reviewed-on: https://chromium-review.googlesource.com/1042359 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
-
Amirhossein Simjour authored
When in VR, CVC popup does not show properly, so there is no support for server side credit cards. GetCreditCardSuggestions in autofill_manager is updated to support a flag to decide whether the server side cards should be included or not. When in VR, we set the flag (include_server_cards) to false and don't show suggestions for server side cards. Bug: 831751 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I86b6a87ba88109d01ef84a6622096118f9970486 Reviewed-on: https://chromium-review.googlesource.com/1031200Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#556446}
-
https://chromium.googlesource.com/angle/angle.git/+log/e88e454803a7..54aafe58f5bd $ git log e88e45480..54aafe58f --date=short --no-merges --format='%ad %ae %s' 2018-04-27 jiawei.shao Use ShaderMap in Caps - Part I Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: If2ee0b23c59a0aa6ae82098022ad0e054168f230 Reviewed-on: https://chromium-review.googlesource.com/1046928 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556445}
-
Elly Fong-Jones authored
TBR=jbudorick@chromium.org Bug: 828031 Change-Id: I496e425a7a3a955b2bee4448d642466235ad3195 Reviewed-on: https://chromium-review.googlesource.com/1047326Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#556444}
-
Ella Ge authored
We were skipping Mac PointerEvent tests with pointerType = 'touch' because mac doesn't have touch event support. This CL adds InjectTouchEvent function in mac RWHV, which supports injecting WebTouchEvent to mac platform. This adds gesture_provider to mac RWHV for testing purpose and will be used on touch emulator in the future. Tests with multiple touch point is still failing because of an issue with SyntheticTouchDriver. Still skip these tests(crbug.com/613672) This Cl also correct that screen coordinate wasn't set when creating synthetic WebMouseEvent. Because of that PointerLock movementX_Y test is failing. On mac, movement_delta was set from NS event. The injected event doesn't set the movement. Skip these two tests until crbug.com/802067 is resolved. Bug: 613672 Change-Id: I78d442032ff36da2bc1ad3b84cc8ba9181ae8f0a Reviewed-on: https://chromium-review.googlesource.com/1039773 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#556443}
-
Guido Urdaneta authored
This reverts commit 1b89887a. Reason for revert: Apparently causes compilation failure on iOS bots. See https://ci.chromium.org/buildbot/chromium.mac/ios-device-xcode-clang/59633 Original change's description: > Roll src/third_party/webrtc/ 823f9135f..a5b903833 (1 commit) > > https://webrtc.googlesource.com/src.git/+log/823f9135f858..a5b903833f88 > > $ git log 823f9135f..a5b903833 --date=short --no-merges --format='%ad %ae %s' > > Created with: > roll-dep src/third_party/webrtc > > > The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng > TBR=webrtc-chromium-sheriffs-robots@google.com > > Change-Id: I93fc64657ce737b93f6ded1f7bf95a1ab27dc518 > Reviewed-on: https://chromium-review.googlesource.com/1046927 > Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#556431} TBR=webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com,webrtc-chromium-sheriffs-robots@google.com Change-Id: I60a4ac7b083df5c4c617e3324773b43d43de59b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1047166Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#556442}
-
Luke Zielinski authored
The previous approach of having a shared feature/param containing a csv of quota for all triggers makes it impossible to run more than one trigger trial at the same time (since the populations would be setting the same feature, even though the triggers run independently). More details at https://groups.google.com/a/google.com/forum/#!topic/chrome-safebrowsing-team/vx1yxXugwCY Bug: 817377 Change-Id: I02903e2bb722a8d5557a684b2d6c3788338c81c5 Reviewed-on: https://chromium-review.googlesource.com/1042377Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#556441}
-
Emily Hanley authored
From what I can see, bot_id is a gauranteed field in the query response vs assuming it comes back as a tag. Bug: 831252 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6cb0c48a1dce8ffcea35ce3ab65404366c450c9a Reviewed-on: https://chromium-review.googlesource.com/1047065 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#556440}
-
Michael Lippautz authored
Address cache is only actively used during roots marking. For incremental marking we pass over roots multiple times, each time potentially requires clearing the cache. Drive-by: - Add unit tests - Rename to AddressCache - Encapsulate handling fully in AddressCache - Remove outdated caller Bug: chromium:757440, chromium:830196 Change-Id: I51780e0bbbb8566ad0c83df98229e15133b42825 Reviewed-on: https://chromium-review.googlesource.com/1044214 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#556439}
-
François Beaufort authored
This is a temporary fix that sets document.pictureInPictureEnabled to false in the case of disabling the GPU. Bug: 806249, 807840 Change-Id: I84445a0231b46cfbd0bb2f25eaca53f96604ce55 Reviewed-on: https://chromium-review.googlesource.com/1042290 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#556438}
-
stkhapugin@chromium.org authored
Disables keyboard shortcuts for FIP (cmd+F, cmd+G, cmd+shift+G) on NTP and other pages where FIP is not available. Bug: 694971 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7f32c55760a2ed976bac085994223afa50c3b976 Reviewed-on: https://chromium-review.googlesource.com/1046829 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#556437}
-
Guido Urdaneta authored
TBR=chongz@chromium.org Bug: 840127 Change-Id: Idb63b21d4b1ea0c6b0eca07f6bcec0f7871dffbd Reviewed-on: https://chromium-review.googlesource.com/1046659Reviewed-by:
-
Guido Urdaneta authored
Bug: 833333 Change-Id: I9154e97c07484c40a2f8308216d2c04d02fae528 Reviewed-on: https://chromium-review.googlesource.com/1021697Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#556435}
-
Guido Urdaneta authored
TBR=pennymac@chromium.org Bug: 840335 Change-Id: I023345430e1eb72038197ae079f880c8515b7598 Reviewed-on: https://chromium-review.googlesource.com/1047205Reviewed-by:
-
Ryan Daum authored
- Switches from detecting fling gestures to detecting touch events, making it possible to prevent the initial ET_TOUCH_PRESSED event from propagating (b/78461207) - Uses new handler interface, which includes HandleSideSwipeContinue, to allow gradual exposure of the bottom settings bar (b/78462154) and to allow using X delta moved instead of the gesture end event for back gesture detection in the future (b/78397215) Bug: b/78462154 Bug: b/78461207 Change-Id: Ic64e13825eaaa5cf8420e94df767a057563a8281 Tested: manual on device and unit test Reviewed-on: https://chromium-review.googlesource.com/1030614 Commit-Queue: Ryan Daum <rdaum@chromium.org> Reviewed-by:Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#556433}
-
Fady Samuel authored
After Visual Properties ACK (Resize ACK) was moved to the RenderFrameMetadataObserverClient interface, Mac web content no longer stuck to the edge of the window. This happened because WindowResizeHelper didn't see RenderFrameMetadata tasks and so did not schedule them until AFTER the resize deadline hit. This CL moves RenderFrameMetadataObserverClient tasks to the WindowResizeHelper's task_runner thereby fixing resize on Mac. Bug: 840197, 672962 Change-Id: If4f8a766a2322f1208b6ffccca89c5181f96bf8f Reviewed-on: https://chromium-review.googlesource.com/1046003Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#556432}
-
https://webrtc.googlesource.com/src.git/+log/823f9135f858..a5b903833f88 $ git log 823f9135f..a5b903833 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I93fc64657ce737b93f6ded1f7bf95a1ab27dc518 Reviewed-on: https://chromium-review.googlesource.com/1046927Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556431}
-
Guido Urdaneta authored
TBR=mfoltz@chromium.org Bug: 840165 Change-Id: I5e8f4db2b51b9a66c3fdb2d546f11965e0d65642 Reviewed-on: https://chromium-review.googlesource.com/1046830Reviewed-by:
-
Takuto Ikuta authored
This is for cl.exe build. Change-Id: Icce6bbb29225d2f77d4b1105778aa26d9416c5e4 Reviewed-on: https://chromium-review.googlesource.com/1046425Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#556429}
-
Tim Schumann authored
This CL focuses on the PrefModelAssociator andPrefServiceSyncable. Removes unnecessary members, reduces visibility where possible and restructures the PrefServiceSyncableTest to no longer rely on late injection (was supported for few tests only). Also adds a test case to increase integration test coverage. It's worth noting that the test infrastructure (in particular TestingPrefServiceSyncable) is overly complex and could be simplified a lot. This Cl goes the first step but unless further changes are needed in that field, returns are diminishing. Change-Id: If2f7665c1994d85568f93455b2654f71cd10c1c2 Reviewed-on: https://chromium-review.googlesource.com/1046048Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/19f90f91..376d927a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ida5a0fbece0f3aa71b98a3a67d50870f5a48cc14 Reviewed-on: https://chromium-review.googlesource.com/1046787Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#556427}
-
Konstantin Ganenko authored
Previously spellcheck provider cached last spell check result, so after adding new word to dictionary misspelling mark could disappear only after changing input. Now we reset cached spellcheck result on each custom dictionary change. R=groby@chromium.org Bug: 757294 Change-Id: Ia47771e0972ab26468c4da9bdebad2070ce89c64 Reviewed-on: https://chromium-review.googlesource.com/1006576 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Cr-Commit-Position: refs/heads/master@{#556426}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 10251873. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17128 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I0e5a732735fb73f758681cf2e8e78473f8951aa5 Reviewed-on: https://chromium-review.googlesource.com/1046985 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#556425}
-
Koji Ishii authored
This class was once used in NGLineBreaker but is no longer used. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ic6823fa745b2d3722c434f009b1b56cbf680dd2b Reviewed-on: https://chromium-review.googlesource.com/1046290Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#556424}
-
Marc Treib authored
instead of using the ThreadChecker class directly. This way, it'll only be instantiated in DCHECK-enabled builds. Bug: 839823 Change-Id: Ifcbbc4113265fd0067a1df10fc4a26ca844139f1 Reviewed-on: https://chromium-review.googlesource.com/1046845Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#556423}
-
Marc Treib authored
instead of talking to ProfileOAuth2TokenService directly. Bug: 825190 Change-Id: I80f1e52857f3fd8effbb6351a22e5bd86062d326 Reviewed-on: https://chromium-review.googlesource.com/1028150 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#556422}
-
Max Morin authored
Actually using it is TODO. No-Try: true Bug: 824019 Change-Id: I9053827dba2504218559be523574b71ef079c72b Reviewed-on: https://chromium-review.googlesource.com/1046646 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#556421}
-
Patrik Höglund authored
enable_webrtc=false has been broken for months and no one has noticed, so let's get rid of this complexity. WebRTC will now be a part of Chromium until the serpent Nidhoggr ascends into the sky and ushers in Ragnarök. Next step: remove #ifdef'd code that depends on defines that were set by enable_webrtc. Bug: chromium:800653 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1661fc56b8005fdae92c3441bb9d7204944bd7c5 Reviewed-on: https://chromium-review.googlesource.com/1044220Reviewed-by:
-
https://webrtc.googlesource.com/src.git/+log/e6256055e7db..823f9135f858 $ git log e6256055e..823f9135f --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:None,chromium:None,chromium:839860,chromium:none The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ief34c2bd69b2feb972c8ffa05f039c8b34c87a25 Reviewed-on: https://chromium-review.googlesource.com/1046925 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Marc Treib authored
As far as I can tell, the current split was a started but abandoned refactoring. As it is, the two classes are very tightly coupled (PSS directly uses many protected members of SSB), and it's entirely unclear what the intended split of responsibilities is. So let's just merge the two back into one. TBRing trivial change in recent_tabs_sub_menu_model.h TBR=ellyjones Bug: 839823 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0dbdf9115c3359dca2cd05bde55ae9d24a081223 Reviewed-on: https://chromium-review.googlesource.com/1044219 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Marina Ciocea authored
Both objects live in browser process. AudioInputStreamBroker maintains and observes state of an input stream. ForwardingAudioStreamFactory forwards stream creation to audio::StreamFactory in audio service process. AudioInputStreamBroker implements media::mojom::AudioInputStreamObserver, replacing media::MojoAISObserver. Bug: 828868 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ieabb77c2edfd7e9939e6f7cd43b953d2af1d1c2c Reviewed-on: https://chromium-review.googlesource.com/1030330Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#556417}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 84578181. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17127 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org: external/wpt/cookies TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Ibdc0b3742082309a6e2c53030ffa7b61754d2b90 Reviewed-on: https://chromium-review.googlesource.com/1046390 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Alex Kalugin authored
map is empty. xml_content string has no "<annotations>" substring because XmlWriter wrties annotations element as "<annotations/>", therefore call to xml_content.insert(xml_content.find("<annotations>"), kXmlComment); crashes. TrafficAnnotationExporter: :GenerateSerializedXML() crashes when archive_ Change-Id: I669975e77e34965aeac02f721bc5f5f85dcfbe8c Reviewed-on: https://chromium-review.googlesource.com/1046673Reviewed-by:Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Kalugin Alexander <akalugin@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#556415}
-
Hayato Ito authored
Support slot's expanded nodes, using slot's assigned nodes, for IncrementalShadowDOM. Inspector can show slot's assigned nodes correctly even in IncrementalShadowDOM. virtual/incremental-shadow-dom/http/tests/devtools/elements/shadow/shadow-distribution.js test is still failing, however, this is not a regression of IncrementalShadowDOM. See crbug.com/840238 for details. This CL adds an expected.txt for the test. Bug: 776656,840238 Change-Id: I037caf9184e9be42525575bf2e027cf000bdbf7a Reviewed-on: https://chromium-review.googlesource.com/1029567 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#556414}
-
Jonas Olsson authored
Not every client cares about observing or logs. This change saves those clients from providing a dummy observer/log. If the log isn't provided, explicitly clear log_. This makes it easier to check if the scoped_refptr<media::mojom::ThreadSafeAudioLogPtr> actually holds a value, and skips some unnecessary message forwarding. Bug: 834702 Change-Id: I4c405a7dd90d241847ee60e4c3b8db58bf0a3fc9 Reviewed-on: https://chromium-review.googlesource.com/1043907Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Marc Treib authored
It's unused. Bug: 839834 Change-Id: Ic354b16a5534aab8ce89c036b8a81a2ceeb3ae60 Reviewed-on: https://chromium-review.googlesource.com/1046672Reviewed-by:
-
