- 17 Jan, 2020 40 commits
-
-
Eriko Kurimoto authored
Options for shared workers are kept as SharedWorkerInstance type in content/browser. We use script_type and credentials_mode for creating workers. These parameters are needed for implementing ES module for shared workers. This change doesn't affect the behavior. Bug: 824646 TBR: chrisha@chromium.org Change-Id: I63e54f25f3064a06ece72157342f2c92a60aef80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994854 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#732801}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ibe331056d6621933513cc1ac7708b5c3b84f1e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005802Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732800}
-
Jan Wilken Dörrie authored
TBR=chenwilliam Bug: 1042688 Change-Id: I64c7d9366907ee3fc41d75ba18509f4fe57c871e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003176 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#732799}
-
Jan Wilken Dörrie authored
TBR=adithyas Bug: 1042703 Change-Id: I5c8634b2b709940fd9b7348bd287e87337587ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006553Reviewed-by:
-
Jan Wilken Dörrie authored
This reverts commit be9ead6f. Reason for revert: Breaks content_browsertests on Linux CFI (https://crbug.com/1043059) Original change's description: > Roll src/third_party/perfetto 11c11a1a891c..cf0fcdbfc9a0 (16 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/11c11a1a891c..cf0fcdbfc9a0 > > git log 11c11a1a891c..cf0fcdbfc9a0 --date=short --first-parent --format='%ad %ae %s' > 2020-01-16 eseckler@google.com Merge "processor: Export pid/tid as signed integers into JSON" > 2020-01-16 lalitm@google.com Merge "trace_processor: fix compile and build on fuzzer" > 2020-01-16 joelaf@google.com Merge "Fix precision errors by explicit casting" > 2020-01-16 lalitm@google.com Merge "Revert "GTEST_EXECUTE_STATEMENT_ is not available on iOS execute the statement directly instead."" > 2020-01-16 chiur@google.com Merge "Add VulkanApiEvent.VkQueueSubmit message" > 2020-01-16 khokhlov@google.com Merge "trace_processor: Run metrics on Windows" > 2020-01-16 primiano@google.com Merge "gn: Fix issue with finding llvm when using python3" > 2020-01-16 hjd@google.com Merge changes Ic6800bd0,I29636316 > 2020-01-16 treehugger-gerrit@google.com Merge "processor: Fix handling of 0 timestamp in TrackEventTokenizer." > 2020-01-16 rsavitski@google.com Merge "heapprofd producer: use sigqueue(si_value: 0) instead of kill" > 2020-01-16 taylori@google.com Merge "perfetto-ui: Toggle sidebar on ctrl/cmd + b" > 2020-01-16 eseckler@google.com Merge "client lib: Support building in Chrome using a fake platform" > 2020-01-16 eseckler@google.com Merge "processor: Translate duplicate pids/tids during json export" > 2020-01-16 buss@google.com Merge changes I1bb0e215,I498ed990 > 2020-01-16 treehugger-gerrit@google.com Merge "processor: Support pid reuse in ProcessTracker without Start/EndThread" > 2020-01-16 primiano@google.com Merge "GTEST_EXECUTE_STATEMENT_ is not available on iOS execute the statement directly instead." > > Created with: > gclient setdep -r src/third_party/perfetto@cf0fcdbfc9a0 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: None > Tbr: perfetto-bugs@google.com > Change-Id: If9d0cfb1de77d821e94bc4598d682f39e70630ee > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005333 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#732631} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: If1b4bef65c19e3a43d04af679d3144b61ec4cd97 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007208 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Alex Chau authored
- Renamed RecipientInfo to FCMChannelConfiguration to match sharing_message_specifics.proto - Introduced ServerChannelConfiguration Bug: 1042672 Change-Id: Idf72f0d0e7ee0df0101c04cd5efcf980acd66fb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004990Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#732796}
-
Jan Wilken Dörrie authored
This reverts commit 870bcafd. Reason for revert: Previous roll broke content_browsertests on Linux CFI (https://crbug.com/1043059) Original change's description: > Roll src/third_party/perfetto cf0fcdbfc9a0..649f757cc08b (1 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/cf0fcdbfc9a0..649f757cc08b > > git log cf0fcdbfc9a0..649f757cc08b --date=short --first-parent --format='%ad %ae %s' > 2020-01-16 ilkos@google.com Merge "Remove symbols that are definitely not obfuscated" > > Created with: > gclient setdep -r src/third_party/perfetto@649f757cc08b > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: None > Tbr: perfetto-bugs@google.com > Change-Id: Idd6f625ab71b7b186970f43df6403bce66ac140a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006484 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#732698} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: I1deea6a0457c8ded6f3ebf65a34f6fe0a800372d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007189Reviewed-by:
-
Javier Ernesto Flores Robles authored
Previously icons where being fetched in an precise URL manner. This led to many password rows not having Favicon. This attempts to reduce that by falling back to any host favicon. It also changes how the search is made for the favicon, previously if no favicon was at least the min amount of pixels no icon would be retrieved. Now the closest icon is resized to the desired pixels. This will improve favicons on iPads with big resolution, were the favicons in the history DB were never as big. Bug: 949076 Change-Id: Iac7619c76e8e3e6bd6b0de961dbaf40a5f3eeea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000697Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#732794}
-
Miyoung Shin authored
This CL replaces the SelfOwnedReceiver for TextSuggestionHost with an owned Receiver that matches the lifetime of TextSuggestionHostAndroid. TextSuggestionHostAndroid creates an instance of TextSuggestionHostMojoImplAndroid when BindTextSuggestionHost method is called, and owns it. Bug: 1034125 Change-Id: Ia07103806b7571008d27ba3e0cf21534121ee6ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000447 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#732793}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6d6e911b50e1..fada3b97d140 git log 6d6e911b50e1..fada3b97d140 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 phoglund@google.com Add reserved_infos.h/cc. Created with: gclient setdep -r src/third_party/catapult@fada3b97d140 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452 Tbr: rmhasan@google.com Change-Id: Ibe159e6f6a0a6e505ef815faf3ea934ae1a16bf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007150Reviewed-by:
-
Omer Katz authored
Bug: 986235 Change-Id: Idf6c50f07977804ae4a9d78a904043ab0bb7ba8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007049Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#732791}
-
Mythri A authored
This CL was created automatically with tools/perf/update_wpr script Bug: chromium:878390 Change-Id: I6551ecfeff091e1f2614e143ae9e6bd8c9f393fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003323Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#732790}
-
Sean Harrison authored
Bug: 1007223 Change-Id: I9aa1f2db14ab501c2ed45900e28b40c99a9d8cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005168Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#732789}
-
Himanshu Jaju authored
Tracks time taken to respond to an incoming SharingMessage with the payload case as the suffix name. Bug: 1035433 Change-Id: I9fa15e5206e9a41c44fc64c0f5ef4a90b9fe7370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002910 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#732788}
-
Kunihiko Sakamoto authored
This histogram is as important as TimeToFirstMeaningfulPaint itself. This patch makes the expiry and the owners of the histogram aligned with the other FirstMeaningfulPaint related histograms. Bug: 1037180 Change-Id: I5e652996384a6444891582763e18d4c382d9dfd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000449Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#732787}
-
Maria Kazinova authored
PasswordForm is a result of parsing and is a part of the browser process. The renderer process doesn't need it, as all necessary renderer process information is contained in FormData. Bug: 949519 Change-Id: Ib5dd365f09e89820dc15b9f2966f88dc59b62519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992086Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#732786}
-
Sean Harrison authored
Move the settings enum and the call to uma to a separate browser proxy. Add UMA to all site settings subpage interactions and new toggles moved to the main settings card Bug: 1032584 Change-Id: Icadd71d4511fa1f604f2d3acbda92c0e84700173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967651 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#732785}
-
Kent Tamura authored
* FileInputType::SetValue() |input.value =""| triggered style recalc because style recalc triggered UpdateFromElement(). However, we don't need style recalc in this case and we need to do just paint invalidation. * UpdateFromElement() just does paint invalidation. The function is called from - HTMLFormControlElement::AttachLayoutTree() - HTMLFormControlElement::DidRecalcStyle() For both of them, paint invalidation by UpdateFromElement() is redundant. So we can remove UpdateFromElement(). This CL has no behavior changes. Bug: 1040828 Change-Id: I3e180de69cef7eef20d1944283938deec8de9685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006436Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#732784}
-
Miyoung Shin authored
Move FrameMsg_CopyImageAt and FrameMsg_SaveImageAt to a LocalFrame, remove from WebLocalFrame interface and move to a mojo implementation on the LocalFrame class, and add plumbing for test. Bug: 1040124 Change-Id: I1fbde485f4aa1d7104a9839b833617853d46a473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994852 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#732783}
-
Yutaka Hirano authored
We need to enter a scope before creating an error object. Bug: 1011392 Change-Id: I7b01d7f9cfa75efb19837387c105e6acd4322a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007089 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#732782}
-
Ehimare Okoyomon authored
Exposed this feature flag that makes it easier for users to enable and manage third party cookie blocking in android. Bug: 1040091 Change-Id: Icc58f7afb6c4c60c78d7963b44d2cbf7e93ba189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002618 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#732781}
-
Kent Tamura authored
to RangeInputType. This CL has no behavior changes. Bug: 1040828 Change-Id: I6d4ba4faf0467da4db268ebd4cc4d37a992c973b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006897Reviewed-by:
-
Rakesh Soma authored
Bug: 1039931 Change-Id: I6203d7692903bf83825a4d27c1b490ccada24efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990452 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Auto-Submit: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#732779}
-
Ehimare Okoyomon authored
session Previously, there was text in the site description that said "Current incognito session" when a site exception rule only applied for the active incognito session and looked like this: https://screenshot.googleplex.com/nqaVgnmQ7ac.png Now, instead, for this type of site exception there is a tooltip with the incognito icon, and when you hover over it, there is an explanation string of what the icon means: https://screenshot.googleplex.com/hy8E1SCws6J.png Bug: 1030274 Change-Id: I6d23af1a9e0b8ca376326aeb97cc524c4f0b7df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948889Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#732778}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b446206d9331..b39daad9ba0c git log b446206d9331..b39daad9ba0c --date=short --first-parent --format='%ad %ae %s' 2020-01-17 bmeurer@chromium.org Roll upstream changes. 2020-01-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@b39daad9ba0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6a83b68ac62634d8f5d1ba88cef976d7a8a89610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006726Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2182260bce54..8dd28cd4db8d Created with: gclient setdep -r src-internal@8dd28cd4db8d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iab7e0411bee9471842d08b1e471dd57f18468bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006723Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732776}
-
Matthias Körber authored
Currently, the '0'/'1' digits are not used in generated password to avoid visual confusion with letters like 'l','I' and 'O'. With this change, the digits are added to the numeric alphabet if the generated password does not contain lower and upper case letters. Bug: 1038659 Change-Id: I25552b85592b8a3f2e286b9c30652db6664eff00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985768 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#732775}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/90449951..47cbd1fb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id70902da5a85540046a13e24a1fb3fa29edef415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006170Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732774}
-
Matthias Körber authored
Change-Id: Ifb1e8828002230bdad4a41d4657b8656a1617120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003318Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#732773}
-
http://localhost`Mike West authored
We should have removed this code when we landed https://chromium-review.googlesource.com/c/chromium/src/+/598068/. Bug: 691930 Change-Id: I018f284eb3f78ff6b7c0d042c704a84385fb754a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002584Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#732772}
-
Kent Tamura authored
This is a reland of 3c4c13ac The difference from the original CL: - Replace LayoutObject::UpdateFromElement() call with HTMLFormControlElement::UpdateFromElement() in HTMLFormControlElement::DidRecalcStyle() too. Original change's description: > Move LayoutMenuList::DidUpdateActiveOption() to HTMLSelectElement > > Also, > - Remove LayoutMenuList::DidSelectOption(). > - Add HTMLFormControlElement::UpdateFromElement() to add > DidUpdateMenuListActiveOption() to each of > LayoutMenuList::UpdateFromElement() calls. > > This CL is a preparation to build a LayoutNG counterpart of LayoutMenuList. > This CL has no behavior changes. > > Bug: 1040828 > Change-Id: If7917af101119a830e899a50711a6c1491e22eb3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003164 > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732313} Bug: 1040828 Change-Id: Ibba19df1c4f9a402c057bbf4548b18f1fdeb44f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006271Reviewed-by:
-
Ioana Pandele authored
This reverts commit ca83da12. Reason for revert: Tests are now failing consistently. Original change's description: > [Android] Fix password generation integration tests > > The manual generation tests were broken because the tab view in the keyboard > accessory could not be found. This CL changes the matcher used. > > All tests used to depend on server predictions for filling, which marked > the field as eligible for generation or not. This broke when the predictions > where not as expected. > > Bug: 1010540, 1010344 > > Change-Id: I8ca5392d80b81a67d414eec33cc7a7a2e282d725 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995273 > Commit-Queue: Ioana Pandele <ioanap@chromium.org> > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732423} TBR=fhorschig@chromium.org,ioanap@chromium.org Change-Id: Ifd9d62d8e29b6327bab291972a1b986260c7586f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1010540, 1010344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006551Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#732770}
-
Yoshifumi Inoue authored
This patch changes |LayoutText::DetachAbstractInlineTextBoxesIfNeeded()| to use |NGPaintFragment::InlineFragmentsFor()| instead of |NGInlineCursor|, because |DetachAbstractInlineTextBoxesIfNeeded()| is called after containg block flow of |LayoutText| changed, e.g. removing, moving, spliting, etc. Note: This is experimatal patch because we don't know exact reproduce case. Note: |NGInlineCursor::MoveTo(LayoutObject)| requires root paint fragment computed from specified layout object. Bug: 1040938 Change-Id: I7624a19e66f449182309a29ab0fc4748839d69b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006837 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#732769}
-
Oleg Davydov authored
Add burunduk@ to OWNERS in the following directories: * content_verifier in extensions/browser/ * forced_extensions in chrome/browser/extensions/ Change-Id: I31359a569e0169eb9819945c405f8678a01bca64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003853Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#732768}
-
Alex Keng authored
This CL fixes <select>'s hover color in high contrast mode (forced_colors.css) per the design. The test select-multiple-appearance-basic.html is modified to test the scenario of focused+selected+hovered. 3 more tests are added to test 1)focused+unselected+hovered, 2)unfocused+selected+hovered, 3)unfocused+unselected+hovered. Change-Id: I2fafe1447290a4783fd3a393f1b0046e143ad9ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995505 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#732767}
-
nancy authored
This CL is used to integrate Extension apps's context menus for app list to AppService: https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/extension_app_context_menu.cc?l=71 https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/extension_app_context_menu.cc?l=162 BUG=1038487 Change-Id: Ieb1eacc74a7c28c498a503e1fa89f91c868e9323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004908 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#732766}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/91096f77a581..6d6e911b50e1 git log 91096f77a581..6d6e911b50e1 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 fancl@chromium.org Reduce min_num_instances of sheriff-config 2020-01-17 dberris@chromium.org Remove dispatch.yaml 2020-01-17 dberris@chromium.org Add commas between distinct strings 2020-01-17 fancl@chromium.org Fix query by subscriptions 2020-01-17 bsheedy@chromium.org Fix minidump symbolize spam 2020-01-17 zhizhouy@google.com Use python 2 for trace2html Created with: gclient setdep -r src/third_party/catapult@6d6e911b50e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1039776,chromium:1040775,chromium:1042949,chromium:953181 Tbr: rmhasan@google.com Change-Id: I2dc3f9402d0aa1087238b67e85528518edce4f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006712Reviewed-by:
-
Josh Simmons authored
This UI is shown only when PerformanceHintsObserver is enabled. It is currently disabled by default. Bug: 1030813 Change-Id: I7f84e319871d5eb31c46faa8e0fc4255e87b5ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992263 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#732764}
-
Rachel Sugrono authored
Add two non-consecutive files to check-select (aka multi- select). Quick View should open in check-select mode with the first file being opened. Left/right arrow keys should show the next selection in check-select. Bug: 1038799 Change-Id: I1164a19391920b9cc08d0f622d1c2a14c006b8d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006901 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#732763}
-
Jan Wilken Dörrie authored
This reverts commit 07b113c5. Reason for revert: Breaks create_tarball step on Deterministic Linux builders: https://crbug.com/1043039 Original change's description: > [Reland] WebUI: Stop auto-generating Polymer 3 version of cr-splitter. > > The Polymer 2 version is not used anymore, therefore no auto-generation > is necessary and the v3 version can be directly checked in. > > Fixed: 1042545 > Change-Id: Ia0267cef30dcf1eb08677d369fd3f8ded21c679f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006421 > Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> > Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732725} TBR=dpapad@chromium.org,rbpotter@chromium.org Change-Id: I59eb715d4f775f98fb9a71d37889bbefbe3d86f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006349Reviewed-by:
-
