- 31 Oct, 2019 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/287957ea..3bcc30e4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifda0f56408e92d5a7173c7f95cfd278b03401339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893292Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711300}
-
Kevin McNee authored
Tbr: bmcquade@chromium.org Bug: 1020182 Change-Id: Ice2171c180637bcb9cc601ea889d6ac782526c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893140Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#711299}
-
Arthur Hemery authored
Found a logic issue with the NavigationSimulator. CommitSameDocument expects browser initiated same document navigation to be in a started state and have the same_document_ flag set. The flag is set at commit time so it is logically impossible. Just go through regular Commit() in this case. Change-Id: Id71d99311661f3e82a473267048ed84c1b63e3e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724074Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#711298}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aae0b57ab143..dbd554ed9e86 Created with: gclient setdep -r src-internal@dbd554ed9e86 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ic19daf588521a8d6979d92c17d24004cbd317f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893401Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711297}
-
David Benjamin authored
The current_time > expiry branch ends in a continue, so we don't need to check current_time <= expiry. Bug: none Change-Id: Ib34895a1098e8f0ae296b0a8ffd8ccf07d40649f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891236 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#711296}
-
Etienne Bergeron authored
ICU parsing (grapheme) will be used by the TextItemize and need to be initialized. Running: crash-3e6400c066a0fc4e1652349294b22b87b9b9dd35 [1030/172842.831069:FATAL:break_iterator.cc(77)] Check failed: false. ubrk_open failed for type 2 with error 2 ================================================================= ==211878==ERROR: AddressSanitizer: ABRT on unknown address 0x2e61100033ba6 (pc 0x7f158a533cfb bp 0x7ffebc185cf0 sp 0x7ffebc185a90 T0) SCARINESS: 10 (signal) #0 0x7f158a533cfa in raise (/lib/x86_64-linux-gnu/libc.so.6+0x36cfa) #1 0x7f1594f60153 in base::debug::BreakDebugger() base/debug/debugger_posix.cc:331:3 #2 0x7f1594628d0d in logging::LogMessage::~LogMessage() base/logging.cc:956:7 #3 0x7f158c07b6ab in base::i18n::BreakIterator::Init() base/i18n/break_iterator.cc:77:7 #4 0x7f1595809bdd in gfx::RenderText::GetLineBreaks() ui/gfx/render_text.cc:1302:29 #5 0x7f1595889e82 in gfx::RenderTextHarfBuzz::EnsureLayout() ui/gfx/render_text_harfbuzz.cc:1758:24 #6 0x7f15957f9105 in gfx::RenderText::Draw(gfx::Canvas*) ui/gfx/render_text.cc:869:3 #7 0x5619787fc3e0 in LLVMFuzzerTestOneInput ui/gfx/render_text_api_fuzzer.cc:198:22 #8 0x5619788a14eb in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) third_party/libFuzzer/src/FuzzerLoop.cpp:553:15 #9 0x561978849dfc in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) third_party/libFuzzer/src/FuzzerDriver.cpp:292:6 #10 0x561978851a25 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) third_party/libFuzzer/src/FuzzerDriver.cpp:775:9 #11 0x5619788cb358 in main third_party/libFuzzer/src/FuzzerMain.cpp:19:10 #12 0x7f158a52052a in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x23 Bug: 1019913 Change-Id: I47a84779eb259b10471c345e7e93f214d644b74d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893354Reviewed-by:Abhishek Arya <inferno@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#711295}
-
Natalie Chouinard authored
Migrate kBlockThirdPartyCookies to use PrefServiceBridge generic methods, making use of the pref.h enum to expose it to Java. Bug: 1016957 Change-Id: I34de6292fb7bf43b88a85686d354c3685cbcdf51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890654Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#711294}
-
Jonathan Freed authored
Change-Id: Ie69a9619bfd00112a0d2f46f0df573af3a8c3d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873404Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Jonathan Freed <freedjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#711293}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b094d526c20b..5d67bf6590f8 git log b094d526c20b..5d67bf6590f8 --date=short --no-merges --format='%ad %ae %s' 2019-10-31 eseckler@google.com Merge "processor: Don't override system process/thread names with Chrome's" 2019-10-31 lalitm@google.com trace_processor: switch SparseVector to use RowMap instead of BitVector 2019-10-31 lalitm@google.com Merge "trace_processor: improve filter performance by iterating over col rowmaps" Created with: gclient setdep -r src/third_party/perfetto@5d67bf6590f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:135177627 Change-Id: I37575d94eeb99f9455b34cb297c5e405085694d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893396Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711292}
-
Armando Miraglia authored
TBR=toyoshim@chromium.org Bug: 1020185 Change-Id: I951ed9e3ab7d4d90d9a1c0a3ee75f1578a1abe62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893285Reviewed-by:
Armando Miraglia <armax@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#711291}
-
Mohamed Abdelhalim authored
Re-enables unit tests for android, since there were many changes done lately around it, and they are now green again. Bug: 970815 Change-Id: I83cc16212974a2c3452fd3cc19b276800f38b03b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893155Reviewed-by:
-
Ulan Degenbaev authored
Revert "Remove DOMDataStore::WrappedReference and hold TraceWrapperV8Reference directly in ephemeron map." This reverts commit 481fb0c1. Reason for revert: speculative revert for crbug.com/1019839 Original change's description: > Remove DOMDataStore::WrappedReference and hold TraceWrapperV8Reference directly in ephemeron map. > > Change-Id: I6ef8b0098a795dc550037306e7b972ea907b0fc1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884285 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710616} TBR=jbroman@chromium.org,haraken@chromium.org,mlippautz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Iba339b519f2aa602773ceb79c95948c1cffdcbdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893282Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#711289}
-
Tim Volodine authored
In this patch: - Add SafeBrowsingService and its implementation for managing initialization and ownership of safebrowsing related objects, such as database manager, ui manager and safebrowsing context. This also includes proper threading and startup of the database manager. - Move some functionality and ownership from ContentBrowserClient to SafeBrowsingService for better decoupling and less code complexity. - Add user agent and user data path for safebrowsing network context. - Make safebrowsing android only for now. - Update build files. BUG=1015809 Change-Id: I8f83c62538bafe81479cb9fe40f065022e1699d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888033Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#711288}
-
Greg Thompson authored
ScopedTempDirs must outlive anything that holds file(s) open within them; otherwise, they are unable to delete their backing directories. BUG=546640 Change-Id: I38da1876e033b9408b5957596311e5dd82b04083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891419 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#711287}
-
Andrew Grieve authored
And mention @RemovableInRelease and @CheckDiscard Change-Id: I0de0fa818af5910bd4147985f6cee21da3c34ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890844 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#711286}
-
Rayan Kanso authored
Grab address info in the contacts fetcher task, and pipe down to the address provider to create a mojo address object. Bug: 1016870 Change-Id: I4d0580f0c27cbaef813cb2374b010ad182cb64d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879240Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Mike Wittman authored
Change-Id: I97297e52bf4288ef3edc52993c7ff4f911327e4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890988 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#711284}
-
Denis Kuznetsov authored
Bug: 1016998 Change-Id: Icfdc5aa90646796e9bd7f09806caf16a7ab050c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893283Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#711283}
-
Avery Musbach authored
Test: SplitViewControllerTest.SnapWindowWithMinimumSizeTest Bug: 1019965 Change-Id: Ia31c621d18fbdcf6016f095f78aceff1fa0dd600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891756Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#711282}
-
Ahmed Fakhry authored
When the device is in a physical tabelt state (detached or flipped) regardless of the UI state (tablet mode or clamshell), auto rotation is allowed, and the system menu shows the auto-rotate button. (See https://crrev.com/c/1861049). This CL exposes the ability to adjust the auto-rotation and rotation lock while the device is in a physical tablet state per UX request. We reuse the rotation drop down menu in that mode, by adding an extra "Auto-rotate" option, and interpret the other options (0, 90, 180, 270) as requests to lock the user orientation to these rotations. The system menu auto-rotate button should be updated accordingly. Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=925087#c19 BUG=925087 TEST=Manually, Added several tests at each layer: ash_unittests --gtest_filter=CrosDisplayConfigTest.TabletModeAutoRotation browser_tests --gtest_filter=SystemDisplayChromeOSApiTest.CheckOnDisplayChangedEvent unit_tests --gtest_filter=DisplayInfoProviderChromeosTouchviewTest.TabletModeAutoRotation extensions_browsertests --gtest_filter=SystemDisplayApiTest.SetAutoRotate Change-Id: Ifb4265bdd6898d393b3e919a7448d7eea701bb3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866203Reviewed-by:
Zakhar Voit <voit@google.com> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#711281}
-
Mohamed Abdelhalim authored
This moves WILL_REDIRECT_REQUEST to NavigationRequest::NavigationState. Bug: 916537 Change-Id: Ifef36753c384592465b72be16737373daa1501bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865167 Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#711280}
-
Chris Harrelson authored
The WeakMember element_ could be garbage collected and needs to be null-checked. There is no test because it's unclear to me how to do so simply. The reproducing clusterfuzz bug used a specially instrumented Chrome with a script-exposed gc() method. Bug: 1016218 Change-Id: Ibf8da7c8b68dab5cbeeb9f3b12a434944c5fa91a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892060Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#711279}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I03d51db4fd103a2c6b91e4824f2519a28cc168fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887237Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#711278}
-
Nico Weber authored
Now that it's no longer in a .h file, move its definition from depending on GOOGLE_CHROME_BUILD to GOOGLE_CHROME_BRANDING, which is the same thing in BUILDFLAG form. Since the use is now in a .cc file, the buildflag doesn't have to be a public_dep, switching between branded and non-branded requires fewer rebuilds, and it's easier to see which files depend on the branding define. No intended behavior change. Bug: 961769 Change-Id: I5abcc4cad3bd709792572d643aea173ad1a0996f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893373 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#711277}
-
Alexander Timin authored
Recently we've renamed "ShouldUseVirtualTime" to CanRunWhenVirtualTimeIsPaused, but we forgot that this flips the meaning to the opposite. R=carlscab@chromium.org CC=sreejakshetty@chromium.org,hajimehoshi@chromium.org,rakina@chromium.org Change-Id: Ibf6fb04e1ceb5980d60e19c5b09b0b50cbe86201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887613Reviewed-by:
Carlos Caballero <carlscab@google.com> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#711276}
-
Yusuke Sato authored
This is strictly unnecessary because either vm_concierge.conf job (in case of user session termination) or session_manager (in case of browser exit) stops all VMs including ARCVM. BUG=b:143569709 TEST=arc.Boot TEST=sign in, sign out, verify StopVm for ARCVM is not called TEST=sign in, change chrome://flags and restart the browser, verify StopVm is not called Change-Id: I4c3a410d76f43da7a9743d692380b5c86962479e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889299Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#711275}
-
Charlie Andrews authored
libunwindstack will be used to extend Stack Sampled Metrics (previously known as the UMA sampling profiler) from Mac and Windows to Android. A broader design doc for this effort is available at http://bit.ly/2okOgOY. The repo being included is available at http://bit.ly/33XnOtK. Because libunwindstack is part of the broader Android platform/system/core repo, it shares its license (Apache version 2.0). The platform/system/core license can be found at http://bit.ly/34e5QmT. eng-review@ has already given approval for this repo (see http://bit.ly/2pNIshi, which is Google internal). Bug: 991960 Change-Id: Ie950d7600d34147211fb0fce588179b6a63afc61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879990Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#711274}
-
Elly Fong-Jones authored
*_mac* matches (eg) common_param_traits_macros.h :) Bug: None Change-Id: Ibb573d8a98eb2ecf13b7946fe7f5616cfd07384b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893351Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 46a4db6c. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I93f79df26f9980eb0917bca8d5d499dd22259647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893451Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711272}
-
Leo Zhang authored
Download LMs based on the lang of IME. There is a clenaup issue after downloading, check b/143685131 TBR=dvallet@chromium.org,shend@chromium.org TEST=it-IT,en-GB Bug: 946913 Change-Id: I2e963f294b603d264fd9577b49e1fd902f6d853a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893471Reviewed-by:
Leo Zhang <googleo@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Auto-Submit: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#711271}
-
Olivier Li authored
Improve comments for ExtensionWebRequestApiTest.WebRequestApiDoesNotCrashOnErrorAfterProfileDestroyed Original comments were a little incorrect. Change-Id: Icb52d1e83ae176be5b019ec9b5874e9193f72c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887430Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#711270}
-
Mohamed Heikal authored
android-binary-size trybot has been updated to fail if expectation files are changed even if they dont break the build. This cl now stops breaking build. Bug: 1011227 Change-Id: If563429a800c29c8c4e50735fe1211d9fc7ed4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890727Reviewed-by:
-
Ulan Degenbaev authored
This fixes a stale pointer in the following scenario: 1) We have a JS object A in the young generation of V8's heap. 2) A Blink object B points to A via v8::TracedReference. 3) Incremental unified heap GC starts. 4) A V8 Scavenge happens during the unified heap GC and discovers that object A is reachable only via the v8::TracedReference. It checks whether the object can be collected using IsRootForNonTracingGC, which returns false. 5) Object A is collected by the Scavenger and object B points to a free region (i.e. it has a stale pointer to V8's heap). 6) Object B is traced and the stale pointer is reported to V8 and added to V8's marking worklist. 7) Next Scavenge crashes when it tries to update the marking worklist. Bug: 1019839 Change-Id: I6f5ae2e21273cdd3ea4150ceb0f70fe33eeb2614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893255 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#711268}
-
Frank Tang authored
Roll the ICU cherry pick https://github.com/unicode-org/icu/pull/902 Bug: chromium:1014272 Change-Id: Ic16eba93942eed279fe649f708f916a0bd359f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892579Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#711267}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1c93b3dec290..1ce01db4f59d git log 1c93b3dec290..1ce01db4f59d --date=short --no-merges --format='%ad %ae %s' 2019-10-31 perezju@chromium.org Revert "[Telemetry] Stop doing metric computation." Created with: gclient setdep -r src/third_party/catapult@1ce01db4f59d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:981349,chromium:1019888 Change-Id: I6e93446842c0a123ee133c4e7709f584a1b4c740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893393Reviewed-by:
-
Mike Wittman authored
Provides API support for specifying an optional user-defined key along with the metadata name. This can be used to distinguish samples based on additional state beyond just the name -- e.g. execution in service of different tabs within the same renderer process. Uploading of the key state with the samples will be implemented in a following CL. Bug: 976864 Change-Id: Ib924be48a816e65e83976c34e27efea19da61925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891112Reviewed-by:
-
Peter E Conn authored
For CCTs (and TWAs) to have a "bring tab to front" functionality, we need an Intent provided by the client that will launch in the client's Task. The client should provide an Intent to an Activity that immediately exits. This way the Task will be brought to the foreground with the CustomTabActivity visible. There are a few cases that this method breaks down. First, the client may have another Activity on top of the Custom Tab - in this case that Activity will be brought to the foreground instead. We deem this to be acceptable as it is unlikely to happen often and still brings the user into the context of the app. (Note that this method won't be called if there is no currently running CustomTabActivity.) Another case is that the client provides an Intent that does not simply exit. There is little we can do to check for this case. Bug: 989908 Change-Id: I8dc5384b4631c7a0c895114621e4810cffb21259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849682 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#711264}
-
Chris Harrelson authored
The MapToVisualRectInAncestorSpace fast-path needs a LayoutObject with LocalBorderBoxProperties set, so that it can call into GeometryMapper. If the start LayoutObject does not have one, it proceeds up the containing block chain until it finds one, and uses the FirstFragment() of the resulting LayoutObject. This is wrong in cases where there multiple fragments on the LayoutObject, because we don't know which one to choose. In such cases, fall back to the slow path. Bug: 999551 Change-Id: I887c15c3acbe41432b2ca64e5a1551f3765a5043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892058 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711263}
-
Alice Wang authored
This CL fixes tests of BookmarkPersonalizedSigninPromoTests on tablet. TBR=twellington@chromium.org Bug: 789531 Change-Id: I04a49042104bcbdf1b0add9a6a9bd88d819cb8a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893259 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#711262}
-
Mohamed Heikal authored
In furtherance of possibly putting a limit on additional native relocations added to the binary. A count of native relocations is now included in the metadata of the .size file. This reverts commit 936b6478. Reason for reland: this cl works on 64bit elf files. Original CL: > https://chromium-review.googlesource.com/c/chromium/src/+/1879504 Bug: 1012373 Change-Id: I47c7fc8e73b6ad05d3ecd9dfd235f8904e9d7c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889946Reviewed-by:
-
