- 08 Jul, 2020 40 commits
-
-
Edward Jung authored
In consulation with other writing teams removing 'share' as it could cause possible confusion with it's usage within Google products and on Android. Change-Id: I0a827a87257c0dde217a682f53dc4e2518ce286e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282753Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#786250}
-
Sylvain Defresne authored
This reverts commit aafd725a. Reason for revert: Breaks downstream checkout. Original change's description: > [ios] Add --landmines-path to build/landmines.py script > > Chrome on iOS has some internal landmines and uses a forked version > of build/landmines.py for that to allow using a separate landmines > file. > > Add a --landmines-path parameter to build/landmines.py script in > order to remove the forked version and instead use the shared one. > > Bug: 1033067 > Change-Id: Iac668c5877ae181442078cda7ce8e727f91104b4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283582 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#786218} TBR=dpranke@google.com,sdefresne@chromium.org Change-Id: Ic3e9ba6b7b56c4d4fb0ae28a158897d1a593b972 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1033067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287302Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#786249}
-
Oleg Davydov authored
Policy implementations for OffHours and SessionLengthLimit use OneShotTimer for measuring time. This timer uses clock like device's uptime and therefore is paused when device is suspended, which leads to the problem: if device was suspended during the session, session length limit is not applied correctly, the same may happen with off hours. This commit changes timers used for these policies to a WallClockTimer, which takes possibility of suspend/resume into account and binds to the "real" time. As part of it, this commit changes TimeTicks to Time in numerous of places, notable one is the session.start_time pref, which now will store internal representation of Time, not TimeTicks. Bug: 1095645 Change-Id: Ia4950561f695053091b36f1ed481807c6d0ed6a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274395Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#786248}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/faef2531ecbb..0b81007941c4 2020-07-08 lalitm@google.com tp: add support for opting out of query output checks in shell If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I59815e0506382f9246532ae12c612daaf1a25f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287134Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786247}
-
Oleh Lamzin authored
Add timezone info to the probe service. Bug: b:158658869 Change-Id: I21e8d3d21ebcad4d0b49da0022597df95cb8502c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274618 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Roland Bock <rbock@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#786246}
-
Oleh Lamzin authored
Add CPU info to the probe service. Bug: b:158658869 Change-Id: I6b1ab0c812f32e905074b1be10e56e9b72ca304c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274403Reviewed-by:
-
Patrick Brosset authored
Corresponding front-end CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2279485/ Bug: 1100384 Change-Id: Ib0dba6dfed055b6a4987a7182976c07fab8c3ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278853 Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#786244}
-
John Abd-El-Malek authored
-remove unused methods -move process-specific methods to browser or renderer interfaces -add comment to ContentBrowserClient method that's used by Qt Change-Id: I3ff5ccbfe9fdf24e42aff87d98979ca749cc8e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285320Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#786243}
-
Ulan Degenbaev authored
The V8ReduceConcurrentMarkingTasks flag will be used in Finch experiment. Bug: v8:10442 Change-Id: I2cb6d0a8445f4eeb9fcbad9ecb8595542d50fc8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283219Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#786242}
-
My Nguyen authored
Bug: 1102561 Change-Id: I0dcacb9a22c8c85b0eb22d1c7ef6552d54c609fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282733Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#786241}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1594014961-b33fec47337d1f487e4dacf5d1b618dace5d3422.profdata to chrome-win64-master-1594187879-6eac15fcdfb0a939dbcd47aeb2bfde0b77cd75b2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ifd154a12a84d74549e8a10305b410fa94939f852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287610Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/41acf46e02a1..14522a51c8d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC huanzhong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1090397,chromium:1094282,chromium:1102355,chromium:1102832 Tbr: huanzhong@google.com Change-Id: I6cc7090c6e1d0925cf0a0a00233693fb82e15d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286788Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786239}
-
Mirko Bonadei authored
When is_asan=true is used, the set of exported symbols differs from a normal release build. This CL adds a .def file only for x64 builds since it looks like Chromium doesn't have an x86 bot with this configuration. Bug: 1102581 Change-Id: I01fe5cc22aa6719e765d790b624f335b0dcc23a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287292 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#786238}
-
sandromaggi authored
When detaching the |UiControllerAndroid| this adds a new |WebContentsObserver| to the current |WebContent|, that triggers the UI self destruct on navigation. This can not be handled in the |Controller| as this one gets destroyed when the |Client| shuts down. Bug: b/159977785 Change-Id: I88a36278b0f517519286d53f49c2de4486f41e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279978 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786237}
-
Nazerke authored
As a tabmodel was decided to be deprecated, this CL is cleaning up the tabmodel from unused properties and functions. This CL removes - public property to know if this tab set is off the record. - public property to know if the model has at least one tab. - public method to close the tab at the given valid index. - public method to close ALL the tabs. - unittests which test those mentioned above. At this stage the tabmodel deprecation is still an on-going work. Bug: 1045575 Change-Id: I3902618da006a112600a814736a78b7d7856955e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278044 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#786236}
-
Ravjit Singh Uppal authored
Bug: 1073883, 1103143 Change-Id: Ib4121c2fea110ae13f490faffeb113a609e6b81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279796Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
-
Saurabh Nijhara authored
The minimum chrome version policy enforces updates within a warning time supplied by the admin. Once the device has installed the updates, it is up to the relaunch notifications to enforce relaunch for applying the updates. This CL configures the relaunch notification according to the deadline of the minimum chrome version policy if the relaunch deadline lies post this policy deadline. It also overrides the relaunch notification type to required. Any further policy change to relaunch notification type, period and heads up period would have no effect to enforce updates within the policy deadline. Bug: 1048607 Change-Id: I96a665a8feb494fd8a59d01e7dcb8155d8b07e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270457 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
-
Sadrul Habib Chowdhury authored
Affected metrics: . Compositing.Browser.PicturePile.UpdateInvalidatedAreaPerMs . Compositing.Browser.PicturePile.UpdateUs . Compositing.Browser.RasterTask.RasterUs . Compositing.Renderer.PicturePile.UpdateInvalidatedAreaPerMs . Compositing.Renderer.PicturePile.UpdateUs . Compositing.Renderer.RasterTask.RasterUs BUG=1088690, 1088688, 1089795 Change-Id: Ie8d1dc15647b9876987a5566626eb5ab002d09f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285478 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#786233}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Idc8096b765b6bb96d8718ae613bb170a06f91dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287611Reviewed-by:
-
Minggang Wang authored
This CL converts base::Bind to base::BindOnce in //chrome/browser/profile_resetter/. With this CL, there should be no base::Callback, base::Closure and base::Bind any more. Bug: 1007635 Change-Id: I57bb5ec4d0dbf9518015c8c9cf1ef6d739a327cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284387Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#786231}
-
Mason Freed authored
This is one CL of many, moving tests out of the virtual/controls-refresh directory, into fast/forms. This CL moves: virtual/controls-refresh/checkbox -> fast/forms/checkbox virtual/controls-refresh/meter -> fast/forms/meter virtual/controls-refresh/password -> fast/forms/password virtual/controls-refresh/range -> fast/forms/range virtual/controls-refresh/fast/forms/text -> fast/forms/text This is a pure move of the above folder(s). A few tests share names in the old/new location, but in all cases, the version being moved is updated/new and should overwrite the old version. Additionally, two password-* tests were moved from fast/forms -> fast/forms/text for consistency. See also crbug.com/1102647 - there is additional cleanup that will be needed after this move is complete. But to keep the review process simple, this is just a pure move. Bug: 1034611 Change-Id: I211d12131dc5503522f4d4a03c75c8a38101bc39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284223 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
-
Omer Katz authored
This CL does the following: 1) Move flushing of ephemeron pairs to the start of AdvanceMarking (also increase frequency by 2x and make step counters actually count steps). 2) Introduce additional (disabled) scopes for diagnostics. 3) Increase frequency of deadline checks when draining worklists (by ~8x) 4) Revise worklist draining so that the deadline is checked before draining starts. Bug: 986235 Change-Id: Ie24827a52cbcb497426fd51bc052fb129c417702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283743 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#786229}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594176896-1abe2c53da5158e1bb4939e0c26aa192b0d7f8b2.profdata to chrome-win32-master-1594187879-ebfd6a43efdbcc89fbe635e86e12f487d90a9077.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I73acae075d7caadc1bcb163e06af4453153e95f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286785Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3688cb363ccd..e6a6e45f3af0 2020-07-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 4c6019a855e9 to 145050bf2b98 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I16ec5fe1a43be66afeef50a2082941b6ff51b0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286782Reviewed-by:
-
Antonio Gomes authored
This is now possible after switching most of Blink to operate over MediaStreamDescriptor directly. BUG=704136, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I1bbce476fb6b83e37ad99723fe799ad94fd8236f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284962Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#786226}
-
Oriol Brufau authored
The list-style-type and list-style-image properties can affect the kind of list marker that we have. However, what matters are the values on the originating list item, not on the ::marker itself. Right now the difference doesn't matter, since ::marker doesn't accept these properties, and thus must be inherited. But in the future we might remove the restrictions and accept arbitrary properties in ::marker. This patch makes LayoutListMarker stop detecting changes in the list properties. They are instead detected in LayoutListItem, which notifies the marker, using a similar logic as for LayoutInsideListMarker and LayoutOutideListMarker. Also, the SetNeedsLayoutAndIntrinsicWidthsRecalcAndFullPaintInvalidation call when list-style-type changes is now avoided if list-style-image is a valid image, since then it overrides list-style-type. And there is no need to check list-style-position, since it affects the display, thus forcing a layout tree reattachment. So the layout invalidation reason can be changed from kStyleChange to kListStyleTypeChange. Bug: 457718 Change-Id: Ifde0068bbc3fbf8802c1c9c4fed13bc682b65d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279775Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#786225}
-
Adrienne Walker authored
This fixes a null pointer crash where the ScriptState's context is not valid and is not checked before being passed to ExecutionContext::From. Bug: 1099813 Change-Id: Ibdb5d33b6383f904a6f0ddb3b0eb0c6489b561d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283926 Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#786224}
-
Titouan Rigoudy authored
Part of the library is unused for now. It will come in handy for CORS-RFC1918. Bug: 986744 Change-Id: Ic5081003d3df470104f1e115da9dbe358a271e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260422 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#786223}
-
Patrick Brosset authored
DevTools wants to highlight named grid areas in the page, but these highlights should not include the space reserved for gaps between tracks. This change just subtract the gap breadth when building the paths for the overlay. Bug: 1100384 Change-Id: I32fe57d80d660941a4eb58112686706d1390c4c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278851 Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
-
arthursonzogni authored
Add a few more tests when navigating with one document using COOP:same-origin-allow-popup or COOP-Report-Only:same-origin-allow-popup (or both) Bug: chromium:1090273 Change-Id: I95bf3c4aaf2f2db5e8f0076c495f5c1872d77431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279767 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#786221}
-
Corentin Wallez authored
Use "blocklist" for the concept of block certain GPU features based on the system's configuration. The usages of "blacklist" in the command line flags are not addressed in this CL and will be done in follow-ups as they require more careful migration. Bug: chromium:1101491 Change-Id: Iafb94471e72e67260131cccbefe571a1360428c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283321 Auto-Submit: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#786220}
-
Elad Alon authored
Bug: 1092514, 1095040 Change-Id: Iea56dea0beed02cca32cd3775a42f3626fb385e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283606 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#786219}
-
Sylvain Defresne authored
Chrome on iOS has some internal landmines and uses a forked version of build/landmines.py for that to allow using a separate landmines file. Add a --landmines-path parameter to build/landmines.py script in order to remove the forked version and instead use the shared one. Bug: 1033067 Change-Id: Iac668c5877ae181442078cda7ce8e727f91104b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283582Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#786218}
-
Artem Titov authored
NOTRY=True Bug: webrtc:11756 TBR: hbos@chromium.org Change-Id: I7eb8aeaa10ff5f2aacc69ec7bf03f18453d7f736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287294Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Commit-Queue: Artem Titov <titovartem@chromium.org> Cr-Commit-Position: refs/heads/master@{#786217}
-
Jan Krcal authored
This CL adds a new implementation of SetProfileIdentityInfo() within ProfileMenuViewBase guarded by a feature flag. The new implementation: - adds a colored background that matches the active frame color, - forces the profile name to always appear (for standard profiles), and - replaces the previous edit action (when you click on the profile name) with a dedicated edit icon. https://screenshot.googleplex.com/1OV5VXrCVKK Bug: 1099286 Change-Id: I20fff5b4a117aeb47174c3337900347057eb4b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266958 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#786216}
-
Kim-Anh Tran authored
This allows DevTools to retrieve possible breakpoints (and thus to set breakpoints) while the main thread is blocking. Bug: chromium:1076337 Change-Id: Ia86d1c59bc3036edc334302eb739d5a113a0f55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284485 Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Maksim Moskvitin authored
This patch: 1. Renames FileBasedTrustedVaultClient -> StandaloneTrustedVaultClient to better reflect its purpose. 2. Moves StandaloneTrustedVaultClient into dedicated subdirectory, since there are more related classes coming. 3. Moves Backend into dedicated file to simplify future testing. Bug: 1102340 Change-Id: Iec2bff0132123ee37cc620dcc504cecd24b6573e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282745Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#786214}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6a4da9da4215..7afbc0c8be3f 2020-07-07 andreperezmaselco.developer@gmail.com spirv-fuzz: Add variables with workgroup storage class (#3485) 2020-07-07 andreperezmaselco.developer@gmail.com spirv-fuzz: Implement the OpVectorTimesMatrix linear algebra case (#3489) 2020-07-07 vasniktel@gmail.com spirv-fuzz: fuzzerutil::MaybeGetConstant* #3487 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,syoussefi@google.com Change-Id: I18d8b33b213d65919e1726e6531750cac073af87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286780Reviewed-by:
-
Victor Hugo Vianna Silva authored
This CL removes checks for the client from codepaths where it's supposed to be non-null. Bug: None Change-Id: Ia85af01559410d8486d158841bbb7bbee8e38201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283311 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#786212}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/90b0c9e859ab..41acf46e02a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC huanzhong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1093365 Tbr: huanzhong@google.com Change-Id: I8ff0507c78345959ecd7ab6fcd9ea85f7f362e88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286778Reviewed-by:
-
