Commits · 20b2496552e4621699e58a837e43141815a30280 · eriksson monteiro / tangled

27 Feb, 2020 40 commits

Roll Fuchsia SDK from 0.20200227.1.1 to 0.20200227.2.1 · 20b24965

chromium-autoroll authored Feb 27, 2020

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I921c72bddfe6c716bad2756a524670efbb991958
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079042Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745154}

20b24965

Reland "Add support for loading predictor to use hints from optimization guide" · 9fbb8b10

Sophie Chang authored Feb 27, 2020

This is a reland of 04f3c8a3

TBR=tbansal@chromium.org for chrome/browser/predictors/... (he also said it was ok over chat)

Original change's description:
> Reland "Reland "Add support for loading predictor to use hints from optimization guide""
>
> This is a reland of 9a31f5ab
>
> Original change's description:
> > Reland "Add support for loading predictor to use hints from optimization guide"
> >
> > This is a reland of eed7024d
> > TBR=tbansal@chromium.org for chrome/browser/predictors/...
> >
> > Original change's description:
> > > Add support for loading predictor to use hints from optimization guide
> > >
> > > Will add metrics in a subsequent CL. This shouldn't affect any current
> > > metrics since the support is all behind a feature flag.
> > >
> > > Bug: 1050101
> > > Change-Id: If6f98dbae86bb5842803cdb3c1b052d99711e62f
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067241
> > > Commit-Queue: Sophie Chang <sophiechang@chromium.org>
> > > Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
> > > Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#743767}
> >
> > Bug: 1050101
> > Change-Id: I796d2bbd322fee835bfc42f3f3bc903b65554291
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068313
> > Commit-Queue: Sophie Chang <sophiechang@chromium.org>
> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#744088}
>
> Bug: 1050101
> Change-Id: I3450fa6cab159b22d0659532ea8f2524bf4944fc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071380
> Commit-Queue: Sophie Chang <sophiechang@chromium.org>
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#744839}

Bug: 1050101
Change-Id: I3a2f925fc8d1d69ef25584848002cc158f2028a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078836Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745153}

9fbb8b10

Roll src/third_party/webrtc eed48b86ed9c..c93595b4b916 (1 commits) · b56ba7be

chromium-autoroll authored Feb 27, 2020

https://webrtc.googlesource.com/src.git/+log/eed48b86ed9c..c93595b4b916

git log eed48b86ed9c..c93595b4b916 --date=short --first-parent --format='%ad %ae %s'
2020-02-27 perkj@webrtc.org Allow REMB messages to be sent immediately in RtcpTransceiver

Created with:
  gclient setdep -r src/third_party/webrtc@c93595b4b916

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I674e68120b0fc63fa1296edb055d9a1130255b3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078599Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745152}

b56ba7be

[Assistant Opt-in] Adaptive to narrow portrait screens · 689e3504

Yue Li authored Feb 27, 2020

Portrait and smaller screen treatment for 2 columns layout:
https://spec.googleplex.com/crosux-spec/feature-specs/oobe-templates.html#oobe-templates-2-columns

Also fix an error that the lottie animation is not found in the
timeout method.

Bug: 1033273, 1033268
Test: Manual Test
Change-Id: I8cbe121b0514a8ff41bab6affecf00a576aad72e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076665Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745151}

689e3504

pl files shouldn't be included in gn. · ea7b037e

Jerome Jiang authored Feb 27, 2020

BUG=chromium:1055917

Change-Id: I7105ed49b94960bec3e267ffcee7aa4d74efff4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072364Reviewed-by: James Zern <jzern@google.com>
Commit-Queue: Jerome Jiang <jianj@google.com>
Cr-Commit-Position: refs/heads/master@{#745150}

ea7b037e

WebLayer: defer (rather than ignore) window.alert on background tabs. · add2c76b

Evan Stade authored Feb 27, 2020

This matches Chrome behavior. When a window.alert is triggered on a bg
tab, it will be deferred until that tab becomes foregrounded. This
logic is implemented in TabModalDialogManager, so there are minimal
changes required to WebLayer.

Note that other js dialogs are simply ignored on backgrounded tabs,
with a console message logged.

Bug: 1025256
Change-Id: I05bce9195198db3685c814246e73721269a4b979
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075053
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745149}

add2c76b

Revert "Label UMA data with backend name for SkiaRenderer" · 865a1e45

Chris Blume authored Feb 27, 2020

This reverts commit ee82ef83.
Originally reviewed on:
https://chromium-review.googlesource.com/c/chromium/src/+/1924632

Bug: 1055899
Change-Id: I5d210a6df3d90ad6e96a6f6d7955845a38721f6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076531Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Auto-Submit: Chris Blume <cblume@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745148}

865a1e45

[webauthn] testdriver API: Add isUserConsenting · c12d3a94

Nina Satragno authored Feb 27, 2020

Add `isUserConsenting` to the content shell testdriver API. This lets
us run the timeout WPTs.

Fixed: 1054810, 1054655
Change-Id: Id90567818a1fcda44794294fc3527790df056870
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078833Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745147}

c12d3a94

[Sheriff] Revert "Reland "Reland "Make tab strip auto scroll to position of the selected tab""" · c5c70dfe

Katie Dektar authored Feb 27, 2020

This reverts commit 18fd0f78.

Reason for revert: Breaks compile, closes the tree

Original change's description:
> Reland "Reland "Make tab strip auto scroll to position of the selected tab""
> 
> This reverts commit 6f50bdff.
> 
> Reason for revert: Try to fix the compile failure.
> 
> Original change's description:
> > Revert "Reland "Make tab strip auto scroll to position of the selected tab""
> > 
> > This reverts commit 1d7cbd22.
> > 
> > Reason for revert: This is still causing a compile failure:
> > ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:70: error: cannot find symbol
> >         CachedFeatureFlags.setForTesting(ChromeFeatureList.TAB_GRID_LAYOUT_ANDROID, true);
> > 
> > Original change's description:
> > > Reland "Make tab strip auto scroll to position of the selected tab"
> > > 
> > > This reverts commit e3a03f83.
> > > 
> > > Reason for revert: Try to fix the compile failure.
> > > 
> > > Original change's description:
> > > > Revert "Make tab strip auto scroll to position of the selected tab"
> > > > 
> > > > This reverts commit 7767aa96.
> > > > 
> > > > Reason for revert: suspect causing compile failure on android-archive-rel
> > > > 
> > > > Sample build: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/9648
> > > > 
> > > > Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8887341380366474896/+/steps/compile/0/stdout?format=raw
> > > > ----
> > > > ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:70: error: cannot find symbol
> > > >         CachedFeatureFlags.setGridTabSwitcherEnabledForTesting(true);
> > > >                           ^
> > > >   symbol:   method setGridTabSwitcherEnabledForTesting(boolean)
> > > >   location: class CachedFeatureFlags
> > > > ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:71: error: cannot find symbol
> > > >         CachedFeatureFlags.setTabGroupsAndroidEnabledForTesting(true);
> > > >                           ^
> > > >   symbol:   method setTabGroupsAndroidEnabledForTesting(boolean)
> > > >   location: class CachedFeatureFlags
> > > > ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:83: error: cannot find symbol
> > > >         CachedFeatureFlags.setGridTabSwitcherEnabledForTesting(null);
> > > >                           ^
> > > >   symbol:   method setGridTabSwitcherEnabledForTesting(<null>)
> > > >   location: class CachedFeatureFlags
> > > > ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:84: error: cannot find symbol
> > > >         CachedFeatureFlags.setTabGroupsAndroidEnabledForTesting(null);
> > > >                           ^
> > > >   symbol:   method setTabGroupsAndroidEnabledForTesting(<null>)
> > > >   location: class CachedFeatureFlags
> > > > 4 errors
> > > > ----
> > > > 
> > > > Original change's description:
> > > > > Make tab strip auto scroll to position of the selected tab
> > > > > 
> > > > > Currently, when a tab in group is selected or a new tab is created
> > > > > within group, the tab strip doesn't scroll to the position of the
> > > > > currently selected tab. This could lead to a state where user needs to
> > > > > scroll by themselves to find their selected tab in strip. This CL fixes
> > > > > this issue by making following changes:
> > > > >   * Always scroll the strip to the last position when new tab is added
> > > > >     in group.
> > > > >   * When selected a tab in group (through tab grid dialog etc), try to
> > > > >     scroll to a state where the selected tab is in the middle of the
> > > > >     strip, if possible,
> > > > > 
> > > > > Bug: 1054079
> > > > > Change-Id: Ic6921225d744a7b5df1853aa78e14a8f9249f2c8
> > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068888
> > > > > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
> > > > > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> > > > > Cr-Commit-Position: refs/heads/master@{#744892}
> > > > 
> > > > TBR=yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org
> > > > 
> > > > Change-Id: I8db970a5e6c2338ce19c8870964b96c48e66eb44
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: 1054079
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076219
> > > > Reviewed-by: Takashi Sakamoto <tasak@google.com>
> > > > Commit-Queue: Takashi Sakamoto <tasak@google.com>
> > > > Cr-Commit-Position: refs/heads/master@{#744908}
> > > 
> > > TBR=tasak@google.com,yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org
> > > 
> > > Change-Id: If473ca1321615dd4d2972287274f53be6e0bb574
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 1054079
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078415
> > > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
> > > Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#745086}
> > 
> > TBR=tasak@google.com,yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org
> > 
> > Change-Id: I8bfddb25a503e743d790d0ddc59c4a45e0c91665
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1054079
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079137
> > Reviewed-by: Patrick Noland <pnoland@chromium.org>
> > Commit-Queue: Patrick Noland <pnoland@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#745123}
> 
> TBR=tasak@google.com,yusufo@chromium.org,wychen@chromium.org,pnoland@chromium.org,yuezhanggg@chromium.org
> 
> Change-Id: I88bc2d374066bf52fc056214ed9d4634a999647f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1054079
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078843
> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
> Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#745129}

TBR=tasak@google.com,yusufo@chromium.org,wychen@chromium.org,pnoland@chromium.org,yuezhanggg@chromium.org

Change-Id: I2483422df9d9bcfb282155ded95a3a52270ba81a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1054079
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079332Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745146}

c5c70dfe

[Payments][Autofill] Show saved UPI IDs in chrome://settings/payments · 33566149

Christos Froussios authored Feb 27, 2020

The new payment type is being added to the existing credit_card_list,
which is renamed to payments_list.

Functions to get the data from WebData were added to
autofill_private.idl
AutofillTable,
AutofillWebData,
PersonalDataManager etc

Bug: 986289
Change-Id: Ie7897c5497864c944e696f8fed2bf9ee20282f09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022769
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#745145}

33566149

Remove use of base::Bind from extensions/docs · d7dde0e3

Alan Cutter authored Feb 27, 2020

Bug: 1007786
Change-Id: I7b3ce7e78c7b15407e8e8f5826d94baae4f946d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076858Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745144}

d7dde0e3

Create trial for HangWatcher. · 26dede50

Olivier Li authored Feb 27, 2020

When the feature is activated HangWatcher will monitor the IOThread
instead of ThreadWatcher. The individual MessageLoop implementations are
instrumented to cover all platforms for the handling of events and
ThreadControllerWithMessagePumpImpl is instrumented to cover the task
execution.

Shutdown hang watching is still covered by ShutdownWatcherHelper.

Bug: 1034046
Change-Id: Ie797a1d1c4ce3b438878ad18e91347ccd02daccf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046404Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Oliver Li <olivierli@google.com>
Cr-Commit-Position: refs/heads/master@{#745143}

26dede50

Clear pending BackgroundTracingAgentClientImpl ctor · 342162af

Wanchang Ryu authored Feb 27, 2020

When renderer process is created, BackgroundTracingManagerImpl creates
closure for constructing of BackgroundTracingAgentClientImpl and creates
its instance lazily only when any agent observers are registered.
But it never releases if none of agent observer exists so it remained
as leaked memory.

To release pending constructor, BackgroundTracingAgentClientImpl
registers a disconnect handler to BackgroundTracingAgentProvider
then it releases when it is disconnected.
BackgroundTracingAgentProvider would be disconnected when the process
is gone.

Change-Id: I880c31caa7731dd3429c089ff523da5f846af00c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065195
Commit-Queue: Darin Fisher <darin@chromium.org>
Reviewed-by: Darin Fisher <darin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745142}

342162af

Fix media error mojom serialization · ddaaa979

Ted Meyer authored Feb 27, 2020

There were no checks in the StructTraits static getter methods, which
was causing DCHECK's when used.

Bug: 1043289
Change-Id: Ic139687493bb1e03b369dda2f30301ee78aa8330
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067949Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745141}

ddaaa979

[paint] Add test for clipping focus outlines. · ee2a9ff0

Ian Kilpatrick authored Feb 27, 2020

This adds a test for the progression caused by:
https://chromium-review.googlesource.com/c/chromium/src/+/1869012
Which corrected the clip state for paint descendants.

Bug: 1049976
Change-Id: I1c53cd800fa9ac342c025703e6d05359b582da56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076534Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745140}

ee2a9ff0

[WebViewShell] Fix a crash on Samsung device · 98fa2a73

Shimi Zhang authored Feb 27, 2020

Samsung devices may have a "Glove Mode", which is determined by Samsung
only API "android.util.GeneralUtil#isSupportedGloveModeInternal". This
method violates StrictMode disk read. So we need to ask extra permission
for Samsung devices.

Bug: 1056368
Test: Install WebView shell on Samsung J7 device (see the linked bug for
Test: ro.build.fingerprint), click the 3-dot menu, no crash observed.
Change-Id: I685e06ed30b3ba1654a4cabb7e2efede7480b8a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076528Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745139}

98fa2a73

Sync to WPT version of audit.js. · 23acd516

Raymond Toy authored Feb 27, 2020

Rebase test results that have changed because of changes in
audit.js. The output basically just has some new output lines and some
changed line numbers.

Bug: 1027300
Change-Id: I4a055a8e136e25139b1cf7e6bf24fbfbc2914796
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076536Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745138}

23acd516

Use FCP instead of FMP in Time To Interactive · 8cbfef6a

Nicolás Peña Moreno authored Feb 27, 2020

In this CL, we change the InteractiveDetector to rely on FCP instead of
FMP for TTI computations. In addition to this, the invalidating input
before FMP was only being used to determine whether to plumb TTI to the
browser process. As this is now never being done, that field can be
removed. The InteractiveDetectorTest is changed accordingly.

Bug: 1055806
Change-Id: Ie0154ffca8c79a0896679278c671e57668d0aa49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076057Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Deep Roy <dproy@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745137}

8cbfef6a

[webauthn] Implement fallback to PIN for UV Token requests · 427eaca9

Nina Satragno authored Feb 27, 2020

Fall back to PIN when an authenticator returns kCtap2ErrPinAuthBlocked
after getting a UV token or the remaining internal UV attempts are zero.

Bug: 1055497
Change-Id: Ie13750dd26f7e0ed5a1335e1c754d825926c00b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072477
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745136}

427eaca9

Added organization name to the relaunch notification recommended string on Chrome OS · 33266f5e

Aya ElAttar authored Feb 27, 2020

Bug: 1044716
Change-Id: I11653c3c6af414b5bde37b93cae0321caf184133
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077478Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Aya Elsayed <ayaelattar@google.com>
Cr-Commit-Position: refs/heads/master@{#745135}

33266f5e

[webauthn] WPT: Clean up virtual authenticators · 98c33104

Nina Satragno authored Feb 27, 2020

Add a step on web platform tests to clean up any virtual authenticators
that are created. Tests should be self contained and clean up after
themselves.

Fixed: 1056231
Change-Id: I2fc3f892efbc602d5bee8ec7cbf3d51873cd6522
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078832
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745134}

98c33104

[iOS] Refactor TabModelSyncedWindowDelegate into a BrowserAgent · 71abbc33

Mark Cogan authored Feb 27, 2020

Bug: 1050134
Change-Id: Ic84167df95cb1b4e0c3bf86cda3677bc18f27283
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074885
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745133}

71abbc33

Enable webview debugging via bool at service creation · f7bddeee

Shawn Gallea authored Feb 27, 2020

This allows webview debugging to be specified at
PlatformViewsAsyncService creation.

Merge-With: eureka-internal/369473
Bug: Internal b/149833693
Test: NONE
Change-Id: Ia9b02cd6f59e1343b4fce70ed639196f80a03010
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079033Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Shawn Gallea <sagallea@google.com>
Cr-Commit-Position: refs/heads/master@{#745132}

f7bddeee

Improve logic for when to show home to overview nudge · f674ebc6

Toni Barzic authored Feb 27, 2020

Do not show the nudge unless the user has at least two (minimized)
app windows, so the user does not see empty overview UI.
Also, add an extra check that the nudges are not shown if the user
session is blocked.

BUG=1008963

Change-Id: I8a9b5380e011f0b84b3c5d76c24faf032931bc26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076449
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745131}

f674ebc6

[Sheriff] Revert "Register the Updater and Chrome app ids with the //chrome/updater." · d7386169

Katie Dektar authored Feb 27, 2020

This reverts commit afcc5be9.

Reason for revert: Appears to have closed the tree by breaking "compile":
see https://ci.chromium.org/p/chromium/builders/ci/Win%20Builder/89067?:
FAILED: obj/chrome/updater/base/installer.obj 
../../chrome/updater/installer.cc(52,10): error: use of undeclared identifier 'sequence_checker_'
  DCHECK(sequence_checker_.CalledOnValidSequence());
         ^
../../chrome/updater/installer.cc(56,10): error: use of undeclared identifier 'sequence_checker_'
  DCHECK(sequence_checker_.CalledOnValidSequence());
         ^

Original change's description:
> Register the Updater and Chrome app ids with the //chrome/updater.
> 
> This change uses prefs to store and retrieve app ids for the apps
> registered for updates.
> 
> Bug: 1020285
> Change-Id: I7dea36049e6e09ff7039b61f79acb268e94baddb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053584
> Commit-Queue: Sorin Jianu <sorin@chromium.org>
> Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#745125}

TBR=sorin@chromium.org,waffles@chromium.org

Change-Id: I0e270d1c6b4fc855f0c4686ee6de0551dbfcbcd1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1020285
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078844Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745130}

d7386169

Reland "Reland "Make tab strip auto scroll to position of the selected tab"" · 18fd0f78

Yue Zhang authored Feb 27, 2020

This reverts commit 6f50bdff.

Reason for revert: Try to fix the compile failure.

Original change's description:
> Revert "Reland "Make tab strip auto scroll to position of the selected tab""
> 
> This reverts commit 1d7cbd22.
> 
> Reason for revert: This is still causing a compile failure:
> ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:70: error: cannot find symbol
>         CachedFeatureFlags.setForTesting(ChromeFeatureList.TAB_GRID_LAYOUT_ANDROID, true);
> 
> Original change's description:
> > Reland "Make tab strip auto scroll to position of the selected tab"
> > 
> > This reverts commit e3a03f83.
> > 
> > Reason for revert: Try to fix the compile failure.
> > 
> > Original change's description:
> > > Revert "Make tab strip auto scroll to position of the selected tab"
> > > 
> > > This reverts commit 7767aa96.
> > > 
> > > Reason for revert: suspect causing compile failure on android-archive-rel
> > > 
> > > Sample build: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/9648
> > > 
> > > Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8887341380366474896/+/steps/compile/0/stdout?format=raw
> > > ----
> > > ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:70: error: cannot find symbol
> > >         CachedFeatureFlags.setGridTabSwitcherEnabledForTesting(true);
> > >                           ^
> > >   symbol:   method setGridTabSwitcherEnabledForTesting(boolean)
> > >   location: class CachedFeatureFlags
> > > ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:71: error: cannot find symbol
> > >         CachedFeatureFlags.setTabGroupsAndroidEnabledForTesting(true);
> > >                           ^
> > >   symbol:   method setTabGroupsAndroidEnabledForTesting(boolean)
> > >   location: class CachedFeatureFlags
> > > ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:83: error: cannot find symbol
> > >         CachedFeatureFlags.setGridTabSwitcherEnabledForTesting(null);
> > >                           ^
> > >   symbol:   method setGridTabSwitcherEnabledForTesting(<null>)
> > >   location: class CachedFeatureFlags
> > > ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:84: error: cannot find symbol
> > >         CachedFeatureFlags.setTabGroupsAndroidEnabledForTesting(null);
> > >                           ^
> > >   symbol:   method setTabGroupsAndroidEnabledForTesting(<null>)
> > >   location: class CachedFeatureFlags
> > > 4 errors
> > > ----
> > > 
> > > Original change's description:
> > > > Make tab strip auto scroll to position of the selected tab
> > > > 
> > > > Currently, when a tab in group is selected or a new tab is created
> > > > within group, the tab strip doesn't scroll to the position of the
> > > > currently selected tab. This could lead to a state where user needs to
> > > > scroll by themselves to find their selected tab in strip. This CL fixes
> > > > this issue by making following changes:
> > > >   * Always scroll the strip to the last position when new tab is added
> > > >     in group.
> > > >   * When selected a tab in group (through tab grid dialog etc), try to
> > > >     scroll to a state where the selected tab is in the middle of the
> > > >     strip, if possible,
> > > > 
> > > > Bug: 1054079
> > > > Change-Id: Ic6921225d744a7b5df1853aa78e14a8f9249f2c8
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068888
> > > > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
> > > > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#744892}
> > > 
> > > TBR=yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org
> > > 
> > > Change-Id: I8db970a5e6c2338ce19c8870964b96c48e66eb44
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 1054079
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076219
> > > Reviewed-by: Takashi Sakamoto <tasak@google.com>
> > > Commit-Queue: Takashi Sakamoto <tasak@google.com>
> > > Cr-Commit-Position: refs/heads/master@{#744908}
> > 
> > TBR=tasak@google.com,yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org
> > 
> > Change-Id: If473ca1321615dd4d2972287274f53be6e0bb574
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1054079
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078415
> > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
> > Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#745086}
> 
> TBR=tasak@google.com,yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org
> 
> Change-Id: I8bfddb25a503e743d790d0ddc59c4a45e0c91665
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1054079
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079137
> Reviewed-by: Patrick Noland <pnoland@chromium.org>
> Commit-Queue: Patrick Noland <pnoland@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#745123}

TBR=tasak@google.com,yusufo@chromium.org,wychen@chromium.org,pnoland@chromium.org,yuezhanggg@chromium.org

Change-Id: I88bc2d374066bf52fc056214ed9d4634a999647f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1054079
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078843
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745129}

18fd0f78

[Sheriff] Disable flaky NewTabPageCustomizeDialogTest.All · 19cf4333

Katie D authored Feb 27, 2020

This test is flaky:
[FATAL:web_contents_observer_sanity_checker.cc(318)] Check failed: !is_loading_.

Example failure: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81768

TBR=aee

Bug: 1056688
Change-Id: I5b6d229ea2178bb2f6ee35e7af5b3423f2f6ad66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079031Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745128}

19cf4333

[Security] Do COOP & COEP parsing on redirects · 85eaa772

Arthur Hemery authored Feb 27, 2020

Parsing of the COOP and COEP header is currently not done for redirects.
This is a requirement for COOP to have that info even for redirects.
So moving it to the general repeated function.

Bug: 922191
Change-Id: Ifba6b4e9f0a649dd4492989bd17af5cd4d84a348
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066931
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745127}

85eaa772

Revert "Reland "[Kiosk] Refactor AppLaunchSplashScreenHandler so it works more reliably"" · 5084b4ef

Katie Dektar authored Feb 27, 2020

This reverts commit 39a8ab18.

Reason for revert: Speculatively causing consistent failures in
KioskTest.LaunchAppWithNetworkConfigAccelerator, which was mentioned
earlier in this revert/reland thread.

First failed build included this change: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3569

Original change's description:
> Reland "[Kiosk] Refactor AppLaunchSplashScreenHandler so it works more reliably"
> 
> This reverts commit 0e5a5146.
> 
> Reason for revert: Fixed errors in AppLaunchController. Time refactor all of this.
> 
> Original change's description:
> > Revert "[Kiosk] Refactor AppLaunchSplashScreenHandler so it works more reliably"
> >
> > This reverts commit cdce07c9.
> >
> > Reason for revert: KioskTest.LaunchAppWithNetworkConfigAccelerator has been failing on msan fairly consistently since this landed:
> > https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/17653
> >
> > Original change's description:
> > > [Kiosk] Refactor AppLaunchSplashScreenHandler so it works more reliably
> > >
> > > This handler was little bit overcomplicated. This led to a bug in web
> > > kiosk mode when we update network state, but do not update the handler.
> > >
> > > Because of this convolution, in web kiosks, the network configure
> > > screen did not update itself when connected to network(which is what
> > > client will expect from the handler which observes network state).
> > > Now it behaves more logically and predictably.
> > >
> > > Bug: 1015383
> > > Change-Id: I78b024b1d51b54b0d01d0a5a5694f6ae3f5ac19e
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031406
> > > Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
> > > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#739128}
> >
> > TBR=xiyuan@chromium.org,rsorokin@chromium.org,apotapchuk@chromium.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: 1015383
> > Change-Id: Ibc08de19048d9c8af95c3f517b748d09e37c7597
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045479
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#739735}
> 
> TBR=xiyuan@chromium.org,thakis@chromium.org,rsorokin@chromium.org,apotapchuk@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 1015383
> Change-Id: Ie77ba40fa6bf3bc94a22c97a8d2b0764ef0614d8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047225
> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#745056}

TBR=xiyuan@chromium.org,thakis@chromium.org,rsorokin@chromium.org,apotapchuk@chromium.org

Change-Id: I8696f63297d359b9aa34dcaa9d8e402ba9afb419
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1015383
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079138Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745126}

5084b4ef

Sorin Jianu authored Feb 27, 2020

This change uses prefs to store and retrieve app ids for the apps
registered for updates.

Bug: 1020285
Change-Id: I7dea36049e6e09ff7039b61f79acb268e94baddb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053584
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745125}

afcc5be9

[Addressinput] Assign getSortKey() return value · 06cc97ef

Tibor Dusnoki authored Feb 27, 2020

Assigned return value of getSortKey() to sort_key_size variable as it was before.
related patch: https://chromium-review.googlesource.com/c/chromium/src/+/1592677

Bug: 1056603
Change-Id: I979ef2416fcc428546148f6a7874ab61d9269b34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078014Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Parastoo Geranmayeh <parastoog@google.com>
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Cr-Commit-Position: refs/heads/master@{#745124}

06cc97ef

Revert "Reland "Make tab strip auto scroll to position of the selected tab"" · 6f50bdff

Patrick Noland authored Feb 27, 2020

This reverts commit 1d7cbd22.

Reason for revert: This is still causing a compile failure:
../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:70: error: cannot find symbol
        CachedFeatureFlags.setForTesting(ChromeFeatureList.TAB_GRID_LAYOUT_ANDROID, true);

Original change's description:
> Reland "Make tab strip auto scroll to position of the selected tab"
> 
> This reverts commit e3a03f83.
> 
> Reason for revert: Try to fix the compile failure.
> 
> Original change's description:
> > Revert "Make tab strip auto scroll to position of the selected tab"
> > 
> > This reverts commit 7767aa96.
> > 
> > Reason for revert: suspect causing compile failure on android-archive-rel
> > 
> > Sample build: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/9648
> > 
> > Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8887341380366474896/+/steps/compile/0/stdout?format=raw
> > ----
> > ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:70: error: cannot find symbol
> >         CachedFeatureFlags.setGridTabSwitcherEnabledForTesting(true);
> >                           ^
> >   symbol:   method setGridTabSwitcherEnabledForTesting(boolean)
> >   location: class CachedFeatureFlags
> > ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:71: error: cannot find symbol
> >         CachedFeatureFlags.setTabGroupsAndroidEnabledForTesting(true);
> >                           ^
> >   symbol:   method setTabGroupsAndroidEnabledForTesting(boolean)
> >   location: class CachedFeatureFlags
> > ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:83: error: cannot find symbol
> >         CachedFeatureFlags.setGridTabSwitcherEnabledForTesting(null);
> >                           ^
> >   symbol:   method setGridTabSwitcherEnabledForTesting(<null>)
> >   location: class CachedFeatureFlags
> > ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:84: error: cannot find symbol
> >         CachedFeatureFlags.setTabGroupsAndroidEnabledForTesting(null);
> >                           ^
> >   symbol:   method setTabGroupsAndroidEnabledForTesting(<null>)
> >   location: class CachedFeatureFlags
> > 4 errors
> > ----
> > 
> > Original change's description:
> > > Make tab strip auto scroll to position of the selected tab
> > > 
> > > Currently, when a tab in group is selected or a new tab is created
> > > within group, the tab strip doesn't scroll to the position of the
> > > currently selected tab. This could lead to a state where user needs to
> > > scroll by themselves to find their selected tab in strip. This CL fixes
> > > this issue by making following changes:
> > >   * Always scroll the strip to the last position when new tab is added
> > >     in group.
> > >   * When selected a tab in group (through tab grid dialog etc), try to
> > >     scroll to a state where the selected tab is in the middle of the
> > >     strip, if possible,
> > > 
> > > Bug: 1054079
> > > Change-Id: Ic6921225d744a7b5df1853aa78e14a8f9249f2c8
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068888
> > > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
> > > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#744892}
> > 
> > TBR=yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org
> > 
> > Change-Id: I8db970a5e6c2338ce19c8870964b96c48e66eb44
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1054079
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076219
> > Reviewed-by: Takashi Sakamoto <tasak@google.com>
> > Commit-Queue: Takashi Sakamoto <tasak@google.com>
> > Cr-Commit-Position: refs/heads/master@{#744908}
> 
> TBR=tasak@google.com,yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org
> 
> Change-Id: If473ca1321615dd4d2972287274f53be6e0bb574
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1054079
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078415
> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
> Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#745086}

TBR=tasak@google.com,yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org

Change-Id: I8bfddb25a503e743d790d0ddc59c4a45e0c91665
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1054079
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079137Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745123}

6f50bdff

Fix accessible alert for deep scanning prompt · ac44b7e2

Daniel Rubery authored Feb 27, 2020

The accessible alert while prompting the user for deep scanning is still
"Downloading, 0% remaining", which is jarring. This CL fixes that.

Bug: 1056350
Change-Id: I5e10dcc702c6bef8368492819ce67e432dd469b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076429Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745122}

ac44b7e2

desktop-pwas: Don't include gaia name in file association menu. · 261bb749

David Bienvenu authored Feb 27, 2020

crrev.com/c/1845766 added the signed in Gaia name to the local
profile name for displaying a profile name in the user menu
and profile switcher.

Since the pwa+profile name in the file association open with
menu is static, I think it's better not to include the
signed in gaia name - and it looks odd the way it is now
<pwa name>(<profile name>(<gaia name>)).

Bug: 960245
Change-Id: Ic6a1476590c469c413cd8a5fe6883440e23c953b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075975Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745121}

261bb749

Added password credential suggestions filtering by username prefix. · 8af98307

Maria Kazinova authored Feb 27, 2020

Implementing the behaviour that already exists on other platforms:
when user starts typing the username into username field, it makes sense
to show only credentials with the same username prefix.
When user types something into password field, no suggestions should
be shown.

Bug: 831564
Change-Id: I9eeffd808e441ff598d26a1af88994150d8682a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073761Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Maria Kazinova <kazinova@google.com>
Cr-Commit-Position: refs/heads/master@{#745120}

8af98307

Remove Time To Interactive plumbing to the browser process · aa4f7b3f

Nicolás Peña Moreno authored Feb 27, 2020

TTI should not be used as a RUM metric. This CL removes the plumbing of
TTI and related values from the renderer to the browser process. It also
removes the UMA and UKM histograms that were using it.

Bug: 1055806

Change-Id: Ia72c454587f633e58882153bd921ddafae3e71f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070384Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Deep Roy <dproy@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745119}

aa4f7b3f

Extension messaging: mark a method as test-only to prevent non-test use. · fb1ddbbd

Mustaq Ahmed authored Feb 27, 2020

Change-Id: I6d8f3dce02ff4fb21e60d38c8c52d79a9ab156ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078656Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745118}

fb1ddbbd

Roll src/third_party/swiftshader 4b34ee3de531..ad3e42a439e2 (1 commits) · 740cdbb5

chromium-autoroll authored Feb 27, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/4b34ee3de531..ad3e42a439e2

git log 4b34ee3de531..ad3e42a439e2 --date=short --first-parent --format='%ad %ae %s'
2020-02-27 amaiorano@google.com Subzero: add support for variadic calls (System V)

Created with:
gclient setdep -r src/third_party/swiftshader@ad3e42a439e2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I4fb314de2dc79619882a5655f2149b86ab193d5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078304Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745117}

740cdbb5

[paint] Remove additional ScopedPaintTimingDetectorBlockPaintHook. · e196d973

Ian Kilpatrick authored Feb 27, 2020

Followup from:
https://chromium-review.googlesource.com/c/chromium/src/+/2044522/3/third_party/blink/renderer/core/paint/ng/ng_box_fragment_painter.cc#325

I was pointed out that now we have the
ScopedPaintTimingDetectorBlockPaintHook within PaintInternal, the one
within PaintLineBoxChildren was redundant.

Change-Id: I285ce15eba904c1c21e24e94ce87cf86184edec8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076080Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745116}

e196d973

[Sheriff] Disable flaky test, LocationBarSteadyStateTestCase/testCopyPaste. · d07a4b9b

Katie D authored Feb 27, 2020

Failure reason:
Exception: NoMatchingElementException

TBR=stkhapugin@chromium.org

Bug: 1056700
Change-Id: I2ee0b6871d2ef725316c158f0cbe2167315b969b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078434Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745115}

d07a4b9b