- 07 Aug, 2020 5 commits
-
-
Nate Chapin authored
This only matters for Documents that will be attached, but given that the Document will attach to the LocalDOMWindow, that should be the primary object the DocumentInit holds. Also, while cleaning up state on DocumentInit, remove GetUseCounter(). It's only use is during the Document constructor, and we have another reliable path to the UseCounter. Change-Id: Iafbb3c1c335c37bdf5bcf7e2ed3856ebf22bc861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339399 Auto-Submit: Nate Chapin <japhet@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#795716}
-
Tomasz Wiszkowski authored
This change introduces mechanism to record existing metrics for omnibox suggestion groups expand/collapse on Android. Bug: 1113476 Change-Id: Ie1ead60ed994eda5035972dc1feefab03b8b18a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339899 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#795715}
-
Etienne Bergeron authored
Sampling profiler is causing jank on the Browser main-thread and io-thread when Trend Micro DLLs are in the process. This is a reland of: https://chromium-review.googlesource.com/c/chromium/src/+/1881980 Bug: 1113832 Change-Id: Ieabf791b6f1ecce5fc4f3d84de822cc4ca11e52d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340675 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#795714}
-
Tommy Li authored
Previously, the user had to click on the header button to expand or collapse the section. This CL makes it so they can click anywhere on the row. This only affects the Views omnibox, and the NTP realbox, both on Desktop. Android already works like this, so it needs no further work. Bug: 1113341c Change-Id: I64de6db54ee63de3d428de69aa23c2759effe1cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340266 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#795713}
-
Reilly Grant authored
This test is flaky on macOS and Windows. TBR=dpapad@chromium.org Bug: 1113912 Change-Id: I01da04ba3fdc85b77442debf35ffe9304000b5cd No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340512Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#795712}
-
- 06 Aug, 2020 35 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dc68e3248ed9..e69d5b2de943 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5957620d77228381a7d47d9d5457c28e9123bdc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341842Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795711}
-
Alex Turner authored
This cl adds a ukm::SourceId to each ServiceWorkerVersion and propagates that down to the ServiceWorkerGlobalScope. A followup cl will have each service worker client inform its respective ServiceWorkerContainerHost of the client's ukm::SourceId. A UKM event will also be emitted on on that connection in order to associate the two ukm::SourceIds. Bug: 1085645 Change-Id: I9a77e4196834379162c8e7516eb0bde58f5fa5e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298349 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#795710}
-
Sorin Jianu authored
Bug: 1109231 Change-Id: I5bfe32fdf39c703bae75e393aa295355094cec31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341180Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795709}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/99f48c74ab76..ea952ff32bf6 2020-08-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 4b40207be32d to b2be8f165978 (32 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Ia67b6a09227152edeab27d32730cc6284f89b1ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340740Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dc68e3248ed9..e69d5b2de943 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie6b975a4d31949f74b0315c0cea8856dc625a39d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341889Reviewed-by:
-
Christopher Cameron authored
Add a method through which VTVideoDecodeAccelerator will be able to access a SharedImageStub. In this case we've hung it off of VdaVideoDecoder's implementation of the VideoDecodeAccelerator::Client implementation. An alternative could be the GpuVideoDecodeGLClient, but that's a GL thing and after this change, VTVideoDecodeAccelerator won't use any GL things. Bug: 1108909 Change-Id: I46e7e92eaa90e7fb89c4582e53d985c3ae1d8d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333304 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#795706}
-
Devlin Cronin authored
Bug: None Change-Id: I71f5cf6d0816b406ac81068a57e924562307f1e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339587Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795705}
-
rajendrant authored
URLLoaderThrottle::Delegate restarts URLLoader only when some response is returned from server. This does not work when the request got blackholed due to server unreachability. This CL adds a RestartWithURLResetAndFlagsNow() API that restarts the URLLoader immediately. This only works when no response had been received from the server yet. Bug: 1110113 Change-Id: I7541c00b05e9fe94a28b95486295b026bfafe020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337338 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#795704}
-
Filip Gorski authored
Theme leaking fix introduced a race condition manifesting in background drawable not always being set on suggestion action buttons. This patch updates the method responsible for adding/binding action buttons to also include setting the background. Second modification of the code prefer copying of drawable over retrieval, which in local testing is significantly better than getting a resource, especially in incognito, where additional theme leaking code causes long wait on the first retrieved resource. In normal case copy is about 2 times faster. In incognito case it is up to 10 times faster than subsequent retrievals. Bug: 1113542 Change-Id: Ic2d09dc0bec4696cec78601b93a30d0fd1b8fd5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341403Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
-
Carlos IL authored
Bug: 1088873, 1089525 Change-Id: I88b0164eca4a5554f59fb588ce0a9f88d60545ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340676 Commit-Queue: Carlos IL <carlosil@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#795702}
-
Angela Yoeurng authored
Bug: 1046523 Change-Id: I18856d4cd56847f4778bdd3d5b1b5ec68e54824d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340268 Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#795701}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/19c3850508fd..2c4a07d925cc 2020-08-06 nifong@google.com allow external files in canvas_perf.js tests 2020-08-06 robertphillips@google.com Fix parameter evaluation order bug in DDLPromiseImageHelper 2020-08-06 johnstiles@google.com Update the DitherEffect @test to ensure non-zero dithering. 2020-08-06 jvanverth@google.com Fix unaligned pointer warning on iOS. 2020-08-06 johnstiles@google.com Implement matrix casting in Metal. 2020-08-06 ethannicholas@google.com simplified SkSL REHYDRATE=0 2020-08-06 johnstiles@google.com Enable ClangTidy check llvm-namespace-comment. 2020-08-06 brianosman@google.com SkRuntimeEffect: Apply uniform transforms in color filters, too If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: I531ff3557e4fed430161fc54970bc4d3d741c87a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341698Reviewed-by:
-
Khushal Sagar authored
Add an API on LayerTreeHost to enable the embedder to dynamically control when the compositor's rendering can be throttled for power/CPU efficiency. Enabling this mode is currently limited to the use-case of synchronizing multiple videos in the display compositor, so currently cc allows throttling up to 24fps to match the video content. R=chrishtr@chromium.org Bug: 976583 Change-Id: Ie9c7ccd631c453cd7db6d0d96885ea686646ff67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341392Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#795699}
-
John Lee authored
Bug: 1098545 Change-Id: Ic9aaf0b95b412198d9db3ce8f1ce805ac42f77b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339641 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#795698}
-
Michael Tang authored
Change-Id: Id271d849ef802e92537f60e3362343f1e05d7c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321216 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#795697}
-
Oystein Eftevaag authored
TBR=sullivan NOTRY=true Bug: 1113921 Change-Id: I4d19e804cdcd040f3b35be151ccd0c91c6b52c42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340875Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#795696}
-
Marijn Kruisselbrink authored
Rather than resolving a mojo Blob to a BlobDataHandle, just forward the request to the Blob and let the blob create the URL Loader. This way we decouple BlobURLLoaderFactory from any blob internals, paving the way for further separating out the blob URL registry from the rest of the blob system, making it easier to change where parts of the blob system live (for example moving Blob URLs to be per storage partition, or in the future perhaps per agent cluster). This does increase binary size significantly because the added mojom method results in java bindings being generated for a lot of interfaces and structs that were previously not generated. In the future this increase can be eliminated by making it possible to tag methods in mojom files with what languages they should create bindings for, or by rewriting BlobURLLoader itself to operate on a mojo Blob, rather than forward the entire URLRequest to the mojo blob (https://crbug.com/1111835). Bug: 1106890 Binary-Size: Size increase is unavoidable (see above). Change-Id: I4fa3c6a5ddf6f8be5ce299e9d1fd95eaef75ec5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330311Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#795695}
-
David Bertoni authored
Bug: 942499 Change-Id: I21c4f5dd3e03419f3d272f3ffe6c38d764bd3328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333063Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#795694}
-
Wenhan (Han) Zhang authored
Splits histograms.xml into smaller files by prefix so resulting files can be indexed and searched. Splits at given depth and aggregate threshold. Change-Id: Ia368af468c8229428b7079ce3a32ecd7d69f4ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327990Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Wenhan (Han) Zhang <zwenhan@google.com> Cr-Commit-Position: refs/heads/master@{#795693}
-
Daniel Classon authored
Better encapsulate network-summary by preventing InternetPage from directly accessing its DOM. Adds getNetworkRow public getter method and uses it in InternetPage. Change-Id: I8a42c5e13db9476b2bc600e3b6e0d97be3390c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341757Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Daniel Classon <dclasson@google.com> Cr-Commit-Position: refs/heads/master@{#795692}
-
Min Qin authored
This CL calls RecordMetrics() on query tile selection, so that Chrome will send the OmniboxEventProto to the backend. BUG=1112961 Change-Id: Ia7d220c129c7f1624eb3462e467cbd0e98f4f60a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336309 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
This is a reland of 853e0dd9 The original CL was reverted due to a data race. The race was fixed in crrev.com/c/2340297 Original change's description: > service worker: Use mojo version of GetUserDataForAllRegistrations > > This CL starts using mojo version of > GetUserDataForAllRegistrations{,ByKeyPrefix}(). > > The type of the return value of these methods is also changed from > map<registration_id, value> to array<ServiceWorkerUserData>, > and ServiceWorkerUserData now has registration_id. > These changes are required to handle a situation where a > registration_id is associated with multiple values. Some features like > payments could associate multiple values for a registration_id. > > Bug: 1055677 > Change-Id: I29e9ae7c1722316b2ac2f163cfc5b50fe7590d54 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331376 > Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794447} Bug: 1055677 Change-Id: I9f9ea4f6deb9953c4b18af941e6e8b70b66afb66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340417Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
Yuchen Liu authored
CastAudioManagerAndroid now becomes a subclass of AudioManagerAndroid, instead of CastAudioManager. Some of the logics are moved into CastAudioManagerAndroid to keep the behavior unchanged: 1. Move MakeLinear/LowLatencyOutputStream into CAMA, to return CAOS. 2. Move some getter into CastAudioManagerHelper (new), so that CAOS can be created from both CAM and CAMA. This will make switch to chromium audio output easier. Bug: internal b/160753974 Test: Build, cast, cast_media_unittests Change-Id: I99249c0c15bd7b5e9cf04b7ee10eb3b8850ee22e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340104 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#795689}
-
Dan Harrington authored
Bug: 1044139 Change-Id: Ieb32cc74c2e6bc18efd8520fb8794a3e44d38ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341832 Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#795688}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2399aa25d56e..beb677bfc877 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC reillyg@google.com,ftirelo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1001667 Tbr: reillyg@google.com,ftirelo@google.com Change-Id: I470a17defdeeaaeb738b403a98a00b4e68691f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341697Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795687}
-
chrome://media-router-internalsTakumi Fujimoto authored
Print the native logs JSON string on the internals page to aid in debugging. Bug: 687380 Change-Id: I864ff7dbdaa32a2b13cab85b1c554e04ed14e53a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324969Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#795686}
-
Scott Violet authored
This is used to fetch a previously downloaded favicon. For consistency this returns the same image as that returned from FaviconFetcher. BUG=1076463 TEST=none Change-Id: Icdd01286d1d564c7cb5b62847ffb1d888d9d70fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340796Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#795685}
-
Eli Ribble authored
This prevents triggering a NOTREACHED() for internal projects that have a very large number of variations. Bug: b:162438420 Change-Id: I171062c0d462e56f70cc6eb7ebeb279169279333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332571Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#795684}
-
Scott Violet authored
There is a bunch more work to be done here, but this makes the code match that of the names in history. BUG=1104873 TEST=none Change-Id: Ib11d1a2335e1c8ee6643b1f5e58d5807dd66a788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340547Reviewed-by:
-
James Long authored
Inbound and outbound depths must be >= 0. Previously, users could select values less than 0, this is no longer the case. Bug: 1102546 Change-Id: I479984448987a30d0b699bcae55336de840aff8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340364 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#795682}
-
Lan Wei authored
After we finish the scroll unification, the scrolls happens mainly on the compositor thread, and the scroll code in the main thread will be removed. eventSender sends the scroll events to main thread, so it would not work after the scroll unification. We should replace eventSender.continuousMouseScrollBy with gpuBenchmarking.smoothScrollByXY in fast/events/mouse-wheel-main-frame-event.html. Bug: 1047176 Change-Id: I5746dc6504e15984862957c670c458979afe5b4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332327Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#795681}
-
Bo Liu authored
Last attempt just moved the flake to the next line that times out while waiting for fullscreen state. Now make the whole rest of the test into a retry loop and see if things improve. Bug: 1107954 Change-Id: I1a358a28a4b22904db23e0b4ee0400b90292c59e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340672 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
-
Adam Langley authored
The current caBLEv2 handshake has the desktop speak first. We expect the network-based design to have the phone speak first, thus this change turns the handshake “around” to accommodate that. Also, the current v2 handshake includes pairing information in the response but, if the phone speaks first, the response is coming from the wrong place to include pairing information and the first message has insufficient protection to include it. Thus that is removed. Instead, a getInfo message can be included in the phone's first message because it'll be needed anyway and it's generic and thus doesn't require forward security. BUG=1002262 Change-Id: If2fb27b2a56ef21c0b21a454ff498f65ce62e81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340062 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#795679}
-
Dominic Farolino authored
We'll soon be adding another Finch group that indicates to the client that we should defer to the BlinkOptimizationGuide (being implemented in [1]) for the delay async script execution milestone, as opposed to relying on the field trial param value being set by Finch. This CL adds the kOptimizationGuide value as an option for the kDelayAsyncScriptExecutionDelayParam field trial parameter. When the BlinkOptimizationGuide is implemented [1], there will be a follow-up to this CL that actually uses the OptimizationGuide hint once it is plumbed to Blink. [1]: https://crrev.com/c/2337050 R=falken@chromium.org, kinuko@chromium.org, nhiroki@chromium.org Bug: 1086227 Change-Id: I8b8419b03b2a52399971cd32262ba003f2750ab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337767Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#795678}
-
Caleb Raitto authored
The problem with xor is it's a commutative operator, so the relative ordering of operations won't be captured in the digest calculated. This is problematic, as drawing an oval and then a rectangle can produce visually-different results than drawing the rectangle and then the oval. Instead, we can use the IdentifiableTokenBuilder library, which was designed to preserve such ordering. Bug: 973801 Change-Id: I45baf54418263a1984bc3446233fd5a7d0a6ebc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311059 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#795677}
-
