- 25 Sep, 2019 40 commits
-
-
Martin Šrámek authored
...by actually waiting for the cache entries to be written, rather than relying on a short timeout. Bug: 911171,978891 Change-Id: I59294b8009ab23d08ec09561184df3e04252dd85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821720 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#699694}
-
Imranur Rahman authored
method. stream_metadata and stream_data were intended for some sort of "streaming response" mode. But it was never used. So, we are removing the unnecessary fields and corresponding proto messages. Bug: 1007190 Signed-off-by:
Imranur Rahman <i.rahman@samsung.com> Change-Id: Ic3cfca34f1d4cf20472b9d40b8a0ab314ca84983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821500Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#699693}
-
Anqing Zhao authored
Add a new policy 'DeviceLoginScreenSystemInfoEnforced' to control the behavior. This setting will be checked in 'VersionInfoUpdater'. Bug: 859298 Change-Id: I06ad06c485feaf7cc23c1067a4047fa1e21070cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806460 Commit-Queue: Anqing Zhao <anqing@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#699692}
-
Petr Smirnov authored
Add VersionUpdater member GetEolStatus to check if device is in end-of-life state. Bug: 1005151 Change-Id: I23655afa42dfff744bc93b90fcd59a140d7d695d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807229Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Commit-Queue: Petr Smirnov <petrsmirnov@google.com> Cr-Commit-Position: refs/heads/master@{#699691}
-
Roman Aleksandrov authored
Detect license existence and save it inside EnrollmentConfig for further use in wizard controller and OOBE screens. Test: unittested by these "*AutoEnrollmentClientImplTest*" tests. Bug: 871207 Change-Id: I52c644c80ec3175c3d1efb9ee13e696b9f500b51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782175 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#699690}
-
Finnur Thorarinsson authored
This reverts commit 1d2c953e. Reason for revert: This is somewhat speculative, but ever since this change was introduced, bot "Builder Linux Tests (dbg)(1)" has been failing on every run. The CL for the failing test talks about Perfetto and tracing, so this CL seems like a likely culprit. [12707:12707:0924/154115.904192:FATAL:privacy_filtering_check.cc(48)] Unexpected field in TracePacket proto. IDs from root to child : 8 #0 0x7f66c614a14f base::debug::CollectStackTrace() #1 0x7f66c5e7cecd base::debug::StackTrace::StackTrace() #2 0x7f66c5e7ce88 base::debug::StackTrace::StackTrace() #3 0x7f66c5ece649 logging::LogMessage::~LogMessage() #4 0x5651bc1aac57 tracing::(anonymous namespace)::VerifyProtoRecursive() #5 0x5651bc1aa9da tracing::(anonymous namespace)::VerifyProto() #6 0x5651bc1aa7d2 tracing::PrivacyFilteringCheck::CheckProtoForUnexpectedFields() #7 0x5651bbb57f38 content::ProtoBackgroundTracingTest_ProtoTraceReceived_Test::RunTestOnMainThread() #8 0x5651bd505564 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() Original change's description: > Add metadata at beginning of trace for discard buffer mode > > Trace metadata is almost always discarded in discard buffer mode of > perfetto tracing. For this case, add metadata at beginning of the trace. > Handles cases when generators are added while tracing. > > Change-Id: I911794fba1e7b460ca1a7a3a54599a8c05678d75 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812248 > Commit-Queue: ssid <ssid@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699493} TBR=oysteine@chromium.org,ssid@chromium.org,eseckler@chromium.org Change-Id: I98fdb75be1a0582ab1a196c66dd74213aeced90b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823861Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#699689}
-
Mohamed Amir Yosef authored
This was to support the fill-on-select experiment. The current UI is very hard and will mostly not going launch. This CL is replacing the behavior of opening of prompts on page load with existing Fill on account select behavior (which is already working on PSL matching and http forms). Using the existing behavior has multiple benefits: 1.decrease maintenance cost 2.ensure that this feature works 3.collects UMA on using this feature TBR=mkwst@chromium.org,vasilii@chromium.org Change-Id: I7a0b19dd18a56ae86712b34429023c96ceab9404 Bug: 949519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821524 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#699688}
-
Fredrik Söderquist authored
Move common (or to-be-common) code into a new TransformHelper class. This class contains logic for computing the reference box as well as the transform based on computed style. Also move the other transform-related helper SVGTransformChangeDetector to this new location. Some to-be-common code is moved from LayoutSVGShape to the super-class, for reuse by LayoutSVGImage. In LayoutSVGShape, set the |transform_uses_reference_box_| flag on style change rather than during layout. Bug: 1007146 Change-Id: Ie61537126a488a5c6c91cf416351ec2e28c692c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821919 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#699687}
-
Jit Yao Yap authored
Change-Id: Ibda3d1206b5fb5923914c0d6d2a8152681a87e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816538Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#699686}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/942786e2..336bd791 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8b57ce3b3ae815ebfea9aacca94dee089058ba37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823983Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699685}
-
Alex Clarke authored
We wish to prioritize loading and compositing tasks till FCP, but that changes the order in which the task posted by AudioWorkletObjectProxy::DidEvaluateModuleScript runs in relation to other loading tasks (it's called by WorkletModuleTreeClient::NotifyModuleTreeLoadFinished). Changing this task to be TaskType::kInternalLoad preserves the original order with the new scheduler policy. Bug: 971191 Change-Id: I1d80a9c7dd7e9c97b7303b087506caa9e51981d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819255 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#699684}
-
Hans Wennborg authored
The trunk version of Clang caught this bug: ../../content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc:350:50: warning: converting the result of '<<' to a boolean; did you mean '(type << ui::ET_TOUCH_CANCELLED) != 0'? [-Wint-in-bool-context] DCHECK(type >= ui::ET_TOUCH_RELEASED && type << ui::ET_TOUCH_CANCELLED); ^ TBR=wjmaclean Bug: 1007367 Change-Id: I0be9c853e6eb1b171fffd4b177e03a87abc9b932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824078Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#699683}
-
Peter Kasting authored
Does not fix chrome/browser/. Bug: 82078 Change-Id: I873944a6e6038cf432596e02df82d9b15eead03d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823910 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#699682}
-
Tomasz Moniuszko authored
Committing operations from KeywordWebDataService destructor doesn't work because it's too late and database is closed already. Bug: 1005769 Change-Id: Ia32def249a7bb6c2907e6e1afb30843441385740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813500 Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#699681}
-
Hans Wennborg authored
The trunk version of Clang caught this bug: ../../net/cert/cert_verify_proc_unittest.cc:2782:53: warning: converting the enum constant to a boolean [-Wint-in-bool-context] EXPECT_TRUE(error == ERR_CERT_AUTHORITY_INVALID || ERR_CERT_INVALID) ^ TBR=eroman Bug: 1007367 Change-Id: I4493f82c7f761f5fc4470343e148f4dd32c3d7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824260Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#699680}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ba04be8c9ef9..096b08fa42e8 git log ba04be8c9ef9..096b08fa42e8 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 3a762d54f649..527a689307a4 (5 commits) Created with: gclient setdep -r src/third_party/angle@096b08fa42e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: chromium:None Change-Id: I5e6bfd28755d53df5e71c655eef2646ac16c3a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824651Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699679}
-
arthursonzogni authored
When a new renderer initiated navigations starts it will either: 1) Create a new pending navigation entry and use it. 2) Reuse the existing pending navigation entry. The problem is that (2) is very wrong. There is no reasons to do it. For instance, when a main frame navigation starts, it creates a pending NavigationEntry. Then if a subframe navigation starts, is reuses the same pending NavigationEntry. This doesn't make sense. Bug: 999932 Change-Id: I53152ab7b62bdf9bcf745b7512f3b1110d0b5e2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818522Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#699678}
-
Takuto Ikuta authored
Test is flaky on https://ci.chromium.org/p/chromium/builders/try/linux_chromium_asan_rel_ng/381379 TBR=karandeepb@chromium.org BUG=1003598 NOTRY=true Change-Id: I2402407f109592cdea7bb0f70529fbd25da9d168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824790Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#699677}
-
Julie Jeongeun Kim authored
This CL converts VisitedLinkNotificationSinkPtr and VisitedLinkNotificationSinkRequest to new Mojo types using Remote, ReceiverSet and PendingReceiver. Bug: 955171 Change-Id: I3ac5ddc1c7e92072ab1848d2478225cc50dfc29e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816059Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#699676}
-
Mikolaj Walczak authored
BUG=b:138996293 Test: `test_that my_crbook cheets_AppPositionTest_P` Change-Id: If908ba85e4b3b8016341829c2c337b235b954cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792516Reviewed-by:
Mitsuru Oshima (Slow) <oshima@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#699675}
-
Julie Jeongeun Kim authored
This CL converts DownloadStreamClientPtr to new Mojo types. It uses Remote, PendingReceiver, and Receiver instead of DownloadStreamClientPtr, DownloadStreamClientRequest, and binding. Bug: 955171 Change-Id: I20205157b4c0400b95fe0fa6ab915dbb098c7caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810440Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#699674}
-
Julie Jeongeun Kim authored
This CL converts CrosNetworkConfigPtr and CrosNetworkConfigRequest to new Mojo types using PendingRemote or Remote, RemoteSet, PendingReceiver, and ReceiverSet. Bug: 955171 Change-Id: I2e942774834cc36d2f6bf586ec8367e9f7d38654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821698Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#699673}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/4881f75b7ca0..db4083fd7f19 git log 4881f75b7ca0..db4083fd7f19 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 wl@gnu.org * src/sfnt/sfwoff2.c (woff2_open_font): Check (sum of) table sizes. Created with: gclient setdep -r src/third_party/freetype/src@db4083fd7f19 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: Idbefdf74a1d739cad357a5655b89702094d8e30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824897Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#699672}
-
Hiroki Nakagawa authored
The test was disabled because a task bound with an unretained object may run after the object gets freed. To avoid that, this CL adds test::RunPendingTasks() call to drain the queued tasks before the object deallocation. For Sheriff, feel free to revert this CL if the flakiness still happens. Bug: 1007616 Change-Id: If7382250336a0f3820795b8a31e4429c6b64353f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824761Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#699671}
-
Eugene But authored
Relanding crrv.com/c/1816807 This CL removes web_state_observer.h and web_state.h from ios/web/public/web_state which are no longer used in downlstream repo (downstream code was switched to use files from ios/web/public). Bug: 942244 Change-Id: I9a6000fd421f9e6a5ac81e45a08d0761d0b9134f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818222 Commit-Queue: Yi Su <mrsuyi@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#699670}
-
Wez authored
Reason for revert: Reverting to an SDK revision that allows the "chromium" package to be updated to a local build. TBR=sergeyu Bug: fuchsia:37329 Change-Id: I78c88dd4e37a69ad0bac9dd8c4974b95882e1a5b Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824649Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#699669}
-
Rika Fujimaki authored
We can pass isolate instead of script_state to ScriptValue's ctor since we replaced ScriptValue::script_state_ with ScriptValue::isolate_. Now that ScriptValue is completely free from context and persistent! Bug: 998994 Change-Id: I31aef94b7c1ead3ba86de0d5b894d96b00287708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824300Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Rika Fujimaki <rikaf@google.com> Cr-Commit-Position: refs/heads/master@{#699668}
-
Hitoshi Yoshida authored
Web IDL spec allows to use '{}' as a default value for dictionaries, to mean an empty dictionary. This CL makes IDL compiler follows the spec. Bug: 984949 Change-Id: I9979f590cfc7f17c2aeff50f9333f23f7baf87a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824758Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#699667}
-
Jan Krcal authored
This CL prepares for a later refactoring by making semantically non-equivalent changes first. This CL: - guards bookmark specific code by model_type == BOOKMARKS; - moving one line around to have all bookmark specific changes after the generic ones. The follow-up CL will extract data type specific code into helper functions to separate them from the main flow. This prepares for adding further WALLET_DATA specific code into the worker. Bug: 881289 Change-Id: Ia197e92294b56ecbe49b8f28f4581b4a8bb581a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818482 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#699666}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 60b35adf. With Chromium commits locally applied on WPT: d4ca0e6e "Add missing worklet referrer tests" a0586590 "Don't fold SaveAlphaLayer into DrawTextBlob" fe1133d1 "Update SXG version in wpt/signed-exchange/README.md" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Idf6473b726fad307600a75747f93161fa110de8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823909Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699665}
-
Marc Treib authored
deprecated = true This replaces new_timestamp, from_timestamp, and sync_timestamp by "reserved" entries, and marks a number of other fields as [deprecated = true]. Bug: 950904 Change-Id: Ic4b26ec368ac94e38ff330024698cd13c30417a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821790 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#699664}
-
Marc Treib authored
This is a variant of ModelType that fulfills the requirements for recording in histograms (i.e. no reordering/renumbering). It's a type-safe replacement for the current system based on ints. The actual values stay identical to the current ints, so the histograms themselves won't be affected. A follow-up CL will update all histogram recording sites to use the new enum. Bug: 1007293 Change-Id: I3e36c97303ba08e34baccffafbab8b55d8b9288b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821787Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#699663}
-
Carlos Caballero authored
Remove references in /device/bluetooth/bluez MessageLoopForIO is going away soon. Use SingleThreadTaskExecutor for main functions and SingleThreadTaskEnvironment for tests instead. Both are no op changes. This CL was uploaded by git cl split. R=mcchou@chromium.org Bug: 891670 Change-Id: I4b67ceda2cf508e5f5d76493c5d2aa05e3619924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780738 Auto-Submit: Carlos Caballero <carlscab@google.com> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#699662}
-
Piotr Tworek authored
This not visible in default chromium setup since it disables exceptions by default. The code does however fail to compile if one enables them: ../../base/containers/intrusive_heap.h:717:48: error: 'operator=' is missing exception specification 'noexcept' IntrusiveHeap<T, Compare, HeapHandleAccessor>::operator=( ^ ../../base/containers/intrusive_heap.h:290:18: note: previous declaration is here IntrusiveHeap& operator=(IntrusiveHeap&&) noexcept; Change-Id: I8c633333ae17002ba0b643e6c88e463d28de0086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815862Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Piotr Tworek <ptworek@vewd.com> Cr-Commit-Position: refs/heads/master@{#699661}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3731bd7ab054..6abaff3041a3 git log 3731bd7ab054..6abaff3041a3 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6d625bfe6e8a..ba04be8c9ef9 (9 commits) 2019-09-25 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-09-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src a76152f4..fb8fbb18 (434 commits) Created with: gclient setdep -r src/third_party/skia@6abaff3041a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: chromium:None,chromium:None Change-Id: If64c9b4ab6a61a43d460b17da2ce5818af6379ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824839Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699660}
-
Keith Lee authored
Change-Id: Ie48fac3c75f6825eca8372abe09afa2696586333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816340 Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Auto-Submit: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#699659}
-
Carlos Caballero authored
MessageLoop is going away. Also had to fix a lot of includes as a bunch of files were not directly including their dependencies. Bug: 891670 Change-Id: I1b962b9513596b399175498278ad526fba2240f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807504 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#699658}
-
Sergio Villar Senin authored
It's currently returning a double. As part of the process of rewriting the animation engine we're replacing doubles by base::Time* alternatives. Bug: 737867 Change-Id: I9d6cca66354ec22f5387ce7328b92c5c396ce283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819243Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#699657}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a130294887fc..f2723363e181 Created with: gclient setdep -r src-internal@f2723363e181 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I97aa9f3b4fc7455ef41451c9cb540bebe020d944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823810Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699656}
-
Koji Ishii authored
32 can avoid most of memory allocations, by consuming 512 bytes on stack ((4+4+8) * 32) on 64 bits. Most major sites are up to 8 or so, such as Google SRP, facebook, twitter, MDN, youtube, etc. Wikipedia is up to 21. Change-Id: I7f06f0ce01b5d2960becf99e0b453d92723e5253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821501 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#699655}
-