- 22 Oct, 2019 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/74d521f2..704ce5c7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I13d420c6ff5caa01d2df93375459cadecb621b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871902Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708158}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b9014fb4bb68..85a10001a508 git log b9014fb4bb68..85a10001a508 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 danilchap@webrtc.org Use deprecated SingleThreadedTaskQueueForTesting as regular task queue Created with: gclient setdep -r src/third_party/webrtc@85a10001a508 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Id24d86e7932540276a21e661097134cec758196a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873590Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708157}
-
Peter Kasting authored
Bug: 82078 Change-Id: I83c992a0c9eaaf1130ace3892cc38dbfeb266214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872983 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#708156}
-
Leo Zhang authored
Add the IME decoder flag in the chrome://flags, so that QA/Dev can turn on/off the feature to verify native deocers. Bug: 837156 Change-Id: I6ace99acf2127958ec4f0868962c721c035fd06d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866370 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Cr-Commit-Position: refs/heads/master@{#708155}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ca28b0ef0037..e3dcc758ca56 git log ca28b0ef0037..e3dcc758ca56 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 dburger@chromium.org Change controller_util and goma_util to handle custom goma approach. Created with: gclient setdep -r src/third_party/chromite@e3dcc758ca56 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I00260f81a2e7489aad99e0ff600cbe0cd3f2ee4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873592Reviewed-by:
-
Mihai Sardarescu authored
This CL ensures that the OAuth multi-login endpoint is always used by the Mirror account reconcilor. The feature |kUseMultiloginEndpoint| is removed from ChromeOS, Android and iOS and is now moved to DiceAccountReconcilorDelegate. Bug: 1013610 Change-Id: I02299b15225e1666d5160bac2ef25d767c3d01c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859966 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#708153}
-
Jan Wilken Dörrie authored
This change replaces existing usages of mutable base::Value::GetList() with newly introduced ListValue APIs in //components/autofill and //components/password_manager. Bug: 646113 Change-Id: I0b0bea5d341951585698ad7438a43be459198c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872212Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#708152}
-
Bettina authored
Currently, there is only one callback in the hash_password_manager.h file and the comments aren't clear enough. The callback is currently only called when there is a change in the |kPasswordHashDataList| and the change is not associated to a first sign-in and the save was successful. Bug: 1016458 Change-Id: I422843144778a2e40eafd1f831576fae9a2d5fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872737 Auto-Submit: Bettina Dea <bdea@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
-
Clemens Backes authored
The methods are deprecated and will be removed in V8 v8.1, thus we need to stop overriding them in chromium. R=rmcilroy@chromium.org CC=ulan@chromium.org Bug: v8:9810 Change-Id: I43d47c87c388a7c93ea87956b75f1db79d78fdb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871592Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#708150}
-
Mathias Carlen authored
Before this patch we only provided listAction and performAction as _pure_ direct actions. Via listActions more actions would be exposed and available to be performed via performAction. This patch also exposes dynamic actions as reported by listAction as _pure_ direct actions so that an external direct action user can perform them directly instead of the indirecation through performAction. R=szermatt@google.com Bug: b/138833619 Change-Id: If8d0f09d28bd8fa8f9d1681570cfc3dbfbbb5c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866830 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#708149}
-
Oriol Brufau authored
This reverts commit 8d3d941a. Reason for revert: 20% performance regression in nested-grid. Bug: 1015213, 935102 Original change's description: > [css-grid] Accommodate spanning items crossing flexible tracks > > The specification added a step to increase sizes to accommodate spanning > items crossing flexible tracks instead of ignoring their contents > completely. This is done after handling all grid items that don't cross > such tracks, and this time items are considered together, not grouped by > their span size. > > Spec: https://drafts.csswg.org/css-grid/#algo-spanning-flex-items > > BUG=935102 > > TEST=third_party/blink/web_tests/external/wpt/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-001.html > TEST=third_party/blink/web_tests/external/wpt/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-002.html > TEST=third_party/blink/web_tests/fast/css-grid-layout/flex-and-content-sized-resolution-columns.html > TEST=third_party/blink/web_tests/fast/css-grid-layout/grid-gutters-and-flex-content.html > > Change-Id: Ic91a2eb471fae23cde1570c461f491cd5335d771 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492337 > Reviewed-by: Javier Fernandez <jfernandez@igalia.com> > Reviewed-by: Sergio Villar <svillar@igalia.com> > Commit-Queue: Oriol Brufau <obrufau@igalia.com> > Cr-Commit-Position: refs/heads/master@{#705228} TBR=jfernandez@igalia.com,rego@igalia.com,svillar@igalia.com,obrufau@igalia.com Change-Id: Id6ad085e32bfb3ae947459c2fc56d097c2dadb94 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 935102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872593Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#708148}
-
Rune Lillesveen authored
We checked for non-null GetComputedStyle(), but it may also be non-null inside display:none when ensured from getComputedStyle(). Skip generating pseudo elements for that case. This caused a DCHECK failure due to an incorrect marking for layout tree re-attachment inside display:none. Bug: 1013570 Change-Id: I75318b9d3bed1ed68dab232d90bbdc9b68655152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872096Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#708147}
-
Juan Antonio Navarro Perez authored
Fix was landed in: https://chromium-review.googlesource.com/c/chromium/src/+/1691586 Keeps browse:social:tumblr_infinite_scroll:2018 disabled as the story is constantly failing in CQ. Bug: 970058 Bug: 1016701 Change-Id: Ifc128a5c00d00f04c9773f6be11bf9a145403d38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872057 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#708146}
-
Francois Beaufort authored
This CL makes sure NDEF tags still fire an onreading Web NFC event even if there are no messages yet. This results in a NDEFMessage with no records as discussed in https://github.com/w3c/web-nfc/issues/367. Bug: 520391, 1012463 Change-Id: Ib87980cfc7354561146f7854272b247fb6df5a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871550 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#708145}
-
Alex Chau authored
Bug: 1011364 Change-Id: I74c42e37b9ca04c22e0d3ce1e84873b4a2765309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872217 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#708144}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9df4d22529ce..1e7968db31d4 git log 9df4d22529ce..1e7968db31d4 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 ulan@chromium.org Revert "[vinn] Enable snapshots and update Windows d8 binary to 7.6.303.31" Created with: gclient setdep -r src/third_party/catapult@1e7968db31d4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:1001953 Change-Id: If1ae7ebc940629b1e655f000d6e8fb11f179522b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873589Reviewed-by:
-
Richard Knoll authored
We only handled some whitespace characters by using \s in the regex. One example that is not handled by that is the non breaking space which is quite common in HTML formatted text. Switching to \p{Z} to consider all unicode characters for whitespace fixes this. Bug: 1015189 Change-Id: Id3e6b3fe98a303e84d1b8427a227bc12a42d6664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872089 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#708142}
-
Tanja Gornak authored
Bug: 945553, 1009993, 960043 Change-Id: Ie359b8088943177af3eb7fe5689662d188d65650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864688Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#708141}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dd844944..74d521f2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I100f66d9633d8b52c34380d661b1ee8252ea605a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871901Reviewed-by:
-
Juan Antonio Navarro Pérez authored
This reverts commit 02b03541. Reason for revert: Test no longer appears to fail. Original change's description: > Disable flaky system_health.memory_desktop/browse_accessibility:media:youtube > > TBR=perezju@chromium.org > > Bug: 983326 > Change-Id: I22be996f9054935f378a05b95f7f7924a9c5f63b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699097 > Reviewed-by: danakj <danakj@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#677130} TBR=crouleau@chromium.org Bug: 983326 Change-Id: If9cb5e9a1d674e49709edbbee4dd2ceafe5bb21b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871998Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#708139}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e8c3f9b0b463..615918c91d1d git log e8c3f9b0b463..615918c91d1d --date=short --no-merges --format='%ad %ae %s' 2019-10-21 stevenperron@google.com Update CHANGES Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@615918c91d1d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Bug: None Change-Id: I61e2804c96dd058af5f8c9b918d0bfdc1a1b358f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873588Reviewed-by:
-
Ankit Jain authored
This reverts commit 77cff635. Reason for revert: <Reverting because of issue (https://bugs.chromium.org/p/chromium/issues/detail?id=1016357#c3) > Original change's description: > Adding asyn auth api, and moving Windows auth call to thread pool. > > When user tries to export password or view saved password by visiting > chrome://settings/passwords url and clicking on "Export passwords..." > or eye icon on password list respectively, OS Reauthentication is > triggered, and on successful authentication plain text password is > revealed. Currently OS authentication call is on UI Thread. > And if OS authentication takes time, it freezes/hangs > browser. This change has made authentication api async, and moved > windows authentication call to thread pool from UI thread. Since the > UI thread will be freed, browser will not freeze or hang. > > Bug: 1007950 > Change-Id: I2f35707fe458687a4ec22de1381d21ec9603733f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828730 > Commit-Queue: Ankit Jain <ankjain@microsoft.com> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707029} TBR=vasilii@chromium.org,ankjain@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1007950 Change-Id: I911ec3a83b24394ce5544e6ecb7f819e519a6bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873567 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#708137}
-
Gauthier Ambard authored
Bug: 987646 Change-Id: I6a7b80daea151ba6bb1400ab578ad35a1a51be53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872211Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#708136}
-
Yi Su authored
web::features::UseWKWebViewLoading is a helper method that uses 3 related feature flags to control the new feature of using WKWebView.loading for WebState::IsLoading: 1. kSlimNavigationManager is used because we only want to fix the failing test cases with slim-nav enabled; 2. kLogLoadStartedInDidStartNavigation is used because the CPM metric was logged in WebStateDidStartLoading. This flag moves the logging to WebStateDidStartNavigation, and if it's enabled then the CPM won't be affected by this feature; 3. kUseWKWebViewLoading is the flag for this feature, because we want to use it for experiment with kLogLoadStartedInDidStartNavigation enabled to make sure that this feature doesn't change CPM. Bug: 991763 Change-Id: I99fe31317277163eb4768b2db1c9ef8f5d2dd844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833470Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5335faaece2a..66aae7e647fd git log 5335faaece2a..66aae7e647fd --date=short --no-merges --format='%ad %ae %s' 2019-10-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 834ee546f93d..5e634c8999e6 (3 commits) Created with: gclient setdep -r src/third_party/angle@66aae7e647fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:None Change-Id: I8f5ae8404967c89c0162ce02b030b7c7551e949e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873587Reviewed-by:
-
Benedikt Meurer authored
These will be rebaselined manually once the fix rolls into devtools-frontend repository. Bug: chromium:1003497 Change-Id: I98b2178dd67be86188e4c212e509330d29f04c94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872098Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#708133}
-
Mihai Sardarescu authored
This CL enables the UseMultiloginEndpoint feature on all non-DICE platforms (including ChromeOS). Note that the feature is not yet removed as will be kept until M80 branches to ensure we have a kill switch in case it is needed. Bug: 1013610 Change-Id: Idd3f79c63e2e3656a52b14e0c46b9d808e40c9f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855988Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
-
Rakina Zata Amni authored
This is a reland of 2000b5b1 Got reverted because of MSAN failure didn't run the msan bot one last time before submitting yesterday after I changed some things to use skip-viewport-activation, oops. The MSAN failure is because we never initialize the enum ax::mojom::NameFrom in InspectorAccessibilityAgent::FillCoreProperties when the ax object is a display:none node within a locked subtree, so I set a default value for it, and it doesn't fail now! Original change's description: > DL: Fix flaky getFullAXTree & wrongly updated accessibility tests > > A devtoools display locking a11y test was marked as failing in MSAN bots > and is also flaky when tested locally, this CL updates that test and > fixes the cause of the failure (getFullAXTree might be called when > style/layout is dirty, which caused failing DCHECKs). > > Some other display locking a11y tests were not updated correctly, and is > updated in this CL as well. > > Bug: 996625 > Change-Id: I32eac1385c54eb07b1e6dab800620a2485158437 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846618 > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: vmpstr <vmpstr@chromium.org> > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706834} Bug: 996625 Change-Id: I168e40614ab600d1bd11f5cf97c166fa95400213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866338Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#708131}
-
Andreas Haas authored
With recent changes in V8 it is not necessary anymore to call {AdjustAmountOfExternalAllocatedMemory} for memory of ArrayBuffers. V8 get this information now from ArrayBuffer objects on the heap. R=ulan@chromium.org, haraken@chromium.org Bug: chromium:1008840 Change-Id: I886b391e1655835ade39dc43027a392490d30cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871876Reviewed-by:Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#708130}
-
Yuri Wiitala authored
Fixes a DCHECK crash related to the cursor device scale factor setting. It seems that sometimes this is left unset, and the default value of zero causes problems. Instead, just force it to 1X whenever it's less than 1X, since that's going to generate the best results for cursor rendering on screen captured content. Change-Id: I042da7ae8591a5e18ae79dbd32da19357069764e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872731Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#708129}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/03882834cb55..9df4d22529ce git log 03882834cb55..9df4d22529ce --date=short --no-merges --format='%ad %ae %s' 2019-10-22 perezju@chromium.org [Telemetry] Remove support for chartjson output format Created with: gclient setdep -r src/third_party/catapult@9df4d22529ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:921000 Change-Id: Idcf79b2661f4c238284f009604d12b9813947c7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873585Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4a152d340f06..f3f8ac37e468 git log 4a152d340f06..f3f8ac37e468 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 4a80ba25e67b..5335faaece2a (2 commits) Created with: gclient setdep -r src/third_party/skia@f3f8ac37e468 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: chromium:None Change-Id: Ia7cf260e051533b4b55248d981904fd3449ec5f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873586Reviewed-by:
-
Joel Hockey authored
Bug: 1016202 Change-Id: I820a076ed53960fcb4cc74a5ff1909ccf354453a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870153 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#708126}
-
Lindsay Pasricha authored
and add back iPhone7 bot coverage to fyi and main. Test cases: testNameOnCardFieldIsPresent testCardNumberFieldIsPresent testMonthOfExpiryFieldIsPresent testYearOfExpiryFieldIsPresent testUseCameraButtonIsPresent Bug: 1015953,1016353,1013462 Change-Id: I02c5a3d5b73b6e788f9001f65665f186fddf7aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872559 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#708125}
-
Colin Blundell authored
Change-Id: I55de2281b96b1a141ac43d75b84677ec16ce7d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856967Reviewed-by:
Darin Fisher <darin@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#708124}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/032591d692..acb77af66d TBR=bmeurer@chromium.org Change-Id: Ifc684ee59db2247143aa5f048e31a75e0ce757f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871595Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#708123}
-
Peter Kotwicz authored
Currently WebAPKs force the toolbar to be shown when the page has a bad certificates but TWAs do not. This CL ports the functionality to TWAs This CL introduces TrustedWebActivityBrowserControlsVisibilityManager which manages the browser control visibility state. BUG=991079 Change-Id: I5bbd40356d33b40c79a6291abdd3ab239484c575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871083 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#708122}
-
Jinsuk Kim authored
BottomSheet triggers onSheetOpened event when the sheet offset goes beyond the height of the minimum swipable state which depends on |swipeToDissmissEnabled|. The method is mainly used for the transition from open to closed state. When transitioning from hidden to open, the minimum swipable state needs to take |isPeekStateEnabled| since even dismissable sheet can have the peek state when opening. Bug: 1014730 Change-Id: I46f4f8edaf7693d9ae4b6fe00a23d635baaa4d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868211 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#708121}
-
Mario Sanchez Prada authored
Convert the remaining bits in both the implementation and clients from the browser and renderer processes for the FrameSinkVideoCapturer interface, and adapt unit tests. Bug: 955171, 978694 Change-Id: I87d6d2758d45f44554a1bd6c88fa0358d0709a0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863091 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#708120}
-
Fredrik Söderquist authored
And its companion SVGAnimationElement::CalculateValuesAnimation(). Bug: 998526 Change-Id: I3895dc070d319f1cefa489e061a598b18a88cf98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871509 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#708119}
-
