- 10 Sep, 2019 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8cae1e95a23b..008a1db55909 git log 8cae1e95a23b..008a1db55909 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src a0cef9f5..340a17ae (385 commits) Created with: gclient setdep -r src/third_party/skia@008a1db55909 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: chromium:None Change-Id: I7f356cdb995a06ec2fabded6e25e6b401d185349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793885Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695054}
-
Kent Tamura authored
An existing forward declaration is enough. Bug: 242216 Change-Id: I1e2c60acf3aac2c90666d916dd92ad187d909900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794326Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#695053}
-
Miyoung Shin authored
This CL converts BluetoothSystem{Ptr, Request} in ash and services to the new Mojo type, and uses pending_receiver<BluetoothSystem> in bluetooth_system.mojom. Bug: 955171 Change-Id: I764daf49604184341812fbb3b3249590b29b7d40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787663Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#695052}
-
Charles Zhao authored
(1) If ScoreTabs is called with type_ == KPairwiseScorer, then more sophisticated ScoreTabsWithPairwiseScorer is used for scoring. (2) The ScoreTabsWithPairwiseScorer puts all tabs without TabFeatures first, and then sort the result with MRU. After that, best candidate for each position j is picked one by one (3) In unit tests, we directly call ScoreTabsWithPairwiseScorer with type_ = kFrecencyScorer, so that the tests can be independent with the ML model. (This won't happen from public interface in real applications.) Bug: 999908 Change-Id: I85302cda11fc0fc754f5402fdacd1e3796a41b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788774Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Auto-Submit: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#695051}
-
Julie Jeongeun Kim authored
It converts RenderWidgetHostNSViewAssociatedRequest and RenderWidgetHostNSViewAssociatedPtr to new Mojo types. These are replaced with mojo::PendingAssociatedReceiver, mojo::AssociatedReceiver and mojo::AssociatedRemote. Bug: 955171 Change-Id: I1658a50da87f9e494a57bbb26e548373fa562268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792463 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#695050}
-
James Hawkins authored
This is modeled after the same functionality in the internet detail page implementation. R=stevenjb@chromium.org Bug: 999474 Test: none Change-Id: If5dcac633d5881aa04878b0e57223a437c9af4bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793808 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#695049}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/46c88567d52f..58c5b07b47cf git log 46c88567d52f..58c5b07b47cf --date=short --no-merges --format='%ad %ae %s' 2019-09-10 timvp@google.com Replace Issue 3221 with 2672 in deqp_gles3_test_expectations.txt Created with: gclient setdep -r src/third_party/angle@58c5b07b47cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: None Change-Id: Ie1bbf0ad193f92949ba767647e59f6383dfd69f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793752Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695048}
-
Eric Willigers authored
Values in the following grammar are tested: [ [ <'font-style'> || <font-variant-css2> || <'font-weight'> || <font-stretch-css3> ]? <'font-size'> [ / <'line-height'> ]? <'font-family'> ] | caption | icon | menu | message-box | small-caption | status-bar https://drafts.csswg.org/css-fonts-4/#font-prop Change-Id: I5180df5bff0e477e08a40197f8886fc8d8cc66c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789217 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#695047}
-
siyua authored
This CL adds the blue round circle highlight animation around the avatar button. It reuses the ink drop hover animation but with a different color. Whenever the animation is visible, hide the avatar sync paused/error state, even if there is no autofill icon visible in the status chip. Controlled by experiment flag kAutofillCreditCardUploadFeedback: No event will be sent to avatar icon if flag is disabled. The animation will be shown when any credit card is saved. Animation for password save will be added later. Bug: 964127 Change-Id: Icc386241e244a6bf9f3db271928ca19029348f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784138 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#695046}
-
Scott Violet authored
This way we get build bot coverage. BUG=none TEST=none Change-Id: Ibce3b2be48420e70a839545a950d105d956477fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790743Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#695045}
-
Dirk Pranke authored
ad9e442d Rename typefdefs for C++17 dba3084e Define StringPiece in terms of std::string_view 102cdd4b Define string16 in terms of std::u16string. b3fefa62 Compile with C++17. 2a6c4e12 [windows] Update Windows SDK to 2019-09-06 2a5b5ca0 Fix typo in linker section of docs. 2f527608 [cleanup] Remove stale documentation from get_target_outputs. fc2f07a8 Add reference to the mailing list to the README. ad9054d1 gen.py: Allow linking libstdc++ dynamically 6f3dad1a Don't use a nested scope for BUILDCONFIG. d9bbb45c Teach gn to handle systems with > 64 processors bac5bd0b Do not use the root scope for BUILDCONFIG.gn. 8dc294d0 Write Rust deps even if there are only non-Rust ones 21242330 Make "gn format" honor the global -q switch 570aaed1 Process transitive dependecies for externs 4dc0ce4d Update quick start guide to reference tutorial files f0a6900f Include Rust proc-macros as externs 1556546b [filesystem_utils] Fix a bug in MakeAbsolutePathRelativeIfPossible dca877f3 Support output_dir for Rust 0a73c484 Fix crash when sources is set to a non-list value 0bc16a82 [args] Ensure gn tracelog is processed when non-fatal error happens. Change-Id: I4ef0406f0deb636eb3213a480f73dff06059d971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793533Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#695044}
-
Steve Kobes authored
Bug: 1000716 Change-Id: Iee211fd0cdb5466fcdaf308a48031f039aaf8258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792581Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#695043}
-
Zhenyao Mo authored
BUG=1002269 TEST=bot R=kbr@chromium.org,jonahr@google.com Change-Id: I268882f668534903fe781ea482975ea37fbbd601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793786 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#695042}
-
Hiroki Sato authored
Previously, Android's AccessibilityEvent.TYPE_VIEW_SELECTED is handled as an event of changing value in ProgressBar or Slider in ARC++. However, this event is usually used when selecting an item in AdapterView (like ListView or GridView). This CL modifies to handle both patterns of the event. app that ListView items can be selected and read by ChromeVox Bug: b:130187244 Test: unit_tests --gtest_filter="ArcAccessibilityHelperBridgeTest.*" Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: manually test with ag/9191465 using PlayStore and TalkBack test Change-Id: If3af1bdc28490d00399fa89bd18258ff89731d19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746326 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#695041}
-
Nick Harper authored
https://quiche.googlesource.com/quiche.git/+log/43652ca1735a..fa2746c4a1fd $ git log 43652ca17..fa2746c4a --date=short --no-merges --format='%ad %ae %s' 2019-09-09 fayang gfe-relnote: False deprecate gfe2_reloadable_flag_quic_fix_adaptive_time_loss. 2019-09-09 fayang gfe-relnote: False deprecate gfe2_reloadable_flag_quic_eighth_rtt_loss_detection. 2019-09-09 wub gfe-relnote: (n/a) Fix a use-of-uninitialized-value in QuicFramerTest.GetRetransmittableControlFrameSize. Test only. 2019-09-06 wub gfe-relnote: (n/a) Update QuicIetfFramerTest.(Application|Connection)Close to use the new QuicConnectionCloseFrame constructor. Test only, not protected. 2019-09-06 dschinazi Deprecate quic_drop_invalid_small_initial_connection_id 2019-09-06 vasilvv Support the use of MESSAGE/DATAGRAM frames in QBONE. 2019-09-06 vasilvv Switch QuicMakeUnique to std::make_unique, part 1: //third_party/quic 2019-09-06 renjietang Remove QuicSession::RegisterStaticStream() and merge it into QuicSession::ActivateStream(). 2019-09-06 fkastenholz Add version-aware QuicConnectionCloseFrame constructor 2019-09-06 renjietang Use QuicSession::transport_version() instead of QuicConnection::transport_version() to make code cleaner. 2019-09-06 fayang gfe-relnote: n/a (TODO added) 2019-09-06 fkastenholz Change Application and Transport ConnectionClose codes to uint64_t 2019-09-06 wub gfe-relnote: (n/a) Only increment flag count for quic_simple_inflight_time when the flag is true. Flag count only. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ia3ce56d19b01f84adb574f29c1c5c8b6aef0c176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793246 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#695040}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5aec10b3bcd4..b388a9a81e11 Created with: gclient setdep -r src-internal@b388a9a81e11 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I1e93ba7a641faf94a991ee5099b1f6e910a54ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794029Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695039}
-
Zhenyao Mo authored
This reverts commit 15cbe81d. Reason for revert: crbug.com/1001364 Original change's description: > Add a FrameSequenceTracker for video. > > This feature allows tracking frame throughput during video playbacks. > This frame sequence tracker is a special case in that its tracking > process occurs in video_frame_submitter, unlike most other frame > sequence trackers that operate mainly in layer_tree_host_impl. > > Sample tracing report: > > https: //drive.google.com/file/d/1B9AZCsbLmOyIzIFxFGzDOgINISx7p3lk/view?usp=sharing > Bug: chromium:986300 > Change-Id: I9a41861e59bbe16d652b49de6b802ccc89833906 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755978 > Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693808} TBR=sadrul@chromium.org,liberato@chromium.org,schenney@chromium.org,mjzhang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. NOTRY=true Bug: chromium:986300 Change-Id: Idbae19675b1ded245ba93ea839c722a34e4a6d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794264 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#695038}
-
Jason Lin authored
More specifically, this CL: * Adds a mojom file to connect the web frontend part and c++ backend. * Adds c++ classes implementing web ui controller and some mojom interfaces. * Adds html and js files implementing the skeleton of the web page, including BrowserProxy, which connects the Renderer JS to the backend C++. * Adds code to display the web page at chrome://crostini-installer if feature CrostiniWebUIInstaller is enabled * Adds skeleton for browser test. Bug: 929571 Change-Id: Ie9b0931862ec5e40bc21ea7683ffc873e4034f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778884Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Auto-Submit: Jason Lin <lxj@google.com> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#695037}
-
Yoichi Osato authored
Added why the value is not a power of 2. Change-Id: I987c50197d8535b2020e9576bdefe3c3ba71c1e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792509 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Auto-Submit: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#695036}
-
John Chen authored
The --force-fieldtrials switch, added by ChromeDriver to work around https://crbug.com/996865, is no longer necessary. Removing it by default. Bug: 996865 Change-Id: I580b42397961e348626b6fc0d5ee8af9d4d21cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788487 Auto-Submit: John Chen <johnchen@chromium.org> Commit-Queue: Rohan Pavone <rohpavone@chromium.org> Reviewed-by:
Rohan Pavone <rohpavone@chromium.org> Cr-Commit-Position: refs/heads/master@{#695035}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/487f9a17e426..c77df78931bc git log 487f9a17e426..c77df78931bc --date=short --no-merges --format='%ad %ae %s' 2019-09-09 qingsi@webrtc.org Revert "Improve performance of RtpPacketHistory" Created with: gclient setdep -r src/third_party/webrtc@c77df78931bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Ibfa14c76f87d99794a35728ab9f10f8a246a773d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794145Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695034}
-
Hitoshi Yoshida authored
IDL Compiler has been ignoring the validity of extended attributes on dictionaries, callback functions, and their membmers. This CL makes to do it. Bug: 999690 Change-Id: Idcb88c6a346989e553a3bbe23e1273e00f8a04da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781902 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#695033}
-
Hiroki Nakagawa authored
This CL renames ServiceWorkerSubresourceLoaderUpdater interface to SubresourceLoaderUpdater because the interface is now also used for dedicated workers. Along with that, this moves the interface from service_worker/ to worker/. Bug: 945101 Change-Id: Ic56d5b372452981b6649b119f3406e168f7f4711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786365 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#695032}
-
Miyoung Shin authored
This CL converts FakeBluetoothChooserRequest, FakeBluetoothChooserFactoryRequest and FakeBluetoothChooserClient{AssociatedPtr, AssociatedPtrInfo} in content to the new Mojo type, and uses pending_receiver<FakeBluetoothChooser> and pending_associated_remote<FakeBluetoothChooserClient> in fake_bluetooth_chooser.mojom Bug: 955171 Change-Id: I73cce0dec73868dbf3b6a0f72d3cab0acd73eade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788964 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#695031}
-
Tsuyoshi Horo authored
This CL do the following refactoring: - Move PrimaryURLRedirectLoader to anonymous namespace. - Remove unnecessary methods, arguments, casting. And this CL sets encoded_data_length = 0 for redirect response. This is because we have "DCHECK_GE(redirect_response.EncodedDataLength(), 0)" check in resource_timing_info.cc. Bug: 966753 Change-Id: I35e877c0e928e596596d3743175d65241ca7bed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792413Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#695030}
-
Alexei Filippov authored
BUG=1002170 Change-Id: I81953154de3326f84e2a240c0ed879bec6ad91cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793358 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#695029}
-
Kent Tamura authored
Almost all -webkit-appearance keywords work only with specific element types. I2DR: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/1d9FpHEVI64/VSELVHzbAQAJ This CL excludes 'button' from the intent. Bug: 981720 Change-Id: I84f3d0fc19fb048911b182369dc64e04b58e152f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792984Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#695028}
-
Justin Cohen authored
The KeepRendererProcess alive logic still hasn't been ported to ios/web_view. Manually add the restored web_view to the view hiearchy for this case. Bug: 1001965, 944077 Change-Id: I4e810b68bfebd1bc44320cc376a8a6e16743393a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791272 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#695027}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Id0903589785a67257354a44ba8667a6af39481c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794148Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695026}
-
Rakina Zata Amni authored
Fix failure from a recent revert: https://chromium-review.googlesource.com/c/chromium/src/+/1792985 TBR=garykac@chromium.org Change-Id: I9805b817f4ac1e5593aa2c61a6ed38fa74b0d27e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792424Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#695025}
-
Antonio Gomes authored
This CL is phase 3.1 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ It basically moves network_manager_uma.cc|h from content/renderer/p2p to blink, placing the header temporarily in Blink's exposed API layer. BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I03079ca5332808a6a68487663bc0f8aeb8542ff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792844Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#695024}
-
Rakina Zata Amni authored
This reverts commit 96c9c934. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 694864 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzk2YzljOTM0YWYxYjY5MDdmNDJkYmY1ZmRlN2YwZjlhYzk4MmEwYzQM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29/82989 Sample Failed Step: remoting_unittests Original change's description: > [Chromoting] Add DisplaySize class to better track DIPS vs pixels. > > This cl also removes some support for the ICE protocol to simplify > the display handling code. > > Change-Id: I64523c0fc766cd80acdaae832c8f0fa08bb59757 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790274 > Auto-Submit: Gary Kacmarcik <garykac@chromium.org> > Reviewed-by: Jamie Walch <jamiewalch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694864} TBR=jamiewalch@chromium.org,garykac@chromium.org Change-Id: Icdc2a54da344f2dc082c0d12477f190c56257394 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792985 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#695023}
-
David Staessens authored
This CL adds additional checks to the simple IVF video file parser used by the video_decode_accelerator_(perf_)tests, to make sure we are reading a valid IVF video file. TEST=./video_decode_accelerator_tests \ vda_sanity-vp90_2_17_show_existing_frame_20190109.vp9 BUG=b:140538436 Cq-Depend: chromium:1789955 Change-Id: I3bab044f9382f10c0926078c4afd0483b3443c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787660 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#695022}
-
Daniel McArdle authored
Change-Id: I686d50b35736fb863ae83bb9a575e6e0cb0a8853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790144Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#695021}
-
Roger Tawa authored
Bug: 999143, 999141 Change-Id: I395da7e76649e46bea9cc69bdb0009168833f90e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793822Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#695020}
-
Peter Kotwicz authored
This CL: - Adds recording for the WebAPK.Visit UKM metric - Changes LaunchMetrics#recordHomeScreenLaunchIntoStandaloneActivity() to take WebappInfo as a parameter Privacy doc: https://docs.google.com/document/d/10m4NwkTFVjQ7uboJP9rUQM0Yh7ULD6dVvGlL3eQtD3g/edit?usp=sharing BUG=982362 TEST=None Change-Id: I93900c9c448d491540b3f857cc4643f23f25cafd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783709Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#695019}
-
Zhenyao Mo authored
BUG=992286 TEST=manual R=marcheu@chromium.org Change-Id: Ie1351437283deb13a161454863e442e5795c4a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794003Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#695018}
-
Hiroki Nakagawa authored
Network Service may crash. In that case, dedicated workers need to create new subresource loaders. This CL implements such the crash recovery mechanism for PlzDedicatedWorker[*]. This mechanism works as follows: - DedicatedWorkerHost in the browser process passes ServiceWorkerSubresourceLoaderUpdater to a worker in a renderer process when starting the worker (FYI: This updater will be renamed to more common name in a separate CL). - The worker binds the given updater with WebWorkerFetchContextImpl on the worker thread. - DedicatedWorkerHost observes Network Service state using a dummy URLLoaderFactoryPtr. When Network Service crashes, the host creates new subresource loader factories, and passes them to the worker via the updater. - WebWorkerFetchContextImpl receives the new loader factories, and replaces existing loaders. [*] Non-PlzDedicatedWorker depends on the crash recovery mechanism provided by the ancestor render frame. Bug: 945101 Change-Id: I640594b5eddeecd072001d15f234842515495e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745673 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#695017}
-
Takashi Sakamoto authored
This reverts commit fe8612d0. Reason for revert: caused compile failure on Fuchsia ARM64 bot Sample build: https://ci.chromium.org/p/chromium/builders/ci/Fuchsia%20ARM64/84538 Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8902744172135456592/+/steps/compile/0/stdout?format=raw --- [1007/1649] CXX obj/fuchsia/engine/web_engine_unittests__exec/accessibility_bridge_unittest.o FAILED: ../../fuchsia/engine/browser/accessibility_bridge_unittest.cc:69:25: error: no member named 'ScopedTaskEnvironment' in namespace 'base::test'; did you mean 'TaskEnvironment'? base::test::ScopedTaskEnvironment::MainThreadType::IO), ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~ TaskEnvironment ../../base/test/task_environment.h:83:7: note: 'TaskEnvironment' declared here class TaskEnvironment { ^ 1 error generated. --- Original change's description: > Reland "[fuchsia] Register Views with Fuchsia Accessibility APIs" > > This is a reland of b02a397f > > This includes the missing deps that caused the component builds to fail > and EXPORTs the AccessibilityBridge class for testing. > > Original change's description: > > [fuchsia] Register Views with Fuchsia Accessibility APIs > > > > * Add the AccessibilityBridge class skeleton, which will eventually > > handle the logic for conversion between Chromium and Fuchsia > > accessibility data structures. > > * Register a ViewRef to the Fuchsia SemanticsManager. > > > > Test: Added AccessibilityBridgeUnitTest.* > > > > Bug: 973095 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708043 > > Commit-Queue: Sharon Yang <yangsharon@chromium.org> > > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > > Reviewed-by: Wez <wez@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#693914} > > Bug: 973095 > Change-Id: I3a5a958fc88a5804023372453420863e97f9df74 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792460 > Reviewed-by: Wez <wez@chromium.org> > Commit-Queue: Sharon Yang <yangsharon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#695013} TBR=wez@chromium.org,sergeyu@chromium.org,yangsharon@chromium.org Change-Id: I4f21d8978e9761506bc31d24d9b2f64ee87f8287 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 973095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792508Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#695016}
-
Finnur Thorarinsson authored
Bug: 1001452, 860467 Change-Id: I0ee2354eda509e800fd0c80a66408de4b01c2536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789151 Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#695015}
-