GitLab

Sometimes the value of sys.prefix (or sys.real_prefix in vpython)
includes the bin/ directory within the python installation, and
sometimes it does not. To accommodate this, check both prefix/bin and
prefix itself for the python executable.

Bug: 1049421
Change-Id: Ia7c072dc0b4b8232ec8fdce20f9211e3c978a3ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055976
Commit-Queue: Sajjad Mirza <sajjadm@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741574}

Updated QUIC flags and fixed tests due to the newly added ACK in the connection closes of TLS1_3 connections.


Roll src/net/third_party/quiche/src/ 084a860a7..4e083db26 (10 commits)

https://quiche.googlesource.com/quiche.git/+log/084a860a79b5..4e083db26373

$ git log 084a860a7..4e083db26 --date=short --no-merges --format='%ad %ae %s'
2020-02-14 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_bbr2_cut_inflight_hi_gradually.
2020-02-13 renjietang Remove QuicStream::PeerAddressOfLatestPacket. It's only used in debug string, and isn't necessary.
2020-02-13 nharper Remove use of GetNumSentClientHellos from //third_party/quic tests
2020-02-13 renjietang Add perspective_ member for QuicStream.
2020-02-13 danzh gfe-relnote: fix UBSAN failure in QuicCircularDeque. No protected.
2020-02-13 fayang gfe-relnote: Do not pad server initial connection close packet. Protected by blocked gfe2_reloadable_flag_quic_enable_version_t*.
2020-02-13 renjietang Change QuicStream::CloseConnectionWithDetails() to QuicStream::OnUnrecoverableError.
2020-02-13 wub gfe-relnote: In QuicPacketReader, use QuicClock::Now() instead of kernel provided systime for receive time. Protected by --gfe2_reloadable_flag_quic_use_quic_time_for_received_timestamp2.
2020-02-13 wub Internal QUICHE change
2020-02-13 fayang gfe-relnote: In QUIC, always bundle ACK with connection close with TLS handshake for debugging purpose. Protected by blocked gfe2_reloadable_flag_quic_enable_version_t*.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

R=zhongyi@chromium.org

Change-Id: I1e6a8cc27a34b1f8544532ee38d3acbf4b45c253
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057446
Commit-Queue: Bin Wu <wub@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741573}

A visibility rule applying to cast_runner_browsertests__exec was added
in https://chromium-review.googlesource.com/c/chromium/src/+/1529685

Making assumptions about the naming of targets defined inside templates
is fragile, and this dependency isn't required, so remove it and the
associated visibility rule.

Bug: 933617
Change-Id: If05af64d54944b7cafb403aae3036981ca1e0698
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050306
Commit-Queue: Wez <wez@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741572}

the user denies permission for Chrome to prompt for camera permission.

Screenshot:
https://screenshot.googleplex.com/himQOS9PQrY

Bug: 1046574
Change-Id: I0df3cf870f0f08e5f0bc08e0dd4f8d963f4797ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037860
Commit-Queue: Tanya Gupta <tgupta@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741571}

Bug: 1052026
Change-Id: Id7e396d64b1c3002472e7b2a694d3e4a719648c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055705
Commit-Queue: Ehsan Kia <ehsankia@google.com>
Reviewed-by: Tanya Gupta <tgupta@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741570}

When an automatic schedule is being used, users can toggle the status
of Night Light manually from the system tray or the system settings.

This manual setting used to get reverted, and the schedule used to get
reapplied in the following cases:
- Switching users.
- Resume from suspend.
- Receiving a new geoposition.

This CL makes it possible to remember manual toggles, and reapply
them if possible.

BUG=999397
TEST=Manually, added new tests.

Change-Id: Idb1b76cf24c95e0833a65542f0b0ffa341195c3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049950
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741569}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c55cadc7..330671f6

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I483fa18ce938424da66c2c32400e5cc3f503bf8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057155Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#741568}

This test is failing ~95% of the time on simulator as well, so
disabling it pending further investigation.

Bug: 1043625
Change-Id: I60d1193297633545153ff537747739c1e5aec370
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057524Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741567}

With this CL, we can inject sysroot precisely.

BUG=1043804
TEST=Built locally.

Change-Id: I459a45eca86f96c4b143b055b588cd50e24f283a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057503
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741566}

Fixes message for Crostini container configuration error during Crostini
installation.

Test: none
Bug: b:148645840
Change-Id: I5cd85b3f42e9fdda48e26d4aa7bd8a8a9c2472c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056910Reviewed-by: Alex Oldemeier <aoldemeier@chromium.org>
Commit-Queue: Olya Kalitova <okalitova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741565}

Bug: 1046064
Change-Id: I874f84ec9e47633fab5f605733dca7667b0c5a4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053516Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741564}

This reverts commit 6d1a45d2.

Reason for revert: Failing KnownExpectedFonts/GetFallbackFontTest.GetFallbackFont/SEthiopicLam.

https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/47644

Original change's description:
> Add unittests for Fallback Fonts on MacOS
> 
> This CL is adding unittests for some basic scripts on MacOS.
> 
> Previously, on MacOS, an empty array of test candidates was
> used. We are adding some of basics languages.
> 
> Bug: 1022455
> Change-Id: I5f1e32feb40cc6c3a6bf22f96821b9e78ceb3906
> Fixed: 5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001142
> Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
> Reviewed-by: Robert Liao <robliao@chromium.org>
> Reviewed-by: Dominik Röttsches <drott@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#741488}

TBR=robliao@chromium.org,drott@chromium.org,etienneb@chromium.org

Change-Id: I5dcded54887c6ee8897936033b06bdcb2772cf71
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1022455
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056758Reviewed-by: Chris Mumford <cmumford@google.com>
Commit-Queue: Chris Mumford <cmumford@google.com>
Cr-Commit-Position: refs/heads/master@{#741563}

This reverts commit d1ad8abe.

Reason for revert: failures were just the death throes of a dying bot.

Original change's description:
> Revert "[iOS] Remove xcode clang bots"
> 
> This reverts commit 3893c26b.
> 
> Reason for revert: Dangling reference to ios-simulator-xcode-clang.json.
> 
> https://sheriff-o-matic.appspot.com/chromium/examine/chromium.read%20build%20config
> 
> Original change's description:
> > [iOS] Remove xcode clang bots
> > 
> > Bug: 1049646
> > Change-Id: If024c2185409167031bcdaf3a801e73cb1c61b0b
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042679
> > Reviewed-by: Justin Cohen <justincohen@chromium.org>
> > Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> > Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#741519}
> 
> TBR=justincohen@chromium.org,martiniss@chromium.org,michaeldo@chromium.org
> 
> Change-Id: I2e0e630a1c4f5ed5706a40a34a5c479e1dff31f1
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1049646
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057583
> Reviewed-by: Chris Mumford <cmumford@google.com>
> Commit-Queue: Chris Mumford <cmumford@google.com>
> Cr-Commit-Position: refs/heads/master@{#741528}

TBR=cmumford@google.com,justincohen@chromium.org,martiniss@chromium.org,michaeldo@chromium.org

Change-Id: I5d2e02e4f3cd2b16c727fbd2f123b50e4e31dfe4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1049646
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056755Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741562}

My suspicion is history initialization is failing. I'm adding some
logging to verify that.

No doubt if faviconservice creation returns null there will be other
places assuming non-null that need to be fixed.

BUG=1024959, 1052127
TEST=none

Change-Id: I425e0b32d8543f46c1db7f18b232bbd65c898b94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057093Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741561}

Add the VideoFrame::IsSameAllocation() method, which checks if the video
frame was created with the given parameters.

I found this bug by code inspection. I suspect the bug was introduced
when new_coded_size was added to VideoFrame::CreateFrame(). The
VideoFramePoolTest.FrameReuse test fails unless we fix this bug.

Bug: N/A
Change-Id: I6885ed885163734fa9c1e6d80f5fd6cb044b27e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043294Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Cr-Commit-Position: refs/heads/master@{#741560}

This CL adds support for AncestorThrottle to parse CSP headers coming
from requests generated in the browser process, such as requests coming
from signed exchanges or AppCache.

Bug: 1042627
Change-Id: I7364cfc5b1c15181cce3e69cc254d7aea435124e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020405
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741559}

input.rawValue returns the actual text inside of input elements which
have text fields, as opposed to the sanitized value returned in the
value property.

Intent to Prototype:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/FMPV2LCc0Ho

Explainer:
https://docs.google.com/document/u/1/d/1UrwLarU-o_-22OMddCH-fu5YJwmIKHwby3SR3_jQ9YM/edit

Bug: 1043288

Change-Id: Ic17c011fb44ef78e89843969dc693f276a827048
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051026
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741558}

This crash started happening after my async form submission patch
http://crrev.com/c/1922699

The crash appears to be a null pointer dereference in the first class
member variable access in HTMLFormElement after the async step, implying
that the form was deleted during the async step.

I'd write a web_test for this but I don't know how to force garbage
collection immediately after form.submit().

Bug: 1050782
Change-Id: Idf77129f1852e4dd719cab926bf5f9cfa3070e53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048035Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741557}

This change disables GoogleSearchDomainMixingMetricsEmitterTest.
EmitsMetricsOnStart, which is the slowest unit test in the codebase by
a factor of >2x. This test runs slowly because it simulates an entire
month worth of history expiration, which amounts to running the same
no-op every 5 simulated "minutes" hundreds of thousands of times.

Since this code is all slated to be deleted soon (per the linked
bug), the test is just disabled.

Bug: 1040458
Change-Id: Idfc0115d00cf9c3b763c07b5715b3b39e5b45c5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057445
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741556}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c53ba5018faa..0bf716dac129

git log c53ba5018faa..0bf716dac129 --date=short --first-parent --format='%ad %ae %s'
2020-02-14 khamu@microsoft.com High contrast for Sources navigator panel and filter widget
2020-02-14 khamu@microsoft.com High contrast work on Sources debugger panel

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@0bf716dac129

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1048378
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: If0bcfb606bea44a25af4119b8318ebb0a2c28bde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057379Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#741555}

Bug: 1047214
Change-Id: Ie9bf8d7130debcbafcbdd9df2bbe40a5be28ec83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033924
Commit-Queue: Michael Chang <donchan@microsoft.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741554}

Bug: 1049830
Change-Id: Ic2025f96852abd32cc3a6535face9223873cea34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056263Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: James Hawkins <jhawkins@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741553}

go/share-in-toolbar

Bug: 1036023
Change-Id: I2ca7468bc1709a0ac2e5a92ed6c704282a5e8e19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977147
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741552}

Context:
This CL adds a test for payment abortion. The test calls request.abort()
from the merchant side.

Expectation:
The test expects that the request.show() promise would be rejected with
the reason written in the exception message.

Bug: 1042892

Change-Id: Ib764ad689a6b114a45e86d8351086c9a4519fbfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040440
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741551}

https://chromium.googlesource.com/catapult.git/+log/32115a7d6f3d..15ef4a463092

git log 32115a7d6f3d..15ef4a463092 --date=short --first-parent --format='%ad %ae %s'
2020-02-14 bsheedy@chromium.org Reland "Fix getservbyname assumption"

Created with:
  gclient setdep -r src/third_party/catapult@15ef4a463092

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC skyostil@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:869557
Tbr: skyostil@google.com
Change-Id: I1781c190e2cb1ffe4b9a1f5d1ba8698a1d7d8c66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057382Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#741550}

The external callback passed in the constructor argument (OnSessionInitialized)
which is defined in the following location:
https://cs.chromium.org/chromium/src/media/blink/webcontentdecryptionmodulesession_impl.cc?rcl=32a0bf8c63263c339f0adb6e923987d9b9c9a34f&l=503
is prepared to be called repeatedly. Since there's nothing else in the
code that prevents this callback from being called multiple times,
I assumed this is a repeating callback.

This is part of the base::Callback migration.

Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40

Bug: 714018
Change-Id: I1e351df7977f0f63e6f84bc553a86c86a1112fa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035955Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Jose Lopes <jabolopes@google.com>
Cr-Commit-Position: refs/heads/master@{#741549}

Bug: 1048336
Change-Id: I49b88b1e39030f0bc990934bee9076bd52b5f35a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037324
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741548}

This is a pure refactor. None of the code in any of the methods has
changed; the only difference is the order of the methods.

Bug: None
Change-Id: If12e6c49eb8c2824fea0bcd3ad824861838ebdb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048110
Auto-Submit: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#741547}

Two of these were disabled as flaky several years ago.
They have not flaked on my workstation in a few dozen runs,
so let's speculatively re-enable them.

Bug: None
Change-Id: Iea9a6953d71c5935a4b36f99d75bf81ae83eb464
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057286Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741546}

Modify ChromeExtensionsCapabilityTest.testCanInspectBackgroundPage
to stop using obsolete LaunchApp API.

Bug: chromedriver:2278
Change-Id: Ided03a33e59ee2251e47550f9b6ae0d8b96f3f19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053172
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741545}

This reverts commit e3b94113.

Bug: 1052146
Change-Id: Ia57fb3f8bb54d62a6adbd6fdaffd586f8798924c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056928
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#741544}

The <zircon/syscalls/definitions.h> header is an implementation detail
of the OS that was never meant to be used by application code.
<zircon/syscalls.h> alone gives access to the Zircon syscall API.

Bug: fuchsia:45844
Change-Id: I0a1594e36c5eb6a05ff2266461970e49958c34bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055591
Auto-Submit: Roland McGrath <mcgrathr@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741543}

If an extension uses all hosts (e.g. by specifying <all_urls> in host
permissions), an API permission kHostsAll is created somewhere down the
line. This permission is used to provide a permission message, but
kHostsAll is not added as an API permission when checking if there is
a privilege increase between a set of granted vs requested API
permissions. As a result, an extension can be reported for a privilege
increase even when it shouldn't.

This CL fixes this issue by adding kHostsAll for privilege increase
checks to make sure the right messages are compared.

Bug: 1014505, 512344
Change-Id: Ie20045c6760b50dae5949b9cceaf10467fcf1534
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042387Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741542}

Also updated test color values to be "valid". The previous set were
intended to be premul-rgba, but they were not legal premul. The new
values are SkColor values, which are defined to be unpremul.

Bug: 896969
Change-Id: Iebaf94ab767d2622798a239a4714ac4b64613225
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053257Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
Cr-Commit-Position: refs/heads/master@{#741541}

TBR: mthiesse@chromium.org
Bug: 1052429
Change-Id: I6aab582df7d71ba3433e23d302b334fd081641b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057099Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741540}

Didn't meaningfully change runtime nor file size, but seems like a flag
we should be using.

Bug: None
Change-Id: I7e42cb4bac8036d97f6db61c4906c1ff6ae88e80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040910
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741539}

This CL adds the DeclarativeShadowDOM runtime enabled feature, and
implements a basic approach. There are no tests yet, as this is an
evolving spec/approach. But this allows basic testing of attaching
the shadow root upon the closing <template> tag.

See the explainer [1], the issue discussion [2], the intent to
prototype [3], and the chromestatus entry [4].

To test this feature:
  --enable-blink-features=DeclarativeShadowDOM

and then:
  <div>
    <template shadowroot=open>
      <div></div>
      <slot></slot>
    </template>
    <span>
  </div>

[1] https://github.com/mfreed7/declarative-shadow-dom/blob/master/README.md
[2] https://github.com/whatwg/dom/issues/831
[3] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/nJDc-1s3R9U
[4] https://chromestatus.com/feature/5191745052606464

Bug: 1042130

Change-Id: I5057c932a89fc401735d024348799d30c97e959e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018336
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741538}

Bug: 710376
Change-Id: I78027a4bb288f9136de105c76df364cf24c70087
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053254Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741537}

BUG=1021151

Change-Id: Ie1b15017136f98b9573b3621cbf816c4e0d0e5dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055893
Auto-Submit: Min Qin <qinmin@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741536}

Before this CL, it was posted on the ThreadPool, however the task assumes that
it runs on the same sequence it was posted from.

This gave me DHCECK failures in browsertests, but could have worse
implications.

Bug: none
Test: browser_tests don't fail with with DCHECK failures for me anymore
Change-Id: I583bbd5e483568fa39595e6e7c4c854570998758
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055085
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741535}