- 01 Apr, 2020 40 commits
-
-
Camillo Bruni authored
--enable-logging practically only supports stderr or the empty string as values. Print a warning if any other value is used. Change-Id: If854af4a910794f72fd1f246a4e039306153c5a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106587 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#755317}
-
Johann authored
The new wrapper changed the behavior slightly during the migration. The wrapper defines a default ContextDestroyed method. If some other cleanup method tries to access the receiver_ it may crash. This change reverts to the pre-migration behavior. BUG=chromium:1049056 Change-Id: Id6e5d9fd7405b490afe13764f340dbcccc5e3210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131797Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#755316}
-
Daniel Vogelheim authored
Make URLs used to construct workers TrustedScriptURLs. Minor rework of how to get the execution context in the generated bindings, because the old method assumed presence of an "impl" object, which is only created at the end in case of constructors. So instead, implement a method with which we can always obtain the execution context from the v8::FunctionCallbackInfo. Bug: 1059684e Change-Id: I00e3e52cad5c3736105289a9fda1eeca15fd6f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105339 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#755315}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7d8c2f2e3322..46ee73e065c6 git log 7d8c2f2e3322..46ee73e065c6 --date=short --first-parent --format='%ad %ae %s' 2020-04-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 9a0f2d99fd5d..f5504529553f (30 commits) Created with: gclient setdep -r src/third_party/angle@46ee73e065c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I13508cb4d51a2093344f69bcce6c8345fc14b4ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131716Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755314}
-
Wojciech Dzierżanowski authored
When a new playback request arrives on a site that is already playing videos in PiP, make sure the MediaSession is active. Bug: 1062291 Change-Id: Ib082b183a0ccd32f757841c1e37564be92a0692e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120403 Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#755313}
-
Rainhard Findling authored
Bug: 1015841 Change-Id: If76653e0fa93b901509af0406a112a67093242de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126934Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#755312}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic9ab33a481119b6b3c1295803abde65953d5ca84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131718Reviewed-by:
-
Yuki Shiino authored
Implements [LegacyWindowAlias] properties on Window objects in the new bindings generator. Bug: 839389 Change-Id: Ic84aa71d98c565d50fbfc02e441b56a45ffb2f50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129789Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#755310}
-
Abhijeet Kandalkar authored
This CL is a fixup for https://crrev.com/c/2121938 and has two goals, 1. Rename columns-center-with-margins-001.html to auto-margins-003.html 2. Use CSS draft spec url in <link>. Bug: 1063749 Change-Id: Idc3429f7f7fc488f67688acfddf7b678001c6dc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131551Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#755309}
-
Yuki Shiino authored
The current bindings generator does not recognize the extended attributes introduced in this patch, and no behavioral change in prod. Bug: 839389 Change-Id: I75afcdc75b293c474557de7076c0885a59cb798d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129786Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#755308}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d2b26ce6739e..ec9040a110fb Created with: gclient setdep -r src-internal@ec9040a110fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ib79d57b6abfd6f742ebf73787a0e64c2167bfe32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131712Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755307}
-
Abhijeet Kandalkar authored
This is a fixup for https://crrev.com/c/2119465 and it uses CSS draft spec url in <link>. Bug: 1063749 Change-Id: Ie726aabfe5a27c5851a8b0f54be4ab7136f3e973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130463Reviewed-by:
-
sauski authored
This CL introduces the safe_browsing_browser_proxy.js which will facilitate communication of the new Safe Browsing settings controls managed state. The new Safe Browsing controls are connected to the proxy and tests are included to ensure they correctly reflect the provided managed state. C++ handler support is not currently in place to support the new proxy, and as such placeholders are used where communication to C++ will occur. Bug: 1061947 Change-Id: Iaccaef70852bcd9e7461a7535be5da83ef4c20f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127370 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#755305}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Rename test name to align-self-015.html 2. Use CSS draft spec url in <link> as suggested in https://crrev.com/c/2120673 Bug: 1063749 Change-Id: Iba4aaf6b9ddd22df672f2381eb323ff7fcb963b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131113 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
-
Alexandre Courbot authored
Using video_profile_ here is not necessary since we also have access to the configuration. Doing this will let us remove profile_ in the next CL. BUG=b:149663704 TEST=vdatest passes on Hana. Change-Id: I34c6466fb1c6d800d743bfae047f014d39a15342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130454 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#755303}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fd773eb50d62..c37c94929bf5 git log fd773eb50d62..c37c94929bf5 --date=short --first-parent --format='%ad %ae %s' 2020-03-31 caio.oliveira@intel.com Validate Buffer and BufferBlock apply only to struct types (#3259) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@c37c94929bf5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I8326875361d3cde3c8c721bf2ec811b2ef417967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131714Reviewed-by:
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I3b36a56849b4d3165173f86dee5c7f1bf14217eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109397Reviewed-by:
-
Sean Harrison authored
Add new light/dark illustrations to the cookies page, security page, and permissions page Bug: 1032584 Change-Id: Ibe2b9e9de215581129d24eb7ee5789291e7ebf0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120425 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/de31800c..d540359a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ieff37ae30b0f48eabcb6a0fa17790778de44e97e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131726Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755299}
-
Kenichi Ishibashi authored
This CL reverts two commits that were added to investigate redundant controllers which should not exist. - crrev.com/c/2114478 - crrev.com/c/2126407 We may re-add these instrumentation later. Bug: 1015692 Change-Id: I0bf98e78898b2c636d4d0ffc7beabda8e9da8ddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131427Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#755298}
-
Javier Ernesto Flores Robles authored
This reverts commit 0fb67af0. Reason for revert: This broke the tree by indirectly compiling ios_internal/chrome/credential_provider_extension/internal_account_verification_provider/account_verification_provider which is broken at the moment. See https://critique.corp.google.com/#review/303938281 for its fix. Original change's description: > [ios] Add data to CPE password list in showcase > > No styling yet. > > Bug: 1045454 > Change-Id: I05155cd76c88cdaf828c62627914dffc0a1a7475 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129536 > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Reviewed-by: edchin <edchin@chromium.org> > Commit-Queue: David Jean <djean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#755278} TBR=edchin@chromium.org,javierrobles@chromium.org,djean@chromium.org Change-Id: I2fbc8f6c95f535a2db997954d3782f9b25792b2c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1045454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130279Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#755297}
-
Maria Kazinova authored
Driver check needs to be omitted on iOS, as cross-origin frames support is not implemented yet for PasswordManager and driver pointer is intentionally set to null sometimes. Bug: 1065196 Change-Id: I898b16a27ff478fd556c06322f00f2482fa1749e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129535Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#755296}
-
Viktor Semeniuk authored
This change adds different dark theme styling for icon which indicates exesting of compromised passwords on password check and passwords section. Bug: 1047726 Change-Id: I555c1fd1fcc37b71dd65ce3d1ef09c2d6729c24a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128074 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#755295}
-
Armando Miraglia authored
This reverts commit 5f6e2aac. Reason for revert: roll-forward with invalidatino fix and test. Original change's description: > Revert "[MediaRecorder] Fix corrupted video problem with pause/resume spamming." > > This reverts commit b7dab9dc. > > Reason for revert: caused crbug.com/1065827 which is more severe. > > Original change's description: > > [MediaRecorder] Fix corrupted video problem with pause/resume spamming. > > > > > > This CL fixes an issue caused by the following sequence of events: > > 1. MediaRecorderHandler::Pause(): recording_ = false > > 2. MediaRecorderHandler::WriteData(): if (!recording_) return > > > > The problem is that the WriteData() invocation was decided to > > happen while the recorder was still resumed. In that state, wholes > > would be produced which are not tolerated by vpx_encoder, which > > interprets those as corrupted. > > > > The fix reverts the semantic of the code to when the class was not under > > oilpan and would require manual memory management and restores the > > "invalidation" semantic from when the class was using a weak ptr. > > In fact, the weak reference would be invalidated hence making the > > callbacks no-ops. To keep the same semantic, this CL introduces a > > boolean and avoids overloading the meaning of 'recording_' > > > > This should also not require calling Pause() in Stop(), as all callbacks > > will not do anything after Stop() is called. > > > > Fixed: 1060358 > > Change-Id: I88b0aeb10fd13034412f3689648cebd1df40d6bf > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106072 > > Commit-Queue: Armando Miraglia <armax@chromium.org> > > Reviewed-by: Markus Handell <handellm@google.com> > > Cr-Commit-Position: refs/heads/master@{#752838} > > TBR=armax@chromium.org,handellm@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: Id8a148253433576469cd7958addf48afdabf44eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128070 > Reviewed-by: Armando Miraglia <armax@chromium.org> > Commit-Queue: Armando Miraglia <armax@chromium.org> > Cr-Commit-Position: refs/heads/master@{#754872} TBR=armax@chromium.org,handellm@google.com Change-Id: Ie1becac31f0f1a2e5aea92bc59e7e356a2c6e62b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129534Reviewed-by:
Armando Miraglia <armax@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#755294}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I83493e669bc936bc3da0e83b321655d06f88a457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131365Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755293}
-
Rushan Suleymanov authored
This reverts commit fab0d10e. Reason for revert: this patch contains refactoring of client tag based model type processor. To prevent too many changes in one release it is better to reland this patch after M83 will be branched. Original change's description: > [Sync] Remove setting of cache GUID for old clients. > > This patch removes old logic of setting cache GUID for old clients which > had no this field. Clients must have set this field after one and a half > years. Clients that haven't migrated will remove sync metadata (treat as > cache guid mismatch) and go through download and merge procedure. > > There is one more little change: ConnectIfReady is removed from > OnPendingDataLoaded because it does nothing and seems to be obsolete. > > Bug: 947044 > Change-Id: I72a441c5ed9bfa2d77a58494aaa2181a1df54d3b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062277 > Commit-Queue: Rushan Suleymanov <rushans@google.com> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752072} TBR=mastiz@chromium.org,rushans@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 947044 Change-Id: I3479fa8d35d851d7852225f5fda69e8ccfb022c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127209Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#755292}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I666b8ade1cd0ea9043df7978a01eb4537fbbc713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109396 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
Adding adding content edge insets for the skip button in the user sign-in coordinator. Updating the skip button title, to always be in upper case, to match the old implementation (MDCButton seems to always have upper case title). Before: https://drive.google.com/open?id=1a1worTgClUtfs3p3YUwp45vH3-DhCflJ After: https://drive.google.com/open?id=19MrZ6a-lP1LBUWonredKKY3zxM4SbsGQ Bug: 971989 Change-Id: I0eddfc2d855413926e794af1713aedc916a82656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130549 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#755290}
-
Mike West authored
We missed a few tests in [1], which were helpfully pointed out in https://github.com/httpwg/http-extensions/issues/1136. [1]: https://chromium.googlesource.com/chromium/src.git/+/77df41c01dc3c89253eae90080ff37cf05dfa1a1 Bug: 1037996 Change-Id: I9674bb8cb66b0989bc77c3cc4e34061b0e675e98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129528 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#755289}
-
Guido Urdaneta authored
Add a test for video flow when the negotiation is started by the remote side. Bug: 1065836 Change-Id: I56a89f4977516694c1ac8ab50860d940b1171ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127927Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#755288}
-
Anton Bikineev authored
This converts backref from BackgroundParser to HtmlDocumentParser to use GCed abstractions for weak references (WeakPersistent). Bug: 1066694, 522357 Change-Id: I8b25f5d7452d0faf62b6d04eee1f69de2d77b646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130209Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Maria Villarreal authored
Per guidance, all the hardcoded colors in this file have new native color IDs. Bug: 1056950 Change-Id: I7477466b64250d049969cf3efa635e42fb819d19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111774Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#755286}
-
Yutaka Hirano authored
For https://github.com/whatwg/html/issues/4924 Bug: 1064920 Change-Id: I3837bd2dab635ec0d09d68362a5e4f13b6f44582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121936 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#755285}
-
Delan Azabani authored
This CL replaces both PluginParameters::FindStringInNames and the MapDataParamToSrc function in html_object_element.cc with a dedicated PluginParameters::FindStringInNames method, based on feedback from Frédéric and Mason in <https://crrev.com/c/2113394>. Like the old version, the code proposed here only adds a “src” param when there’s a “data” param but no “src” param, doing nothing if both “data” and “src” parameters exist (regardless of mutual order). Change-Id: I143ea81c5711c6f20cb5e1f6e791bf446ff33b02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121937 Commit-Queue: Delan Azabani <dazabani@igalia.com> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#755284}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e157435c1e77..1fff36235504 git log e157435c1e77..1fff36235504 --date=short --first-parent --format='%ad %ae %s' 2020-04-01 cepheus@frii.com Build warning: Fix #2167: Remove nested reuse of 'unreachable'. Created with: gclient setdep -r src/third_party/glslang/src@1fff36235504 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I2ee56ce72f255e18175a6f883051aabad2a79a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131505Reviewed-by:
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I9e67f0a246dc8532942caf6265aa287a0697e100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131361 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#755282}
-
Zain Afzal authored
Previously we used a invisible overlay ontop of the guest iframe to hold two green buttons for navigating forward and backwards in the current directory. Since then we have moved the navigation ui down into the guest frame (see cl/304099160) for better behavior, UX and a11y. This Cl removes this invisible overlay and the two buttons as they are no longer needed. Bug: 996088 Change-Id: Ic9307d90f9fb3ecd1f5a5ef30d4e078810625833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131676Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Zain Afzal <zafzal@google.com> Cr-Commit-Position: refs/heads/master@{#755281}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/43d002a2caf2..4f30cf017965 git log 43d002a2caf2..4f30cf017965 --date=short --first-parent --format='%ad %ae %s' 2020-04-01 iannucci@chromium.org [man] Followup: Fix order of depot_tools in PATH in html docs Created with: gclient setdep -r src/third_party/depot_tools@4f30cf017965 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Id70d4baffcf1fd73b8d50e940e90c1c0e5841e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131503Reviewed-by:
-
Clemens Arbesser authored
Before this patch, invalid view definitions would sometimes crash debug builds due to a failed DCHECK in show_generic_ui_action. Bug: b/145043394 Change-Id: Icbd392cb929a0145e72bb1fb3434a0a10df26bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126667 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#755279}
-
David Jean authored
No styling yet. Bug: 1045454 Change-Id: I05155cd76c88cdaf828c62627914dffc0a1a7475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129536Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#755278}
-
