- 31 Aug, 2020 35 commits
-
-
Eric Willigers authored
Requiring and consuming transient activation prevents a page from repeatedly requesting permission to open a connection, without prior engagement with the page by the user. Not yet done: We should not consume or detect transient activation during re-connection attempts. Bug: 1119600 Change-Id: I3cbfea09bbdeebe30be2f56bee57459eef07f198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384229 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#803016}
-
Darren Shen authored
|setCompositionRange| takes in relative offsets, which causes several bugs. Deprecate |setCompositionRange| and replace with |setComposingRange| which takes in absolute offsets. Bug: 1035248 Change-Id: Ic82eaad58f18f727ac682853def7076aaf70310f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371444 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#803015}
-
Adam Rice authored
The transferable streams implementation would crash when it received a chunk that wasn't deserializable, because it failed to enter a ScriptScope before creating a V8 object. Fix it. Also fix the message on the DOMException that is created when deserialization fails. Add a test for deserialization failure. This is hard to trigger in a cross-browser fashion. In this test, we use a WASM module, which can't be transferred to a different site. BUG=1122725 Change-Id: I6e49c69978388357a3c6006cc02dce8f0a949954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379417 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#803014}
-
Alan Cutter authored
This CL is a mechanical change that renames launch_url to start_url in the WebApp class. This is to make "start_url" more closely match the app manifest field and to make room for a separate "launch_url" in a follow up CL that includes additional query params added to the start_url. Bug: 1045537 Change-Id: I040e62b8fb79e36427720609bcc50911cdc2aaec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376936 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#803013}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1598806680-ea8cbf643223574fcb349af48fd14418e961fcb1.profdata to chrome-win32-master-1598834860-65570273a8a9241ebf147440a3fd9be058e3b8e7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Iae335235a36197be95ef1be7981e6dfaa4076e0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384510Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803012}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/809a6d42384e..b6f22fe80638 2020-08-31 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iab876098571c0c948cd53ec15e2cc33b56797690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384512Reviewed-by:
-
David Black authored
Following this CL, there will be one delegate left to add to move download manager logic out of `HoldingSpaceKeyedService`. Bug: 1119496 Change-Id: Ida9e3df4f45386f977ac0ce4d2a7b9f96e4cf6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383191 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#803010}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a0d048a4023f..2f291c0bd181 2020-08-31 syoussefi@chromium.org Vulkan: Re-enable fixed dEQP tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I919463a31a4ef5518f2323086131ee1a02a38266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384511Reviewed-by:
-
Yusuke Sato authored
This makes the code simpler and shorter. This is a follow-up CL for chromium:2380733. BUG=None TEST=components_unittests Change-Id: I7e3a607f001824df9e57f821df46fc515e221d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380442 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#803008}
-
Alice Boxhall authored
AX-Relnotes: n/a Bug: 1114959 Change-Id: Ib6d9f51a04fa8059dc6bd6192d182b8e0244367d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352451 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#803007}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I0c3348b5efb93c0e08d4ca4acc76a0dbb204e0c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384319Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803006}
-
Eric Willigers authored
DirectSocketsServiceImpl is now a WebContentsObserver. OpenTcpSocket() and OpenUdpSocket() now fail safely if they are called after the RenderFrameHost is destroyed. Bug: 1122917 Change-Id: I4a880c9aee73271cd5895818e0da3d85e32a8e5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383531 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6c484875cdcb..c73782c8d8ff 2020-08-31 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I4469754998d3a012744744009e224672d8a6e29c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384401Reviewed-by:
-
Hiroki Nakagawa authored
This reverts commit 056d2885. Reason for revert: This is a speculative revert for failures on https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38382 This could fail the following test: ClipboardHistoryWithMultiProfileBrowserTest.ShouldPasteHistoryAsPlainText Original change's description: > cros: Implement ClipboardImageModelFactory > > Implements ClipboardImageModelFactoryImpl. > Previous CL landed ClipboardImageModelFactory, and all > ash-side usages of the factory. > > This CL implements rendering of HTML via > ClipboardImageModelRequest. > > Bug: 1117230 > Change-Id: I2f7ac67eadac5ef1a3c7cfca9918de438f02ff8e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367395 > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Auto-Submit: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802779} TBR=xiyuan@chromium.org,newcomer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1117230 Change-Id: Ibc178e2d0b50bb423bc5a128aead30a5f471bd18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383532Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#803003}
-
Mason Freed authored
These are all of the form: String::Format("constant string") I.e. they contain no % specifiers and no extra arguments. Change-Id: Ib0f7e79084406330b008e7bb4713695b9c8cded9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382110 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#803002}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4e662367b179..d9d64f51f078 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nhiroki@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1112687,chromium:1115826 Tbr: nhiroki@google.com Change-Id: Icbe2adb26a6d811206514e2172dfa66d5ae68006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384396Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
-
James Zern authored
https://chromium.googlesource.com/codecs/libgav1.git/+log/e46493b9148e..a9449e612bc2 $ git log e46493b91..a9449e612 --date=short --no-merges --format='%ad %ae %s' 2020-08-17 vigneshv Set frame parallel threshold multiplier to 3 2020-08-17 linfengz trivial: call Clip3() in Tile::BuildConvolveBlock() 2020-08-17 linfengz dsp,trivial: update WienerFilter_SSE4_1() 2020-08-17 linfengz fix fuzz bugs in PostFilter::ApplySuperResThreaded() 2020-08-14 jzern inverse_transform,GetNumRows: expand some conditions 2020-08-14 linfengz update PostFilter::ExtendFrame() 2020-08-14 linfengz dsp: update ComputeSuperRes() 2020-08-14 linfengz dsp: update ComputeSuperRes() dsp functions 2020-08-13 jzern ReadSymbolWithoutCdfUpdate: pass a single uint16_t 2020-08-13 linfengz update PostFilter::ApplySuperResThreaded() (...) 2020-07-14 jzern entropy_decoder: LSB align cached bits 2020-07-14 wtc Automated rollback of commit dda67c1927bf5878a069df9be136551317f82e0e. 2020-07-14 wtc Clear reference frames if key frame and show_frame 2020-07-13 jzern symbol_decoder_context: align cdf tables 2020-07-13 wtc Only wait for the ref frames used by current frame 2020-07-13 vigneshv trivial: Rename MoveTileBuffer to MoveTileBuffers 2020-07-13 wtc Skip MarkInvalidReferenceFrames if show key frame 2020-07-13 wtc Don't validate primary_reference_frame twice 2020-07-13 wtc Initialize the reference_frame_index array to -1 2020-07-13 jzern entropy_decoder,sse4: add some missing casts Created with: roll-dep src/third_party/libgav1/src Test: media_unittest --gtest_filter=Gav1* on x86 Change-Id: I20b08161d20e1f3c2a465ee79a94872e5f6e1d36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381015 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#803000}
-
My Nguyen authored
Add blank dialog for now. Both Action and Cancel buttons currently close the dialog. Current view: http://screen/BpiwRzGMHfgHgYw Design doc in progress: http://go/cros-lang-settings-step-5 Bug: 1113439 Change-Id: I93c8e7a432e67a2c785b258d8bfa661c1360b543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379467 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#802999}
-
Yoshisato Yanagisawa authored
For ease of distinguishing Goma's builder, let me specify special service accounts for them. Bug: b/166712857 Change-Id: I45317d787e2b3f8bbf9e1cb15d588ba661fad4fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384450 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#802998}
-
Eric Willigers authored
We ensure the direct sockets API cannot be used to by-pass CORS, by causing NotAllowedError failures when web apps attempt to open direct socket connections on port 443. Not yet implemented: We should issue CORS pre-flight checks, to see if the connection attempt may be permissible. Bug: 1119601 Change-Id: Ia2179ae41072b99eda2ad4d5a8bbf41ddba252ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383373Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ic432627efc292b958b9d30dc3e8886aee02c2b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382832Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#802996}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1598806680-bf4202c36f1e343eed4671b6753fc4351a3e6e6e.profdata to chrome-mac-master-1598831810-48c324362c2be2fbbcf6a178b22d323ccaa14725.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I249c4aedda106209e307d1dbf45f876cdc2fbff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384398Reviewed-by:
-
Darren Shen authored
The event code is incorrect. Should be "KeyA", not "A". Fix the expectations to match the purpose of the test. Bug: 1035145 Change-Id: I5f269aea5bae9f441b4021f8c5c5e3ccea1ba6d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371386Reviewed-by:
-
Joel Hockey authored
Change-Id: I51f4442d9fb4cb8c1eeed8618e03606227549fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384449 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Daniel Ng <danielng@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#802993}
-
My Nguyen authored
Make the button actually confirm and restart. Spec: http://go/cros-lang-settings-ux-slide#slide=15 Bug: 1113439 Change-Id: I4d728f8d2e237ceb15139493fadeaf4b7f0b83f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379405 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
-
nancylingwang authored
When the test exist, the data_decode process has't finished yet, so it might cause fatal error: data_decoder::ServiceProvider::Set() must be called before any instances of DataDecoder can be used. Call app_service_test().WaitForAppService() to add RunLoop to wait the decode process finish to fix the flaky tests. BUG=1115763 Change-Id: Ic03dd66eca615096b2e51b90b6d3a590fe7c5e8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383593 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#802991}
-
Eric Willigers authored
When remotePort is omitted, the navigator methods openTCPSocket and openUDPSocket return promises that reject. Requiring remotePort will allow the user agent to show helpful UI describing the connection the web app would like to initiate. https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md#security-considerations Change-Id: Ic244b72252340e9532fb6c2520fde1a0e00e1ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383511 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
-
Eric Willigers authored
Change-Id: I8f056c53fda6e5f7e0686af0b1fcffdb229fb93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383213 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
-
Darren Shen authored
Native rule-based has already been launched for 2 milestones. Deleting the flags code related to it. The corresponding internal code was deleted in cl/307494837. Bug: 1034355 Change-Id: I831816b9dd023c14f2e21017af9b2fa69983c88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367300Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium deff7e4c. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I2da44a2bb55f64b81414dfc31c51e4f2f9549e20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382263Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802987}
-
Hiroki Nakagawa authored
Bug: 1123394 Change-Id: I34d3e7ce48d4f8db5c274b7300c1dbf5e992c3d2 Tbr: aleventhal@chromium.org, dmazzoni@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383395Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b1e3f57ef7c0..79257bae3c9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I52ada3e1abcfa1efd29f925fb27d2a61ece46523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382716Reviewed-by:
-
Wenbin Zhang authored
This reverts commit 8700df8a. Reason for revert: Android builders started failing since this commit: https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/217957 Traceback (most recent call last): File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 105, in Main ret = self.args.func() File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 378, in CmdGen return self.RunGNGen(vals) File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 961, in RunGNGen ret = self.GenerateIsolates(vals, isolate_targets, isolate_map, build_dir) File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 1075, in GenerateIsolates command, extra_files = self.GetIsolateCommand(target, vals) File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 1392, in GetIsolateCommand 'generated_scripts can no longer customize the script path') AssertionError: generated_scripts can no longer customize the script path Original change's description: > Rename wrapper_scripts for generated_script tests in MB. > > A few tests (some Android resource_sizes tests, and one Perfetto > test), were using generated_script tests that were generating > wrappers that weren't named 'bin/run_$target_name'. > > We want all generated_script tests to be using consistent names, so > this CL changes those targets. > > Bug: 816629 > Change-Id: If447fbee6b33637de4c9711e87379128272285af > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380672 > Commit-Queue: Dirk Pranke <dpranke@google.com> > Reviewed-by: John Chen <johnchen@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802694} TBR=dpranke@google.com,agrieve@chromium.org,johnchen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 816629 Change-Id: I11ec06405105860f01f3b7752df2024615f7badc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384069Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#802984}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/af2dca5c5320..79257bae3c9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3faeb9a98c46cd94e2d9ee01b1e72c17726e90b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382619Reviewed-by:
-
My Nguyen authored
Also add description for the dialog. Will update search field look later. Keeping search field's onKeyDown behavior similar to AddLanguagesDialog Current view: http://screen/89QAGJxXX5Yh2nB Spec: http://go/cros-lang-settings-ux-slide#slide=15 String is being finalised so translateable=false and no screenshots required Bug: 1113439 Change-Id: I8b7e428d42754eaaf91252aa4f23664cdd3690bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379031 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
-
- 30 Aug, 2020 5 commits
-
-
John Chen authored
Several stories have been deleted by crrev.com/c/2380497. Remove them from expectations.config and timing_data to avoid presubmit errors. TBR=wenbinzhang@google.com NOTRY=true Change-Id: I82c206ffe37e4f9583bc33713b56fef806eea89d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384334 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#802981}
-
Peter Kasting authored
Bug: none Change-Id: Iaf29f57b6085d96fd5cf0dc890e57500bfc0bfb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384333 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#802980}
-
Sara Kato authored
Address remaining comments from crrev/c/2336000 Test: none Bug: none Change-Id: I7b153dddc977701289f813cafecef018a4902ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379421Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#802979}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I7adc49071b1bbaa7c37e3839e10395114e0ff7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384266Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1598787629-5050e58a06f338b550c38a558c54620e2382ffcd.profdata to chrome-win32-master-1598806680-ea8cbf643223574fcb349af48fd14418e961fcb1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: If57a487c563e75372f713e409f17484fabfbce51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384252Reviewed-by:
-
