- 22 Sep, 2020 40 commits
-
-
Stephen McGruer authored
Passing an async function to async_test will soon be disallowed in WPT, as any asserts thrown will be turned into unhandled promise rejections and the test will timeout. If a test needs async functions it should use promise_test instead. (The naming conflict is a sad historical legacy; WPT had async_test long before EcmaScript spec'd promises!) Bug: https://github.com/web-platform-tests/wpt/issues/21435 Change-Id: I0a31872525844a1540aea548e329929e8097663e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414923Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#809464}
-
Yue Zhang authored
Bug: 1130814 Change-Id: If8d93fb7c134637f399735637ff031abbe31ebc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411671Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#809463}
-
Azeem Arshad authored
This CL adds //third_party/barhopper to .gitignore. This repo is imported from src-internal and is used for implementing Chrome's shape-detection API's in ChromeOS. DEPS entry previously added at https://crrev.com/c/2416746. Bug: 1093185 Change-Id: I714456bfa8b484be58381c4cb34fe6c1a5e6d943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422821Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#809462}
-
Taylor Bergquist authored
Two closely related bugs fixed here: - When the tabstrip is not stretched to fill all available space (see https://crrev.com/c/2300993) and the window is dragged wider, the tabstrip stays small as if the window had not been widened. This was happening because the tabstrip was ignoring all Layout() calls unless its width changed. Now, it also needs to relayout if the available width has changed. The fix was to track the available width at the last layout time in parallel with the tabstrip's own width, and ignore the layout only if both are unchanged. - When the tabstrip is being resized wider, the trailingmost tab may become invisible until the next call to Layout(). This was happening because the tabstrip was being sized based on stale layout information, but the tabs themselves were being laid out based on current layout information, so the total width of the tabs didn't line up with the width of the tabstrip. The tab that didn't fit in the tabstrip was then hidden. The tabstrip calculated its preferred size based on the current location of the tabs in order to correctly handle the case where the tabstrip was being animated wider, e.g. when opening a new tab. The fix was to calculate the tabstrip's preferred size in a more conventional way, based on the unconstrained widths of the tabs, except when animation was ongoing. Bug: 1116741 Change-Id: I2006aef4a57389b2c75d21db777d6675b6479048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419633 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#809461}
-
Alison Maher authored
When we were adding new proxy fragments directly after a spanner, we were computing the wrong offset for these new fragmentainers. This change fixes this by looking at the offset of the spanner when determining the offset of proxy fragments in this case. Bug: 1079031 Change-Id: I34a6358f9bc1b1d630d72bb268f3ae79edcdff00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422424 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#809460}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/aeda49ba5046..6db3a24c19e7 2020-09-22 bryan.bernhart@intel.com Revert "Disable debug layer logger" 2020-09-22 cwallez@chromium.org Simplify the BindGroupLayout validation code. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1130483 Tbr: cwallez@google.com Change-Id: I160391ec7da675af7e2a265f15c8caaacb9b9325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424565Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809459}
-
Jihwan Marc Kim authored
Currently the BluetoothChooser has C++ enums for event type. And the BluetoothChooserDialog java code has event type too. It would be better to define these enums in one place in C++ And the Java code can share it without defining them again. Bug: 994392 Change-Id: I12c8ba92219b4aa3290da6a746467d40e39de1f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387901 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#809458}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I4d7ee548c4ed9f8203509d15fd10e07d4aac72df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424644Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#809457}
-
Alexandre Courbot authored
Quick and easy fixes reported by clang-tidy. BUG=None TEST=video.DecodeAccel.h264 passes on Kukui. Change-Id: Id4f54a7c29cbf17ae10e2f4e289e95edf81d5a4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421995 Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#809456}
-
Boris Sazonov authored
If MobileIdentityConsistency flag is enabled - replaces "Sync and Google services" link in Privacy settings with: * One "Google services" link if sync is off; * Two separate "Sync" and "Google services" links otherwise. Bug: 1130623 Change-Id: I0bd8db188350a5ca3ac8c8c0276eba0a3f9bc8f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421461 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#809455}
-
Mohamed Amir Yosef authored
This reverts commit 670197a4. Reason for revert: https://ci.chromium.org/p/chrome/builders/ci/linux-autofill-captured-sites-rel/2954 Original change's description: > [Autofill] Parse the new proto in FormStructure > > Before this patch: > The new protos were converted to the old protos before being > parse by the FormStructure. > > After this patch: > The new protos are parsed directly. > > Bug: 1114655 > Change-Id: Ieb7d71c573e3010067aba250ab161be7946d203e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404584 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Dominic Battré <battre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809279} TBR=battre@chromium.org,mamir@chromium.org Change-Id: Iadc92bd3b29f9e2ddca7051e65cb8548c1e0fd80 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1114655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424272Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#809454}
-
Xiaodan Zhu authored
This CL Adds two unit tests of ReverseGestureHandlerTest: - OverviewReverseGestures to test the overview reverse gestures. - SwitchDesksReverseGestures to test the desk switching reverse gestures. Bug: 1107183 Change-Id: I2ea9304d637217330ecd0c16ab79a296eb8fedaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419930 Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#809453}
-
Livvie Lin authored
Change-Id: I4c7baafca5fd55365f456e3357421dbdd9f040ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422728 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#809452}
-
Ali Juma authored
This histogram is still being used to ensure that new features (e.g., Safe Browsing) do not regress page load time. Bug: 1052999 Change-Id: Ib7951a308443a56f0d7e383d7ba3d512ff9e96cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423906Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#809451}
-
Markus Handell authored
When forwarding a frame to Video Encode Accelerator, RTCVideoEncoder would almost always create a frame copy unless the incoming media::VideoFrame was backed by STORAGE_SHMEM. The copy would be backed by STORAGE_SHMEM, which results in the video decode accelerator wrapping the VideoFrame's memory in a CVPixelBufferRef. Changes: 1) Break out code in media::VideoFrame::WrapIOSurface() that creates an IOSurface from a GMB handle. 2) Code is added to WrapVideoFrameInCVPixelBuffer to create a CVPixelBufferRef via GpuMemoryBuffer::CloneHandle(). 3) RTCVideoEncoder is changed to pass on GMB-backed video frames. Bug: 1127791, 1125879 Change-Id: I59dd1eae59ae4dffb591830152f44e470fb3cce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410244Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#809450}
-
Hui Yingst authored
OpenPDFParamsParser currently maintains an array of requests and assumes they will get replied in the same order. By changing the return type of getNamedDestinationCallback() to a promise, this CL enables getViewportFromUrlParams() to handle the data returned by the plugin directly, without storing all the requests inside OpenPDFParamsParser. This CL also removes the usage of onNamedDestinationReceived() from browser tests. Bug: 55776,535978,748852 Change-Id: If6e8285a363d2efee169457856ca465cb498805a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391102 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#809449}
-
Nelson Billing authored
- .dwp files produced by clank build will now be output to lib.unstripped folder instead of the root out folder. This is to ensure they are in the expected place for Breakpad symbol generation and symbol archiving. Bug: 1112935 Change-Id: Id5cfb8a0188e3a6fa30fb56ed98bdb4e7da2af03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406595 Commit-Queue: Nelson Billing <nbilling@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#809448}
-
Jose Dapena Paz authored
Fixes this compilation error: ../../components/autofill/core/browser/data_model/autofill_offer_data.cc:56:8: error: ‘sort’ is not a member of ‘std’; did you mean ‘sqrt’? Bug: 957519 Change-Id: Iaef429cfca5e55af8b819457f9b9729ab4f669f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423586 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#809447}
-
Stephen McGruer authored
Bug: None Change-Id: I9a0817a90270266a538062aaf4e322a86fa3ed6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422146Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#809446}
-
Xing Liu authored
This CL makes the "don't show again" checkbox by default unchecked. This is discussed with PM that the 3+1 approach may be confusing to the user, and we don't want a IPH on the download later dialog. Bug: 1117573 Change-Id: I23a95720d031489a4a5ccfa4ec872e9e613279a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423044 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#809445}
-
Alexandre Courbot authored
Controls can be applied on the device as a whole, or only on a request. Add an optional request parameter to SetExtCtrls() to cover this use-case. We can use it in the V4L2DecodeSurface once the config store is retired. BUG=chromium:1009921 TEST=video.DecodeAccel.h264 passes on Kukui. Change-Id: I2fefdedd2b9ad3a2b02d3a8ecfe74bbd19b6db58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421994 Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#809444}
-
Alexandre Courbot authored
Stumbled upon a big bunch of these, so took the opportunity to quickly fix them. Looks like they are all gone, at least according to this command: $ git grep 'struct *v4l2_.*= *{.*};' BUG=b:153935975 TEST=video.DecodeAccel.h264 passes on Kukui. Change-Id: I2c4709ff0a15c01c446a8599c7de5e498017294b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421993Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#809443}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: OSSettingsInternetKnownNetworksPage* Change-Id: I8b689fc1fa915f2dc2a2994515422d9d0e0db68a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419583 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#809442}
-
Keren Zhu authored
ActivationAction controls both focus and blur behaviors of a bubble: a) DO_NOT_ACTIVATE: no focus, persistent bubble. b) ACTIVATE: get focus on creation, dismiss bubble on blur. The blur behavior was not well documented. Feature bug 1121399 introduces snoozable IPH bubble that needs to c) get focus on creation, persist on blur. To add support for c) and keep support for a) and b), this CL breaks ActivationAction into two bools to control focus and blur behaviors of a bubble separately. Bug: 1121399 Change-Id: I2a38d740d901905bc13855d421000bff4bf2ca3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423305 Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#809441}
-
Kevin McNee authored
Bug: 1115597 Change-Id: Ibd17d29f636ac6b4b480d8e20658e51a3a31d650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409606Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#809440}
-
Lei Zhang authored
Remove the "TEMP" comment for WebLocalFrame::UsageCountChromeLoadTimes() from 4 years ago. Bug: 621512 Change-Id: If823b6685d73e3065e931a12e231380e6cd0833d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404523Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#809439}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/899ea244a8db..2fb4be6e85e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC huangdarwin@google.com,lgrey@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1128988 Tbr: huangdarwin@google.com,lgrey@google.com Change-Id: I9c05869132f0c86936ac52259b46f2d2aeb69900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424723Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809438}
-
Kartik Hegde authored
Add the LanConnectivity routine to the ServiceConnection. BUG=chromium:956783 TEST=1) chromeos_unittests --gtest_filter=CrosHealthdServiceConnectionTest.* 2) Applied LanConnectivity changes and successfully ran the LanConnectivity routine on a DUT (verified using cros-health-tool diag --action=run_routine --routine=lan_connectivity). Change-Id: Ia0c9fd15d07c121d04fa08466694575cc3048d0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321005 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#809437}
-
Dan Harrington authored
Bug: 1069183 Change-Id: I6bbcb5857c798faabd164e7b08523d05ec7aecdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414916 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#809436}
-
Gavin Williams authored
In destination dialog display red error status text whenever a local CrOS printer has an error printer status. Hide the search-hint <span> when empty to make more room for the error status text. Screenshot: http://screen/rsAqy3dWhECQNyS Bug: 1123754 Change-Id: Ifbbee309b8dee17ad88c4a51923c0f445cf225c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405711Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#809435}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ada5d5129f48..82c70d97576c 2020-09-22 fmayer@google.com Merge "Have separate sampler per heap." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I40e4aaf295b21fb28ff7be47ff71746a99d72825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424567Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809434}
-
Keren Zhu authored
An non-focasable widget will not set its anchor view's kAnchoredDialogKey, but currently a bubble dialog will reset kAnchoredDialogKey when it detaches from its anchor view. This will break the focus traversal path if kAnchoredDialogKey was pointing to a different widget. This CL fixes this issue by resetting kAnchoredDialogKey only if it is pointing to the current bubble. This issue blocks bug 1121399 where a focusable IPH bubble will contest kAnchoredDialogKey of a tab while a non-focusable tab hover card might anchor to it. The hover card will later accidentally detaches the IPH bubble from the tab when it dismisses. Bug: 1121399 Change-Id: Ia7f82ee166eae100cd18ffa816ddf50cf02acba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422709Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809433}
-
Camillo Bruni authored
Change ModuleRecord::ModuleRequests to return directly Vector<ModuleRequest>. This avoids the overhead of two temporary Vectors for source position and specifiers. Remove ModuleRecord::ModuleRequestPositions as it is no longer needed. Bug: 945094 Change-Id: Ie6400e7511f2a5879bbf95223f4eeb021b4ae0c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414288 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#809432}
-
Xiaodan Zhu authored
This CL add system toast for reverse scrolling gesture changes. - If the user perform wrong gestures twice, a system toast will show up to indicate the right gestures. - If the toast shows at the fist time, it will disappear until the user perform the right gesture. Otherwise, it will shows for 2500ms. Bug: 1107183 Change-Id: I1fd3fb9f0c898ca15cae2de87df6e89c7b62aecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417242 Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#809431}
-
David Grogan authored
Old behavior: Use max content contribution for flex base size, which is roughly: use computed width if it exists, otherwise use intrinsic size after applying the aspect ratio and min/main/max height. In either case, apply min/max width. New behavior is similar to the 'max-content' size: use the intrinsic width after applying the aspect ratio and min/main/max height. Ignore computed min/main/max width. Also, we weren't returning available size as the max-content size of an SVG item that only has an aspect ratio and no intrinsic sizes, which is what Firefox does and what the spec dictates. Both of these are fixed with a new aspect-ratio sizing method that currently lives in flex but will be moved to NGReplacedLayoutAlgorithm when it exists. Change-Id: I4afb382a7604a4fcd0626f0702edf72f21cd0bcc Bug: 987000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399082Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#809430}
-
Dave Tapuska authored
Fix a crash related to change https://chromium-review.googlesource.com/c/chromium/src/+/2418998 Seems there is reentrancy during destruction for pepper plugin instance. Do not access any containers if we've been marked for deletion. This follows the same convention for handling messages. BUG=1130991 Change-Id: I2004265dc5592761c24c957be6231c3a1ad86d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423271Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#809429}
-
Adrienne Walker authored
This is a followup to this patch: https://chromium-review.googlesource.com/c/chromium/src/+/2412834 ...to make the same changes to LocalFileStreamReader that were requested for the FilesystemProxyFileStreamReader in that review. Bug: 1119547 Change-Id: Ibaccd858c807969eb185012add8ab01fed4aad33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422271 Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#809428}
-
danakj authored
The callers can just do layer->device_scale_factor() themselves. R=sky@chromium.org Bug: 1130050 Change-Id: Iccfd2ae47b4988e3f83868f10f99b61b4be3e0a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419507 Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#809427}
-
Lei Zhang authored
As is, the utility processes launched by the Cloud Print service process are generic utility processes. This worked fine for Cloud Print on Windows until https://crrev.com/748400 limited the sandbox types to do gdi32.dll patching for. To resume gdi32.dll patching, update the utility processes to be of type |kPdfConversion|, which better reflects what they do. Bug: 1128450 Change-Id: Ib2f3bfb688891d628ba798965f3e137ec4490c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423543Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#809426}
-
rbpotter authored
R=johntlee@chromium.org Fixed: 1130854 Change-Id: I546c0650bb940ce8a92d4cf2a3ea54a309ba1346 Bug: 1130854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423056Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#809425}
-