- 11 Aug, 2018 40 commits
-
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I55fde6cc5f184386b780a060c5b6868b4e174735 Reviewed-on: https://chromium-review.googlesource.com/1172063 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582456}
-
Bill Orr authored
A recent change accidentally modified the mapping of OpenVR contoller state to Gamepad buttons/axes. This change moves back to the original behavior. Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ifa821ef1610e04be42cd8a6c352d4dc93c006cfa Reviewed-on: https://chromium-review.googlesource.com/1171663 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#582455}
-
Scott Violet authored
This makes Ash create an Env if passed SingleProcessMash. In addition this makes all window creation go through a factory that ensures the right env is supplied. See https://docs.google.com/document/d/11ha_KioDdXe4iZS2AML1foKnCJlNKm7Q1hFr6VW8dV4/edit for more details. This also adds the feature to ui/base. BUG=847992 TEST=covered by tests TBR=jamescook@chromium.org Change-Id: I446ba2dd7a05702cfca41a0e0d657d6606cc28e5 Reviewed-on: https://chromium-review.googlesource.com/1172054Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#582454}
-
Christopher Cameron authored
This is to limit the error spew in about:gpu (currently any useful messages are easily lost in warnings about these blank-resource uses). This function in SetVisible(false) to ensure that resources be dropped at tab switch. The current implementation immediately deletes the GL resource backing, even if it may be in use by the display. This results in flashed-black scrollbars and lots of GL errors. Change EvictAllUIResources to just evict the resources without deleting their backing. The resources are then destroyed when they are returned from the display (at OnUIResourceReleased). Bug: 864905, 870317 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1e079e1790275d3194b565457971e65f7d265587 Reviewed-on: https://chromium-review.googlesource.com/1171832 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#582453}
-
Chris Harrelson authored
ShouldRespectOverflowClip conditions on paint_flags. However, AdjustForPaintProperties removes some of those flags (kPaintLayerPaintingOverflowContents in particular) when changing painting root. Before this patch, a non-composited clip (e.g. overflow:scroll) under a composited layer would not correctly apply a clip to the cull rect of the clip; now it does. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I04e4df8f1e0d987a3787ce430c80171f268884a4 Reviewed-on: https://chromium-review.googlesource.com/1171583 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#582452}
-
Peter Kasting authored
This reverts commit b6cde39f. Reason for revert: Caused flaky compile failures, e.g. https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/54711 , https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-rel/192 , https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-rel/1165 Original change's description: > Propagate update on RendererPreferences to ServiceWorkerFetchContextImpl > > Each FetchContexts needs to be notified it's update. This introduces a new Mojo > interface (mojom::RendererPreferenceWatcher) to observe changes in the > preferences. > > Bug: 853085 > Change-Id: I3985c0ee363e073099d1a3ac85bf210f5bbce537 > Reviewed-on: https://chromium-review.googlesource.com/1164151 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Makoto Shimazu <shimazu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582445} TBR=avi@chromium.org,kinuko@chromium.org,shimazu@chromium.org Change-Id: Idda3a12439b55f00269ba3a3c0ea129a44c2fcf6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 853085 Reviewed-on: https://chromium-review.googlesource.com/1171716Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582451}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ea926a362b77..7ae70d8fb360 git log ea926a362b77..7ae70d8fb360 --date=short --no-merges --format='%ad %ae %s' 2018-08-11 jie.a.chen@intel.com ParallelCompile: Parallelize D3D linking Created with: gclient setdep -r src/third_party/angle@7ae70d8fb360 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Iaab7a283e847ad95981074123daffcd3db07a34e Reviewed-on: https://chromium-review.googlesource.com/1171713Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582450}
-
Danil Chapovalov authored
undefine StrCat from StrCatW after including windows headers that redefine it Add preprocessor checks StrCat is not defined to something else. Add presubmit check headers that include shlwapi.h that redefines StrCat are wrapped Bug: chromium:856536, chromium:817738 Change-Id: Ief9303cbf6fa4f55f671861e49fb1fc747ed59aa Reviewed-on: https://chromium-review.googlesource.com/1117180Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Cr-Commit-Position: refs/heads/master@{#582449}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5fb1b7e0ffe1..02d174687cc9 git log 5fb1b7e0ffe1..02d174687cc9 --date=short --no-merges --format='%ad %ae %s' 2018-08-11 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 ea926a362b77..7ae70d8fb360 (1 commits) Created with: gclient setdep -r src/third_party/skia@02d174687cc9 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: I9416d8cdad46cb1244ae903d8fa4e87fb3e0f7aa Reviewed-on: https://chromium-review.googlesource.com/1171714Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582448}
-
Ella Ge authored
TextAutosizer::ComputeAutosizedFontSize are used in both font_builder and computed_style. The size passed in from font_builder is computedsize, which has zoom factor applied. But in ComputedStyle::SetTextAutosizingMultiplier, zoom factor doesn't. And also, kPleasantSize is hard-coded css pixel (without zoom factor), and it was used in calculation with computed_size(with zoom factor). The inconsistancy causes line height incorrect when multiplier applied(crbug/871124), and also text sometime lost scaling(crbug/871054) This CL correct the variable in ComputeAutosizedFontSize to computed_size, and pass in effective_zoom, so the sizes are computed in correct scale. Bug: 871054, 871124 Change-Id: Icf546795663b76af3cd03e4e42da96483eb83af7 Reviewed-on: https://chromium-review.googlesource.com/1169972Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#582447}
-
Trent Apted authored
Give it a js_unit_tests target, and lint the externs in gallery/js/BUILD.gn. Delete externs/gallery_event.js - it's currently unreferenced and unused. ribbon.js gets the definition of event.item from an assignment in gallery_data_model.js - not from this extern file. Bug: 867700 Change-Id: Iae49ca0af61768b37274db2314630cbde9b120ef Reviewed-on: https://chromium-review.googlesource.com/1170452Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#582446}
-
Makoto Shimazu authored
Each FetchContexts needs to be notified it's update. This introduces a new Mojo interface (mojom::RendererPreferenceWatcher) to observe changes in the preferences. Bug: 853085 Change-Id: I3985c0ee363e073099d1a3ac85bf210f5bbce537 Reviewed-on: https://chromium-review.googlesource.com/1164151Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#582445}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/98d4b8559aab..62dc9deeea75 git log 98d4b8559aab..62dc9deeea75 --date=short --no-merges --format='%ad %ae %s' 2018-08-11 manojgupta@chromium.org Revert "generic_stages: temporarily ignore all target prebuilts." Created with: gclient setdep -r src/third_party/chromite@62dc9deeea75 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I46b302f8674366c6c6dd8d8df6cca713fad1c0f2 Reviewed-on: https://chromium-review.googlesource.com/1171712Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582444}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/6fdfe3876452..0c7cf97859dd git log 6fdfe3876452..0c7cf97859dd --date=short --no-merges --format='%ad %ae %s' 2018-08-11 thestig@chromium.org Cleanup CFX_CTTGSUBTable. 2018-08-11 thestig@chromium.org Initialize CPDF_CIDFont members. 2018-08-11 thestig@chromium.org Simplify CPDF_SimpleFont::LoadPDFEncoding(). Created with: gclient setdep -r src/third_party/pdfium@0c7cf97859dd The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I12e58b51de4a4236d386bbcd26f0cc5c324128a6 Reviewed-on: https://chromium-review.googlesource.com/1171711Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582443}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f3ca1c6abb07..5fb1b7e0ffe1 git log f3ca1c6abb07..5fb1b7e0ffe1 --date=short --no-merges --format='%ad %ae %s' 2018-08-11 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 04c084dd3cf4..ea926a362b77 (4 commits) 2018-08-11 reed@google.com check for overflow in maxedgecount Created with: gclient setdep -r src/third_party/skia@5fb1b7e0ffe1 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:848521 TBR=djsollen@chromium.org Change-Id: I010a73604f808dbb485a82845cf42e72a0e464be Reviewed-on: https://chromium-review.googlesource.com/1171406Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582442}
-
Antoine Labour authored
This adds a InProcessSharedImageInterface tear-off class linked to InProcessCommandBuffer, that implements SharedImageInterface using the same GLContext/GLSurface and TaskExecutor as the InProcessCommandBuffer. Bug: 870116 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I916a87a3ae6c1360e1e10766654b96455eb2e1ca Reviewed-on: https://chromium-review.googlesource.com/1171782 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#582441}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fa55f08ba456..98d4b8559aab git log fa55f08ba456..98d4b8559aab --date=short --no-merges --format='%ad %ae %s' 2018-08-11 llozano@google.com generic_stages: temporarily ignore all target prebuilts. 2018-08-11 chingcodes@google.com signing: Add Signer for image signing 2018-08-11 chingcodes@google.com signing: Add key management 2018-08-11 saklein@chromium.org Adding overlay master searching to license functionality. Created with: gclient setdep -r src/third_party/chromite@98d4b8559aab The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I1f3b02401925cabd1884b4249fa35699afdac0bd Reviewed-on: https://chromium-review.googlesource.com/1171707Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582440}
-
Peter Kasting authored
This reverts commit ace3f1f7. Reason for revert: Checking to see if this caused flaky scrolling failures on Mac 10.13 ( https://bugs.chromium.org/p/chromium/issues/detail?id=873435 ) Original change's description: > [RootScroller] Allow main document horizontal overflow > > When implicitly promoting an element to be the root scroller, we first > check if the main document has any overflow. If it does, we err on the > side of not promoting since it is likely the main document's content is > important and meant to be scrollable. > > This heuristic turns out to be too restrictive. For example, this makes > it hard to build a root scrolling carousel. This CL loosens the > restriction to allow horizontal overflow. > > Bug: 838683 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I6007f6faa8e2006799a9dca6240b68ff0de7f09a > Reviewed-on: https://chromium-review.googlesource.com/1165859 > Commit-Queue: David Bokan <bokan@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581408} TBR=bokan@chromium.org,dtapuska@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 838683 Change-Id: I14e6a0158bb8b06f2344c3b30b38b86c6eabd583 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1172004Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582439}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I1f69e90795707e9ef3b4310c6d04ef4b23b379ba Reviewed-on: https://chromium-review.googlesource.com/1172043Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582438}
-
Wenzhao Zang authored
The dialogs should always be full-screen as long as there's no user added yet. This covers the corner cases that user stops in the middle of OOBE and returns later. Do not show the dialog as full-screen (at least for now, until there's UX update) for cases that the OOBE is completed, but user pods are not shown (due to policy, or all users are removed manually on an enrolled device). Bug: 872936 Change-Id: I02a648585a7cbebd1b570096ab3608bff000e96d Reviewed-on: https://chromium-review.googlesource.com/1171916Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#582437}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f5f537337258..f820a5ea1c5c git log f5f537337258..f820a5ea1c5c --date=short --no-merges --format='%ad %ae %s' 2018-08-10 steveanton@webrtc.org Fix use after move in SafeSetError 2018-08-10 peah@webrtc.org AEC3: Allow the main and shadow filters to have different lengths 2018-08-10 peah@webrtc.org AEC3: Further utilize the shadow filter to boost adaptation Created with: gclient setdep -r src/third_party/webrtc@f820a5ea1c5c The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:873100,chromium:873074 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I17c5ef48542d75bd785d1bdf3ac026a23ed46229 Reviewed-on: https://chromium-review.googlesource.com/1171447Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582436}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f36a4644b828..6fdfe3876452 git log f36a4644b828..6fdfe3876452 --date=short --no-merges --format='%ad %ae %s' 2018-08-10 tsepez@chromium.org Kill some optional parameters that are always supplied. 2018-08-10 tsepez@chromium.org Remove unused form of PDF_EncodeText(). 2018-08-10 thestig@chromium.org Make the 4th parameter in CPDF_Form non-optional. 2018-08-10 thestig@chromium.org Minor cleanup in CPDF_ContentParser. 2018-08-10 thestig@chromium.org Fix sign mismatch in CPDFXFA_DocEnvironment. 2018-08-10 tsepez@chromium.org Make CPDF_PSFunc::m_PS mutable. 2018-08-10 tsepez@chromium.org Remove const args and const_casts where not required. Created with: gclient setdep -r src/third_party/pdfium@6fdfe3876452 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iab53be69d9f0d924e963168cd83c3c139ebb5d4b Reviewed-on: https://chromium-review.googlesource.com/1171446Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582435}
-
Peter Kasting authored
This reverts commit 1f637a1a. Reason for revert: Part 2 of trying to revert history throttling changes to see if https://bugs.chromium.org/p/chromium/issues/detail?id=870861 improves. Original change's description: > Soften the history.{push,replace}State throttling mechanism. > > johnme@ suggests a better way to handle it; let's do that. > > Bug: 786211 > Change-Id: I446c70117451d2ef49ce13f5884ebb858d9ee392 > Reviewed-on: https://chromium-review.googlesource.com/1161400 > Commit-Queue: Chris Palmer <palmer@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580455} TBR=palmer@chromium.org,dcheng@chromium.org,kinuko@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 786211 Change-Id: Ia6a35add136361834c3afb40295b950c05cb9169 Reviewed-on: https://chromium-review.googlesource.com/1171709Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582434}
-
David Roger authored
This is a reland of: https://chromium-review.googlesource.com/1170202 which was reverted because of missing svg icon. The user events UI toggle should be grayed out and turned off when there is a passphrase or when history sync is disabled. Note that this is purely a UI change: the internal sync datatype is not really turned off in that case, and we assume that the Sync engines will correctly stop syncing user events in these cases, even if the preference is still ON. Bug: 865522, 865537 Change-Id: I745f048b3ca301231f57c04b82d0d9d82a6f3b90 Reviewed-on: https://chromium-review.googlesource.com/1170825Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#582433}
-
Peter Kasting authored
This reverts commit 8e4127dd. Reason for revert: Part 1 of trying to revert the history throttling changes, to see if https://bugs.chromium.org/p/chromium/issues/detail?id=870861 improves. Original change's description: > Change the history state throttle interval from 60 to 120 Hz. > > This is a bit more lenient and may enable some callers, including a flaky test, > to get (more of) what they need. The test's root problem seems to be data races > (see issue 847326), however. > > Bug: 870861 > Change-Id: I249e9f06fa9a9a9f3b74e53cf2ef3f34b0c2371c > Reviewed-on: https://chromium-review.googlesource.com/1171825 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Chris Palmer <palmer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582415} TBR=palmer@chromium.org,dcheng@chromium.org,kinuko@chromium.org Change-Id: I9fb7b5b0f8ebff8b6d6c5a772745cfd2c10ef51a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870861 Reviewed-on: https://chromium-review.googlesource.com/1171708Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582432}
-
Cheng-Yu Lee authored
Bug: 868249 Change-Id: Ie99e4c4ac7738c369a9b54bf2621a2c16dc8bc1d Reviewed-on: https://chromium-review.googlesource.com/1168222Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Cheng-Yu Lee <cylee@chromium.org> Cr-Commit-Position: refs/heads/master@{#582431}
-
Findit authored
This reverts commit b3392d98. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 582403 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2IzMzkyZDk4OGFlMjNkYzUyZDliMzg2YWY0N2RjNmE1M2EyZDIyYzgM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28575 Sample Failed Step: unit_tests Original change's description: > Add vector of intervals range checking to Time Restrictions policy > > * Add function GetEndOfCurrent interval to obtain the last end of the > interval which contains the current time. > * Add function MaterializeIntervalsToLocalTimezone, which materializes > the given intervals to the current local timezone. > * Add function TimeIsInsideCrosSettingsIntervals, which checks if the > current time is inside the intervals set in cros settings. It then > returns the localized string of the end of the interval that contains > the current time. > > BUG=chromium:852860 > TEST=added unittests > > Change-Id: Ife32e31c8a929827fd14ab9f108c49eacb9c32c3 > Reviewed-on: https://chromium-review.googlesource.com/1132676 > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Commit-Queue: Maksim Ivanov <emaxx@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582403} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=chromium:852860 Change-Id: I1663fc559003d938270da4b8fd7e85719b8e9e01 Reviewed-on: https://chromium-review.googlesource.com/1172003 Cr-Commit-Position: refs/heads/master@{#582430}
-
Peter Kasting authored
This reverts commit 5eeadd14. Reason for revert: Seems to have caused failures on mac_cocoa_rel, see e.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8938549477439492256/+/steps/interactive_ui_tests/0/logs/WebViewFocusInteractiveTest.Focus_AdvanceFocus/0 Original change's description: > Remove unnecessary tab key press from Focus_AdvanceFocus test > > The associated bug which required this extra tab is fixed. > > Bug: 147644 > Change-Id: Ied21533accc82613053e119aa2c5c64fc9de8343 > Reviewed-on: https://chromium-review.googlesource.com/1170986 > Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> > Commit-Queue: Kevin McNee <mcnee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582240} TBR=ekaramad@chromium.org,mcnee@chromium.org Change-Id: I6c84e6950d7f74ae5b15eec084a536115e635ceb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 147644 Reviewed-on: https://chromium-review.googlesource.com/1172002Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582429}
-
Yuwei Huang authored
Previously AudioStub is owned by the the (Remoting|Jni)Client class and being passed to ChromotingSession as a WeakPtr. The AudioStub is not used after it is passed to ChromotingSession and it is a burden for the *Client class to manage its lifetime. This CL fixes this by making ChromotingSession own the AudioStub. Bug: 868088 Change-Id: I067f321b3aab7110df7bb85a8b8c519ea889865e Reviewed-on: https://chromium-review.googlesource.com/1171840Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#582428}
-
Findit authored
This reverts commit b092ae62. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 582411 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2IwOTJhZTYyMmI5YWIzODU2ZDY0ZDNlY2E1NDNlNGVjYjI0M2JlNzcM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/7241 Sample Failed Step: ash_content_unittests Original change's description: > chromeos: add SingleProcessMash mode > > This makes Ash create an Env if passed SingleProcessMash. In addition this > makes all window creation go through a factory that ensures the right env is > supplied. > > See https://docs.google.com/document/d/11ha_KioDdXe4iZS2AML1foKnCJlNKm7Q1hFr6VW8dV4/edit > for more details. > > This also adds the feature to ui/base. > > BUG=847992 > TEST=covered by tests > > Change-Id: Ica3c433627222f0e076dddaf19b1ab09168cebeb > Reviewed-on: https://chromium-review.googlesource.com/1168282 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582411} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=847992 Change-Id: I9e2e3c0d92dc7b51f08fa35a2dfacd5ca8af57f2 Reviewed-on: https://chromium-review.googlesource.com/1171706 Cr-Commit-Position: refs/heads/master@{#582427}
-
Julie Jeongeun Kim authored
When 'CreateTooltipWidget' creates 'Widget' for tooltip and initializes it, it needs its bounds at InitParams. If it doesn't have the bounds information, some platform widgets get crashed and DesktopWindowTreeHostX11 keeps |sanitized_params| to avoid this case. This patch delivers the bounds for the tooltip widget and adds DCHECK to find what causes the empty bounds. Bug: 849585 Change-Id: I3de067a917e4343bab642c3a1b13434b6cfaeee0 Reviewed-on: https://chromium-review.googlesource.com/1086820Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#582426}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I4cabb60493cd431bb673a5459e1283c615c6c0ec Reviewed-on: https://chromium-review.googlesource.com/1171982Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#582425}
-
Peter Kasting authored
This reverts commit 3b8db25c. Reason for revert: Checking to see whether this caused https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8938549477343009904/+/steps/content_browsertests_on_Intel_GPU_on_Mac_on_Mac-10.12.6/0/logs/WebRtcAudioDebugRecordingsBrowserTest.CallWithAudioDebugRecordings/0 and similar. Original change's description: > Make //content layer default to --site-per-process mode on desktop. > > After this CL site-per-process is the default in all layers on desktop > platforms, except: > > - Layout Tests which still run with no isolation by default > (see https://crbug.com/856734#c5 for the explanation why) > > - //content embedders that don't want to use site-per-process: //chromecast > > - //content embedders that don't yet support site-per-process, but will > need to migrate eventually: //headless > > > Also note that even after this CL: > > - //content on Android still defaults to no isolation. > This is compatible with not_site_per_process_* test steps > because such steps are not run on Android bots... > > - //chrome layer ChromeContentBrowserClient controls usage of > site-per-process in the Chrome browser and continues to be controlled > by a field trial (note that Android is not covered by the field trial > or by testing/variations/fieldtrial_testing_config.json). > > > Bug: 856734 > Change-Id: Iebd46e5502583f84a4b0a7c2ee8d8b0e081c6ff2 > Reviewed-on: https://chromium-review.googlesource.com/1153981 > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > Reviewed-by: Stephen Lanham <slan@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582223} TBR=thakis@chromium.org,boliu@chromium.org,skyostil@chromium.org,alexmos@chromium.org,slan@chromium.org,lukasza@chromium.org Change-Id: Ieca3a36422b0f90dccc0040eeece799523c954e0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 856734 Reviewed-on: https://chromium-review.googlesource.com/1171705Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582424}
-
Peter Kasting authored
This reverts commit 1e3c1743. Reason for revert: Breaks Mac tests, see e.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8938549477492727648/+/steps/browser_tests_on__none__GPU_on_Mac_on_Mac-10.11/0/logs/TextSuggestionsTouchBarControllerTest.Offset/0 Original change's description: > [Mac] Add Offset to TextSuggestionsTouchBarController Text Selection > > When the text surrounding the current selection gets too long, only > part of it is received by TextSuggestionsTouchBarController. The > location of the received text within the total block of text is > denoted by an offset. Previously, TextSuggestionsTouchBarController > did not take this offset into account, causing crashes when the > selection range was past the end of the received text. > > The offset is passed along with the text and selection range. The > selection range within the received text is calculated using the > offset and received selection range. The editing word range is stored > both as the range within the received text and the range within the > total text for checking when to ignore text selection updates. > > RenderWidgetHostView::GetOffsetForSurroundingText() was added to > retrieve the offset on WebContents update. > > Browser tests were modified to account for the new offset parameter. A > new browser test, TextSuggestionsTouchBarController.Offset, was added > to test that the controller properly handles offsets. > > Bug: 717553 > Change-Id: I6dce1405fd5c115ca6ddfdbe4157faf75ccc3a6c > Reviewed-on: https://chromium-review.googlesource.com/1169597 > Commit-Queue: Tessa Nijssen <tnijssen@google.com> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Sarah Chan <spqchan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582205} TBR=avi@chromium.org,spqchan@chromium.org,tnijssen@google.com Change-Id: If0acdd0494b5270c4b4e221e16b8e901ce2cacc3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 717553 Reviewed-on: https://chromium-review.googlesource.com/1171704Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582423}
-
Ned Nguyen authored
This also add this check to PRESUBMIT perf_json_config_validator script Bug: 873389 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I16fd762e567d5a41d75a221456e12e14a03f0b85 Reviewed-on: https://chromium-review.googlesource.com/1171578Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#582422}
-
Wez authored
Bug: 808287 Change-Id: Ic699462759818049666babb0587939e4ca687643 Reviewed-on: https://chromium-review.googlesource.com/1167555Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#582421}
-
Stephen Martinis authored
They seem to need longer timeout for now. Hopefully will be temporary. TBR=bpastene Bug: 853248 Change-Id: I6665013085631c69e6d78fe1f43f195e12d3295c Reviewed-on: https://chromium-review.googlesource.com/1171909Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#582420}
-
Peter Kasting authored
Bug: 622387, 871692 Change-Id: Ie03b640422b120d903ca56bf9f0650a1ffc23065 TBR: mgiuca Reviewed-on: https://chromium-review.googlesource.com/1171852Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582419}
-
Yafei Duan authored
Implement live page sharing: - Adding a new temporary client namespace for the usage of live page sharing, which has a limit of one page per url and expiration period as one hour. - Adding saveAndSharePage in OfflinePageUtils, implementing the workflow of save page, get page and share page. Bug: 870895 Change-Id: Iab5f074dfa955ba30f8b125a70cedb87e8610246 Reviewed-on: https://chromium-review.googlesource.com/1162827Reviewed-by:
Peter Williamson <petewil@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#582418}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4eac21fee047..f3ca1c6abb07 git log 4eac21fee047..f3ca1c6abb07 --date=short --no-merges --format='%ad %ae %s' 2018-08-10 brucewang@google.com Implement FreeType COLR/CPAL support. 2018-08-10 timliang@google.com fixed the size in bytes of vec3s to match Metal standard in Metal gpu backend 2018-08-10 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-10 timliang@google.com only set color index if using dual source blending in Metal gpu backend 2018-08-10 kjlubick@google.com [PathKit] Add various path effects 2018-08-10 mtklein@google.com clean up SK_LEGACY_CONVERT_PIXELS_IMPL 2018-08-10 caryclark@skia.org fix text blob example errors 2018-08-10 caryclark@skia.org fix bookmaker check for enum size 2018-08-10 liyuqian@google.com Reland "Update ShouldUseAAA with our better complexity estimation" 2018-08-10 timliang@google.com enabled gms and most unit tests for Metal gpu backend 2018-08-10 mtklein@google.com switch ubsan to blacklist 2018-08-10 bungeman@google.com Change generateAdvance to never chain. 2018-08-10 caryclark@skia.org refresh generated includes 2018-08-10 fmalita@chromium.org [sksg] Simplify ScopedRenderContext 2018-08-10 caryclark@skia.org new batch of docs 2018-08-10 timliang@google.com implemented GrMtlGpuCommandBuffer for draws in Metal gpu backend 2018-08-10 mtklein@google.com add bounds sanitizer to ASAN/UBSAN bots 2018-08-10 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader dd662d210afc..c47cd435bf6f (1 commits) Created with: gclient setdep -r src/third_party/skia@f3ca1c6abb07 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: I5274deea227ad59efbb4157cf2401fcc016ae264 Reviewed-on: https://chromium-review.googlesource.com/1171445Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582417}
-