- 03 Dec, 2019 40 commits
-
-
Fritz Koenig authored
Uses multiple overlays to display rectangles. BUG=none TEST=ozone_demo --enable-overlay=2 Change-Id: Ic6cb683dbc043744597261fe15c711e09390ef46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922705 Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Auto-Submit: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#721091}
-
Ce Chen authored
Bug: 925072 Change-Id: I8929e0bcdd89009320a35cb3c95d4daa349cb6ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946458Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Ce Chen <cch@chromium.org> Cr-Commit-Position: refs/heads/master@{#721090}
-
Sahel Sharify authored
This cl removes stubs from PaymentApp and PaymentInstrument classes as well as payment_handler_host.mojom This should get landed after the dependnet Clank cl gets merged: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2255260 Bug: 984694 Change-Id: I03972ab75d7c4f33b644ebf77a9ef2618ef07921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946457Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#721089}
-
Pavel Yatsuk authored
BUG=1028382 R=dtrainor@chromium.org,mdjones@chromium.org Change-Id: I241391133850a23b2dd63193a4949889d45c9ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938027 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#721088}
-
Scott Violet authored
This is what chrome/content do to ensure the keyboard doesn't occlude any web content. BUG=1029720 TEST=test only change Change-Id: Ib12f5b5fbd5a9cca6415451413ab400c7f03aeb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948323Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#721087}
-
Sky Malice authored
Bug: 1027246 Change-Id: Ia5f47b53b502dc98ef65d4f65f9e933ab73b2330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928204Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#721086}
-
Dominique Fauteux-Chapleau authored
Change-Id: I5b1132e596225950efc889494c8221ed8cce45ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948229 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#721085}
-
Kamila authored
Changes the highlight of the indicator when a promo is shown, to mimic being focused/hovered rather than clicked. This is done according to recommendation from UX to achieve a lighter shade of the background color (promo is showing) in contrast to a darker shade (when the bubble opens). This change provides the user with subtle visual feedback. Bug: 986737 Change-Id: I6238548c74fcb0027c0f9a105fc9c769a23c052a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948929Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#721084}
-
David Black authored
The proactive suggestions entry point times out after a fixed interval. When the entry point is hovered over, timeout is paused. ProactiveSuggestionsRichView is not currently pausing timeout on hover because the embedded web contents consume the events causing mouse enter/exit to not be received by the embedding view. To fix this, we'll use an EventMonitor on our views native window to make sure we get the events we need to detect hover state. Bug: b:145056104 Change-Id: I2588fe119addfe9577963d4c29baf566e9168336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938448Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#721083}
-
Juan Antonio Navarro Perez authored
Story tags were being mixed up into platforms. Bug: 1029042 Change-Id: I33627111e3821c64b4f7a7970265337ae44d91cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948834 Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#721082}
-
Lei Zhang authored
Change-Id: I166725c025a6fa186ad011d0b542769c1d351b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947421Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#721081}
-
Mike Dougherty authored
This reverts commit 944d38d2. Reason for revert: iOS build fails when RLZ is enabled. ios/chrome/browser/rlz/rlz_tracker_delegate_impl.h also needs to be updated to this new signature. crbug.com/1030223 Original change's description: > Convert base::Bind and base::Callback in components/rlz to Once/Repeating > > Bug: 1007725 > Change-Id: Ie9ce62d0775094cba94261d95853e4fe9dc19376 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935649 > Commit-Queue: Ayu Ishii <ayui@chromium.org> > Reviewed-by: Roger Tawa <rogerta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720626} TBR=rogerta@chromium.org,ayui@chromium.org Change-Id: Ia083d7ba2d272af221feaab1e415f786d2548e46 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1007725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949080Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#721080}
-
John Delaney authored
This change disables triggering of the heavy ad intervention on pages that are the result of a user reload(referred to as reloads). This also records in UMA whether we ignored a potential intervention due to this logic. This change simply disables the intervention on all reloads rather than on reloads where the intervention occurred on the prior page. This type of logic would require persisting information across page loads and adds a lot of complexity for marginal gain, as only ~5% of pages are reloads. UMA metrics, such as ComputedType are still recorded on reloads, even though these ads are technically not eligible for intervention. The added metrics, PageLoad.Clients.Ads.HeavysAds.IgnoredByReload is recorded prior to querying the blocklist on a site, meaning that we may record ignore in scenarios where the intervention may not have triggered. Bug: 1028248 Change-Id: I4b0abce4172c7ad295885a4ce82b1d928ae33f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932175Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#721079}
-
Benjamin Beaudry authored
This change makes accessible list item markers when using LayoutNG. Before this change, Windows ATs would not read aloud the list item markers but would read the list item content. On windows, the AXTree looked something like this: // <li>item 1</li> --ListItem ----ListMarker"1." ----StaticText"item 1" ------InlineTextBox"item 1" Now, we also read the list item markers. We expose a StaticText node under the list marker node and made the list marker a generic container instead of a text node. On Windows, the AXTree now looks like this: // <li>item 1</li> --ListItem ----Group ------StaticText"1." --------InlineTextBox"1." ----StaticText"item 1" ------InlineTextBox"item 1" We intentionally don't support the Legacy layout. Bug: 1015100 Change-Id: Ie9f4a254a55b459f59367d3a1512c12a57bfac1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880017 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Adam Ettenberger <adettenb@microsoft.com> Cr-Commit-Position: refs/heads/master@{#721078}
-
Ana Salazar authored
This reverts commit 61668118. Reason for revert: Still crashing flaky tests (All/ShelfLayoutManagerTest.NoShelfUpdateDuringOverviewAnimation/1) Original change's description: > Cros: Reland "Add metrics for transitions in the hotseat" > > Report animation smoothness for the transition into the hotseat in the > HomeLauncher. > > The original change caused use-of-uninitialized-value flaky tests. This > is a possible fix for the issue by explicitly resetting the > |animation_metrics_reporter_| > > Bug: 1022178, 1022177, 1028255 > Change-Id: I9abe9532e4f8b8cbc8c3700b21db48144f76f767 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940562 > Reviewed-by: Manu Cornet <manucornet@chromium.org> > Commit-Queue: Ana Salazar <anasalazar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720619} TBR=manucornet@chromium.org,anasalazar@chromium.org Change-Id: I0989a28c010ad5c28c6d6a45c49d3a924e8acdb1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1022178, 1022177, 1028255, 1030222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949070Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#721077}
-
Daniel Rubery authored
This change adds a status field to the malware deep scanning verdicts, as well as the logic needed to use this status field. Fixed: 1028256 Change-Id: I1d9cab0ea002dd5c03ff7063a472e904abce66ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935042Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#721076}
-
John Chen authored
Add a little delay between creating <div> and sending touch events, to avoid flakiness. Bug: 1011225, 1030260 Change-Id: I2075ff32ef8324194d1d8e2a6d6b68e644290f9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948492 Auto-Submit: John Chen <johnchen@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#721075}
-
Collin Baker authored
When a new window is opened in touch mode, or any windows switch to touch mode, the tab strip starts open. Fixed: 1028384 Change-Id: Ie50c4df7725ebe4841d29ba84382638418df2f2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941057 Commit-Queue: Collin Baker <collinbaker@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#721074}
-
Erik Chen authored
The test suite has 10 minutes of real work, and 4 minutes of per-shard overhead. By using 2 shards, we keep total runtime at 9 minutes, without wasting too many resources on overhead. Change-Id: Idcf5acc332845547229caf2cf2005c2db6fc0d2b Bug: 1030341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933384 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#721073}
-
Yue Zhang authored
Right now when Duet and GridTabSwitcher are both turned on, the bottom toolbar shows at the top of the screen in landscape mode. This CL changes this behavior so that in landscape mode, we keep showing the original top toolbar for GridTabSwitcher instead of the Duet bottom toolbar. So far the change is only visible when Duet and GTS are both turned on and TabGroups is turned off. Bug: 1012014 Change-Id: Ia6c6ed5dddfccb33c4b51374f483e60dda99fb84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929352 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#721072}
-
Joe Mason authored
The previous solution can only capture logs after the child process creates a ScopedLogging object. We see flaky crashes in sandbox creation that happen before that so this will let us see the child process stack traces. Also moves some functions that were exported from ipc_test_util.h to be private to proto_chrome_prompt_ipc_unittest.cc, which is the only test that still uses them. Bug: 1030333 Change-Id: Ie30eed3b16631721e81a420b3b70f1ec5f0d9a0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948483Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#721071}
-
Nico Weber authored
Bug: 999871 Change-Id: I04f7bcff1ed4ff7c17573980301647a64b29836d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947474 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#721070}
-
Lachlan Ford authored
The RETURN_IF_XR_FAILED macro previously required a local variable to already exist for it to function correctly. This change removes that requirement. Change-Id: Ib0ebb5855abfe8788f906235d2bec95b13eb6655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934394 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#721069}
-
Mei Liang authored
This CL adds accessiblity strings for closing suggestion. In addition, it updates description for other closing suggestion related strings. Change-Id: Ie3c87ae4b91273a818b8b8950e59ca7b9c284709 Bug: 1004570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935045 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#721068}
-
minch authored
The back gesture kSwipingFromLeftEdgeToGoBack feature is disabled by default, and is only enabled on the devices that has hotseat feature enabled (i.e., on Krane and on Dogfood devices). Bug: 1030122, 1002733 Change-Id: Ie6fed45ff8df7113bc86923c23ac9e581da64937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947947Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#721067}
-
Kurt Catti-Schmidt authored
There is a bug that text selections cannot be expanded via keyboard shortcuts (i.e. control+shift+down) with Narrator running. This is because Narrator intercepts the keyboard shortcuts and instead performs selections via UIA. When GetSelection was implemented, we followed a restriction that is visible in Edge and Inspect, where no selection was reported if it spans multiple nodes. It turns out that this is not entirely true - a selection will be reported that spans multiple nodes if the text range originally spanned those nodes. This appears to be a side-effect or bug that isn't anywhere in the UIA spec. Rather than attempt to model this behavior more exactly, this change simply removes the cross-node restrictions on GetSelection entirely, which fixes Narrator's text selection issues. Bug: 1029901 Change-Id: Ifad1ae4f4bd48122bffd44bfbd974e8de96b7493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946983Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#721066}
-
Ben Pastene authored
This reverts commit 9f51fb75. Reason for revert: internal linux builds broken with "no member named 'start_hidden' in 'base::LaunchOptions'" from https://ci.chromium.org/p/chrome/builders/ci/linux-google-rel eg: https://ci.chromium.org/p/chrome/builders/ci/linux-google-rel/13653 Original change's description: > Refactor the recovery component action handler for Windows. > > This CL refactors the implementation of the recovery component action > handler for Windows so that most of the code can be reused in the > future for macOS recovery component. It also adds a unit test. > > Bug: 1029953 > Change-Id: Iead0b562ae311560b3ca0eacd8d417bedd007331 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946020 > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Commit-Queue: Sorin Jianu <sorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721041} TBR=sorin@chromium.org,waffles@chromium.org Change-Id: I9cac86b0150217bc5e10915b4f54ce4a72365d08 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1029953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949071Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#721065}
-
Michael Crouse authored
This change records the duration of successfully evaluating a prediction model. No timing is recording if the evaluation fails or a cached result is used. Bug: 1001194 Change-Id: I73b1f11cdfb7c9cbc4759e4de13b182c6e2e0b66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946926Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#721064}
-
Alex Gough authored
These pipes were used by Inter-Module Comms (IMC) but this was disabled some time ago. (see https://crbug.com/nativeclient/3864) Bug: 1023583 Change-Id: I8c6c573d32d6a7fff2218b8a3739d66684665185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934867Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Mark Seaborn <mseaborn@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#721063}
-
Dominic Battre authored
Chrome contains Autofill{CreditCard,Profile}Enabled and {CreditCard,Profile}AutofillEnabled function calls. This CL unifies them to the former. This CL does not modify the CWVPreferences interface on iOS because that's a public interface. Bug: 1027122 Change-Id: Iba26414d7ba9635ab2c2b9aa9f4e2d2cfb44a61e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929233Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#721062}
-
Avery Musbach authored
The present CL fixes what happens if you switch to tablet mode when the following criteria are met: 1. There are at least two displays. 2. There is only one window. 3. The window is active. 4. The window is snapped on the primary display. Without the present CL, NOTREACHED is hit (Issue 1024309), and there is also a crash if DCHECKs are disabled (Issue 1024325). Fixed: 1024309, 1024325 Change-Id: Ie1a6e378067076c7dbd8ec3ed388e70cd9382611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938463 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#721061}
-
Dave Tapuska authored
Move the sudden termination enumeration to mojo and move the message to be transported on the LocalFrameHost mojom interface. BUG=1008432 Change-Id: I090df4df1e53b8dc5f4173e917a72d6bd1d33225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928048 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#721060}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8c0012bc5c16..a002a375f2cc git log 8c0012bc5c16..a002a375f2cc --date=short --first-parent --format='%ad %ae %s' 2019-12-03 rslawik@google.com Merge "Cleanup: remove deprecated fields" 2019-12-03 lalitm@google.com Merge "trace_processor: don't reset ion memory counters" 2019-12-03 lalitm@google.com Merge "trace_processor: cleanup ugly double function call to get col by name" 2019-12-03 primiano@google.com Merge "Remove some other libprotobuf deps from perfetto cmdline client" Created with: gclient setdep -r src/third_party/perfetto@a002a375f2cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3c9e7d7869db728062873b17ff3c2ef211e9ee33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948983Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721059}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7b9a9186c365..4b6a26740234 git log 7b9a9186c365..4b6a26740234 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 changhaohan@chromium.org Leverage CDP error signal for timezone emulation 2019-12-03 aerotwist@chromium.org Migrates js_main/ to esm Created with: gclient setdep -r src/third_party/devtools-frontend/src@4b6a26740234 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I49affd5ee94615497c04148a5a75c01f792e2003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948970Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721058}
-
Dave Tapuska authored
With change http://crrev.com/c/1659011 the secure state was incorrectly passed always as true into origin trials. While this shouldn't matter because origin trial tokens have not been issued for insecure origins in the pastthat is being experimented with and I was alerted to the oversight in my CL. This change moves the initialization of the SecureContextState after the origin is determined but before origin trials are initialized. BUG=970360 Change-Id: I8001f15d8e6ffac6d4b043f1f35529fece9977ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940561 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#721057}
-
Friedrich Horschig authored
Unfortunate timing may lead the threshold calculation to request a height for an internal state (e.g. calling expand() right after requestShowContent() before the animation finishes). Transition from/to internal states should always succeed, so consider a threshold cleared if one of the states in transition is internal. Bug: 1028783 Change-Id: I8650845c23e1ba9f13fd8c79c7e021637d824777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939414 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Auto-Submit: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#721056}
-
Vasilii Sukhanov authored
Bug: 986298 Change-Id: I18c57d1987c64b5c303a02ffb8097d9b011b313f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948896 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#721055}
-
Trevor Perrier authored
This CL adds the list android_bundle_locales_as_resources which formats all locales for .xml resource outputs. It then uses this new list in all the android output list in all build targets that used have .xml outputs. In addition the following two .grd files were missing .xml outputs for the most recently added locales on Android. And these were updated. - chrome/android/features/keyboard_accessory/internal/java/strings/ android_keyboard_accessory_strings.grd - chrome/browser/touch_to_fill/android/internal/java/strings/ android_touch_to_fill_strings.grd No new locales were added to apk bundles. Bug: 812837 Change-Id: Ib9587def0aceb6894b27a8b3dc39ce920c768377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940949 Commit-Queue: Trevor Perrier <perrier@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#721054}
-
Armando Miraglia authored
To reduce the risk of issues by posting WTF::String objects, this CL postpones the conversion to when the result is available in std::string rather than before posting the closure. Bug: 1028536 Change-Id: I6560f788d76973551f66041af7abe85965cddd54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944674 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#721053}
-
Dominic Farolino authored
Current spec discussion is heading in the direction of ultimately not considering a request's initiator origin when determining the referrer, and instead preferring Chrome's old behavior. We need a resolve by the branch point (12/05), so this CL preemptively reverts, for the last time, the previous referrer changes introduced in crrev.com/c/1808663, restoring the referrer-computing logic in //net and Blink to the original behavior. A future CL will change the WPT expectations so that Chrome passes the tests, since it seems we will change the spec to match Chrome's old behavior here. R=yhirano@chromium.org TBR=caseq@chromium.org,kinuko@chromium.org,lizeb@chromium.org Bug: 1021908 Change-Id: I9ffeb3e3982b141a101242d2fc7004b753a6e681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946861Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#721052}
-