- 30 Sep, 2019 40 commits
-
-
Dan Harrington authored
These directories were created automatically, and should be ignored Change-Id: I34bfc68c9f002523f52295b2d358cf3cbe66574a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830109Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#701323}
-
Manu Cornet authored
Bug: 982511, 1009525 Change-Id: Iaa4b571c9ed8db5e0317f27096053c48ab5149a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832622Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Auto-Submit: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#701322}
-
Xinghui Lu authored
Text typed through dedicated number bar on Android keyboard is not captured through ImeCommittedTextEvent. Instead, it is captured through OnInputEvent with event type kKeyDown. Ideally there is no overlap between InputEvent and ImeCommittedTextEvent, if KeyDown event is triggered, ImeCommittedText event should not be triggered, and vice versa. Bug: 1006430 Change-Id: I366e87e80cf0741c209b67eb972df4f507b94bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824059Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#701321}
-
Shakti Sahu authored
This CL cleans up : 1- An unused feature : DownloadHomeShowStorageInfo which was used in download home v1 to toggle storage info button. 2- The flag DownloadHomeV2 3- The feature DownloadHomeV2 and its usage. 4- Some unused code cleanup in DownloadFilter.java Bug: 850608 Change-Id: I6c4d3cb84a54e512a51d0d51ce974d7a38324612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826996Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#701320}
-
Jon Mann authored
This reverts commit 465e6173. Reason for revert: Breaks build Original change's description: > tools/metrics/histograms/extract_histograms.py: Python 3 support > > Example error: > Traceback (most recent call last): > File "../../tools/metrics/histograms/generate_expired_histograms_array.py", line 14, in <module> > import extract_histograms > File "C:\Google\chromium\src\tools\metrics\histograms\extract_histograms.py", line 60, in <module> > import HTMLParser > ModuleNotFoundError: No module named 'HTMLParser' > > Also fixed deprecation warnings: > C:\Google\chromium\src\tools\metrics\histograms\extract_histograms.py:150: DeprecationWarning: The unescape method is deprecated and will be removed in 3.5, use html.unescape() instead. > return HTMLParser().unescape(line) > ...C:\Google\chromium\src\tools\metrics\histograms\extract_histograms_test.py:481: DeprecationWarning: Please use assertEqual instead. > self.assertEquals('This is a summary with & and " and \'', > > The changes are backwards compatible. > > Bug: 941669 > Change-Id: Ieb22e72b37ec26886f3ca1341e487be4f0ba3ab1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830657 > Auto-Submit: Raul Tambre <raul@tambre.ee> > Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701265} TBR=asvitkine@chromium.org,raul@tambre.ee Change-Id: Ie6f8b307af54bd3d0ca347efef8908d013416879 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 941669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830287 Commit-Queue: Jon Mann <jonmann@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Jon Mann <jonmann@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#701319}
-
Eric Karl authored
Logic which applies de_jelly_delta_y in SurfaceAggregator. Handles clipped / rounded_rect quads by promoting them to a render pass and skewing the resulting render pass. Bug: 995965 Change-Id: I2ddbc4333593252eb6dc0d678b1b3d1d863678e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819641 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#701318}
-
Etienne Bergeron authored
This CL is lifting out the FcPattern accessors to the fontconfig_util file. It is also adding the unittests related to that code. The goal of this refactoring is to share the accessors with the new fallback font caching algorithm. R=robliao@chromium.org Bug: 1008531 Change-Id: Ib8d0ec9ef2ec93b91247595f7b03613d640ade80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830059 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#701317}
-
liberato@chromium.org authored
Test is flaky. Bug: 1009673 Change-Id: I1f80d9b4ff4e201182284d7004838da0bffec188 TBR: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830111Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#701316}
-
chromium-autoroll authored
Roll airmont AFDO profile from 79-3903.0-1569234053-benchmark-79.0.3923.0-r1 to 79-3904.19-1569838411-benchmark-79.0.3923.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I3ee29bd0ff9df5ef768bd9720cfaf2f79333a9d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832821Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701315}
-
John Williams authored
Setting DesktopMediaPicker::Params::select_only_screen to true allows the desktop picker dialog to be bypassed in the case where the user is asked to select a screen and there is only one screen available. Bug: 637643 Change-Id: I3a5ce311e4c0e63d1a9fd2eae1c7388056beb51b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669775 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#701314}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d58f380d..f85c9327 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6a7704ddcbd5cb31646f6fab4dbdec5fe7a34cc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831560Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701313}
-
Mario Sanchez Prada authored
This CL migrates code to the new BrowserInterfaceBroker class for the TextDetection, BarcodeDetectionProvider and FaceDetectionProvider mojo interfaces. This allows retrieving the remote implementation from the renderer process without relying on FrameClient's InterfaceProvider. Bug: 955171, 978694, 936482 Change-Id: I8772caa7877bc9d5ee14043dba87c59a4e9fbd77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826782 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#701312}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 79-3903.0-1569232734-benchmark-79.0.3923.0-r1 to 79-3903.0-1569840015-benchmark-79.0.3923.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: Id58dced7e805344a11f47d90bd7179300365e6de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832764Reviewed-by:
-
chromium-autoroll authored
Roll silvermont AFDO profile from 79-3904.12-1569231291-benchmark-79.0.3923.0-r1 to 79-3904.19-1569836348-benchmark-79.0.3923.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I697bffcc9e79dfa4fd2597147ddd4600ad9780a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831596Reviewed-by:
-
Andrey Kosyakov authored
We do collect stacks often, so having v8_enable_lazy_source_positions on leads to everything being parsed twice. Change-Id: Id37340cb7f423672e89e204db20f9101b1c63082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829573Reviewed-by:
Johannes Henkel <johannes@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#701309}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2a301a6d. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ic1282b8faf7e32406adfc5dd8d9b697c9e720045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832118Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701308}
-
Eric Stevenson authored
This CL was partially created by //base/android/jni_generator/jni_refactorer.py. The conversion also required converting unit tests to use the new JNI mocking approach provided by JniMocker. Bug: 929661 Change-Id: If47b5ba988f61e4b179d483fb0073e11f0d50992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831416Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#701307}
-
liberato@chromium.org authored
Continuing to fail even after being marked 'Slow', so perhaps it's just plain flaky. Bug: 1003715 TBR: rockot@chromium.org Change-Id: I1cdd747b59976929e85a0689d32848d5ea6cc648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830110 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
-
rbpotter authored
This namespace is leftover from the old Print Preview JS code, is no longer needed to disambiguate anything, and makes enum names unnecessarily long. Remove it and move the enums to the general "print_preview" namespace. Bug: None Change-Id: Iaf43f4f514b0a4332e8b0e7157bf75cf731ecaf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832621Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#701305}
-
Rouslan Solomakhin authored
Bug: 966507, 980641, 971339 Change-Id: I2ef7c051ba8b2cd9c6cc952743bfb3a55ab623ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774322Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#701304}
-
Amr Aboelkher authored
A device policy which controls the keyboard focus highlight accessibility feature on the login screen.The policy can be applied as a recommended or mandatory policy. Test: 1. Set the login_screen_keyboard_focus_highlight_enabled policy to True, open System Tray => "Accessibility", check that "Highlight object with keyboard focus" is displayed with a green check in the login screen. 2. Set the policy to False, open System Tray, check that "Highlight object with keyboard focus" is not displayed in the login screen. Bug: 552439 Change-Id: Id640c6ba9aab7913c17e3ea43bc9c74d945c4a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826791 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#701303}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Ifca3232d3a8ba06635c2326f20f7f4ae931e069e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832322Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#701302}
-
Patrick Monette authored
This ensures that profiles created by the IndependentOTRProfileManager class triggers both NOTIFICATION_PROFILE_CREATED and NOTIFICATION_PROFILE_DESTROYED. Change-Id: Ie62b994ed7a02790c30331f9fb0053d1e9f38c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812002Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#701301}
-
Alex Newcomer authored
Handle the case where scrollable shelf is disabled. Bug: 1009609 Change-Id: I97c82661bd32b4355e3ed4664c6c2424f1dd2276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832683 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#701300}
-
Anthony Vallee-Dubois authored
This reverts commit 544877a2. This patch changes the way the double translation issue that was happening during auto-translate is fixed. Instead of reordering calls in TranslateManager and checking if a translation is already in progress, this stops the bubble from observing actions in the UI when they are triggered programatically. As a result, the fix is more self-contained and shouldn't affect iOS tests anymore. Original change's description: > Revert "Add Field Trial Config for translate UI refresh" > > This reverts commit 24ddb486. > > Reason for revert: broke ios full_configs bot: > https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-full-configs/18443 > https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-full-configs/18444 > > Original change's description: > > Add Field Trial Config for translate UI refresh > > > > Bug: 976352 > > Change-Id: I9e125f2a7d2dfe24691e8097623cbc65866fe353 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796002 > > Reviewed-by: Alexandre Frechette <frechette@chromium.org> > > Reviewed-by: Jesse Doherty <jwd@chromium.org> > > Commit-Queue: anthonyvd <anthonyvd@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#695796} > > TBR=jwd@chromium.org,anthonyvd@chromium.org,frechette@chromium.org > > Change-Id: I5f43ca5c2d623815d45b171efd91b9e70342c38a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 976352 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799628 > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#695895} TBR=jwd@chromium.org,justincohen@chromium.org,anthonyvd@chromium.org,frechette@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 976352 Change-Id: Ia458f36227792dd87b2a0624cae79ab81c0e1c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829572Reviewed-by:
Alexandre Frechette <frechette@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#701299}
-
Daniel Hosseinian authored
This is the last step before rolling out the feature to 100% stable. Experiment results may be found on the issue. Bug: 931719 Change-Id: Ibd9cbeea735066e57e61a0fa8853b8b2a8ad737e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832299Reviewed-by:
-
Eric Orth authored
Bug: 1006902 Change-Id: Ib57ad8fe5d296c5fe5b5aac8db12b783fd79ddb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827774 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#701297}
-
Tsuyoshi Horo authored
We are implementing "Navigation to Bundled Exchanges". Design doc: https://docs.google.com/document/d/1Bulrd7E1lFZyPfRFIXP3vNMOM9FX-kWJOCxMOeR8pAQ/view# Demo movie: https://www.youtube.com/watch?v=rs-3R0ji6dA To open the Bundled Exchanges files on Android from other applications, we need to add intent-filters in AndroidManifest.xml. The first intent-filter is for the applications which can't detect the "application/webbundle" mime type. (eg: Open .wbn file from "Internal Storage" in Files app.) We use pathPattern to capture the ".wbn" file extension. But due to the strange behavior of intent filter's pathPattern [1], we need to have multiple patters to load the .wbn files under folders which name contains ".". [1] https://stackoverflow.com/questions/51912180/strange-intent-filter-pathpattern-behaviour The second intent-filter is for the applications which can detect the "application/webbundle" mime type. (eg: Download the Bundled Exchanges file with "content-type: application/webbundle" header, and open the file from "Download" category in Files app.) We don't have plan to ship this feature in Beta and Stable yet. So this CL uses "{% if channel in ['dev', 'canary', 'default'] %}" not to change the AndroidManifest.xml for Beta and Stable. Bug: 995177 Change-Id: I754ca1c74f5bc56d17462cde9d5bd764671c849b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811405Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#701296}
-
Yue Zhang authored
* Expose two more observer calls of TabGroupModelFilter.Observer. * Introduce TabGroupTitleEditor as an abstract class and specify the logic about when to delete stored titles. Bug: 1001738 Change-Id: I0e915582c50bb7a900d2464f3fbd03d1a173a47f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825459 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#701295}
-
James Cook authored
Add them to OSSettingsPageTest.AllJsTests. Rework the existing test slightly to directly query for sections with the specified name using CSS selectors, rather than using JS code to look things up. Bug: 967896 Test: browser_tests Change-Id: Iac51bae17cfa2e8d2ccb9d4d3cc449a59dee8e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831949Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#701294}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7d6c98f10423..9ee7f7856b07 git log 7d6c98f10423..9ee7f7856b07 --date=short --no-merges --format='%ad %ae %s' 2019-09-30 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@9ee7f7856b07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I114dab75995e10621f5348680c2d90933b7ccfa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832050Reviewed-by:
-
Sophie Chang authored
This should reduce the page loads that have blacklist unavailable eligibility reasons for commit-time previews. Bug: 905088 Change-Id: I2350706637e2d0b37cc07d3ac9325137143164a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831276Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#701292}
-
Raul Tambre authored
Fixed errors: Traceback (most recent call last): File "../../tools/metrics/histograms/generate_expired_histograms_array.py", line 293, in <module> sys.exit(main()) File "../../tools/metrics/histograms/generate_expired_histograms_array.py", line 289, in main _GenerateFile(arguments) File "../../tools/metrics/histograms/generate_expired_histograms_array.py", line 241, in _GenerateFile header_file_content = _GenerateFileContent( File "../../tools/metrics/histograms/generate_expired_histograms_array.py", line 217, in _GenerateFileContent expired_histograms_map = _GetHashToNameMap(expired_histograms_names) File "../../tools/metrics/histograms/generate_expired_histograms_array.py", line 158, in _GetHashToNameMap hash_to_name_map[_HashName(name)] = name File "../../tools/metrics/histograms/generate_expired_histograms_array.py", line 151, in _HashName return "0x" + hashlib.md5(name).hexdigest()[:16] TypeError: Unicode-objects must be encoded before hashing C:\Google\chromium\src [expired_histograms]> .\tools\metrics\histograms\generate_expired_histograms_array_unittest.py File "C:\Google\chromium\src\tools\metrics\histograms\generate_expired_histograms_array_unittest.py", line 96 base_date = datetime.date(2000, 10, 01) ^ SyntaxError: leading zeros in decimal integer literals are not permitted; use an 0o prefix for octal integers C:\Google\chromium\src [expired_histograms]> .\tools\metrics\histograms\generate_expired_histograms_array_unittest.py File "C:\Google\chromium\src\tools\metrics\histograms\generate_expired_histograms_array_unittest.py", line 132 self.assertEqual(base_date, datetime.date(2010, 01, 01)) ^ SyntaxError: leading zeros in decimal integer literals are not permitted; use an 0o prefix for octal integers The changes are backwards compatible with Python 2. Bug: 941669 Change-Id: I1f1dbedd8f55737fec20f7ae82e97bd140637ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829204 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: -
Samuel Huang authored
We will add ~45 DevUI pages to the DevUI DFM. Each of these has an "atomic" PAK file, and an entry in the main resource_ids file. This CL rearranges existing items in the main resource_ids file in preparation: * Move bluetooth_internals and usb_internals resources to a new section: "/chrome WebUI section". * Extract ios/web/ section from ios/ section, since there's a restriction for ios/web/ to start from same IDs as content/. * Move content/ section between ios/ and ios/web/. This order makes it easier for semi-automated tools to extract structure. Bug: 927131 Change-Id: I35b32a88f56cfd4437a9bd66fda08e1156fc7d97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832443Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2e80cf9d91ab..087f1384f233 git log 2e80cf9d91ab..087f1384f233 --date=short --no-merges --format='%ad %ae %s' 2019-09-30 jmadill@chromium.org Vulkan: Introduce CommandQueue helper class. Created with: gclient setdep -r src/third_party/angle@087f1384f233 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: None Change-Id: I36b69ed92d69f8979ff6f5978ca33c3e8f16fdcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832245Reviewed-by:
-
Adrian Taylor authored
Clarifying documentation to make it clear that a disabled feature does not necessarily result in Security_Impact-None. Also, bringing note on Sheriffbot behavior up to date. R=cthomp@chromium.org, nasko@chromium.org Change-Id: I6073b579dc490e8dd67e0faf240ad8232cb58af4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829743 Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#701288}
-
Dan Harrington authored
Change-Id: I628b4ae3bc43c11764c64ba537491ae2d77fee0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809503 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#701287}
-
Jaeyong Bae authored
This is a reland of Ie6bc51cf71f82228df32db551489bf66168a54e6 OnAddressListChanged, OnCreditCardsChanged Instead it should have a single OnPersonalDataChanged call Bug: 923868 Change-Id: I08f99ddaadffb84bfb9fd6fb8584313fbf10a9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631451 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
-
zhaoyangli authored
Added a flag to |ChromeTestCase| class to indicate whether +setUpForTestCase has been executed in a test case, preventing +setUpHelper from being called twice after one relaunch during test case set up. Bug: 1008495 Change-Id: I6f7b6fbda5d2fb08c98d6a61a66043852587f86c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828076 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#701285}
-
David Tseng authored
Change-Id: I5af333c9554762e332999450fba1b432920e305f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825104Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#701284}
-
