GitLab

Only track http and https in duplicate resource handler metrics. Specifically, exclude data and blob urls because they can be generated by content. This avoids a slow leak with generated URLs.

R=gavinp@chromium.org,frankwang@google.com
BUG=114570

Review URL: https://chromiumcodereview.appspot.com/10824236

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151452 0039d316-1c4b-4281-b951-d872f2087c98

BUG=142336


Review URL: https://chromiumcodereview.appspot.com/10832273

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151451 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=gman@chromium.org
TBR=nfullagar@google.com

Review URL: https://chromiumcodereview.appspot.com/10829307

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151450 0039d316-1c4b-4281-b951-d872f2087c98

Sometimes the next perf test would try to start the http server,
but the port wouldn't be available. This matches what we do on Linux.

In the long run, we should use a random port to avoid having to wait.

BUG=29228


Review URL: https://chromiumcodereview.appspot.com/10834299

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151449 0039d316-1c4b-4281-b951-d872f2087c98

Changes to the UI to bring it closer to the mocks:
- Add cookies section to Permissions tab, and add "Cookies" and "Permissions" headers.
- Change identity status text to green when the site identity is verified.
- Add permission icons to the Permissions tab.

BUG=135407

Review URL: https://chromiumcodereview.appspot.com/10831280

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151448 0039d316-1c4b-4281-b951-d872f2087c98

This is part of Chrome for Android upstreaming.

It affects how long our side of an idle TCP socket can know the other end has
closed the connection. The default value is 2 hours which is too long. We
should use the same values on Linux.

BUG=136750


Review URL: https://chromiumcodereview.appspot.com/10831286

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151447 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136519
TEST=browser_tests --gtest_filter=SystemInfoCpuApiTest.*


Review URL: https://chromiumcodereview.appspot.com/10830240

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151446 0039d316-1c4b-4281-b951-d872f2087c98

Get ChangeList using Drive V2 API and then converts to
DocumentFeed.  This is not optimal but change can be minimal
to make file list appear in FileBrowser UI, which makes
other development/debugging/refactoring easier.

This depends on the change in
https://chromiumcodereview.appspot.com/10837201/
for GetKind() function.

BUG=chromium:127728
TEST=specify "--enable-drive-v2-api" and open file browser (Ctrl-M), then go to drive folder and see if file listing works.

Review URL: https://chromiumcodereview.appspot.com/10837201

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151445 0039d316-1c4b-4281-b951-d872f2087c98

- Adding 'offset' value in the preference and set to display controller
- Allow offset in Options UI too
- Redesign the Options UI a bit: now it has "apply" button rather than just applying on mouse-up, and remove 'ok' button.  See crbug.com/130385#c26 for the mock.

R=ben@chromium.org
BUG=137516,130385

Review URL: https://chromiumcodereview.appspot.com/10836046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151444 0039d316-1c4b-4281-b951-d872f2087c98

of DownloadFileImpl by DownloadItemImpl.

BUG=123998
R=benjhayden@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10799005

TBR=rdsmith@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10827314

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151443 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138013


Review URL: https://chromiumcodereview.appspot.com/10830282

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151440 0039d316-1c4b-4281-b951-d872f2087c98

BUG=134748


Review URL: https://chromiumcodereview.appspot.com/10854123

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151439 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151438 0039d316-1c4b-4281-b951-d872f2087c98

The modification is not needed anymore, because for dirty files
we always look up metadata from the local cache file (r148712).

Besides, this patch renames OnXXXForCloseFile to CloseFileAfterXXX,
to match the recent convention.

BUG=142466
TEST=existing tests, in particular:
 browser_tests --gtest_filter='RemoteFileSystemExtensionApiTest.RemoteMountPoint'
 unit_tests --gtest_filter='GDataFileSystemTest.OpenAndCloseFile'

Review URL: https://chromiumcodereview.appspot.com/10830298

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151437 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10826298

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151435 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151434 0039d316-1c4b-4281-b951-d872f2087c98

TBR=enne@chromium.org
BUG=none

Review URL: https://chromiumcodereview.appspot.com/10823304

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151433 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compile succeeds

Review URL: https://chromiumcodereview.appspot.com/10837183

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151432 0039d316-1c4b-4281-b951-d872f2087c98

BUG=142047

Review URL: https://chromiumcodereview.appspot.com/10828298

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151430 0039d316-1c4b-4281-b951-d872f2087c98

BUG=142310

Review URL: https://chromiumcodereview.appspot.com/10827298

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151429 0039d316-1c4b-4281-b951-d872f2087c98

TBR=cduvall@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10832289

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151428 0039d316-1c4b-4281-b951-d872f2087c98

The labels include starred, trashed, hidden, restricted, viewed.

BUG=chromium:127728
TEST=unit_tests --gtest_filter="DriveAPI*"

Review URL: https://chromiumcodereview.appspot.com/10836205

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151427 0039d316-1c4b-4281-b951-d872f2087c98

Returns DocumentEntry::EntryKind for corresponding MIME type of the
entry.

This CL is split off of https://chromiumcodereview.appspot.com/10837201/

BUG=chromium:127728
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10828277

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151425 0039d316-1c4b-4281-b951-d872f2087c98

The protobuf-based cache was only being read at startup and written at shutdown. (Except that when the cache could not be read at startup the cache would immediately be saved upon private data reconstruction from the History database.) With the new implementation using an SQLite database for the HQP cache the private data will be restored from the cache database at startup and continually updated during normal operation. There is no need to flush or write the cache at shutdown as it is constantly kept up-to-date.

Detailed comments about the changes made in this CL can be found in the document shared separately.

Reviewer suggestions:
  sky: for proper thread usage. Also chrome/browser/ui/ and chrome/browser/visitedlink/.
  pkasting: for whatever you'd like to check over but please look over the design document shared separately.
  shess: please take a look at database usage in chrome/browser/history/in_memory_url_cache_database.h/.cc.

BUG=95686,95876,131668
TEST=New tests added, old tests updated, all tests pass.
To manually verify changes:
NOTE: For tests using chrome://omnibox be sure to check the "Show results per provider" and then look at the results for the HistoryQuickProvider.
1) New visits: Type an URL never visited before. Bring up new tab. Start typing the URL or parts of the page title or both and verify that the page is offered as a suggestion.
2) New visits: Type an URL never visited before. Do search using chrome://omnibox. New visit should show.
3) Delete visit: Visit some pages and verify they have been recorded. Bring up history and delete one of the visits. Check via chrome://omnibox that it was deleted.
4) Clear history: Visit some pages. Clear the visit history. Check via chrome://omnibox that none of the visits are still returned by the HQP.
5) Updated site: Create a local page and visit it. Search using chrome://omnibox by page title and verify it can be found. Change the page title dramatically and revisit the page. Verify via chrome://oomnibox that the page can be found by words from the new title.
Review URL: https://chromiumcodereview.appspot.com/10477018

TBR=mrossetti@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10830297

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151424 0039d316-1c4b-4281-b951-d872f2087c98

BUG=142030
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10826254

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151423 0039d316-1c4b-4281-b951-d872f2087c98

Tests that explicitly want to test other channels (e.g. test feature X behaves
differently on stable) then they can still enable that explicitly.

Review URL: https://chromiumcodereview.appspot.com/10829312

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151422 0039d316-1c4b-4281-b951-d872f2087c98

BUG=132950

Review URL: https://chromiumcodereview.appspot.com/10855015

TBR=koz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10826295

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151421 0039d316-1c4b-4281-b951-d872f2087c98

BUG=132950

Review URL: https://chromiumcodereview.appspot.com/10855015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151420 0039d316-1c4b-4281-b951-d872f2087c98

The protobuf-based cache was only being read at startup and written at shutdown. (Except that when the cache could not be read at startup the cache would immediately be saved upon private data reconstruction from the History database.) With the new implementation using an SQLite database for the HQP cache the private data will be restored from the cache database at startup and continually updated during normal operation. There is no need to flush or write the cache at shutdown as it is constantly kept up-to-date.

Detailed comments about the changes made in this CL can be found in the document shared separately.

Reviewer suggestions:
  sky: for proper thread usage. Also chrome/browser/ui/ and chrome/browser/visitedlink/.
  pkasting: for whatever you'd like to check over but please look over the design document shared separately.
  shess: please take a look at database usage in chrome/browser/history/in_memory_url_cache_database.h/.cc.

BUG=95686,95876,131668
TEST=New tests added, old tests updated, all tests pass.
To manually verify changes:
NOTE: For tests using chrome://omnibox be sure to check the "Show results per provider" and then look at the results for the HistoryQuickProvider.
1) New visits: Type an URL never visited before. Bring up new tab. Start typing the URL or parts of the page title or both and verify that the page is offered as a suggestion.
2) New visits: Type an URL never visited before. Do search using chrome://omnibox. New visit should show.
3) Delete visit: Visit some pages and verify they have been recorded. Bring up history and delete one of the visits. Check via chrome://omnibox that it was deleted.
4) Clear history: Visit some pages. Clear the visit history. Check via chrome://omnibox that none of the visits are still returned by the HQP.
5) Updated site: Create a local page and visit it. Search using chrome://omnibox by page title and verify it can be found. Change the page title dramatically and revisit the page. Verify via chrome://oomnibox that the page can be found by words from the new title.
Review URL: https://chromiumcodereview.appspot.com/10477018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151419 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug/com/125937
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10832282

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151418 0039d316-1c4b-4281-b951-d872f2087c98

when histogram is created. 

We will back out this change. This is temporary to catch
corruptions as early as possible.

TBR=jar,kaiwang
TEST=base unittests
BUG=140688
Review URL: https://chromiumcodereview.appspot.com/10826293

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151415 0039d316-1c4b-4281-b951-d872f2087c98

This is so it's clear that they depend on content module. In a follow up
patch we will have views_examples_lib and views_examples_exe targets that
does not depend in content/ module to build.

BUG=141187
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10855119

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151408 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138338,141682

Review URL: https://chromiumcodereview.appspot.com/10831273

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151405 0039d316-1c4b-4281-b951-d872f2087c98

BUG=142058


Review URL: https://chromiumcodereview.appspot.com/10834298

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151402 0039d316-1c4b-4281-b951-d872f2087c98

BranchUtility was crashing when it tried to fetch the branch numbers for the
dev, beta, and stable channels. There was also a problem using the branch number
where the name should have been used.

ServerInstances are no longer leaked.

BUG=141909

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151386

Review URL: https://chromiumcodereview.appspot.com/10831269

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151401 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10825331

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151400 0039d316-1c4b-4281-b951-d872f2087c98

This is needed to support hidpi for browser/page actions.

BUG=138025,135271
TEST=manually checked that browser and page action buttons are displayed correctly.


Review URL: https://chromiumcodereview.appspot.com/10827191

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151399 0039d316-1c4b-4281-b951-d872f2087c98

When user signs out and transit to the login screen, the wallpaper fade in from a white screen. Described in 141563, this Cl fixed it.
Also, after user login, or switch users at login screen. when wallpaper change, the new wallpaper should fade in nicely. There is a regression in recent builds. This fix fixed the regression as well. 

BUG=141563, 141676, 142042

Review URL: https://chromiumcodereview.appspot.com/10827284

TBR=bshe@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10854136

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151398 0039d316-1c4b-4281-b951-d872f2087c98

If we do this, the OMX_FillThisBuffer function will fail, and will put the OMX
class in error mode. Then resource freeing will not happen. This is especially
annoying since this can happen during Destroy and leads to resource leaks.

BUG=chrome-os-partner:12316
TEST=by hand: play a video, look for buffer leaks.

Change-Id: If14311d188f1a2048c11b5bb6186dbf5fc20c1f5


Review URL: https://chromiumcodereview.appspot.com/10837212

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151396 0039d316-1c4b-4281-b951-d872f2087c98

DownloadsDOMHandler::download_items_ does not always contain all of the items that it observes, so std::find may return end(). I have no idea what happens when you set *end()=NULL, but it could explain the crash in DownloadsDOMHandler::ClearDownloadItems() on windows, somewhere in "for (OrderedDownloads::iterator it = download_items_.begin(); it != download_items_.end(); ++it)".
BUG=142389

Review URL: https://chromiumcodereview.appspot.com/10855135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151395 0039d316-1c4b-4281-b951-d872f2087c98