- 09 Sep, 2020 40 commits
-
-
Ayu Ishii authored
Bug: 1124891, 1125194 Change-Id: Ia8346f1b68b3f0726662b8dd37de66cce0b9e490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393182Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#805189}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/99396cad183b..515a3a6dd433 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC patricialor@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085419,chromium:1098447,chromium:1099917,chromium:1123724 Tbr: patricialor@google.com Change-Id: Ia087f19dda05e3835230aa52383162efc59c5a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399266Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805188}
-
Kyle Horimoto authored
BleScanner scans for incoming BLE advertisements but only notifies observers of results once they have been filtered by parameters provided by clients. Before this CL, a filter consisted of a DeviceIdPair and a ConnectionRole. We will be utilizing BleScanner for Phone Hub, so now it must also filter by ConnectionMedium. Since ConnectionAttemptDetails objects consist of a DeviceIdPair, a ConnectionMedium, and a ConnectionRole (i.e., exactly what we need), this CL change the type of the scan filter parameters with ConnectionAttemptDetails. A TODO is added in ble_scanner_impl.cc to reflect the fact that we must now include the medium as part of the filtering process. This is left for a follow-up CL. Bug: 1106937 Change-Id: I251fe812b87145ae9861140af7021dfe2530084b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392954 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#805187}
-
Joel Hockey authored
Bug: 1125841 Change-Id: I4d86cbd40f00db05a64af390b82fe6f69ec5e781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395904 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#805186}
-
James Vecore authored
This add the GetSendPreview() call to the DiscoveryManager interface so the UI can show the correct description and icon when on the discovery page. Follow up CL's will add the icons and handle the multiple file translation string (i.e. 'x and n other files') Change-Id: I5c454e597f6977ba35377e05603a5394a2a80e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394377Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#805185}
-
Noel Gordon authored
The variables used to re-write image loader client request URLs do not change. Define them as ImageLoaderClient const properties. No change in behavior, no new tests. Bug: 1126229 Change-Id: Icd3f548164eb98437fbde89117a54a2ef207aec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398602Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#805184}
-
chrome://user-actionsMiyoung Shin authored
This fixes a regression of https://crrev.com/c/2335213 that the user actions isn't recorded at chrome://user-actions since Javascript is disallowed in WebUIImpl::MainFrameNavigationObserver::DidFinishNavigation after it is allowed in UserActionsUIHandler::ReadyToCommitNavigation. This CL registers a message called when the page is loaded to allow the JavaScript and adds the user action callback in OnJavascriptAllowed instead of ctor not to access RenderFrameHost too early. Bug: 1122791 Change-Id: I285d62b8fb15ff388c1183e63047efe93705390d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387900Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#805183}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599587571-75a79fa48b42004db7f7ebb181ae53e5f370e716.profdata to chrome-mac-master-1599609504-d5a4da8648bee9c45af68f0bedc0e876fcbf0d82.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I6e3b326a9663518aebad19599430f6e5ec326084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399272Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805182}
-
Peter Kotwicz authored
This CL: - Sets resource_overlay=true in //weblayer:components_java_strings to indicate that the target duplicates resources in //components/strings:components_locale_settings - Renames android_webview/nonembedded/java/res_devui/drawable/ic_search.xml as the resource conflicts with R.drawable.ic_search BUG=1093825 Change-Id: Ica9c2335fdf688bec594f842e617e82e1a826773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389229 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805181}
-
Kent Tamura authored
This directory has a circular dependency with modules/worklet:worklet. Update allow_circular_includes_from in it. This CL has no behavior changes. Bug: 800764 Change-Id: I6a525f8114dce476a7cd3dec5529e48781a47515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398745 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#805180}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3e2d6551..bb481754 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I33eaa84361ce01ba013b21113dba43a6b9d8e64f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398860Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805179}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 800764 Change-Id: If9ae82d08aa4b8eac163a19001cbcd6a402f5e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398744 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Sangwoo Ko authored
The property should be interpolable. https://drafts.csswg.org/css-text-3/#tab-size-property Bug: 1124184 Change-Id: Ic298057b17a78717df08dde4f82d8d860e230612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392164Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#805177}
-
manukh authored
When rich autocompleting titles, |fill_into_edit| & |fill_into_edit_additional_text| are swapped (i.e. the former contains the title, and the latter contains the URL). This is consistent with how the suggestion should be displayed. But the shortcut DB must persist the original (i.e. URL) |fill_into_edit|; otherwise the shortcut provider may autocomplete the title even when title autocompletion is inappropriate (e.g. because the input is too short). Therefore, |swapped_fill_into_edit| is set to true when rich autocompleting titles. Bug: 1062446 Change-Id: I925752e60d2529d0fd8f9fac7f51aea169bc678d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399567 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
-
Rachel Carpenter authored
Bug: b/161658580 Change-Id: Ief273a5a9b1e37177d127251b4bccd491fcf30ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397993 Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#805175}
-
David Stevens authored
We want to drop vgem support from minigbm, so filter out the vgem render node before trying to creating the gbm device to prevent the expected unsupported backend failure from being treated as a real error. Bug: b:141278896 Change-Id: Ia68c6fc57cff51cf04d76053026d5ee5ae5c57e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392161Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: David Stevens <stevensd@chromium.org> Cr-Commit-Position: refs/heads/master@{#805174}
-
danielng authored
Added unit tests for the borealis installer logic. Cq-Depend: 2391891 Tests: Ran tests Bug: b:161650651 Change-Id: I708753a61e98be5b392c9559200c9b07b12b8dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392163 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#805173}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0cf22e5ad89d..a67d868f6c11 2020-09-08 aerotwist@chromium.org Adds Puppeteer support to frontend 2020-09-08 aerotwist@chromium.org Bypass third_party files when linting in presubmit If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1107392 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I94793ae7ab120a016da872741af0d93e3b5809a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399073Reviewed-by:
-
Sophie Chang authored
Bug: 1112500 Change-Id: I48ca40822ea7677e438fca13009454c863658ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399521Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#805171}
-
Joel Hockey authored
Bug: 960056 Change-Id: Ic8b449303b5858e1677fd0bb346bc332c9fbc9b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391702 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium b5eeca1f. With Chromium commits locally applied on WPT: c255d0e2 "Add WPTs for invalid WC inputs" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I80d656ef8e0da4cab510e5f0b183c19e82c29730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398859Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805169}
-
John Abd-El-Malek authored
Bug: 1123212 Change-Id: I8d5d3a23d9d8c7902d37cf19faa3a1dbfe898ed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399574 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#805168}
-
Siye Liu authored
During long tap, |WebViewImpl::HandleGestureEvent| asks the main frame's GestureManager is the long tap should invoke context menu. However, the previeus long press event was routed to iframe's GestureManager. Therefore, main frame's GestureManager returns false in |GestureManager::LongTapShouldInvokeContextMenu|. Therefore, context menu is not invoked if the link is in an iframe. We should ask the hit frame to decide whether we should invoke context menu during long tap. Bug: 1112987 Change-Id: I90f5e1f09380258b6bdf83c9cc78b9764d2adeca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382054Reviewed-by:
Siye Liu <siliu@microsoft.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#805167}
-
Yoshisato Yanagisawa authored
This reverts commit ccb9f3bf. I noticed I need to update other GCS permission to allow the task service account to run gclient sync. Bug: b/166712857 Change-Id: I4e534eb1bb1a026de169b2c0b58e9bd50b354b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398070Reviewed-by:
-
Martin Šrámek authored
Since this file has a limited maximum size, a new entry can only be added if one previous one is removed. We remove the FriendlySettingsHats entry, as this study has been fully launched and all corresponding features are enabled by default on Desktop platforms. Bug: 1097757 Change-Id: I59024c59c7c7754051fff90e194b40dea2b83a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377935Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#805165}
-
Johann authored
Remove usage of DISALLOW_COPY_AND_ASSIGN from mojo documentation. styleguide/c++/c++-dos-and-donts.md: 'DISALLOW_COPY_AND_ASSIGN` is deprecated. For a non-copyable/movable type, delete the copy operations (the move operations will be implicitly deleted); otherwise, declare either copy operations, move operations, or both (a non-declared pair will be implicitly deleted). Always declare or delete both construction and assignment, not just one (which can introduce subtle bugs). Change-Id: Iad752e093643a0f964056c1d4b6714cea724728f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398069Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#805164}
-
Melissa Zhang authored
This CL adds a strings file for Sharesheet UI. It also changes the target display label to be multi-line if there is no secondary label. Bug: 1097623 Change-Id: Id75f9fa0de851de58707fa6b730098d472038599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395135Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#805163}
-
wutao authored
This patch uses the ic-checked-filled icon for the checked mark. Screenshot: https://screenshot.googleplex.com/69U4WGtZ63GUsoK Bug: b/167085170 Test: added new js test Change-Id: I5249ca6470a795bf45a782f3687be96c00e9ad08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384335 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#805162}
-
Daniel Cheng authored
It is possible for the browser to ask the renderer to commit a document with an unsupported MIME type [1], though `NavigationURLLoaderImpl` [2] ould normally turn this into a download. For example, when mobile emulation is enabled, plugins are disabled in the renderer. However, the browser-side navigation code is not aware of this. If the user navigates to a PDF file, the browser will still ask the renderer to commit a PDF navigation, even though requesting an unsupported MIME type should normally turn into a download. In the renderer, the `CommitNavigation()` request is currently ignored. With this CL, synthesise an artificial response so that `CommitNavigation()` cannot silently fail in this case. Note that there is at least one other bug: when `ShouldNavigate()` returns false, `FrameLoader` calls `DidFinishNavigation()`. However, this does not actually appear to stop the progress spinner. The fact that this doesn't work is now masked by the fact that `ShouldNavigate()` never returns false. [1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/public/common/mime_util/mime_util.h;l=25;drc=3abd909af895533327e5ce0fe554bce7f87087a6 [2] https://source.chromium.org/chromium/chromium/src/+/master:content/browser/loader/navigation_url_loader_impl.cc;l=800;drc=48d758b185dbcf4f4e3380de15990378fa7485eb Bug: 696745, 1117282 Change-Id: I1b44b1ff59e81f2b4f3a7b5dc2e0a98921869373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388705 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#805161}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/04b9443274cf..b8ae7fa12aa0 2020-09-08 jvanverth@google.com Reland "Use Microsoft's ComPtr to wrap D3D12 objects." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: Idab289262f5240dba73b358b31cbe4161d3ef6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399262Reviewed-by:
-
Sophie Chang authored
Proto without histogram change was initially landed here: https://chromium-review.googlesource.com/c/chromium/src/+/2387905/5 Bug: 1112515 Change-Id: I8663add11363d7edbbae8d7c2f85ec6fb1b03e4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399309 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Joel Hockey authored
Bug: 1117088 Change-Id: Ib59706e6494f732babe70dd970c0f803c7698ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391703Reviewed-by:
-
Donn Denman authored
Extends a couple of Contextual Search histograms to M89 for the Related Searches experiment. BUG=1125745 Change-Id: I37f69019e682694f18ee8f962b7ccc4b7ee7b288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399504Reviewed-by:
-
Liquan (Max) Gu authored
Change: Only moving mId, mRawShippingOptions, mRawLineItems, mRawTotal. Bug: 1102522 Change-Id: I58f1e56a2a51a4deacd4d2684ccb56456677fdb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390942 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#805156}
-
Fergus Dall authored
Concierge now supports a dlc_id parameter to boot a trusted VM from a DLC. Set this when the crostini dlc flag is enabled. With this CL it is now possible to use termina-dlc on any board with dlc enabled. Bug: chromium:953544 Change-Id: I95fba796e6f80f10e308dd306b5ef1befd416e62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397455 Auto-Submit: Fergus Dall <sidereal@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
-
Ryan Hansberry authored
Discovered while debugging crbug.com/2393616. The code in question moves the wrapped CorePayload of a std::unique_ptr<CorePayload>, instead of moving the entire smart pointer. Resolved by simply not using std::unique_ptr in the first place. Also fix a minor typo discovered while debugging. Bug: 2393616 Change-Id: I518230bd2ced6735d13f4fc8fbee54758ceec1e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398952 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
-
Noel Gordon authored
This API is used by image loader clients: Gallery, Video Player, Files app. They are chrome extensions and have an extension id: nlkncpkkdoccmpiclbokaimcnedabhhm Gallery jcgeabjmjgoblfofpppfkcoakmfobdko Video Player hhaomjibdihmijegdhdafkllkbggdgoj Files app The image loader client code must replace the client extension id with the image loader extension id in client request URLs. The code uses chrome.i18n.getMessage() to figure out the client extension id. Remove that code: use a regular expression instead. No change in behavior. Bug: 1126229 Change-Id: I3214335a6ecc2b70be614918a4cffd577071ffb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397969Reviewed-by:
-
Kent Tamura authored
- It contained non-existent encoded_frame.h. - It has a circular dependency with modules/webrtc. The dependency is safe because these targets are in a single library. This CL has no behavior changes. Bug: 800764 Change-Id: I8759b5e88a4596d22a9d2e83e447dc94214bb4eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397104 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
danielng authored
Added browser tests for the Borealis installer view. Cq-Depend: 2391891 Tests: Ran tests Bug: b:161650651 Change-Id: I2e5e6a2fb5d744f1fd3cd2f0e6efa1622953c0ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392285 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
Siyu An authored
Introduced the autofill_offer_data which will be shared by chrome client codebase. Also added tests. Bug: 1112095 Change-Id: If335e20074b580f5caa613b7360e24f884da8081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391906 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#805150}
-
