- 28 Apr, 2020 40 commits
-
-
Stepan Khapugin authored
This histogram is occasionally used for iOS omnibox feature analysis. Bug: 1037597 Change-Id: I6803c155e3406aff6bd40c1874143fbc9ae4684d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170626Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#763441}
-
Mugdha Lakhani authored
Return a valid TabSpecificContentSettingsDelegate from PageInfoControllerDelegateImpl and add a browsertest to verify the same. Bug: 1052375 Change-Id: I60db31480fbefc46b48851891ffaa0d977c7fdc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170349 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#763440}
-
arthursonzogni authored
Up to very recently, the CSP mojo struct only contained directives using a list of CSP sources, except for 'upgrade-insecure-requests', which used an empty list. In the next few weeks. Two new directives will be added: - treat-as-public-address (https://crbug.com/1042164) - sandbox (https://crbug.com/1041376) So there will be 3 kind of directives: 1) The ones containing a set of CSPSources. 2) The ones with no data. 3) The WebSandboxPolicy one. [Question] Can we continue storing everything in the map |directive|? |directive| is: map: CSPDirectiveName -> CSPSourceList. To continue [A], we could make |directives| to store a mojo union. union { CSPSourceList source_list WebSandboxFlags sandbox_flags void none. } or we could stop storing everything in |directives| [B]. Instead, we could just add more attributes. It is not clear to me what in between [A] and [B] to be preferable. This patch tries [B]. Please let me know if you think otherwise. [A] would gives: ~~~ - csp->directives[kSandbox].get_sandbox_flag(); - csp->directives[FrameAncestors].get_source_list(); ~~~ [B] would gives: ~~ - csp->sandbox - csp->directives[FrameAncestors]; ~~ cons of [B] is that we need to update all the conversions from/to this CSP struct in between non-blink/blink-public/blink-private. Bug: 1041376 Change-Id: I8ed473bca2d47beaab82187a68204cc10643e0ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165113Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#763439}
-
Gayane Petrosyan authored
Add similar action for floating action bar. This CL creates a new action for Android M+ as we cannot filter by OS flavor in User Action Sequencer. Also record only in onPrepareActionMode and not in onCreateActionMode to avoid doubles. Bug: 1072811 Change-Id: I321574d6fc5ae6cc3e52784df6f0c69f269979b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159566 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#763438}
-
Dominik Röttsches authored
Implement property and parsing for text-underline-offset. Enable corresponding WPT tests by removing existing FAIL expectations. Bug: 785230 Change-Id: Ie55aa4ec66c1a41143037447c279d5b437cfd75e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148786 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#763437}
-
Dale Curtis authored
We were using the data in the buffer without retaining a ref, so it could be destroyed while we were using it. R=sandersd Bug: 1073995 Change-Id: I7e625103c3e881a47baa6e85499a1bc904efd7f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168822 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#763436}
-
Sebastien Marchand authored
On shutdown the browser terminates all the renderers here: https://cs.chromium.org/chromium/src/chrome/browser/lifetime/browser_shutdown.cc?l=142&rcl=25a11f45ff00559b2f46242918e967ede9d4a50f This (seems to) initiates the shutdown process in the renderers (which calls __llvm_profile_dump) but as soon as the browser dies all the child processes are terminated before finishing to flush their profiling data. See crbug.com/1071664 for more details. This CL sends some notifications to the renderer and GPU processes when they're about to be terminated asking them to dump their profiling data, a waitable event is used to make sure that the browser doesn't terminate before the child processes are done dumping their profiling data. Note that this code is only meant to be used on PGO profiling builds, it's not meant to be used on production builds. On Windows, the reason why this doesn't repro when disabling the sandbox is that (IIUC) the sandbox causes all the processes to belong to the same Jobs object (see https://docs.microsoft.com/en-us/windows/win32/procthread/job-objects), we're using a nested job hierarchy that causes all the child processes to die when their parent is terminated. In this case it means that terminating the browser process, the parent in the nested job hierarchy, causes all the child to be terminated immediately. Without the sandbox this hierarchy doesn't exist and so the child process can do a clean shutdown. It's not clear if this issue is affecting the profiling builds on platforms other than Windows but this change gives the guarantee that the profiling data will be flushed to disk properly on shutdown and so it's probably worth enabling this on all platforms. Bug: 1071664, 1059335 Change-Id: Ie41e597fe32214be5ab0a798f7c3c2ad12593845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157967Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#763435}
-
Istiaque Ahmed authored
It can already be (and should be) accessed through browser_context() getter. Bug: None Change-Id: If2518a288b48dabd96c121c235d0a08c8e20e85d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166802 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#763434}
-
Armando Miraglia authored
Fixed: 1072524 Change-Id: I7c577e94a1c51f3e11a7b1878feda6e51b6e597b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170097Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Alex Ilin authored
Sometimes OAuthConsent.setConsentResult() JS Bridge is called by the server before it has been initialized by the injected JavaScript, so the browser doesn’t receive the consent result. This CL makes Chrome inject JS bridge as early as possible, after the navigation commit. Fixed: 1075932 Change-Id: I4030163cd51b8af6be785be577412b2d5f077687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169910Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#763432}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I7a7c2f8152ba541a596dbaf49d1683d889def03e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169756Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#763431}
-
Maksim Sisov authored
ActivationWaiter should be created as early as possible so that PropertyNotify has time to be set before the widget is activated. Otherwise, the waiter can miss that event, and the test times out. Bug: 955316 Change-Id: I0e993e2aacdf8a2a97bfdeeeab75c7312c9259b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169886Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#763430}
-
Sahel Sharify authored
This is a reland of c7dc1979 after adjusting expected PH window height. original cl: https://chromium-review.googlesource.com/c/chromium/src/+/2165673 revert cl: https://chromium-review.googlesource.com/c/chromium/src/+/2169450 Original change's description: > [Web Payments][Desktop]PH window size matches pop up size. > > This cl changes the payment handler window size on desktop to better > align with a common pop up size for payment apps (600x600). > This change gives payment apps enough space to show additional contents > (e.g. shipping address) inside the viewport. > > The pop up window size is chosen since 1- users are already used to > this window size and 2- payment apps already using pop up windows won't > have difficulty adjusting their UI. To avoid clipped PH windows on > devices with small screens the height is capped at the browser > window's content height. > > Change-Id: I26b0debcd9b1eef1fc6f5b807ed8f209890b8423 > Bug: 1064452 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165673 > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org> > Reviewed-by: Danyao Wang <danyao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#763088} Bug: 1064452 Change-Id: I18c43df22bded0f22167854f959cc5a60df4330e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170135 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#763429}
-
Mugdha Lakhani authored
Implement two more methods in PageInfoDelegateImpl and add browsertests to verify expected behavior. Bug: 1052375 Change-Id: I474bbd06ad2736894881461cb8381b0adf0dcfa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170348Reviewed-by:
-
George Steel authored
Fix DCHECK failure which occurred when attempting to serialize such an operation, which can occur due to the SVG transform presentation attribute and is unreperesentable in CSS. As there is currently no consensus on how to handle this case and there are no relatice lengths in such operations, I am computing them as matrix() values. See the CSSWG issue at https://github.com/w3c/csswg-drafts/issues/5011 to determine the correct way to handle this. I have proposed the approach used here. Add regression test (crashes without patch). Change-Id: Ia116ead6c451cafc6fb222be3bb52362123bae3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163758Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#763427}
-
Matt Menke authored
The class has created confusion between the following: * URLRequestStatus(FAILED, ERR_ABORTED) * URLRequestStatus(CANCELED, ERR_ABORTED) * URLRequestStatus(FAILED, ERR_FAILED) * URLRequestStatus(CANCELED, ERR_FAILED) The class also obfuscates the difference between OK and ERR_IO_PENDING. These have confused consumers, and make the many state checks in the URLRequest code hard to follow. Also, the net error code is all we really need. Bug: 651119 Change-Id: Ic1dc5bc466a97ecfd040ad09cfaff2e1b535a8b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165149Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#763426}
-
Stephen Roe authored
Previously the amber repository only ran during initial package installation. Since 2020-04-08 it is required during the entire test run. Bug: 1033565 Change-Id: If21cfeefaf8de0a4680aedcd31f79ba35d3e9577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159372Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
-
Trent Begin authored
This change adds a basic mojo interface to query NetworkHealth for the cached active networks and devices. Bug: chromium:1057739 Change-Id: I5c7437a522535f8a3154e3ec74bc17d67f4b2dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161701 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#763424}
-
Andrew Grieve authored
And removes some obsolete flags Change-Id: Ia51b586f00c0c9eeb30d588f20f0743af5b2e395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169755 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#763423}
-
Richard Knoll authored
These instances were found by adding a CHECK to the WidgetObserver DTOR to ensure the observer is removed before destruction and then running all tests. Bug: 1055483 Change-Id: I83353f33962b00f0f922a21ebb0afb2131295482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165105 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#763422}
-
S. Ganesh authored
There are cases where the elevation service may fail to install, for instance, if security software prevents installation. Bug: 1023080 Change-Id: Ibab20f2ee44395254ef702a460f8fad60836e682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168825Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#763421}
-
Etienne Pierre-doray authored
This CL removes StackCopier::Delegate::OnThreadResume and manually resets MetadataProvider in StackSamplerImpl::RecordStackFrames, and enables RecordMetadata() on android (more specifically StackCopiedSignal). |read_lock_| is only acquired: - before CopyStack() on the sampling thread. Since there is only 1 sampling thread per process, this won't have any contention. - in TryReclaimInactiveSlots() with |read_lock_.Try()|. Failing to acquire delays ReclaimInactiveSlots(). Since read_lock_ is only held during stack capture (compared to stack walking which takes ~3x as long), starvation is unlikely to affect TryReclaimInactiveSlots(). Bug: 1056283 Change-Id: I4f0ef3e8c3641ec7b7258da519c3fba519fb096b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154738 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#763420}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/80e9d2ce1c17..71c190060689 git log 80e9d2ce1c17..71c190060689 --date=short --first-parent --format='%ad %ae %s' 2020-04-28 jacktfranklin@chromium.org Up e2e timeout to 5 seconds 2020-04-28 jacktfranklin@chromium.org Add support for `Platform.UIString` calls in GRDP parsing 2020-04-28 tvanderlippe@chromium.org Start with typechecking sdk/NetworkManager.js 2020-04-28 ankit.mishra131990@gmail.com Fix focus not being centered for inline buttons 2020-04-28 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-04-28 wolfi@chromium.org [issues] Add Mixed Content Issues to Issues Pane 2020-04-28 mathias@chromium.org Represent CSS property weights as a map Created with: gclient setdep -r src/third_party/devtools-frontend/src@71c190060689 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1053468,chromium:1075871 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib2b8a78c3280f5e4b85d0530caad474de980257a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170299Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763419}
-
Lei Zhang authored
Also fix IWYU lint errors. Change-Id: I814836a05639abab91b146a9559f84fff5278c6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168806Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#763418}
-
Philip Rogers authored
BackgroundImageGeometry has complex logic for adjusting the background when painting the document element in the view's coordinate space. This logic can be moved into ViewPainter by reusing an existing offset (BackgroundImageGeometry::offset_in_background_). This offset is for the background image itself (similar to the background-position CSS property). Bug: 1071957 Change-Id: I0794a4f90bd8e98e6b257fdd30f1415d9e0f5484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166805Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#763417}
-
Aaron Gable authored
This is a reland of https://crrev.com/c/2161689, which was reverted in https://crrev.com/c/2163254 due to breakages on the branch builders. The prerequisite changes have been cherry-picked to the currently active branches (m81 and m83), so this should be safe to reland. We've already shown this to work on Mac10.15 Tests on the FYI waterfall, so let's do this for the rest of the Mac triggered testers on the main waterfall as well. This will allow us to free up some Mac resources to do more important tasks (e.g. compile, run tests). It also makes these builders builderless, increasing our flexibility and improving our utilization. This CL also introduces a new ci.triggered_tester starlark function to enable easily specifying builders as "we don't care what OS you use", and to enable easily turning all of them into "thin testers" if/when we go down that path. Bug: 1061582 Change-Id: I31b80f76784cc909633056ff9c71e03ebaf31504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170416 Commit-Queue: Aaron Gable <agable@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Aaron Gable <agable@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#763416}
-
Morten Stenshorne authored
NGFragmentItems::FinalizeAfterLayout() will typically update the bits after layout, but apparently not always. This should have been part of CL:2169929 This hopefully fixes: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/5530 https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/102130 TBR=kojii@chromium.org Bug: 1075993 Change-Id: I53207183f6fa7f9c4ccd7db6b64fa8e5c755c332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170098Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#763415}
-
Brandon Jones authored
Implements https://immersive-web.github.io/webxr/#xrlayer-interface New interface added to serve as a common base class between the existing WebGL layer and the WIP layers module. No changes in functionality. Bug: 1074150 Change-Id: I695ff842cce5d38cf37b263acecf95dafc21d572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164146Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#763414}
-
Yury Semikhatsky authored
DevToolsBrowserContextManager::OnBrowserRemoved is called from Browser destructor and the destructor acesses the profile after notifying its observers. If the profile is deleted synchronously in the DevTools' observer it will cause use after free. This change restores the logic changed in https://chromium-review.googlesource.com/c/chromium/src/+/2141097 Bug: 1075664 Change-Id: I02b924d8a45fa6a74fdc2ccc2647033f5f86d904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168515Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yury Semikhatsky <yurys@chromium.org> Cr-Commit-Position: refs/heads/master@{#763413}
-
Mugdha Lakhani authored
A skeleton PageInfoControllerDelegateImpl is introduced for WebLayer. This also adds AutoCompleteSchemeClassifer impl for WebLayer, plumbs it into the existing C++ AutoCompleteSchemeClassifierImpl, and uses it to implement a PageInfoControllerDelegateImpl method. TODOs have been added for unimplemented methods of the controller impl. This class isn't used anywhere right now but is necessary to build Page Info UI for WebLayer. Bug: 1052375 Change-Id: Ie33e0f20e9068a0c382489553121022a84b3ada3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159433Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#763412}
-
Sergey Ulanov authored
Bug: 1067068 Change-Id: If88c4ff1a624e1d29b86181794e1bcd5b4aea792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166807Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#763411}
-
Shik Chen authored
NOPRESUBMIT=true Bug: 1058325 Test: Manually Change-Id: I9864fd9e99d0987e27781602b98ef112adf4150c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169427 Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#763410}
-
Akihiro Ota authored
Bug: 1075752 Change-Id: I47236a717a46e26b8fb23fbe526ade65277ff21c Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168657Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#763409}
-
Vladimir Levin authored
This patch ensures that we properly handle situations where style causes us to be force-unlocked (e.g. display: inline) and cases where we no longer should be force-unlocked (e.g. going from display: inline to display: block). - Ensure to check if we need to be relocked in DidStyle for self. - Ensure that if we were unlocked in DidStyle for self, then we update the child style change to include any deferred dirty bits stored on the context. R=futhark@chromium.org, chrishtr@chromium.org Change-Id: Iba330be74ddbb705357cc99658797d900f800589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165447Reviewed-by:
-
David Van Cleve authored
Lily said that it's safe to use CookieManager on the main network sequence, so I'm removing this obsolete reference to the "IO thread," which scared me into thinking I'd need to PostTask to use CookieManager accessors. R=chlily, morlovich Bug: None Change-Id: I29b305406db253e10654a096f24ab310220eff1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166604 Auto-Submit: David Van Cleve <davidvc@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#763407}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9c39e0c3432b..7b61d5985f4e git log 9c39e0c3432b..7b61d5985f4e --date=short --first-parent --format='%ad %ae %s' 2020-04-28 vapier@chromium.org cbuildbot: afdo: migrate to python3 only 2020-04-28 vapier@chromium.org toolchain_util: migrate to python3 only 2020-04-28 morg@google.com Enable skylab hw tests for RVC PFQ 2020-04-28 vapier@chromium.org cbuildbot: CollectPGOProfilesStageTest: rewrite cros_build_lib.run mocking 2020-04-27 cjmcdonald@chromium.org portage_testables: Make factory fixture for stacked overlays 2020-04-27 cjmcdonald@chromium.org Basic test fixtures for real Portage operations 2020-04-27 vapier@chromium.org unittests: drop python3-only tests 2020-04-27 tcwang@google.com afdo: Fix a typo for recipe AFDO builders. 2020-04-27 vapier@chromium.org cbuildbot: CollectPGOProfilesStage: use UTF-8 encoding when capturing output 2020-04-27 vapier@chromium.org replication_lib: migrate to python3 only 2020-04-27 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@7b61d5985f4e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I2f2373f0c2961c39e99aa56b9750d4e150f368cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170300Reviewed-by:
-
danakj authored
Gin/Javascript can be holding onto a reference to the object when the list of Persistents is cleared. They will be destroyed when the last reference goes away. R=avi@chromium.org Bug: 1074655, 866140 Change-Id: I62ce389e3dd84b04652a8724149cf4dd47274b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169765Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#763405}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/80d3e268d2ec..1f9e2a8feb5a git log 80d3e268d2ec..1f9e2a8feb5a --date=short --first-parent --format='%ad %ae %s' 2020-04-28 jmadill@chromium.org Update .clang-format. Created with: gclient setdep -r src/third_party/angle@1f9e2a8feb5a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I95e5a32c85538bdd6a567aa9d38ef27c810730f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170298Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/03fcfdd74f97..1e6581c46ce7 git log 03fcfdd74f97..1e6581c46ce7 --date=short --first-parent --format='%ad %ae %s' 2020-04-28 fmayer@google.com Fix heap_profile for Python 3.x. 2020-04-28 treehugger-gerrit@google.com Merge "gn: Disable new GCC redundant move warning" Created with: gclient setdep -r src/third_party/perfetto@1e6581c46ce7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Icd7759672aa128b29d9eb680389d406a585703ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170296Reviewed-by:
-
Evan Stade authored
- move ChromeNotificationBuilder interface, PendingIntentProvider - split out Chrome specific bits (UMA) from NotificationBuilder and NotificationCompatBuilder into subclasses. The base classes are componentized. A few Android version conditionals are removed since we're no longer supporting KitKat. Bug: 1069894 Change-Id: Ibef6e2d1d8f82d6182a4e3430aa71d4c61608ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161420 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#763402}
-
