- 06 Feb, 2019 40 commits
-
-
Kent Tamura authored
Fix it in order to match to DOM Parsing and Serialization specification. We should not expose hash values of strings. Bug: 928639 Change-Id: I589572d87715805961f2931c6808c1bd38acade6 Reviewed-on: https://chromium-review.googlesource.com/c/1454070Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#629490}
-
Hiroshige Hayashizaki authored
To remove ExecutionContext::Url() call before worker top-level script response is received. Bug: 861564 Change-Id: I94de13404a54a248663579b755c9270b1d299968 Reviewed-on: https://chromium-review.googlesource.com/c/1394381Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#629489}
-
Alan Cutter authored
This CL ensures we consistently use GTK theme colours for PWA windows. Before this change the title bar colour would use the GTK theme but the title text would not; resulting in unreadable text for dark GTK themes. This CL adds BrowserFrame::ShouldIgnoreTheme() as an equivalent to BrowserNonClientFrameView::ShouldPaintAsThemed(). The latter cannot be used everywhere due to initialisation order dependencies. Deduping these functions is done in a separate CL https://chromium-review.googlesource.com/c/chromium/src/+/1453217 in the interest of keeping this CL merge friendly. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=378056&signed_aid=KLS7LkKg4N2vijhbrVDErQ==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=378057&signed_aid=_AbZIHu6j7Hwm57_i9KhRA==&inline=1 Bug: 927381 Change-Id: I308d8c3c0606cb54ba708cee1ec89a620c1f9d6c Reviewed-on: https://chromium-review.googlesource.com/c/1453558 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#629488}
-
Yoshisato Yanagisawa authored
Let me rename filter to git_log_filter to fix the following pylint warnings. W: 54,32: Redefining built-in 'filter' (redefined-builtin) W: 89,37: Redefining built-in 'filter' (redefined-builtin) W: 191, 2: Redefining built-in 'filter' (redefined-builtin) Change-Id: Ie0a58a5640d388ecb8ee015f29bd1af53d4ce638 Reviewed-on: https://chromium-review.googlesource.com/c/1454353Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#629487}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3f7ec52eaa5f..ab06f0c622bf Created with: gclient setdep -r src-internal@ab06f0c622bf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I00b3efe72fbbd93f16159ec1424cbb38fdea02b5 Reviewed-on: https://chromium-review.googlesource.com/c/1455759Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629486}
-
Jun Cai authored
Revert "Network Service: Use histograms instead of chartjsons for network service performance tests" This reverts commit 44a1b51b. Reason for revert: linux-perf-fyi bot failed: https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/linux-perf-fyi/1762 Original change's description: > Network Service: Use histograms instead of chartjsons for network service performance tests > > This CL modifies the network service performance tests to generate > histograms instead of chartjsons so that the Pinpoint can automatic > bisect CLs. > > Bug: 927155 > Change-Id: I3619704882c3636e76790d610e719a97c045e165 > Reviewed-on: https://chromium-review.googlesource.com/c/1454633 > Commit-Queue: Jun Cai <juncai@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Simon Hatch <simonhatch@chromium.org> > Reviewed-by: Ben Hayden <benjhayden@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629424} TBR=jam@chromium.org,benjhayden@chromium.org,simonhatch@chromium.org,crouleau@chromium.org,juncai@chromium.org Change-Id: I6115a10797ec60dd5623dc1ef0e763b2eb84bd9a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 927155 Reviewed-on: https://chromium-review.googlesource.com/c/1455856Reviewed-by:
Jun Cai <juncai@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#629485}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d9ed5b949aa2..fac1e367f428 git log d9ed5b949aa2..fac1e367f428 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader a69ca6050e3e..c81766320762 (1 commits) Created with: gclient setdep -r src/third_party/skia@fac1e367f428 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: Ica9a638b95e8fd0125932fbd877f5c405fecac5d Reviewed-on: https://chromium-review.googlesource.com/c/1455760Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629484}
-
tzik authored
The web tests below are served as `file:` scheme resources, and uses `setAllowUniversalAccessFromFileURLs(true)` to bypass all origin check. So that they can access the URL of iframes. - forms/formtarget-attribute-button-html.html - forms/formtarget-attribute-input-2.html - forms/formtarget-attribute-input-html.html This CL moves them from web_tests/fast to web_tests/http/tests, so that they are served via http, and they can access iframes without disabling the origin check. Change-Id: I408ac5714d1e81adc248307a3534fb014f2811c9 Reviewed-on: https://chromium-review.googlesource.com/c/1454200Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#629483}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5830d87cf137..1b8d2cc9056a git log 5830d87cf137..1b8d2cc9056a --date=short --no-merges --format='%ad %ae %s' 2019-02-06 thestig@chromium.org Fix integer overflow in CPDF_DocPageData::GetFontFileStreamAcc(). Created with: gclient setdep -r src/third_party/pdfium@1b8d2cc9056a The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:925736 TBR=dsinclair@chromium.org Change-Id: Id7f0982b07a4a0e3f9f666398558ca7a0e29f715 Reviewed-on: https://chromium-review.googlesource.com/c/1455758Reviewed-by:
-
Yutaka Hirano authored
Design doc: https://docs.google.com/document/d/1n0IIRmJb0R-DFc2IhhJfS2-LUwl6iKSBNaR0klr3o40/edit Bug: 902633 Change-Id: I5f2c70db01019af9816980c2c83b0f1840ecfe3d Reviewed-on: https://chromium-review.googlesource.com/c/1454346 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#629481}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fa9e5064..23873283 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I038f5ec27f85d9d0ece5bc867fe15f5e564db7ca Reviewed-on: https://chromium-review.googlesource.com/c/1455744Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629480}
-
Fergus Dall authored
This CL changes CrostiniManager to not try to install/restart crostini while it is being uninstalled, and to abort any running restarts if the uninstall process starts. It does not update the UI to prevent the user from trying to do both operations at the same time. Bug: 919153, 928339 Change-Id: Iccb829228e902c24a1ce653c1c244ad789bebe41 Reviewed-on: https://chromium-review.googlesource.com/c/1453956 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#629479}
-
Alex Moshchuk authored
When a new proxy is created, its renderer-side loading state is currently initialized as not loading. This is not always accurate, however, if the proxy is created for a frame that hasn't yet finished loading after a navigation. Our current DidStartLoading and DidStopLoading IPC only update the loading state of any existing proxies, but this isn't done for new proxies. Password manager is currently running into an issue stemming for the fact that a proxy's loading state is inaccurate. To fix this, this CL sends a separate IPC to update the proxy's renderer-side loading state whenever a new proxy is created for a frame that's currently loading. This is a reland of https://crrev.com/c/1440728, with the fix to not send the IPC when creating proxies while swapping out. Bug: 916137, 928209 Change-Id: I004c8fb89fb0af0317be70cea14c4452012db66b Reviewed-on: https://chromium-review.googlesource.com/c/1440728 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#628577} Reviewed-on: https://chromium-review.googlesource.com/c/1455117 Cr-Commit-Position: refs/heads/master@{#629478}
-
Kenneth Russell authored
The test is intermittently crashing the GPU process in webgl_conformance_d3d11_validating_tests . Bug: 929009 Change-Id: I2f91f232c257521d7cbb460861b754901ba5cef3 Tbr: geofflang@chromium.org Tbr: enga@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1454143Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#629477}
-
Jimmy Gong authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/9ae41aa0622c..13b2686c57be $ git log 9ae41aa06..13b2686c5 --date=short --no-merges --format='%ad %ae %s' 2019-01-07 matthewmwang shill: Add fallback URL and rotation URLs to PortalDetector::Properties 2019-01-18 jimmyxgong smbprovider: Add UpdateSharePathOptionProto 2019-01-25 ljusten cryptohome: Dedupe install_attributes.proto Created with: roll-dep src/third_party/cros_system_api Bug: none Change-Id: I791333c48797b620ef33be75cf87a96e82a85e7c Reviewed-on: https://chromium-review.googlesource.com/c/1455504Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#629476}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a69ca6050e3e..c81766320762 git log a69ca6050e3e..c81766320762 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 sugoi@google.com Basic DescriptorPool and DescriptorSetLayout implementation Created with: gclient setdep -r src/third_party/swiftshader@c81766320762 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I3861108e738405fd5fe1df571eef2bcf78485acb Reviewed-on: https://chromium-review.googlesource.com/c/1454888Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0c12f92a4b03..d9ed5b949aa2 git log 0c12f92a4b03..d9ed5b949aa2 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 09a91e48c066..a69ca6050e3e (4 commits) 2019-02-06 ethannicholas@google.com Reland "SkSL is now pickier about type conversions" 2019-02-06 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-06 fmalita@chromium.org Revert "third_party/icu: use upstream" 2019-02-06 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-06 fmalita@chromium.org [skottie] Fix logging of oversized messages Created with: gclient setdep -r src/third_party/skia@d9ed5b949aa2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I411d186748036a5b2b22324db541d1007295f508 Reviewed-on: https://chromium-review.googlesource.com/c/1455604Reviewed-by:
-
Kent Tamura authored
Serializer-related classes should not change the state of node objects. This CL has no behavior changes. Change-Id: Ic0a1075ae437a2b5387079902a7b373b5a5c1685 Reviewed-on: https://chromium-review.googlesource.com/c/1454018 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
rbpotter authored
Bug: 927118 Change-Id: I9f45b349f94edec5326aad35ee8b3cf7091ce8d5 Reviewed-on: https://chromium-review.googlesource.com/c/1441649 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#629472}
-
Kenneth Russell authored
Do early rejection of the case where the user requests an ES 3.0 or WebGL 2.0 context, but the driver is not capable of it. Previously, this was going down the full initialization path, and failing first during creation of the black 3D textures in the TextureManager. Added an integration test which verifies the fix; it crashes the GPU process in the same way the browser was crashing under the Android emulator. It was infeasible to add a unit test due to how the harness works. The new test is currently skipped on Android and macOS due to difficulties in making the new lower-level driver bug workaround work on those platforms. Bug: 923134 Change-Id: I4c89d5c5e144e5b3f6b8c47f912e7123242860ae Reviewed-on: https://chromium-review.googlesource.com/c/1419340 Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#629471}
-
Yuki Shiino authored
This reverts commit a365352b. Reason for revert: Suspicious to have caused test failures at viz_browser_tests on GNU/Linux. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/31373 Original change's description: > cros: Simplify how views/screens are mocked in WizardControllerBrowsertest > > This eliminates MockOutShowHide and simplifies lifetime. > > MockOutShowHide derived from another Mock class, and also embedded the > view inside of it. This means that the view was destroyed while the > model was being destroyed. > > EXPECT_* methods are now moved to test code instead of the mock class, > since the EXPECT_* methods assume a specific type of usage that is not > always present. > > ScreenManager is also cleaned up so that it does not declare any friend > tests. > > Bug: 928555 > Change-Id: I2f61648dc980e4d5b08620d76d3bbd4d58cd2403 > Reviewed-on: https://chromium-review.googlesource.com/c/1450281 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Denis Kuznetsov <antrim@chromium.org> > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629264} TBR=antrim@chromium.org,alemate@chromium.org,jdufault@chromium.org Change-Id: I7b3dc97e5425e3bf1b743fe130fcb985f61df9e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 928555 Reviewed-on: https://chromium-review.googlesource.com/c/1454352Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#629470}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/377617c6c0d9..3f7ec52eaa5f Created with: gclient setdep -r src-internal@3f7ec52eaa5f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I69cbddd068b9d2c6bee035a874d09938ba6c4574 Reviewed-on: https://chromium-review.googlesource.com/c/1455374Reviewed-by:
-
Etienne Pierre-doray authored
Creates a feature kMayBlockWithoutDelay that changes SchedulerWorkerPoolImpl's behavior in response to MayBlock workers. When enabled, the blocked worker is replaced immediately instead of waiting for a threshold. Bug: 874080 Change-Id: I81be2f43e9603754328b4901a1e9b9acc59baffc Reviewed-on: https://chromium-review.googlesource.com/c/1452759 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#629468}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f07bed8f. With Chromium commits locally applied on WPT: af3b056c "[WPT] [wasm] Add JS-API tests for wasm threads" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ia6a4d8f2132babc1171f9b9a8182a463310a8964 Reviewed-on: https://chromium-review.googlesource.com/c/1455737Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629467}
-
Andrew Grieve authored
Speculative fix for a NullPointerException (see bug). Both of these getters were being used to stop asynchronous work assocatied with an activity. According to Android docs, an activity can be destroyed without .finish() being called on it, so perhaps that's how the NPE was happening. Bug: 927223 Change-Id: Ic93e611c1199f27e50ec7988efbf67f262be03da Reviewed-on: https://chromium-review.googlesource.com/c/1453370 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#629466}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4fbc755cc6bf..a3b840037dfd git log 4fbc755cc6bf..a3b840037dfd --date=short --no-merges --format='%ad %ae %s' 2019-02-06 rmhasan@google.com Fixes issue for tests that are skipped via calling self.skipTest() Created with: gclient setdep -r src/third_party/catapult@a3b840037dfd The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:923494 TBR=sullivan@chromium.org Change-Id: I8c58625e605316c58c7d1a7514dc0952b5aa2571 Reviewed-on: https://chromium-review.googlesource.com/c/1455756Reviewed-by:
-
Matt Falkenhagen authored
The UpdateJobTestHelper had a complex start worker sequence. Those operations don't need to be done directly in the start worker IPC mock. This is a small cleanup to help make a big cleanup of the unit test harness to use Mojo. It also cleans up linter warnings along the way. Bug: 927651 Change-Id: Ib3b1a5b698ea6ae2b074863008dcc7f26e01fdd6 Reviewed-on: https://chromium-review.googlesource.com/c/1454337Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#629464}
-
Sam McNally authored
Step by step mode doesn't support concurrent remoteCall calls. Each call overwrites window.step with its own function to continue the call. This is error-prone and can be hard to get right. Avoid this by serializing the remoteCall calls when step by step mode is enabled. Bug: 909056 Change-Id: I8970da4bd56eb9df3f03fdf061e7ba19deb5cc61 Reviewed-on: https://chromium-review.googlesource.com/c/1454208Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#629463}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b11ecd3564d6..5830d87cf137 git log b11ecd3564d6..5830d87cf137 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 thestig@chromium.org Change CXFA_ContentLayoutItem::GetIndex() to return size_t. Created with: gclient setdep -r src/third_party/pdfium@5830d87cf137 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic6f27fe6bdb51c4c6765a3d886169c7af805ab07 Reviewed-on: https://chromium-review.googlesource.com/c/1455371Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I89ec35664f817895065623bb5a1d18b3d65b1953 Reviewed-on: https://chromium-review.googlesource.com/c/1455667Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#629461}
-
Sorin Jianu authored
The code is calling into //components/update_client. The code fails at this time because the network is not initialized yet. Bug: 926236 Change-Id: Ib5b6f6b98bb6054bc9b9dbbc64533201c791057d Reviewed-on: https://chromium-review.googlesource.com/c/1452465 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#629460}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I877d45ff9945a02323ce412497241dcf82f23a03 Reviewed-on: https://chromium-review.googlesource.com/c/1455369Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/67d70d26b08e..484d74fa21a5 git log 67d70d26b08e..484d74fa21a5 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 mmoss@google.com Add 'chromeos' as one of the DEPS_OS_CHOICES. Created with: gclient setdep -r src/third_party/depot_tools@484d74fa21a5 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:928829 TBR=agable@chromium.org Change-Id: I38ca6cd92c076cc0ffe567e138ec2e225ad4b2bd Reviewed-on: https://chromium-review.googlesource.com/c/1455375Reviewed-by:
-
Hiroshige Hayashizaki authored
This CL: - Adds wpt/upgrade-insecure-requests and worker-related subdirectories of wpt/mixed-content. - Fixes the runtime flags for external/wpt/referrer-policy. - Merges multiple README.txt into a single top-level README.md. - Updates README.md to mention classic shared workers. Bug: 835717, 924041 Change-Id: Ifbafe9ca89a0c45d99e23d295430df89125d71ce Reviewed-on: https://chromium-review.googlesource.com/c/1389639Reviewed-by:
-
David Staessens authored
This CL adds a test that measures VDA performance. Currently only decode FPS is captured by measuring uncapped performance. Future performance tests will also measure capped performance. TEST=ran new VDA tests on nocturne BUG=925714 Change-Id: Ia9f65adba4ca077e85bac03727c2bd11cbbcafee Reviewed-on: https://chromium-review.googlesource.com/c/1429306Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7192fd51f570..e0b10f3e2c36 git log 7192fd51f570..e0b10f3e2c36 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 dgarrett@google.com workspace_stage: Add WorkspaceUnitTestStage. Created with: gclient setdep -r src/third_party/chromite@e0b10f3e2c36 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I24deb6338102d6e960005e8440a732b06d227709 Reviewed-on: https://chromium-review.googlesource.com/c/1455600Reviewed-by:
-
Noel Gordon authored
appWindow.fakeKeyDown is async these days so we should await it. Mark audioTimeLeapForward async therefore. Bug: 909056 Change-Id: Iaf72e60a92b3d6c5d9da25410df3768dfb4a6c96 Reviewed-on: https://chromium-review.googlesource.com/c/1454107Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#629454}
-
Bailey Berro authored
- Previously the assertion logic in SmbCredentialDialog treated 0 as an invalid mount_id. Since 0 is a valid mount_id, we want to ensure that the assert is only verifying that mount_id is a number. Bug: 928933 Change-Id: I165f6696252265a66af7de488a624d6fc41e5d22 Reviewed-on: https://chromium-review.googlesource.com/c/1455498 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#629453}
-
khmel@chromium.org authored
This remove runtime dependencies for the ARC++ settings section creation. Not it is created or not created based on ARC++ availibility for the profile. Runtime conditions now controlls hidden state of the ARC++ settings section. TEST=Manually, AOSP mode, new user sign-in, default settings. BUG=915158 Change-Id: I70fd89c710416514675086ae8982b3643ff64c31 Reviewed-on: https://chromium-review.googlesource.com/c/1455056 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#629452}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/09a91e48c066..a69ca6050e3e git log 09a91e48c066..a69ca6050e3e --date=short --no-merges --format='%ad %ae %s' 2019-02-06 capn@google.com Add SPIRV-Tools to the Vulkan build. 2019-02-06 capn@google.com Add Visual Studio project files for SPIRV-Tools. 2019-02-06 capn@google.com Switch to SPIRV-Headers from subtree. 2019-02-06 capn@google.com Suppress Clang warning for unsupported warning. Created with: gclient setdep -r src/third_party/swiftshader@a69ca6050e3e The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I7601f4c69b20599a4446418455dae375308f8141 Reviewed-on: https://chromium-review.googlesource.com/c/1455601Reviewed-by:
-
