- 30 Oct, 2020 40 commits
-
-
Liquan (Max) Gu authored
Changes: * Moved PaymentAppService, PaymentAppFactoryDelegate, PaymentAppFactoryInterface into //components. Note that this CL will break clank in compile time because the GPay integration depends on the changed classes in this CL. A fix[1] on clank will be submitted immediately after this CL. [1] https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/3358145 Bug: 1098908, 1098911, 1142846 Change-Id: Ie3e05b34e5ceb42d40fbc3d472c203297d5b7ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493144 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#822811}
-
Anders Hartvoll Ruud authored
Bug: 979041 Change-Id: I11e132a51dfe8284c1fb7f9ab3f87dbe07e74dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509852Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#822810}
-
Rakib M. Hasan authored
Replace android-weblayer-pie-x86-fyi-rel with a pie tester that will run skew tests on weblayer. Bug: 1114563 Change-Id: I41bba86bb23e7790327f771b4752cc7804a9a72a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504589Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#822809}
-
Brian Sheedy authored
Retries the Telemetry minidump tests up to 2 times on failure. This matches the default behavior when running all of the Telemetry tests via //tools/perf/run_tests, but we need to explicitly request retries in this case since specifying the set of tests to run (BrowserMinidumpTest) causes the retries to default to 0. Bug: 1084931 Change-Id: I9eca291afb4b1eeac69bfd7c1ca68824105c5ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510712 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#822808}
-
Anders Hartvoll Ruud authored
Bug: 1074052 Change-Id: I04682962935ae10e35d2eeb907428c746380235b Fixed: 1096420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510056Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#822807}
-
Katie Dillon authored
This feature has been enabled by default. Bug: 966177 Change-Id: Ib41a4cfb721d9cc5115de8c5569112493b1cc4e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490921 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#822806}
-
Titouan Rigoudy authored
This aligns the code computing `document.addressSpace` with what I believe should be laid out in the spec (PR to come). https://wicg.github.io/cors-rfc1918/#address-space At a high level, we want the address space to reflect where the response data actually came from. Bug: chromium:1142505 Change-Id: Ib7ba5cdca407c3c86af5b58c7c9da982dc355c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460824 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#822805}
-
Henrique Nakashima authored
Bug: 1115268 Change-Id: Ib08fa726f29a39e857f2ee61ba72deac0c9de0f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510771Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#822804}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/eed4cbab5e8c..750109bfd19d 2020-10-30 johnstiles@google.com Update component arrays to use SkSTArray<4, int8_t>. 2020-10-30 johnstiles@google.com Add unit test for error discovered by fuzzer. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I9c4f1aa424e68023386fa5b4baacd38376fcbd40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510651Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822803}
-
Cattalyya Nuengsigkapian authored
- [NIT] fix typos in fullscreen capture label of tablet mode and edit button desc. - Testing: a screenshot of the correction https://storage.cloud.google.com/chromium-translation-screenshots/bd512a7ae20c1d0f18f3c7e935e812185dbefc19 Bug: 1142947 Change-Id: I4b97952ce7c20e05234d6e1cf7940494db8c8a31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510491Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Cr-Commit-Position: refs/heads/master@{#822802}
-
Salvador Guerrero authored
This CL Disables the following test: * ToolbarButtonIphTest#testTabSwitcherButtonIph Because it's flaky on the following builder: * android-pie-x86-rel TBR=mdjones@chromium.org Bug: 1144263 Change-Id: I3d935f8e0ce12c09222f60e6ac28214c0c93cfca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510873Reviewed-by:
Salvador Guerrero <salg@google.com> Commit-Queue: Salvador Guerrero <salg@google.com> Cr-Commit-Position: refs/heads/master@{#822801}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604059108-a438e57d21f2dfad804e970e84edcffc08a2b95c.profdata to chrome-linux-master-1604080750-96a3ce07c396c7c5f9c28dac9995321371c2c9a1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I98fa71d07f443d5cc8f0ed75dc31aa8113f8ab73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510654Reviewed-by:
-
Evan Stade authored
Bug: none Change-Id: I2f242f1c14dc9ce032f4233ae686c651a7ef9f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508334Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#822799}
-
Ana Salazar authored
Bug: 1138409, 1138410 Change-Id: Idab54cc099b32a514678378e83a0dafa200352c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511031 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#822798}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604059108-cc1e9f40825b0164b708aba4465bfece5e57e39b.profdata to chrome-mac-master-1604080750-57b938941e5d0fc2e4e9a8db795b6e934af11898.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1caecd847df12a17e1e48588bdddc010c6708bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510655Reviewed-by:
-
Kramer Ge authored
--enable-webgl-image-chromium flag enables WebGL content to be eligible for overlay. WaylandOverlayDelegation feature (default on in LaCrOS) needs it to delegate WebGL overlays to Ash. If WaylandOverlayDelegation is off, or LaCrOS version is older, overlay strategy will not pick WebGL quads as candidate and they should be properly composited. Change-Id: I59efdda46ba2254d258f29f0fb576fd4a3adaee7 Bug: 1063865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510929Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#822796}
-
Illia Klimov authored
As part of http://crbug.com/1064647 this CL removes DisabledPlugins, DisabledPluginsExceptions, EnabledPlugins policies. Bug: 1083496 Change-Id: I88ad8fc1797d8567c64a110f523387d6cd09d2a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505803Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Illia Klimov <elklm@google.com> Auto-Submit: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#822795}
-
Patrick Noland authored
This fixes a bug where we only suppressed start events for *newly* suspended domains. This works most of the time, but not always, e.g. when switching back to the tab after checking the dashboard in DWB. Bug: 1144245 Change-Id: Ifc5d0a9345eb5ad462cff7775bd1fc2a7b63fe41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510733Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#822794}
-
Liquan (Max) Gu authored
Changes: * PaymentHandlerMediator, PaymentHandlerActivity returns different messages for different errors. * ServiceWorkerPaymentAppBridge combines similar methods into onClosingPaymentAppWindow(). * Added two enums to PaymentEventResponseType in payment_app.mojom and sorted all enums of the type: - PAYMENT_HANDLER_ACTIVITY_DIED - PAYMENT_HANDLER_FAIL_TO_LOAD_MAIN_FRAME Bug: 1091957 Change-Id: Iab712ea3b72965ffd4e2bae6a1bd1c5e4776e441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469116Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#822793}
-
Katie Dillon authored
This CL is a follow-up to this CL[1] which changed MTTQ to own a TaskQueue instead of implementing it. This change adds a getter to the underlying TaskRunner as a step towards removing raw pointer access to MTTQ's TaskQueue. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2453591 Bug: 1143007 Change-Id: I871105ae000867e64cf0142bbe433457bdde3f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504090 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#822792}
-
Joel Hockey authored
Move RefCountedString16 from exo DataOffer to base where it can be reused. Change-Id: I0a3e13b006d690be1605c90da6d46274c4811685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507235 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
bartekn@ has kindly identified r819402 as a source of performance regression in rewriter runtime - the numbers below represent the time (in minutes) of the 1st pass, 2nd pass and the total rewrite runtime: Before crrev.com/c/2488744: 89, 89, 196 After crrev.com/c/2488744: 167, 165, 349 To improve rewrite performance, this CL goes back to unconditionally skipping fields in generated files (i.e. partially reverts crrev.com/c/2488744). This is okay, because we have already gathered and stored the statistics about the skipped fields in generated files here: https://drive.google.com/file/d/1L27GU76qZZspq-AVLdIamsl61FKazPuf/view?usp=sharing Bug: 819402 Change-Id: Ie00b326c800ee68fabe64fd2ad12f18e69bc8f0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507233Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#822790}
-
Collin Baker authored
This allows clients to supply a callback upon starting a promo. When the bubble closes, it will be called. No information is given in this CL. In the future, supplying a close reason is desirable. Bug: 1143465 Change-Id: I6a1af8d6f314cc268e67406371a5414cbc4feb6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508395Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#822789}
-
Olivier Li authored
Previously reasons to skip capturing were checked in both Monitor() and WatchStateSnapshot() which is redundant. This also needs to change to be able to record hang metrics even when we don't want to grab a crash dump. Bug: 1135528 Change-Id: Ie50c57146a9f79d968956ec02f4e24a41c252c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506352Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#822788}
-
Shubham Aggarwal authored
Migrate all uses of the relevant set_* functions on sql::Database to use the new DatabaseOptions constructor instead. This change should have no intended behaviour changes. Bug: 1126968 Change-Id: Ic1f5cbde9420ae64b33353795ed29bffce6dfd0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505794 Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#822787}
-
Yi Gu authored
crrev.com/c/2429236 records SMS receive time and success time. This patch adds metrics to record the time from the API is called to the time a user clicks "Deny" to terminate the verification flow. There's an existing metric called "TimeCancel" which is from the origin trial. After the trial we changed the backend. Since then it no longer record "user" cancellation time. crrev.com/c/2428825 introduced a new catergory "user cancel" and this patch records the timing of such behavior. UKM collection review: https://docs.google.com/document/d/15orQiLx06QSuZr4ShBaozY0dvPzXiTWwJZ9Xk5cgzAA/edit?usp=sharing Bug: 1127402 Change-Id: I1314bf8e3efb4f2817132bc0ef629124b4b10d69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502950Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822786}
-
adamta authored
Reverts cl/2414613 and adds the ability to trigger the Discover feed IPH bubble manually, rather than at the same time as the other bubbles. Stores a reference to the Discover feed header menu button in the ContentSuggestionsCoordinator. This allows for the menu button to be accessed whenever it is needed, in order to create a named guide for the IPH to work. Also, this allows for the feed alert menu to access the button more easily. Change-Id: I7cd50c922af8e2ace6914e680cce7f494e325bb6 Bug: 1139320, 1131571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507386 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#822785}
-
Rohan Pavone authored
RequestMemoryDump, by default, specifies DETAILED memory dumps. This change allows different levels to be specified so the manual memory dump requests, like through Telemetry, can run on platforms that do not support detailed dumps (or that do not wish to request them). Change-Id: Id65e80d7763abace3e3631ace9409ab6fa57b0bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500958Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Rohan Pavone <rohpavone@chromium.org> Cr-Commit-Position: refs/heads/master@{#822784}
-
rbpotter authored
Generate grdps for shared resources and mojo resources from c/b/r/nearby_share, instead of preprocessing and directly including the shared resources from OS settings. This will also simplify the process of moving the nearby shared dialog to use preprocessing and autogeneration. Bug: 1132403 Change-Id: I0a4f77604aafc5ab95b89125edc08ffe7ee53152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505967Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#822783}
-
Caroline Rising authored
Bug: 1109316 Change-Id: I24873f3896d8e19a500d6e9df83da91dbc881ed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510432 Commit-Queue: Caroline Rising <corising@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Auto-Submit: Caroline Rising <corising@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#822782}
-
Dominique Fauteux-Chapleau authored
This removes the following policies from policy_templates.json: BlockLargeFileTransfers AllowPasswordProtectedFiles BlockUnsupportedFileTypes DelayDeliveryUntilVerdict URLsToCheckComplianceOfDownloadedContent URLsToNotCheckComplianceOfUploadedContent URLsToCheckForMalwareOfUploadedContent URLsToNotCheckForMalwareOfDownloadedContent This still leaves some references to those policies in Chrome in tests that map their enum to the new Connector policies, but those are going away as a part of fixing crbug.com/1109242 Bug: 1103390 Change-Id: Ia6b95165ff952f8a5b417292e5fb707e55d92ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508330 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#822781}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I5bb2d12a189b3fb139214ffc6687de2b4e772346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510379Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#822780}
-
Bo Liu authored
Simple copy of chrome on android's implementation, using the equivalent activity lifecycle callbacks. All done in java. Bug: 1143945 Change-Id: Icae399db1c64c5cb872de18f2673270625d7679e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510371Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822779}
-
James Hollyer authored
Pointer Lock should fail without user gesture. However, the logic which checks that is overridden in in web tests. This adds logic to mimic those checks in the overriding class in order to test that the proper error is routed out. A follow up CL is planned to move the actual logic up in the flow so that the real logic is tested. Bug: 1142136 Change-Id: I9d62ad2df0bde3666fe987ea70131378a605ffba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496191Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Henrique Nakashima authored
We've been tracking the size of chrome_java_sources.gni, this makes the process automatic and more accurate. Change-Id: Ide6a912cb5a137349885c84bd45c0894ffd41b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508556Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/25eb373eede4..5a1d786754ad 2020-10-30 kainino@chromium.org Check for deprecation warnings in ValidationTests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I53012496582006b316df190fafcd70cce68c3501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510092Reviewed-by:
-
Collin Baker authored
Fixed: 1143461 Change-Id: Ifc5df8a84188e403af6986bf7e5a7d30c4d066ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508909Reviewed-by:
-
Yuheng Huang authored
Bug: 1099917 Change-Id: Ie97e2092b0b60d28e00c31e0f7c5c32b92d8de28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510357Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#822774}
-
Andrew Grieve authored
And move checking for embedded configs to after expectations code so that it only runs when actually optimizing (took 300ms on my machine). Bug: None Change-Id: I692a7b54f355783565bca58669829008b3820fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510378Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#822773}
-
Alex Moshchuk authored
Previously, the KilledWhileVisible and KilledWhileHiddenThenShown tests relied on sad frame metrics being logged synchronously after a process kill or after a WebContents visibility. Make these tests more robust by explicitly waiting for all sad frames to be shown before checking metrics. This is an attempt to deflake these tests. Additionally, add some explicit expectations around subframe visibility on a shown/hidden a WebContents, to aid debugging in case these tests are still flaky. Bug: 1097060 Change-Id: I05567e9c76f94f32c0f2bbabf47fc2cfa2b013e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509003 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#822772}
-
