GitLab

This patch switches UsbServiceLinux to being initialized with a
SequencedTaskRunner that puts it on its own non-shutdown-blocking
sequence. Individual device connections are also put on their own
sequences because there is no dependency between them and the global
service.

As DeviceMonitorLinux is global and owned by the FILE thread a new
UdevWatcher class has been added which can be owned by each service
that needs to monitor udev and lives on its own sequence.

This should resolve issue 694496 by allowing Chrome to exit even if a
faulty driver or device has locked up the USB service.

BUG=694496

Review-Url: https://codereview.chromium.org/2849953003
Cr-Commit-Position: refs/heads/master@{#468456}

Previously, WMPI used kNoSurfaceID to indicate both that a surface
shouldn't be used for overlays on Android, and that no surface has
been provided yet by the SurfaceManager.  This could lead to a
deadlock if the SurfaceManager actually does return kNoSurfaceID,
and we're on pre-M Android.

This CL represents the surfac ID as a base::Optional, with the
unset state indicating that a call to SurfaceManager is pending.

BUG=

Review-Url: https://codereview.chromium.org/2856643002
Cr-Commit-Position: refs/heads/master@{#468455}

After the direct share icon is clicked, the dialog of context menu
does not dissmiss. This is because onClick event of the direct share
icon does not call dialog to dismiss. To fix the problem, add an
delegate interface for direct share action and implement it in the
TabularContextMenuUi.

BUG=None

Review-Url: https://codereview.chromium.org/2853483003
Cr-Commit-Position: refs/heads/master@{#468454}

BUG=707642

Review-Url: https://codereview.chromium.org/2847203002
Cr-Commit-Position: refs/heads/master@{#468453}

The SAMLPolicyTest.TransferCookiesUnaffiliated test and its PRE-test
were timing out in Debug builds.

There is nothing obvious that can be improved in the test. Also the
timeout times agree to some degree with the slowdown of the Debug mode
measured locally.

Therefore disabling this test in Debug builds.

BUG=683161,714167

Review-Url: https://codereview.chromium.org/2845393002
Cr-Commit-Position: refs/heads/master@{#468452}

PluginPlaceholders are RenderFrameObservers, and render_frames can
go away before the object is actually destructed (during shutdown).

This CL adds the missing null checks needed to prevent trying to use
null pointers.

BUG=693120
R=raymes@chromium.org

Review-Url: https://codereview.chromium.org/2845413002 .
Cr-Commit-Position: refs/heads/master@{#468451}

https://pdfium.googlesource.com/pdfium.git/+log/b8e00f247803..a0a69233cafa

$ git log b8e00f247..a0a69233c --date=short --no-merges --format='%ad %ae %s'
2017-05-01 tsepez Remove more |new|s, part 5

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: If0b0a847696fdb7d64b8ebf186af9e0db4a5652f
Reviewed-on: https://chromium-review.googlesource.com/491929
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468450}

BUG=707642

Review-Url: https://codereview.chromium.org/2846283002
Cr-Commit-Position: refs/heads/master@{#468449}

changes:
(1) When entering the tablet mode, the status area tray will always show the rotation lock auto or locked.
(2) For system tray menu, the locked state is divided into two states: landscape and portrait.

crbug.com/704923 #9 shows the UI implementation.

BUG=704923
TEST=tested on device

Review-Url: https://codereview.chromium.org/2846883006
Cr-Commit-Position: refs/heads/master@{#468448}

Also removed some delegate-to-superclass-only
DeprecatedInvalidationPaint() because there is no more naming
conflict with the new version.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2851453005
Cr-Commit-Position: refs/heads/master@{#468447}

A series of tests are flaking right now due to SessionController.cc issue.

This disables those tests while I work on a fix.

TBR=sky@chromium.org
TEST=mash_browser_tests
BUG=717176

Review-Url: https://codereview.chromium.org/2852963003
Cr-Commit-Position: refs/heads/master@{#468446}

I was unable to completely switch over to const ModelTypeSet& usage in
the syncer, as during a NormalSyncShare we modify the ModelTypeSet*
during GetUpdates, so when we Commit we have a reduced set of types.

BUG=

Review-Url: https://codereview.chromium.org/2850213002
Cr-Commit-Position: refs/heads/master@{#468445}

This line was mistakenly added in:

https://codereview.chromium.org/2839183002/

BUG=717099

Review-Url: https://codereview.chromium.org/2853013003
Cr-Commit-Position: refs/heads/master@{#468444}

The method returns true if the table has "border-collapse: collapse"
style. A better name could be CollapsesBorders() to reflect its
purpose, but both this name and the original name are easily confusing
with another method "CollapsedBorders()".
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2850633003
Cr-Commit-Position: refs/heads/master@{#468443}

BUG=176436

Review-Url: https://codereview.chromium.org/2843213002
Cr-Commit-Position: refs/heads/master@{#468442}

Caused by https://codereview.chromium.org/2836293003. Instead detect
when margin has moved a float completely out of its former position
and mark any affected siblings for layout.

BUG=716385

Review-Url: https://codereview.chromium.org/2846923003
Cr-Commit-Position: refs/heads/master@{#468441}

These tests are still flaky when virtualized GL contexts are used in
the command buffer. So far no luck reproducing these failures locally.

BUG=694359
TBR=zmo@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2853133002
Cr-Commit-Position: refs/heads/master@{#468440}

For now start with content_browsertsts with network service enabled.

(chromium repo change)

BUG=713857

Review-Url: https://codereview.chromium.org/2848013002
Cr-Commit-Position: refs/heads/master@{#468439}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/2b7090e93566..9300a23423c0

$ git log 2b7090e93..9300a2342 --date=short --no-merges --format='%ad %ae %s'
2017-05-01 eakuefner [Dashboard] Implement add_histograms_queue
2017-05-01 simonhatch Dashboard - Fix email_summary for internal_only.

Created with:
  roll-dep src/third_party/catapult
BUG=716025


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I8ff3ac7ca1fea1f131d1bb0cc5c166dd6f44d103
Reviewed-on: https://chromium-review.googlesource.com/491907
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468438}

BUG=717201

Review-Url: https://codereview.chromium.org/2853013004
Cr-Commit-Position: refs/heads/master@{#468437}

https://chromium.googlesource.com/angle/angle.git/+log/f584177..d262799

BUG=chromium:716323,715875,705865

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2851303002
Cr-Commit-Position: refs/heads/master@{#468436}

Top frames of the crash stack don't make much sense. Checking the
obvious sources of memory access issues.

BUG=715761

Review-Url: https://codereview.chromium.org/2856633002
Cr-Commit-Position: refs/heads/master@{#468435}

BUG=707638

Review-Url: https://codereview.chromium.org/2849903002
Cr-Commit-Position: refs/heads/master@{#468434}

When a user modifies a bound input's text and presses Enter, the bound callback
would fire once on keydown and once on the following 'change' event.  This CL
prevents the default 'change' event from following up to avoid two calls.

BUG=621922

Review-Url: https://codereview.chromium.org/2843203003
Cr-Commit-Position: refs/heads/master@{#468433}

Part 3/2.

BUG=713847

Review-Url: https://codereview.chromium.org/2856593002
Cr-Commit-Position: refs/heads/master@{#468432}

Per request here: http://crbug.com/714166

R=dgozman
BUG=714166,715405

Review-Url: https://codereview.chromium.org/2850923002
Cr-Commit-Position: refs/heads/master@{#468431}

Revert of Restore tests for single-sample storage in histograms. (patchset #1 id:1 of https://codereview.chromium.org/2850233002/ )

Reason for revert:
The mac dbg builder has started failing again. See https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.9_Tests__dbg_%2F40054%2F%2B%2Frecipes%2Fsteps%2Fbase_unittests%2F0%2Flogs%2FNonThreadSafeDeathTest.DestructorNotAllowedOnDifferentThreadInDebug%2F0 :
[ RUN      ] NonThreadSafeDeathTest.DestructorNotAllowedOnDifferentThreadInDebug

[WARNING] ../../testing/gtest/src/gtest-death-test.cc:834:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 4 threads.
../../base/threading/non_thread_safe_unittest.cc:140: Failure
Death test: { NonThreadSafeClass::DestructorOnDifferentThreadImpl(); }
    Result: died but not with expected error.
  Expected: Check failed
Actual msg:
[  DEATH   ] The process has forked and you cannot use this CoreFoundation functionality safely. You MUST exec().
[  DEATH   ] Break on __THE_PROCESS_HAS_FORKED_AND_YOU_CANNOT_USE_THIS_COREFOUNDATION_FUNCTIONALITY___YOU_MUST_EXEC__() to debug.
[  DEATH   ] The process has forked and you cannot use this CoreFoundation functionality safely. You MUST exec().
[  DEATH   ] Break on __THE_PROCESS_HAS_FORKED_AND_YOU_CANNOT_USE_THIS_COREFOUNDATION_FUNCTIONALITY___YOU_MUST_EXEC__() to debug.
[  DEATH   ] Received signal 11 SEGV_MAPERR 000000000110
[  DEATH   ]  [0x00010bd9c12e]
[  DEATH   ]  [0x00010bd9c1cd]
[  DEATH   ]  [0x00010bd9a65c]
[  DEATH   ]  [0x00010bd9c017]
[  DEATH   ]  [0x7fff915c85aa]
[  DEATH   ]  [0x000000000000]
[  DEATH   ]  [0x7fff95a203f9]
[  DEATH   ]  [0x7fff95a2001b]
[  DEATH   ]  [0x7fff95a1fbed]
[  DEATH   ]  [0x7fff957349cb]
[  DEATH   ]  [0x7fff90a97899]
[  DEATH   ]  [0x7fff90a9772a]
[  DEATH   ]  [0x7fff90a9bfc9]
[  DEATH   ] [end of stack trace]
[  DEATH   ]
[  FAILED  ] NonThreadSafeDeathTest.DestructorNotAllowedOnDifferentThreadInDebug (533 ms)

From looking at 705342 it seems as though your changes failed with a similar error before and were reverted. Specifically NonThreadSafeDeathTest.DestructorNotAllowedOnDifferentThreadInDebug . I'm going to revert and see if it fixes things.

Original issue's description:
> Restore tests for single-sample storage in histograms.
>
> These tests were removed from the main CL because they were
> believed to be the cause of some instability in other tests.
> Without the tests, everything seems fine so now it's time to
> restore these.
>
> Main CL: https://codereview.chromium.org/2811713003/
>
> BUG=705342
>
> Review-Url: https://codereview.chromium.org/2850233002
> Cr-Commit-Position: refs/heads/master@{#468396}
> Committed: https://chromium.googlesource.com/chromium/src/+/da4b99838d459396d412bc278358b7f335ac0fdc

TBR=asvitkine@chromium.org,bcwhite@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=705342

Review-Url: https://codereview.chromium.org/2851363002
Cr-Commit-Position: refs/heads/master@{#468430}

(code health)
BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2847963003
Cr-Commit-Position: refs/heads/master@{#468429}

Overlay scrollbars expand when mouse is near the whole scrollbar today.
In this patch, we change it to expand only when mouse is near thumb.

We pass mouse position to SingleScrollbarAnimationControllerThinning
instead of calculating the distance from mouse position to scrollbar in
LayerTreeHostImpl.

In SingleScrollbarAnimationControllerThinning::DidMouseMove we
calculate:

1. distance from mouse to scrollbar: determind should scrollbar keep
appear, fade out or hover fade in.
2. distance from mouse to scrollbar thumb: determind should thick/thin
scrollbar

BUG=713218
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2841943002
Cr-Commit-Position: refs/heads/master@{#468428}

R=mark@chromium.org

Review-Url: https://codereview.chromium.org/2856723002
Cr-Commit-Position: refs/heads/master@{#468427}

This CL changes the SUBRESOURCE_FITER which is not a valid category
type to SUBRESOURCE_FILTER which is valid.

BUG=716661
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2851933002
Cr-Commit-Position: refs/heads/master@{#468426}

This CL retires some file deletion related metrics for JumpList since
they're no longer needed.

Accordingly, the JumpList file deletion related methods are updated to
return nothing instead of the detailed delete status which is used for
the retiring metrics. This makes the ENUMs for the delete status no
long needed so they're removed. These methods are also refactored a
little bit to make them cleaner.

BUG=40407, 179576

Review-Url: https://codereview.chromium.org/2836363003
Cr-Commit-Position: refs/heads/master@{#468425}

The test ensures that DefaultSettingsFetcher never returns null even when fetching default settings fails.

BUG=716372

Review-Url: https://codereview.chromium.org/2850103002
Cr-Commit-Position: refs/heads/master@{#468424}

The blocking pool is being deprecated in favor of TaskScheduler.

BUG=667892
R=alemate@chromium.org

Review-Url: https://codereview.chromium.org/2834343003
Cr-Commit-Position: refs/heads/master@{#468423}

BUG=703369

Review-Url: https://codereview.chromium.org/2855463003
Cr-Commit-Position: refs/heads/master@{#468422}

The blocking pool is deprecated. base/task_scheduler/post_task.h
should be used instead. More than 180 CLs to migrate the blocking
pool to base/task_scheduler/post_task.h have landed (ref. bug).

BUG=667892

Review-Url: https://codereview.chromium.org/2841173002
Cr-Commit-Position: refs/heads/master@{#468421}

BUG=703369

Review-Url: https://codereview.chromium.org/2854553002
Cr-Commit-Position: refs/heads/master@{#468420}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/df06cc9f..58c56c18

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2856643003
Cr-Commit-Position: refs/heads/master@{#468419}

This CL:
1. Fixes the screen tearing issue by getting rid of the GLKViewController,
   which runs its rendering loops and swaps buffers in unexpected moment. The
   GL view will now do on-demand buffer swapping, similar to how the Android
   client works.
2. Passes GL view dimensions to the renderer to fix the screen aspect issues.

BUG=716699

Review-Url: https://codereview.chromium.org/2848143002
Cr-Commit-Position: refs/heads/master@{#468418}

The new constructor accepts any number of TaskTraits in any order.

E.g.
constexpr TaskTraits default_traits;
constexpr TaskTraits user_visible_traits = {TaskPriority::USER_VISIBLE};
constexpr TaskTraits user_visible_may_block_traits = {
    TaskPriority::USER_VISIBLE, MayBlock()};
constexpr TaskTraits other_user_visible_may_block_traits = {
    MayBlock(), TaskPriority::USER_VISIBLE};

BUG=713683

Review-Url: https://codereview.chromium.org/2829083002
Cr-Commit-Position: refs/heads/master@{#468417}