GitLab

Holding space item views depend on HoldingSpaceItemViewDelegate owned by
the HoldingSpaceTray. The delegate is reset with HoldingSpaceTrayBubble
when the bubble is closed, which happens before the bubble widget gets
torn down. Given that widget is destroyed asynchronously, there's a
short time interval where holding space item container views are still
around, but the delegate they depend on is destroyed - if a new item
gets added at this time, it would cause usage of deleted delegate.
(Found by tests added in CL:2493323).

To prevent this, remove container views from holding space controller
model and controller immediately when the HoldingSpaceTrayBubble gets
reset.

Change-Id: Icf5c523027ad352adff11ce9856a82bd93a7e4c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503628Reviewed-by: David Black <dmblack@google.com>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821361}

To make TWA and WebAPK the same.
As far as I can tell, there is no visual difference.

Since both TWA and WebApk can do it in the shared SplashController,
TwaSplashController doesn't need the lifecycleDispatcher anymore.

Bug: 1129093
Change-Id: I320ece59b28d2c5b39da0869f97f5ac2baf5f9cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414845Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821360}

This is the boundary between Commander internals and the rest of the
system.

Also includes the enable check and current logic (command line flag),
though nothing will happen until Initialize is hooked up (and nothing
*interesting* will happen until the WebUI CL lands).

Bug: 1014639
Change-Id: I9063766657fb4bceb8bbf11faab8655b515315a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500245
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821359}

This CL annotates the OverviewModeBehavior and OverviewModeObserver
interface, and the EmptyOverviewModeObserver class as deprecated to
avoid new usage.

Change-Id: Ic1f0da301e67a0f302492c9e1f41fab3b2a5fbb3
Bug: 1108496
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501071
Commit-Queue: Mei Liang <meiliang@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821358}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/47c8f45b..20aa521f

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I22e0197ef32e327e24eb2696ea4a27f333eb3590
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502671Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821357}

SetFocusForPlatform() was used to override Button and its subclasses'
focus behavior. Now the platform default focus behavior becomes Button's
default setting. This API is no longer needed.

Bug: 1001103
Change-Id: I565e9e85b7146b35794d52a23df2143e7008d3c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499421Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821356}

Also test that it can IgnoreResult a callback with arguments and the
resulting callback will still accept those arguments.

R=dcheng@chromium.org

Bug: 1140582
Change-Id: If01cd5442f1ef0185fce74f6952cbdf54aaef07a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503769Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821355}

Add a few share features to the testing config. These features
will be tested in beta soon as the sharing hub is launching.

Bug: None
Change-Id: I960930af2185b30bb749609084bc1bd76bb03d5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495403
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821354}

The FuchsiaCdmManager needs to create directories for each origin to
pass to the platform CDM services to fulfill EME origin isolation
requirements. The FuchsiaCdmManager runs on the main thread and the
calls to CreateDirectoryAndGetError are potentially blocking. This CL
moves the directory creation step to a background task.

Bug: 1140655
Change-Id: I060edc909976e7b5a493afc3bc9a2a26e26994be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500532Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: RJ Ascani <rjascani@google.com>
Cr-Commit-Position: refs/heads/master@{#821353}

The new Delegate class is called to open the connected device
settings UI.

This refactor is allows:
  * logging the current screen when the button is pressed
  * a unit test case for pressing the settings button

BUG=1138137,1106937

Change-Id: I71af2ec6c00813536c15f684fdb8459f4671cada
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501072Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821352}

Continuation of crrev.com/c/2463047

This requires moving other structures and functions from
partition_alloc.* into their own, new files.

Change-Id: I8ceb9966787ef0b4240790f8a77fa46d35efa455
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498022
Commit-Queue: Bartek Nowierski <bartekn@chromium.org>
Auto-Submit: Bartek Nowierski <bartekn@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821351}

Updates the expires_after attribute for 111 histograms that show
frequent access in the past 90 days.  These are the 95% most
frequently used histograms over that time that do not already
have a date later than or within 60 days of 2021-01-25.

TBR=chromium-metrics-reviews@google.com

Change-Id: I668f13de1ed48c53a6701d7567244f942d9fdc74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502393Reviewed-by: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Cr-Commit-Position: refs/heads/master@{#821350}

Before adding a fifth schema migration, move the existing migration code
into their own separate functions.

Bug: 984163
Change-Id: Id36caabf7582e180f70206f28e6e31e8ff3833b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500265Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Auto-Submit: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821349}

This reverts commit 2251f312.

Reason for revert: <crbug.com/1142433>

Original change's description:
> Ensure that devtools stays visible when window is made smaller.
>
> Original CL - https://chromium-review.googlesource.com/c/chromium/src/+/1665550
>
> Original CL didn't account for left and bottom docked dev tools. This
> CL handles those cases by looking at the incoming strategy.bounds.
>
> Bug: 974178
> Change-Id: Ic2b7f0b8b642d884f563815b2ccc94a94d423eeb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472612
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#817363}

TBR=caseq@chromium.org,davidbienvenu@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 974178
Change-Id: I681deef3e8a0b939f1876190df62bace8946fb7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502455Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821348}

NavigatorXR is fairly trivial, and XRSystem can just hang off of
Navigator directly.

Change-Id: Ied94d8e303c3d407f14531c85c860c366ee2183e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494822Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821347}

This is useful for developers to locate a shard from a test name, when
there are multiple shards for a suite.

Bug: 1047704
Change-Id: Ie107d145036e85ca60fe44305fc33ddb17d30ef1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495792Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821346}

All hosts should now (as of several years ago) be set up using a
robot account so the codepath to handle host registration for a person
account is no longer useful.  Removing it to clean up the logic and
prevent future confusion.

Change-Id: I7cb813dc05e9eb79a76d04ea37a80470edd66d73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495981
Commit-Queue: Joe Downing <joedow@google.com>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821345}

The GPU workaround wasn't being passed to Skia when running with Vulkan.
In general, GPU workarounds aren't implemented for Vulkan so remove the
GPU workaround and add a real flag. Set the GrContextOption based on the
flag from GetDefaultGrContextOptions() so it's picked up everywhere.

Bug: 1138979
Change-Id: I469a7b38517e62f0577673ac1b8c1430fee9f55a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502952Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821344}

This CL pulls the holding space tray icon out into a separate class.
Moving forward, the new HoldingSpaceTrayIcon will be modified to add
support for a content forward UI and accompanying motion spec. Changes
will be gated by a new feature flag (or param to the existing flag).

No changes should be visible to the user as a result of this CL.

Bug: 1142572
Change-Id: I21f85f37eeb595f7aa9ac3c79a171634b22e939b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499376Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#821343}

Changes:
* Separated PaymentRequestService#Delegate into the common part (will be
shared with WebLayer) and the Chrome part (moved into
ChromePaymentRequestService#Delegate). After the change, the Chrome
part has the TWA and basic-card related logic (skipUiForBasicCard).
* skipUiForBasicCard is used by both java tests and browser tests. The
java tests depends on its being overridden in
PaymentRequestServiceObserverForTest#onPaymentRequestCreated. The
browser test depends on its being overridden in
PaymentRequestTestBridge#PaymentRequestDelegateForTest
#skipUiForBasicCard (which was buggy as it was not set)

Bug: 1142636

Change-Id: I4556f025e5a1c646d26bd4768724ac8ddcf9e874
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499323
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821342}

Bug: 1088919
Change-Id: Iabd3bf97ec3abd8ccb5e54ca63e201fdfc2867a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485942Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821341}

This CL adds an optional experiment param that controls what positions
of the navigation prediction can be prefetched if they are eligible.
In practice, this will hopefully control the number of prefetches that
occur on searches where the first eligible link is pretty far down the
page.

The param is a CSV instead of a min/max to allow fine-grained control.

Bug: 1141988
Change-Id: I35d581e10c291f6aaca79370c9f8f23aca76e40d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495965Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821340}

Adds an implementation for the ctor/dtor.

Bug: 1128204
Change-Id: Id5f1534333909d88c44c988258df1007adb3f285
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503195
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Auto-Submit: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821339}

This CL was uploaded by git cl split.

R=tiborg@chromium.org

Bug: 1142671
Change-Id: Ie2aff35d42822e95da7a00b10c1d0e791998e25c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500490
Auto-Submit: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821338}

https://chromium.googlesource.com/catapult.git/+log/4f6c1bb4191b..a01dd2af4292

2020-10-27 bsheedy@chromium.org [typ] Add ResultSink support

Manually rolling Catapult as automatic roll failed. The changes in
Catapult repo require updates in chromium repo.

Bug: chromium:1104252
Change-Id: Ifca77cd77b141e4561091c95acceeeb15530f761
TBR: bsheedy@chromium.org, agrieve@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503190Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821337}

Conversion is complete and exception is no longer needed.

Bug: 1007794
Change-Id: I53ca46ad6405f9de6792d022c7d4416509cc025d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503808
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Auto-Submit: Renjie Tang <renjietang@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821336}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/64543505bd67..ea2a4adced5c

2020-10-27 andoli@chromium.org [ts] Typecheck snippets/SnippetsQuickOpen.js with TypeScript
2020-10-27 ciccolella.krishnal@gmail.com [WebAuthn]: Add highlight to focused checkboxes
2020-10-27 tvanderlippe@chromium.org Typecheck formatter/ScriptFormatter.js with TypeScript

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1127286
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ie950d080ea63ce46926033591b545dc5a4f0120b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502836Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821335}

Bug: 1141527
Change-Id: Id1df958b7c413adc2b04a401c2723bece05e9c72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492661Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#821334}

This should help us debug the ongoing issue of old
Finch configs being served to users.

R=mpearson@chromium.org

Bug: b/167728915
Change-Id: I394a0b2d08e6b40476725e3e901149372723b862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500533
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Auto-Submit: David Schinazi <dschinazi@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821333}

Bug: 1109240
Change-Id: I70af6c0371edffbaf4bf108cb332683de4c77bdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498880
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821332}

Primary captive portal detection is done in Shill and reflected in
NetworkState::portal_state(). Chrome portal detection is also reflected
in NetworkState, so observing NetworkPortalDetector is not needed.

This enables removal of the per-network tracking of portal
state in NetworkPortalDetectorImpl.

BUG=1133376

Change-Id: I7d610092ec7412da1e7e727ced29ab80b0b6991f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490141Reviewed-by: Kartik Hegde <khegde@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821331}

Remove two obsolete flags: FLAGS_quic_bbr_rtt_variation_weight and
FLAGS_quic_ietf_draft_version.

Every remaining flag is a reloadable flag or a restart flag, all
Boolean.  Remove type argument.

Change-Id: I0b9d6db33b82968c05aa8025d86921f1df7a29b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502751Reviewed-by: David Schinazi <dschinazi@chromium.org>
Reviewed-by: Victor Vasiliev <vasilvv@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821330}

ids.

We encountered a device that reserves three-finger touches for a
system-defined gesture, so it cancels all touch points at the moment the
third finger touches the screen.  But the device wrongly sends a
pointercancel for the third finger without sending a corresponding
pointerdown first.  This caused Blink to fire a pointercancel with a new
id, which is not a valid event sequence!

This CL suppresses such pointercancel events.

Bug: 1007164
Change-Id: I0af68ac229e56344ee013a8e65fe18b3cc4e9fd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488181
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821329}

This CL modifies the context menu behavior to match the new speech
submenu behavior on the New Tab Page.

Bug: 1141372
Change-Id: Icb79a66290d1c49b132ce0bef123a91facf7d67c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500423Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Angela Yoeurng <yoangela@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821328}

BUG: 1142196

Change-Id: I5d3ad265e026ba93a3b2d69866b0ef29dda72113
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495462Reviewed-by: Orin Jaworski <orinj@chromium.org>
Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru>
Cr-Commit-Position: refs/heads/master@{#821327}

* Adds a flag for disabling -checkdiscard failures
* Contains fix for assertions being removed when code coverage
  is enabled.
* Contains fix needed for vertical class merging

Bug: 1040534
Change-Id: I6e5eb6242a6126fd4293920bff5267149fabbe1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489729
Commit-Queue: Sam Maier <smaier@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821326}

StyleRuleKeyframes internally stores its name with an AtomicString but
returns it as a String, while there are some other code using StringImpl
for a keyframes name, which causes some confusion.

So this patch unifies all such code to use AtomicString.

Change-Id: Ic7eeff262bcb2ff1c055c9a36ce43ff03ccee1cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500954
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821325}

This CL is the third part of an effort to port the existing Desktop
feature to Android. This feature enables a user to send an image to
Google to process to generate a descriptive alt text if a website
does not provide one.

Design Doc: go/2020-q1-android-image-descriptions
Slide Deck: go/clank-imageDescriptions
Launch Bug: 1057168

Original Desktop Design Doc for reference:
go/chrome-a11y-annotations-design

This is a conservative approach, we use a separate set of profile
Prefs for this feature rather than syncing with the Desktop Prefs.
This can be updated in time as needed. We have also hidden the
entire feature behind a feature flag, so this CL is not visible
to an average user.

----------

This CL adds the following:

- Adds helper text/hint for unlabeled images
- Adds returned image description to node's inner text
- Associated strings etc for above

----------

Binary-Size: Size increase is unavoidable, it comes from adding necessary content strings and descriptions for translations.
AX-Relnotes: Adds feature to enable generating alt image descriptions, currently behind a feature flag.
Bug: 1057169
Change-Id: I6becb973045e127681136a1fe0b7171d5cbddca8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317712Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Mark Schillaci <mschillaci@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Cr-Commit-Position: refs/heads/master@{#821324}

This CL updates the behavior of aria-current nodes on Android.

With this change, the value of aria-current (e.g. "date",
"page", "location", etc.) will be read as a part of the state
description for that node on Android. For example, if
aria-current="page", then the node will announce "current page".

We append this status as part of the state description in the
AccessibilityNodeInfo object.

This CL also updates associated unit test expectations.


AX-Relnotes: aria-current nodes now explicitly announce their state.
Bug: 1093578
Change-Id: I6028f235e663e7df5ce4e626db16f68acbbc9b65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493660Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Mark Schillaci <mschillaci@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Cr-Commit-Position: refs/heads/master@{#821323}

We don't want to sync chrome-untrusted: or devtools: schemes to user
profiles. They are internal details about system apps. This cl brings
the behavior of those schemes in line with how the chrome: scheme works.

Bug: 1044864
Change-Id: Ia3549a57840d071826dda02d0f38b242404ed0a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493260
Commit-Queue: Dominic Schulz <dominicschulz@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821322}