- 04 Jan, 2019 40 commits
-
-
Jamie Madill authored
The passthrough command decoder uses robust buffer access behaviour. This makes OOB error checks unimportant because OOB accesses will not cause errors. OOB accesses will also return implementation-dependent values. See the KHR_robust_buffer_access_behavior spec for more information. This will allow ANGLE to selectively disable range checking when robust buffer access behaviour is enabled. This applies to DrawArrays calls only. DrawElements already had the robust buffer access check instated. Bug: angleproject:3000 Change-Id: I3bf5f694d740025a9c40142bb5b0a7801489a70a Reviewed-on: https://chromium-review.googlesource.com/c/1396298Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#619996}
-
Steven Bennetts authored
This moves //chromeos/cryptohome from //chromeos public_deps to deps so that other components (chrome, ash, extensions, arc) must depend on it explicitly. This will also allow the dependency to be removed from src/ash. For explicit dependency add to components/arc/BUILD.gn: TBR=hidehiko@chromium.org Bug: 918682 Change-Id: I660aedbdb04b4edd9f6308d27135be9d5aab8276 Reviewed-on: https://chromium-review.googlesource.com/c/1394865 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#619995}
-
Jérôme Lebel authored
Setting "Sign in to Chrome" as the AccountSignInItem title. Related to crrev.com/c/1392962 Change-Id: I2b2eef3320dd1455e0b1db6a564699ee9e0596a1 Reviewed-on: https://chromium-review.googlesource.com/c/1396125 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#619994}
-
Nicolas authored
This class can listen for prefs changes, and pre-compute/convert types for the BrowserSwitcher prefs. It also checks whether the prefs are managed or not, and offers getters to conveniently access the prefs. Change-Id: I64a218f10e30193b8a322c49f1ae08feaf80a128 Reviewed-on: https://chromium-review.googlesource.com/c/1393450 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#619993}
-
Manu Cornet authored
This is the first step of an effort to de-duplicate some code between ShelfButton, AppListButton, BackButton, ShelfControlButton. This makes the class inheritance of ShelfControlButton a lot closer to ShelfButton. None of the functionality of ImageButton is used anyway, so inheriting from plain Button directly makes more sense. Bug: 714781 Change-Id: I20cdc87b39a82ea70813ca7492df79890a255126 Reviewed-on: https://chromium-review.googlesource.com/c/1395565Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#619992}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d16e9a9b..6bff88d7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I012c9e2d1fd4805463f13b7b30239491e720f348 Reviewed-on: https://chromium-review.googlesource.com/c/1396228Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619991}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/43f09d829d87..b428ef224ff5 git log 43f09d829d87..b428ef224ff5 --date=short --no-merges --format='%ad %ae %s' 2019-01-04 fmayer@google.com Bump flush timeout in client and service to 5s. Created with: gclient setdep -r src/third_party/perfetto@b428ef224ff5 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:121352331 TBR=perfetto-bugs@google.com Change-Id: I8f8c97ede843eb0e0f14a5e2f4ac3c98486bb1d6 Reviewed-on: https://chromium-review.googlesource.com/c/1396185Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619990}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I3f2f3a9a1b0e7f593373c0a9c9d8bcfaebcd07da Reviewed-on: https://chromium-review.googlesource.com/c/1396338Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#619989}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/39a48a8a5d7d..6551d805f7ca git log 39a48a8a5d7d..6551d805f7ca --date=short --no-merges --format='%ad %ae %s' 2019-01-04 jclinton@chromium.org Reland "cbuildbot/manifest_version.py: Use Gerrit autosubmit feature throughout" Created with: gclient setdep -r src/third_party/chromite@6551d805f7ca The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Id9afa1ade12492313d9d152cec8e0b3cb035c686 Reviewed-on: https://chromium-review.googlesource.com/c/1396183Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/93158ebede89..110bc7918fc2 git log 93158ebede89..110bc7918fc2 --date=short --no-merges --format='%ad %ae %s' 2019-01-04 cwallez@chromium.org Validate EndPass isn't called more than once. 2019-01-04 cwallez@chromium.org dawn_native: Add Instance and Adapters 2019-01-04 cwallez@chromium.org Vulkan: Print the VkResult value on device creation failure. 2019-01-04 cwallez@chromium.org WireServer: check buffer exists before sending the map callback 2019-01-04 cwallez@chromium.org WireCmd: guard against overflows when computing array sizes 2019-01-04 yunchao.he@intel.com Unify the compare function for sampler and depth stencil Created with: gclient setdep -r src/third_party/dawn@110bc7918fc2 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918254,chromium:917555,chromium:918254,chromium:918094,chromium:918348,chromium:918260 TBR=cwallez@chromium.org Change-Id: I4fe10af6d77616459112369b6414dc5b18b3cee4 Reviewed-on: https://chromium-review.googlesource.com/c/1396182Reviewed-by:
-
Mason Freed authored
With this CL, there are more early-outs in UpdateCompositorFilterOperationsForBackdropFilter and CreateCompositorFilterOperationsForBackdropFilter in the case where there isn't a backdrop filter present. Also combined BackdropFilterBounds and BackdropFilterReferenceBox, as the latter was not used anywhere else. And added a backdrop-filter test that uses an SVG reference filter. Bug: 497522 Change-Id: If6807f774fa0a552ee57b584839ad960fdc27189 Reviewed-on: https://chromium-review.googlesource.com/c/1393943Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#619986}
-
Miguel Casas authored
As explained in crbug.com/878255#c13, MR should not take into account MediaStreamTrack::IsEnabled() to start recording a given MediaStreamTrack: when they are disabled, they produce either black VideoFrames or all zero Audio -- but that's a legit content and should be recorded. This CL fixes that and adds a LayoutTest. TBR=foolip@chromium.org Bug: 878255 Change-Id: I4be380e838d3287acae7737efb7075e195ac65fd Reviewed-on: https://chromium-review.googlesource.com/c/1393538Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#619985}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5f1692c60a43..be7fc466271b git log 5f1692c60a43..be7fc466271b --date=short --no-merges --format='%ad %ae %s' 2019-01-04 egdaniel@google.com Restrict ops that can be executed when we have a wrapped vulkan secondary command buffer. Created with: gclient setdep -r src/third_party/skia@be7fc466271b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I06b34b6a2f7fa128910450cc0368df8201d12445 Reviewed-on: https://chromium-review.googlesource.com/c/1396179Reviewed-by:
-
Ted Choc authored
This can be handled w/o a server side config now. BUG=918895 Change-Id: I47393da7efd42259f170e19f37a4feee24fc83b0 Reviewed-on: https://chromium-review.googlesource.com/c/1394863Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#619983}
-
Bo Liu authored
In preparation for new draw functor which does not have synchronous invoke to free render thread resources, change all resource return to posting to UI thread instead. Correctness is relatively simple: if BrowserViewRenderer is destroyed then there is no need to return any resources. Otherwise resources are returned eventually. Detach/shutdown has the same logic. RTM just neends to ensure all resource returns are posted. There are some potential perf downsides: There will be more tasks on the UI thread. This is not really avoidable. Can no longer synchronous return resources before starting a new frame. This may cause higher resource usage. This is technically avoidable but is technically complicated, so go with the simple solution first. Bug: 900965 Change-Id: Id34d05a575799f2cf22166da595ba5e062c0078c Reviewed-on: https://chromium-review.googlesource.com/c/1385854Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#619982}
-
Dominik Röttsches authored
As this helper function will be used by font_cache_skia_win.cc as well, move it out to FontCache and share the implementation between backends. Bug: 889864 Change-Id: Ic0d6c3eec1cd7689af7f2e394b9f83c8487dd22a Reviewed-on: https://chromium-review.googlesource.com/c/1396020 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#619981}
-
Antoine Labour authored
PPB_Compositor is going away, so replace with PPB_Graphics3D. Also fix logic related to submitting frames while callbacks are pending (might be related to test flakiness). Bug: 918951 Change-Id: I232c87525f39e268c6fd26072cb465c07fc4256b Reviewed-on: https://chromium-review.googlesource.com/c/1395144Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#619980}
-
Steve Kobes authored
Also use std::unordered_map instead of std::map in BasicIntervals, which is much faster. Bug: 581518 Change-Id: If36a6a70bdf5a4d02d87c66a2ee8264441602388 Reviewed-on: https://chromium-review.googlesource.com/c/1394402Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#619979}
-
Eric Karl authored
GL uses triple buffering, but Vk was set to use double in most cases. Bump Vk to triple buffering for now. Change-Id: I8e68106b5f0306eb6867382d58d1195341d62a07 Reviewed-on: https://chromium-review.googlesource.com/c/1388223Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#619978}
-
Xida Chen authored
leak TBR=maxmorin@chromium.org NOTRY=true Bug: 919117 Change-Id: I74df3710087857eaab2a44e8d1751b4bc7df4a19 Reviewed-on: https://chromium-review.googlesource.com/c/1396235Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619977}
-
Steven Bennetts authored
This forces explicit dependencies for code relying on //chromeos/login. Only code that is part of the Chrome process should have these deps. For minor BUILD.gn changes: TBR=rdevlin.cronin@chromium.org,hidehiko@chromium.org Bug: 918682 Change-Id: Ic443725f1f6763e36a7214f569542822db94482c Reviewed-on: https://chromium-review.googlesource.com/c/1394800 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/936a99460834..f3d4ab343082 git log 936a99460834..f3d4ab343082 --date=short --no-merges --format='%ad %ae %s' 2019-01-04 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@f3d4ab343082 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I5972a30c28af89df8c6b29da5a70ce002ef04746 Reviewed-on: https://chromium-review.googlesource.com/c/1396186Reviewed-by:
-
Roger McFarlane authored
This CL annotates as obsolete and removes the code which generates the following histograms: Autofill.Unknown.HttpResponseOrErrorCode Autofill.Unknown.RequestDuration Autofill.Unknown.BackoffDelay Autofill.Unknown.FailingPayloadSize Samples for these histograms have never been generated in the wild. Bug: 915891 Change-Id: Ic74997a0326c22dee3dc95267c3157c4d646573f Reviewed-on: https://chromium-review.googlesource.com/c/1396233Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#619974}
-
Jungshik Shin authored
It has one change to update the IANA timezone database to 2018i. See https://chromium-review.googlesource.com/c/1395498 for details. TBR=gsathya@chromium.org Bug: 473288 Test: See the CL description at https://crrev.com/c/1395498 Change-Id: Idefb26be5852a4839a0a6d8cf062b09815b626a4 Reviewed-on: https://chromium-review.googlesource.com/c/1396231Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619973}
-
edchin authored
This CL works towards reducing duplicate code in snapshot_generator.mm. An improvement made in an earlier CL was only made to web view snapshots and not to native views. This CL fixes native view snapshots. Bug: 918032 Change-Id: I37d0a9bdead31ccce8e467846c2927105c0a76c7 Reviewed-on: https://chromium-review.googlesource.com/c/1395878Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619972}
-
Roger McFarlane authored
This CL removes expires-after="M73" for the following histograms: Autofill.Query.BackoffDelay Autofill.Query.HttpResponseOrErrorCode Autofill.Query.RequestDuration These histograms continue, and will continue, to be of value and should not expire. In particular, these histograms will be of use when comparing the autofill canary server environment users with the prod environment control group. Bug: 915896 Change-Id: Icf9845bc24c2e3cbf5f80ce453c7ff234c5ba756 Reviewed-on: https://chromium-review.googlesource.com/c/1394790Reviewed-by:
-
Mike Wasserman authored
The Keyboard Shortcut Viewer app has been on by default since M-70. The deprecated codepath to run synchronously in Ash is no longer needed. Remove the flag and cleanup. Bug: 841020 Test: KSV app (Ctrl-Alt-/) works well enough, flag no longer exists. Change-Id: I1c156705acbd1a5d9a5d5cc3beda50a3d1c4ed26 Reviewed-on: https://chromium-review.googlesource.com/c/1394994Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Xida Chen authored
TBR=maxmorin@chromium.org NOTRY=true Bug: 919100 Change-Id: Iae7d18c3664a0aef21ebee4bc7e5bdcf9ea4a08c Reviewed-on: https://chromium-review.googlesource.com/c/1396300Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/63707fc2cc12..5d262aa379e9 Created with: gclient setdep -r src-internal@5d262aa379e9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I712ba8ff8f689ed68edeeec93a93429fa800e461 Reviewed-on: https://chromium-review.googlesource.com/c/1396184Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619968}
-
Theresa authored
Also use BlackHeadline for selectable list layout toolbar (e.g. bookmarks, history, photo picker, etc). BUG=849845 Change-Id: Idc1e643b0d3a22bfb6d8dd9f595e77d48a618195 Reviewed-on: https://chromium-review.googlesource.com/c/1387672 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#619967}
-
Antonio Gomes authored
This is an oneliner removal follow up of crrev.com/c/1351152. TBR=msarda@chromium.org BUG=909715 Change-Id: I8bc16bfb73348c23425351761695cca2258342c6 Reviewed-on: https://chromium-review.googlesource.com/c/1396237Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#619966}
-
Maxim Kolosovskiy authored
Bug: 919089, 919088, 910546 Change-Id: I0ce5a28ccf7f13cfa6fda547b628fbe6cf4d9a83 Reviewed-on: https://chromium-review.googlesource.com/c/1396032 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#619965}
-
Vladimir Levin authored
This patch adds style & layout containment as another criteria for when we establish isolation. R=chrishtr@chromium.org Change-Id: I325edc499d41ea8580d138e982a358f74d13f22e Reviewed-on: https://chromium-review.googlesource.com/c/1388747Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619964}
-
Vladimir Levin authored
This patch removes the flag added earlier, since the feature has been on without any problems. R=chrishtr@chromium.org, pdr@chromium.org Change-Id: I42e41417f531e2ba47a096cf172234d4f549a5fd Reviewed-on: https://chromium-review.googlesource.com/c/1394915Reviewed-by:
-
Stephen Chenney authored
With background-repeat: no-repeat and background-size: cover, the computations for dest rect for the no-repeat case use the tile size to set the dest rect. This prevents tiled drawing from painting more than one tile. But the background-size computations for cover and contain use an unsnapped position area to set the tile size, which produces an unsnapped tile size. This unsnapped tile size, when set as the dest rect for painting, results in a tile that doesn't fill the background as one would expect for cover or contain. This patch switches to always computing the cover and contain tile sizes using a snapped position area to give a snapped dest rect. R: fs@opera.com, fmalita@chromium.org Bug: 785171 Change-Id: I38343ac09d689e9d1360e7043b2ef49adeadb983 Reviewed-on: https://chromium-review.googlesource.com/c/1394014 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#619962}
-
Ryan Meier authored
To fix a class of theme-related contrast bugs, BrowserThemePack now does processing for the toolbar to generate COLOR_TOOLBAR by compositing the provided image with the color it will be drawn on top of, and then samples that image into COLOR_TOOLBAR - this solves some issues with contrast checking not working properly if a toolbar image is specified alongside an explicit toolbar color that doesn't represent the color of the image. Additionally, COLOR_FRAME (and its variants) now similarly get replaced with the values computed from their composited images regardless of whether an explicit color was provided (previously, the colors only got set as such if there was no explicit color provided). To preserve some existing behavior, any explicit color provided for COLOR_TOOLBAR is copied into COLOR_INFOBAR (new), and COLOR_DETACHED_BOOKMARK_BAR_BACKGROUND (existing), and several UI elements have been updated to draw using those colors instead of COLOR_TOOLBAR. Bug: 913227 Change-Id: Idc4166f3f4e4ee75f178fddc40458b03883e85cc Reviewed-on: https://chromium-review.googlesource.com/c/1387154 Commit-Queue: Ryan Meier <rameier@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#619961}
-
Liquan(Max) Gu authored
Currently, FCP++ records new image and text for the whole life cycle of a tab. However, FCP++ should only be interested in the elements attached before user input. This is because user input can cause changes to the DOM. That's why FCP++ need to stop recording new elements upon user input. The CL causes behavior changes to FCP++. * When users give input other than kMouseMove, kMouseEnter, kMouseLeave and pinches, FCP++ deactivate its detectors. Note that the user inputs include both those handled by mainthread (click, touch, etc) and compositor thread (off-mainthread scrolling, gesture, etc). But these exclude the input events that have been filtered from the browser side. * When deactivated, the text and image detector stops to record new entries and node removal. But they still observe the loading status. In other words, if an image is recorded before deactivation, and finish loading after deactivation, the image paint detector can still observe the loading being finished. Bug: 915804 Change-Id: I49d3d9aa0b2e73a4775147ff1a2bb4b065c5b9b2 Reviewed-on: https://chromium-review.googlesource.com/c/1380947Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#619960}
-
Friedrich Horschig authored
This CL adds and connects the new view binder which creates chips and footer commands based on the AccessorySheetTab data. In order to make the "ripple effect" work for chips, the drawable draws a large rounded rectangle in the background color over the animated image which effectively cuts and rounds the corners. Bug: 853772, 911084 Change-Id: If2740994aa752e11233c90eca062b529b8ea36ce Reviewed-on: https://chromium-review.googlesource.com/c/1367650 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#619959}
-
Xida Chen authored
TBR=maxmorin@chromium.org NOTRY=true Bug: 919100 Change-Id: Ie218eb7ea89b447c9f53d303b5d0d73ed9a9b4c3 Reviewed-on: https://chromium-review.googlesource.com/c/1396226Reviewed-by:
-
Max Morin authored
Tbr: charliea Bug: 820282 Change-Id: Ifa750d2c2a1b208b1c07acb1c473c220b7356a44 Reviewed-on: https://chromium-review.googlesource.com/c/1396146Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619957}
-
