GitLab

R=ericrk@chromium.org

Bug: 997592
Change-Id: I800164a985a9fae6781aad6fcd0666a86fa3a8bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797363
Auto-Submit: Khushal <khushalsagar@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695712}

This change replaces usages of base::Value::GetList() followed by either
emplace_back() or push_back() with base::Value::Append(). This is
because of the upcoming change to GetList() to return a base::span
instead, which does not support either emplace_back() or push_back().

This is a mostly mechanical change. Steps to reproduce:
- sed -i 's/GetList().push_back/Append/g'
- sed -i 's/GetList().emplace_back/Append/g'
- git cl format
- Manually fixing the breakage in base/json/json_writer_unittest.cc
  and tools/json_schema_compiler/util.cc

TBR=afakhry,boliu,eugenebut,mmoroz,rdevlin.cronin,rockot@google.com,sandersd

Bug: 646113
Change-Id: I2f13fd0efa7fe712f7659500404192be4a344e14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796427
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695711}

Anything table-like should support the table interface. This includes
the cross platform kTreeGrid role, which is mapped to
ROLE_SYSTEM_OUTLINE on MSAA/IA2.

Bug: 1002544
Change-Id: Ic97539e9462f7da5c089bbe4f067d56ca2e27dbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796262Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695710}

This should fix the problem of cookies not clearing consistently
on iOS 13.
More details are on the crbug comments.

Also Change onViewUpdated on web_frames_manager_impl to remove all
messages instead of looking for specific messages. This is needed
as removing specific messages DCHECKs if the message is not registered.
and during the Purge which happens in clear browsing data the message
router is destroyed so there will be no messages in the registered with
the webview.

TEST= I tested manually on ipad, iphone for both iOS 12 & 13 on devices
, a test on the simulator is meaningless as the simulator doesn't use
the same cookie storage that the device use. There exist unit tests but
they will not fail in the case that i'm fixing because in these tests
we set cookies manually and this current case happen when cookies are set
by the web view. I'll discuss further creating EG tests to test the failed
scenario using a browsing test page that can set/get cookies.

Bug: 997172, 956516
Change-Id: I3befee1bf38ac1d3d86c33e50bbbbd4fb9e75ec9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791629
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695709}

OverlayUIDidFinishPresentation is called from a weakptr, which can be nil
and it's not checked. If the weakptr is nil the call is crash as it's
called from a C++ object.

Change-Id: Idf9a6a73aded75d411e92e35a97a07a2db04b8df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795890Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695708}

Whitespace-only change.

Change-Id: I0d87dc3a1e11ec1b9f212298dad77934913c910c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797005
Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695707}

This supports writing unit tests.

Merge-With: eureka-internal/311500

Bug: None
Test: build
Change-Id: I61d6bd28599f260091f5f9ad43575fe4214d28b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764393
Commit-Queue: Joshua LeVasseur <jlevasseur@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695706}

The common case for SkiaRenderer would be to draw to an opaque
framebuffer. Tweak the microbenchmark config to match that.

Bug: 974359
Change-Id: I95ff319148b3a1e1159aba49974f55fb2a073b47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797701
Commit-Queue: Jonathan Backer <backer@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Auto-Submit: Jonathan Backer <backer@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695705}

https://swiftshader.googlesource.com/SwiftShader.git/+log/fccbd75b5718..5f1b4c0ba92e

git log fccbd75b5718..5f1b4c0ba92e --date=short --no-merges --format='%ad %ae %s'
2019-09-11 bclayton@google.com CMakeLists.txt: Don't set MARL_BUILD_TESTS to OFF

Created with:
  gclient setdep -r src/third_party/swiftshader@5f1b4c0ba92e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: chromium:b/140546382
Change-Id: Ib33c852b925b1f829b2b579c065b2f8ff6306858
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797052Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695704}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/472d39ef..6de79412

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Id7a5c4988f05236ebcb473c69677df437d988c7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798276Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695703}

This change addresses problem where keyboard would cease to work on any
site (including google.com) for any user who tabs through the omnibox.

Affects Android 7.

Users tabbing through the omnibox would end up in a bizarre state, where
after leaving the Omnibox by pressing tab focus would be granted to the
Omnibox Suggestions Results list element. The list would next change
visibility, after which Android 7 seems to be taking to action (ie. not
looking for the next focusable element), redirecting all subsequent user
input to an invisible element.

Nearly all subsequent input is consumed by that invisible element - with
an exception of shift-tab, which brings focus back to the Omnibox (but
would offer no remedy).

The offered solution is to prevent FocusFinder from considering
OmniboxSuggestionsList elements as candidates when searching for next
focusable element.

Suggestion results continue to be focusable for talkback / a11y enabled
users.

Bug: 805718

Change-Id: I49fb6daefec2175c06d4631e2b805d758a082f24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795319Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#695702}

Tighten up some of the logic for when to apply the targetURL fix.  Only target
real relow pages, not renderer initated navigations (such as restoration) and
back forward navigations.

Bug: 1002656
Change-Id: I837257128784167d2a1cdd6e305952aaea3df7bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797703
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Ali Juma <ajuma@chromium.org>
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695701}

Under certain conditions, a call to FrameLoader::DidFinishNavigation()
can lead to DocumentLoader::DetachFromFrame() which sets the frame_
field of DocumentLoader to null, which can lead to a unll-dereference.
This issue was found by clusterfuzz.

Added a null check to resolve.

See stacktrace from FrameLoader::DidFinishNavigation() (entry #46) to
DocumentLoader::DetachFromFrame() (entry #5) in the first comment to
this CL at your own risk.

Bug: 1002829
Change-Id: I022556309fc099d56ebb86cdfc3c112bb588650e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798329
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695700}

Add a way for OfflineContentProviders to synchronously tell the front
end to ignore high quality visuals for a particular OfflineItem.  This
lets the UI layer optimize around this fact and not show asynchronous
loading images.

This should apply to both notifications and downloads home.

Bug: 1001208

Change-Id: I49fd6b5388b1f9ffe1b87856015a593e1b9ce5a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786664
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695699}

More details in the bug. The problem was that we would start observing,
but not stop observing. The normal workflow was to stop observing when
the window itself was done animating, but it didn't because it was already
maximized. It would also stop observing, if there was no animation
detected normally, but it didn't because the overview restore animation
was going on.

Move the overview within the scoped observer so that TabletModeController
observes the scheduled animation properly, and will cleanup properly.

Test: manual
Bug: 1002735
Change-Id: I3aff9cc81375a9258db6de57571241ab5bb1f0e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797110Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695698}

Change-Id: I018d44da16943973206e04084f85aa3793bec79f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791626Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695697}

Removing since the functionality has been long reverted and feature bug
closed. Tried reverting original CL but had many merge conflicts.

Bug: 965681
Change-Id: Iff15a18ce689e9aa19a444640dccfaa9a75956a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792458Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695696}

This CL stops resizing the popup when navigating from date view to year
list view. The resize of the popup could cause a weird behavior when
the popup is moved from above the in-page control to below it due to
height constraints.

Instead of resizing the popup, the calendarTableView visibility is
changed to either visible or hidden.

Bug: 1001348
Change-Id: Ia2e5ff286a231b685265f46b849d9e636ddf133b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795318Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#695695}

https://helpx.adobe.com/security/products/flash-player/apsb19-46.html

BUG=412078
TBR=jschuh@chromium.org

Change-Id: Idc39e39c089eb67a1df34025e8ed56d6dcff0756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798495Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695694}

This reverts commit 8963402b.

Reason for revert: <reverting did not fix crbug.com/999467>

Original change's description:
> Revert "Include profile name in AppUserModelId for default profile."
> 
> This reverts commit 7f9c2bff.
> 
> Reason for revert: <crbug.com/999467>
> 
> Original change's description:
> > Include profile name in AppUserModelId for default profile.
> > 
> > Migrate pinned PWA shortcuts as well.
> > 
> > This makes pinned icons for the default profile on Windows have
> > the profile name in the AppUserModelId, which prevents weird behaviors
> > when other profiles are added/removed.
> > 
> > If shortcuts are migrated, shortcuts without a profile will be migrated
> > to point to the default profile.
> > 
> > Originally submitted as 1658991, which was reverted because of an issue
> > with pinned PWA shortcuts.
> > 
> > Bug: 593414, 328738
> > Change-Id: I68bc7083e233cf6dd3cfd56359245df59fd0e4a1
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686222
> > Reviewed-by: Gabriel Charette <gab@chromium.org>
> > Reviewed-by: Alan Cutter <alancutter@chromium.org>
> > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#677305}
> 
> TBR=gab@chromium.org,alancutter@chromium.org,davidbienvenu@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 593414, 328738
> Change-Id: I1414fe5915c0f8b78e7ae58f447274c42331f60c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787902
> Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#693955}

TBR=gab@chromium.org,alancutter@chromium.org,davidbienvenu@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 593414, 328738
Change-Id: I1d1959632502114321847671361807be50dfcfb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797698Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695693}

This adds support for the kForceEnableMetricsReporting, but should not
change behavior unless this flag is specified.

When the flag is specified, override sampling, user consent, and app
consent to always upload metrics logs.

This does not aim to support the flag for other embedders, only WebView.

Bug: 994418
Test: build/android/adb_system_webview_command_line --force-enable-metrics-reporting
Test: out/Default/bin/system_webview_shell_apk launch https://example.com/
Test: Verify AwMetricsLogUploader#uploadLog is consistently called
Test: run_android_webview_unittests -f AwMetricsServiceClientTest.TestCanForceEnableMetrics
Change-Id: I2a8804ad26a1e7d55cb0e9fdf9ef0b58f4bbfc3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797025Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695692}

in order of how many of each we have in the pool.

Bug: 947561
Change-Id: Ia8d94e0c009d1bcb3b9142ae172e661f9f764c93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796523Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695691}

Test: manual
Bug: 1002726
Change-Id: I0809b87c4a61601aa5b9a80e716f8b2fc77c57d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797111Reviewed-by: Avery Musbach <amusbach@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695690}

This eliminates the handling/manipulation of the 'active_' vector in
SMILAnimationSandwich. This vector contains the currently active
animations, and needn't be updated at the same time as timing, so move
the updating of it to a new method UpdateActiveAnimationStack().

All the clearing of the "result element" is moved to the sandwich.

Bug: 998526
Change-Id: Ic44d9265db93ea2de69b446856778f53feb6e92d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796322
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695689}

https://android.googlesource.com/platform/external/perfetto.git/+log/6b8d5911e8f4..9fb2ed7f23e8

git log 6b8d5911e8f4..9fb2ed7f23e8 --date=short --no-merges --format='%ad %ae %s'
2019-09-11 tneda@google.com Merge "perfetto-ui: Clicking on a counter should tell more information"

Created with:
  gclient setdep -r src/third_party/perfetto@9fb2ed7f23e8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I45a816c2e8ce6902d99f642abe561a33225ac448
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797865Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695688}

The welcome screen is no longer used. Slay the zombie code.

Bug: 1002590
Change-Id: I0ef7c5e6df668ee3fa383b466ff90fe7c85401cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797803
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#695687}

R=avi@chromium.org

Change-Id: I37cf7910f88251abb29f550c26e0ef57236527e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798572Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695686}

If an empty password is entered in the password editing activity
and someone tries to press save, a message that the password field
is required appears and the activity stays open. If everything is
ok with the data, the activity closes, for now without actually
performing the save.

Bug: 377410
Change-Id: I1bc75d3a6c538b9e8c7b819e916d0588b1fb4763
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798325
Commit-Queue: Ivana Zuzic <izuzic@google.com>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695685}

This reverts commit d631bcd2.

Reason for revert: We have enough data from this dump.

Original change's description:
> Add DumpWithoutCrashing to debug https://crbug.com/996337.
> 
> Bug: 996337
> Change-Id: I18d8fee2f27842abd3ab48cb5bde90815afba5ca
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785078
> Commit-Queue: Lucas Gadani <lfg@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#694873}

TBR=alexmos@chromium.org,lfg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 996337
Change-Id: I8ccca0add4031683153f2407b2c1120bcb05eaec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797695Reviewed-by: Lucas Gadani <lfg@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695684}

Declare std::unique_ptr specializations for CUPS in one place.

Change-Id: Iffa00a1cfb4167ff4b46fdbffcfd4c367ffe1ac5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782880
Auto-Submit: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695683}

https://webrtc.googlesource.com/src.git/+log/0ba1705c6af4..ff060eef97db

git log 0ba1705c6af4..ff060eef97db --date=short --no-merges --format='%ad %ae %s'
2019-09-11 yvesg@webrtc.org Disable AudioDeviceTest unittests under sanitizers.

Created with:
  gclient setdep -r src/third_party/webrtc@ff060eef97db

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: None
Change-Id: I1e001c0268be517e3db5d395930425abceaa3cd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798387Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695682}

Using wpt-import in Chromium adab81b1.
With Chromium commits locally applied on WPT:
cf88186a "[LayoutNG] Fix `vertical-align: top` and `bottom`"
30dde1e3 "[LayoutNG] Fix `vertical-align: top/bottom` with leading"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I5f9caba6df22844277b49184ac7e479bdc49e5e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798273Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695681}

Each SkMatrix44::set call calls recomputeTypeMask. By using a batch
call we reduce the number of times that this is called.

Bug: 974359
Change-Id: If3f31c939da9efc72727af8e8dfa10db46321fcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797654Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695680}

This change adds FrameTokenGenerators to CompositorFrame builders in
ClusterFuzz. During normal operation subsequent CompositorFrames are
expected to have incremented |frame_token|'s, this change makes fuzzed
frames follow that behavior.

Bug: 997147
Change-Id: Ib41ac8318bb2c14edfd0d9b51061f3fbde490df4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787992Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#695679}

Fixes regression after refactoring of DownloadItemView where the new
view implementation is not focusable (but a subset of its children are).

DownloadShelfView returns a DownloadItemView as its first focusable
item (totally reasonable), but since the item itself is not focusable we
need to forward focus to the open button inside it.

I still think it's reasonable to focus an unfocusable item if its
children are focusable, so ideally a fix would change ::SetFocusedView
to focus the first focusable child (if any) or otherwise clear focus.
There's a TODO present inside AccessiblePaneView to address this.

Bug: chromium:1000998
Change-Id: I071d1c59401b35f251cd429ae3b5892462f91adf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798086Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695678}

Bug: 1002687
Change-Id: I7a8801c81e6901d637e771c7a5873f8c49eaa979
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797326
Auto-Submit: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695677}

Frame visibility is affected by CSS display while page visibility is
not.

Bug: 999006
Change-Id: Ia2ee70f6222d88474cea92fd28c8da77269f3a2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797131Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695676}

https://skia.googlesource.com/skia.git/+log/56df7910b051..120e7d6766e4

git log 56df7910b051..120e7d6766e4 --date=short --no-merges --format='%ad %ae %s'
2019-09-11 bsalomon@google.com Make building in Chrome with base/logging.h included in SkTypes.h work.

Created with:
  gclient setdep -r src/third_party/skia@120e7d6766e4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=mtklein@google.com

Bug: None
Change-Id: I2f54b859fa5a26b13f5fe2e9aac29035a23c3c53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798762Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695675}

The unconsented primary account is the best notion of profile identity
for our purposes, since the additional download warnings do not
depend on consenting to Sync. (They are gated behind the Safe Browsing
enabled preference).

Bug: 917190
Change-Id: I61c1a8d5e47865f61e052ac75de03560e7b52e7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793445
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695674}

This was added to improve performance of the original algorithm.  Since
we have launched the sweep line algorithm (go/janktrackingsweepline),
granularity snapping is no longer used or needed.

Bug: 1000716
Change-Id: I3c15b5fa70de04b98802f858438b7dbfc4f16539
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791438Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695673}