- 22 Jul, 2020 40 commits
-
-
jchen10 authored
This parses the codec information in EncodedVideoConfig. Size has to be explicitly specified in the config as well. With these changes, a basic VP9 encoding and decoding test can run correctly. This test can also cover the path of creating ImageBitmap from hardware decoder VideoFrame. Bug: 897297 Change-Id: Ifbac15db0305bcd781786707916b94be5a151215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301590 Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#790744}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/1c42d4ee7bcb..11fa4d0d5694 2020-07-22 johnkslang@users.noreply.github.com Merge pull request #2348 from ben-clayton/thread-local If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,timvp@google.com Change-Id: I94a859ef673e60b5c5df25022fac5db09d10170e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311086Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790743}
-
Jan Wilken Dörrie authored
This change is a simple search and replace to rename base::win::String16FromGUID to base::win::WStringFromGUID. This is a better name, since the function was changed to return a std::wstring. TBR=dcheng Bug: 911896 Change-Id: I846674496295b1545d0890627611d5fa2ceb34f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308718 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#790742}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/964c4089cb51..f6659b3df028 2020-07-22 syoussefi@chromium.org Vulkan: Fix invalidate + deferred clear 2020-07-22 syoussefi@chromium.org Vulkan: Fix deferred clears and noop clear and blit 2020-07-22 courtneygo@google.com Inline depth/stencil clear if in middle of renderpass If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Ib6864bfcc87096efab947b71256bb9f1a6062423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311087Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790741}
-
Yuki Shiino authored
The build rule of V8 context snapshot is missing some deps, and this patch supplements them. Bug: 839389 Change-Id: I875a194718f32d291b582da5071ec28dd992f08c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307849 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#790740}
-
Kalvin Lee authored
This change migrates the Chromium browser's primary documentation for CL footers from the Chromium site: https://dev.chromium.org/developers/contributing-code/-bug-syntax into the in-tree contributing guide. There are two bugs to correct the language used in this change: * https://crbug.com/1108213 * https://crbug.com/1108214 Test: Gitiles preview Change-Id: I3c67aa008c3d77edc373531a8a698e3af033be0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311826 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#790739}
-
Jose Dapena Paz authored
In decoder selector test, we alias DecoderSelector to the instantiated template (i.e. DecoderSelector<media::DemuxerStream::AUDIO>). GCC does not allow that as the alias name clashes with template name. To solve it we rename the alias to be MockDecoderSelector. Bug: 819294 Change-Id: I8ca0664df9b874fd5bd0c1db3397cbd17d14e084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310492Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#790738}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5e102dafa79a..398319047f2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hayato@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085419,chromium:1106471,chromium:1106878,chromium:1107845 Tbr: hayato@google.com Change-Id: I8228d698b7f9abd90ca239d9a0c7840facea74bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311725Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790737}
-
Yuki Shiino authored
Implements ReportCoopAccess in the new binding generator. Bug: 839389 Change-Id: I76cbc937e8dee63abbebeafedc834060b8fca5d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306111 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#790736}
-
Greg Thompson authored
With this CL, mini_installer now holds the files it creates open with FLAG_DELETE_ON_CLOSE so that they are automatically deleted by the filesystem when they are no longer needed. The most risky operation is the multi-step process to drop write permission on the files so that they can be opened for consumption by parties that do not allow writers. New process exits codes have been introduced to track whether or not this operation fails in practice. BUG=516207 Change-Id: Ic5e25692cf3dca0fcc7cd01faf5759648f5c6890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307250Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#790735}
-
Julie Jeongeun Kim authored
When a modal dialog appears, GetChildCount and ChildAtIndex just consider the modal dialog and skip other children. Since GetIndexInParent compares itself with all siblings to get the index, if the parent has a modal dialog, it couldn't find anything matched. This CL returns nullopt on GetIndexInParent if its parent has a modal dialog. AX-Relnotes: n/a. Bug: 1104282 Change-Id: I3c8b45fe96aa188fd29aa63bc5fd4b1fc0bac476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299664 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#790734}
-
Dominic Farolino authored
Context: LazyLoadFrameObserver::LoadImmediately only expects to ever be called one time. Before this CL, both LocalFrame::Navigate and RemoteFrame::Navigate didn't immediately call HTMLFrameOwnerElement::CancelPendingLazyLoad(). Therefore if LazyLoadFrameObserver::LoadImmediately() was called, and attempts to navigate a frame but the navigation fails before CancelPendingLazyLoad() was called (which can happen due to the navigation rate limiter etc.), LazyLoadFrameObserver::LoadImmedaitely may be called a second time by the underlying intersection observer which still observes the element. R=sclittle@chromium.org Bug: 1106290 Change-Id: I77f052c5d5a113d0c35f702322d6dc6ec831650b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303352Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#790733}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1595128170-8aaf6de27e89b142e6e1e7e7a3316cb88b9b2b37.profdata to chrome-win64-master-1595373454-124f6f7a8fdf3bef9667f80d39ed93302475736e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: If3d2f06d87356d871de8f64635862c6db2c8b272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311083Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790732}
-
Trent Apted authored
Currently it bails out early due to a missing dependency on accessibility_common/accessibility_common.js The file was moved to accessibility_common/autoclick/autoclick.js, but it doesn't compile so comment out the build target. The move happened in r780890 and r781588. AX-Relnotes: n/a. Tbr: katie@chromium.org Bug: 1108171 Change-Id: I3ea751c538b689cf7515529e80aa50f1b101b642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311838 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#790731}
-
Hayato Ito authored
Skip the following tests on Mac as they seem to be failing. - http/tests/devtools/tracing/timeline-js/timeline-script-id.js - virtual/threaded/http/tests/devtools/tracing/timeline-misc/timeline-event-causes.js TBR=aerotwist@chromium.org BUG=1107572 Change-Id: Idd6fa34188bf5efc5acb84f9bc5b8febbecd68e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310020Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#790730}
-
Yuichiro Hanada authored
It's not used anywhere in Chromium. Bug: b:161129562 Change-Id: I14c8414d58c6e1bd2dec3cd666a99418bdf2a6a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310269Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#790729}
-
David Munro authored
Bug: chromium:1100726 Test: Unit tests, manual Change-Id: I58057a29ae2a1cecab14f82630d1cb90fb0fcc34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308437Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Auto-Submit: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#790728}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1595191024-521ec280875ff00917e41f4db8004114035c0cbe.profdata to chrome-win32-master-1595373454-95f078484e58a8592358a4d377034f6d1c7c30df.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Icdfffb3b6a454a85e9c6d14e712e873e3c13dde6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311876Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790727}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: I3624571e20521c04c538bc21617a6175da5a8a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302972Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#790726}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d2093b13c8c9..96dc2c70cf5b 2020-07-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 97f9923235cf to f272427bda39 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I6d1015ee46e719f896a73027ced2e6daa1e9f6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311080Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790725}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I718fa42d762126917b33c1871dd08a13639e43ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311081Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790724}
-
Guido Urdaneta authored
Prior to this CL, a command-line switch was set in the browser process and copied to the utility process to enable the audio sandbox. This was not ideal since it resulted in the browser command line being altered, which is visible, for example, in chrome://version for platforms that have the sandbox enabled by default. This CL replaces the switch with a method in ContentBrowserClient which indicates if the audio service should be sandboxed or not. The result of this method is used to set the type of sandbox to be used (kAudio or kNoSandbox). Bug: 1057969 Change-Id: I5fe214795daf6af67c03984c8c59516641fa19c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302193Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#790723}
-
Melissa Zhang authored
This CL integrates apps from the App Service into the Sharesheet as targets. When clicked on, the app opens with the supplied intent and the Sharesheet closes. Bug: 1097623 Change-Id: I216f39ada019125807f92fd93e0d00f77d4622ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306137 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#790722}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b99a6a727318..1c42d4ee7bcb 2020-07-22 johnkslang@users.noreply.github.com Merge pull request #2345 from mbechard/master 2020-07-22 john@johnkgo.com SPV: Update to the latest SPIR-V headers. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,timvp@google.com Change-Id: I4d70a05a16602f80ea5361f8f682610198626120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311079Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790721}
-
Kent Tamura authored
This is a reland of ad354ace Differences from the original CL: - Add text_direction.mojom-blink-forward.h to apply_style_command.h and style_command.h to fix build. Original change's description: > Reduce the size of frame.h > > This CL reduces the estimated pre-processed size of frame.h by 1.33MB. > This CL has no behavior changes. > > Bug: 242216 > Change-Id: Ibf3551b924b070664120bb04fce9706b0415975a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309370 > Auto-Submit: Kent Tamura <tkent@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790698} Tbr: tikuta@chromium.org Bug: 242216 Change-Id: I8b18fd1715e58a7b0db1db5a750a10051091f289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310222Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#790720}
-
tby authored
Bug: 1108064 Change-Id: I51401be1b2ad21b0f1706c466050c8245839b20f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311837Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#790719}
-
Eugene But authored
Do not hardcode expectations for the length of BreakpadServerParameterPrefix_platform value. Bug: None Change-Id: I8a0fabaae7e6f4f1b1100f8967a08b094bfa1206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311699Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#790718}
-
Jiewei Qian authored
In System Web App related browsertests, we have three different App launching methods that do the same thing, this CL consolidates these methods: - LaunchApp - WaitForSystemAppInstallAndLoad - WaitForSystemAppInstallAndLaunch The new LaunchApp method handles the launch, and waits for load stop by default. LaunchAppWithoutWaiting does the same thing, but doesn't wait for load stop, which is useful to test certain defaults (e.g. browser window size, toolbar visibility, window title). Bug: TBD Change-Id: I38f74a3faef83b3902a7af2387f2e31fe78127e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294879 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#790717}
-
Kent Tamura authored
Copying diff content is useful, and line numbers should not be copied together. Change-Id: I396c6bffee03683228df31b6dfa753da8e1a6d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029469Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#790716}
-
Yutaka Hirano authored
ResourceFetcher::EmulateLoadStartedForInspector can be called with a Resource whose status is kNotStarted, because some resources (e.g., fonts) don't start loading when ResourceFetcher::RequestResource is called. Showing "emulated" resource loading for such stalled resources is confusing, so stop doing that. Bug: 1099256 Change-Id: I0547506fd65fd9ef14c7bb483d92b5eeb42bc21c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301556 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#790715}
-
Peter Kotwicz authored
This CL adds a compile target for the errorprone plugin tests BUG=1104558 Change-Id: Ied09f76cddd536a0a11582422a9e766bcb195bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299083 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#790714}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6ca2c1162445..964c4089cb51 2020-07-22 syoussefi@chromium.org Vulkan: fix RenderPassDesc::mColorAttachmentRange If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1107884 Tbr: timvp@google.com Change-Id: Id8eb0be8b9e4590efa640a3a5834428d32bdd39d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311723Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790713}
-
nancylingwang authored
Sometimes, during the system init phases,the windows are not added to the observe list in AppServiceAppWindowLauncherController, so when the window is destroyed, AppServiceAppWindowLauncherController is not notified, and the window is not removed from AppService instance, which might cause crash when operating the destroyed window saved in instance. This CL modified the code to check and add the window to AppServiceAppWindowLauncherController's |observed_windows_|, when the window is added/modified in AppService instance, so that the window destroy callback in AppServiceAppWindowLauncherController can catch the window destroy information to remove the window recorder. BUG=1011235 Change-Id: I48ee1a7fc55adc9097a53f18149f44672ac10a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307669 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#790712}
-
Majid Valipour authored
Enables the feature be default on ToT and on M86+. Blink API Owners approval of this launch: https://groups.google.com/a/chromium.org/d/msg/blink-dev/7X2CKPGeEa0/L2itpO2bAgAJ We will be using a finch experiment to enable the flag on M85+ that will give us the ability to pull back if needed. Bug: 721759 Change-Id: I61259b0fbaabbdbfc93b9423afae56165b1e30bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310799 Auto-Submit: Majid Valipour <majidvp@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#790711}
-
Richard Li authored
The color conversion pass using kSrcOver blending mode may cause blending error when alpha channel exists in child pass. Using kSrc as blending mode will avoid this problem. Bug: 1045800,1062184 Change-Id: If03bf0ff7b366f8810a11f2f02e9c57aa904d6cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306909 Commit-Queue: Richard Li <richard.li@intel.com> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#790710}
-
Hiroki Nakagawa authored
As a part of the Onion Soup project, this CL changes the timing to create WebWorkerFetchContext for shared workers. Before this CL, WebWorkerFetchContext was created as follows: - [in content] EmbeddedSharedWorkerStub::EmbeddedSharedWorkerStub() - [in blink] WebSharedWorkerImpl::CreateAndStart() - [in content] EmbeddedSharedWorkerStub::CreateWorkerFetchContext() - Creates WebWorkerFetchContext instance here. This needed an inter-module function from blink to content, and WebSharedWorkerClient::CreateWorkerFetchContext() was that. After this CL, WebWorkerFetchContext is created as follows: - [in content] EmbeddedSharedWorkerStub::EmbeddedSharedWorkerStub() - [in content] EmbeddedSharedWorkerStub::CreateWorkerFetchContext() - Creates WebWorkerFetchContext instance here. - [in blink] WebSharedWorkerImpl::CreateAndStart() - Passes the context into WebSharedWorkerImpl here. This enables to remove the function. Bug: 911415 Change-Id: Ieec240321f7a5884c5680c8ce6d3f24b4081813e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309314 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#790709}
-
Jia authored
This cl adds latency and index size metrics. For inverted index search, the index size metrics will be logged in another cl. Bug: 1096834 Change-Id: I254f7c8dfae7ab4ecc615d474e1a2da07d90d580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308557 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#790708}
-
Trent Apted authored
Since r790679 their presence triggers a gn assert failure on official bots. Tbr: dominicschulz@google.com Bug: 1108151 Change-Id: I55cb7dd479f7e9e83fce590811f707d43c0bbdbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310018Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#790707}
-
shrekshao authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/d0fcf3d..a503e42 Tbr: kbr@chromium.org Bug: 1099955,1107994,1078330,1108044 Bug: 1058160,1100834,890539, 1108086 Bug: angleproject:4849, angleproject:4807, angleproject:4754 Change-Id: I1765c384d2f6fb4bf4ba08e8858ba58e8d32e561 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310835 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#790706}
-
Joel Hockey authored
Apps should be unregistered when VMs are disabled, but in case they are not, and particularly for terminal which is intentionally available even when crostini is not installed, we must check if VMs are enabled before using apps for open-with in FilesApp. Change-Id: If0dd0ceb074c0bf8c07c5b609af368a68d4c2a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308630 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#790705}
-