- 25 Nov, 2020 40 commits
-
-
David Bienvenu authored
This finishes the conversion for this directory, except for the typedef for CancelCallback, which is used externally. Bug: 1007788 Change-Id: I5471ff1e1917aa95122cb62c3c6ec0084fa38319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551747Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830840}
-
Clark DuVall authored
The fix for crbug.com/1146745 started using the ClassLoader from ContextUtils.getApplicationContext() for loading service classes. In the browser process, this ClassLoader will be the chrome module ClassLoader. DecoderService runs in it's own process, so the application does not load the chrome specific code. This change makes sure the application ClassLoader can actually load the service class before replacing the passed in context. Bug: 1152467 Change-Id: I82b4081afc349fec2e540a5763586153b50b67b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558957Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#830839}
-
Bailey Berro authored
This change adds a cpu_max_clock_speed_khz field to SystemInfo and a scaling_current_frequency_khz to CpuUsage. Bug: 1128204 Change-Id: I1773748f1fc307564e2a98d7504f3823e1e08c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532765 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#830838}
-
Matt Wolenetz authored
Stubs new MSE methods and overloads that, when fully implemented in later changes, would allow: 1. use of WebCodecs decoder configs as addSourceBuffer() and changeType() arguments (in lieu of parsing initialization segments from a container bytestream), and 2. buffering of WebCodecs encoded chunks via appendEncodedChunks() (in lieu of parsing media segments from a container bytestream). Much of the complexity of this initial change is in the coordination of the IDL bindings generator to achieve disambiguated overload resolution, primarily to keep the exposed API simple (only 1 actual new method name is added, corresponding to bullet 2, above), using two approaches: * Dictionary of Dictionaries: SourceBufferConfig wraps either a WebCodecs audio or video decoder configuration. Without such a distinct new type wrapping them, unioning or overloading would fail to resolve. * Unions, with caveats: the new appendEncodedChunks method takes either sequences of audio or video chunks, or single audio or video chunks, all in a single argument of IDL union type. Caveat: "sequence<A> or sequence<V>" cannot be disambiguated by the bindings, so sequence<A or V> is used in this change. Regardless, the eventual implementation would need to validate that all in the sequence are either A or all are V (along with the usual validation that appended chunks or frames also appear to use the most recent SourceBufferConfig). Caveat: The bindings generator requires help when generated union type identifiers are too long for some platforms. This change adds a seventh case to the existing hard-coded lists of names that need shortening with the generator. I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/bejy1nmoWmU/m/CQ90X3j5BQAJ TAG early-design review request: https://github.com/w3ctag/design-reviews/issues/576 Explainer: https://github.com/wolenetz/mse-for-webcodecs/blob/main/explainer.md MSE spec bug: https://github.com/w3c/media-source/issues/184 BUG=1144908 Change-Id: Ibc8bd806fe1790ae74fe5ce86865cdfebcdc3096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515199 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#830837}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I05527499bc2bd117c282a0f306f4612f3935f729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537446 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606229875-9be2cd912654833e55877c29390e1b8095877a20.profdata to chrome-win64-master-1606240669-a966a0de7533a2c29e2a147761a10e8425d1cfe7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0f8b92f139836b50dd21b3905c8357775425b296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559277Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830835}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9041ca0c3407..acf004a14a8a 2020-11-24 syoussefi@chromium.org Vulkan: Use transfer more opportunistically with copyTextureCHROMIUM 2020-11-24 syoussefi@chromium.org Vulkan: Initial expectations for GLES32 KHR tests 2020-11-24 cclao@google.com Vulkan: Avoid driver call when yflip changed but shader not using it If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: I7a6a426d9ed5ba18db884b71708ac4a4bd8cce52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559276Reviewed-by:
-
Maggie Chen authored
Job Type: linux_ubsan_chrome Crash Type: Float-cast-overflow expanded_rect.Inset(-max_pixel_movement, -max_pixel_movement); GetExpandedRectWithPixelMovingForegroundFilter() viz::SurfaceAggregator::PrewalkRenderPass Use gfx::RectF.Inset() and gfx::ToEnclosingRect() to fix the overflow bug caught by the Fuzzer. Bug: 1152414 Change-Id: If4e8c55c660de16de32e5d710fef671cb98a102c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558922Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#830833}
-
Renjie Tang authored
In port migration, we don't care about data usage as the network stays the same. Bug: 1082509 Change-Id: I92b2ea637dac62f944ee0c2c540c29266b59854f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558737 Commit-Queue: Renjie Tang <renjietang@chromium.org> Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#830832}
-
Rohan Pavone authored
Adds system_health.memory_benchmark tests to perf FYI waterfall, as this is the only supported benchmark on Telemetry for it. This also adds other swarming dimensions as the controller dimensions is important to Fuchsia bots. Change-Id: I11ecc9a259590a8ef5b4e63ba97bf4970efb8284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551290 Commit-Queue: Rohan Pavone <rohpavone@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#830831}
-
Peter Kasting authored
Bug: 1097283 Change-Id: I570f98b1f42487aff2696c50f87fd0832667379b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547620 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#830830}
-
Changwan Ryu authored
According to https://w3c.github.io/manifest/#the-display-mode-media-feature , if the user puts a browser window into fullscreen without the aid of the Fullscreen API, display-mode: fullscreen should still apply. Therefore, if WebView is embedded in an already fullscreen window, then the display mode should be fullscreen. In applying this, we are concerned about corner cases such as, 1) When the screen is rotated or scaled 2) When webview is in a scrollable view As such, we will report the display mode to be fullscreen only when webview is fully occupying the window and screen, which is the safest option for now. Note that we will reuse this for display cutout in WebView. Bug: 1094366 Change-Id: Ib49d1af1be31a1d9d1c93eea888e26c08da528ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544062 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830829}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/295dd1879f8e..8820ab859bea 2020-11-25 vapier@chromium.org gerrit_client: validate --param options If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ib487e045667650a6fa82b830b47e7c1a348f42e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559388Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606240669-c1104e164a95943470032f861bc56133b735d819.profdata to chrome-linux-master-1606262372-53701711e1f3f7b0d49627ad74cc045279aff3ad.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I42e91cd8ad46d06bdec5c44fd77dc3162be603fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559633Reviewed-by:
-
Clark DuVall authored
This will allow testing with only isolated splits enabled, which will be a useful configuration for perf testing, and a backup plan if the chrome module ends up needing more work. Bug: 1151538 Change-Id: I2db5ec610d9f1c21c0b9bca607cf51ad6ad3b85a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553222Reviewed-by:
-
Mounir Lamouri authored
This is split from https://chromium-review.googlesource.com/c/chromium/src/+/2548699/ which needed to call the helper function but without sync. Bug: None Change-Id: Ife32574545aafd3d881f68c4d62ee664b3a5c432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555802Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Auto-Submit: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#830825}
-
Luciano Pacheco authored
Remove reference to util.isFilesNg() because we don't have to support non-FilesNG anymore and this makes easier to support Polymer 2 and 3 concurrently. Bug: 1133186 Change-Id: I8caab9060b2e986f8cbaa42833c0697e8c952143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554260 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#830824}
-
Clifford Cheng authored
Bug: 1152593 Change-Id: Ida36054201cea49bb1210416be99430f74bca5d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487836 Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#830823}
-
Nidhi Jaju authored
This CL fixes "AUthors" in multiple files to "Authors". Change-Id: I05424e626fe57b72407c3dc9dc6716f94055462e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557884Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Cr-Commit-Position: refs/heads/master@{#830822}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/90bac683b40f..70102b71900b 2020-11-24 senorblanco@chromium.org Add preliminary OpenGL ES and EGL support to Dawn. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: Ib839f739dc7eb7afd08dac14c4672f8493020b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558767Reviewed-by:
-
Findit authored
This reverts commit c754406a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 830817 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2M3NTQ0MDZhY2JjZjgwOWU1OGRjMWFlMmMwZTVkYzIzZDk2MDMzYTYM Sample Failed Build: https://ci.chromium.org/b/8862701172936116704 Sample Failed Step: compile Original change's description: > [SH-Blink] Move Link Generation Error Logging > > By consolidating the error histogram logging (and import the shared > component), we'll be able to make use of the new UKM logging functions > in a follow-up CL and provide it with the error causes. > > Added histogram validation steps in unit tests before moving the > logging logic. > > Bug: 1148807 > Change-Id: I63fd8ca1652d885705c0a17f6131e207ce2e6da3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551793 > Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Reviewed-by: Gayane Petrosyan <gayane@chromium.org> > Reviewed-by: sebsg <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830817} Change-Id: I27cc3e78742d57aba7fb9b23f595cbd6e12cf6c9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1148807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559585 Cr-Commit-Position: refs/heads/master@{#830820}
-
Gyuyoung Kim authored
This CL replaces all uses of media::VideoFacingMode with blink::mojom::FacingMode to reduce type conversion between them in blink. Bug: 919392 Change-Id: I759c80ac81fef18d334b169d6205ebaa4abcf662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557117Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Christoph Schwering authored
The script failed under Python 3 if the locale encoding wasn't UTF-8. Bug: 1112471, 1147608 Change-Id: If8c96f514cd0eb78f140240ea4307d48673b1a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555420Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#830818}
-
Sebastien authored
By consolidating the error histogram logging (and import the shared component), we'll be able to make use of the new UKM logging functions in a follow-up CL and provide it with the error causes. Added histogram validation steps in unit tests before moving the logging logic. Bug: 1148807 Change-Id: I63fd8ca1652d885705c0a17f6131e207ce2e6da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551793 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#830817}
-
Melissa Zhang authored
We are relanding the commit to record ShareAction invocations. This was previously reverted because we are adding a new enum to record this metric but did not add the enum to enums.xml. Original CL: https://crrev.com/c/2537505 Bug: 1148694 Change-Id: I8b6b12eea5aaec5239ceedd99cc9c7d5bbf4cdfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554742 Auto-Submit: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
-
Ian Barkley-Yeung authored
Media App already has its own error reporting system; don't send duplicate reports via WebUI. Bug: chromium:1121816 Change-Id: Ia0c4410cf7cda9a87a92bffd269421f9d0575bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556446Reviewed-by:
dstockwell <dstockwell@google.com> Commit-Queue: dstockwell <dstockwell@google.com> Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#830815}
-
evliu authored
This CL disables the CFI-icall checks for the SodaClient. The function pointers used by the SodaClient are dynamically resolved through the use of dlsym(). Bug: 1152586 Change-Id: I23fab868416b3b91c5dc0a7453480dddf1fa92c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559223 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#830814}
-
Nina Satragno authored
Make FIDO owners own settings_security_key_handler.{cc/h}. Fixed: 1152556 Change-Id: I396e2119a660d78260469845da0e18b194bc77a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559251 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:dpapad <dpapad@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#830813}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ab436aebc566..d6c1c090774f 2020-11-24 nigi@chromium.org Enable some embeddertests in FPDFProgressiveRenderEmbedderTest suite for Skia/SkiaPaths. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1500 Tbr: pdfium-deps-rolls@chromium.org Change-Id: Iae65ef0278efab48d213d4d7dac956a6a7ed11e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558769Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4324.9-1606129869-benchmark-89.0.4334.0-r1 to 89-4324.9-1606129869-benchmark-89.0.4335.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ib34de8453dfdc4164b0eaa1d2aeff0da06b2e2ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558929Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4324.9-1606128713-benchmark-89.0.4334.0-r1 to 89-4324.9-1606128713-benchmark-89.0.4335.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Idc43e972a4c325cad166033348dccb89a643d7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559325Reviewed-by:
-
Jacques Newman authored
This reverts commit 640dc3cc. Reason for revert: Post-merge comments caused us to rethink GridNG's approach to storing data internally. As we no longer need ComputeMinMaxSizes to be able to mutate NGLayoutAlgorithm, it should go back to being a const method. Original change's description: > Remove const from NGLayoutAlgorithm::ComputeMinMaxSizes. > > NGGridLayoutAlgorithm::ComputeMinMaxSizes is fairly complicated, and > would like to modify its internal data to make the algorithm easier to > read. There does not seem to be any reason we must guarantee > ComputeMinMaxSizes needs to be const. > > Bug: 1045599 > Change-Id: I57f6ded3757b19694601b506747ccdd1c48d84a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552705 > Commit-Queue: Jacques Newman <janewman@microsoft.com> > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829843} TBR=ikilpatrick@google.com,ikilpatrick@chromium.org,kschmi@microsoft.com,janewman@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1045599 Change-Id: I975d7ae1a8b9d37037b9d2b21c64678a3a7e497b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555468Reviewed-by:
Jacques Newman <janewman@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#830809}
-
Ian Barkley-Yeung authored
Help App already has its own error reporting system; don't send duplicate reports via WebUI. Bug: chromium:1121816 Change-Id: I4a93498860dc61d11351798ec13ffa73930b2eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559286 Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#830808}
-
Yi Gu authored
The test has been very flaky on Win: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=BrowserTest.ThirtyFourTabs TBR=kylixrd@chromium.org Bug: 1099186 Change-Id: Icc124244df369a8ac07631ad109d19b22ef436fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559382Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830807}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I4c3f302ce8a4389e472cc9d0be9b6c8088d9a9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559008Reviewed-by:
-
Charlene Yan authored
When a tab is dragged into a new window, its bounds should be the same. This is a regression test/check for crbug.com/1140808 Because tabs can be different widths by one pixel, we need the test to get the width of the tab before dragging then when the tab is detached, verify this width is the same. Bug: 1140808, 1141674 Change-Id: I2ed53d6101ea50999b706a6e050e5c732bbd9ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539251Reviewed-by:
Charlene Yan <cyan@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#830805}
-
Anne Lim authored
Screenshot with feature enabled in light mode: https://screenshot.googleplex.com/6V8VaPzxTCNTaKg Screenshot with feature enabled in dark mode: https://screenshot.googleplex.com/76j9FRyHMug7JUd Bug: 1135847 Change-Id: Ied72725636b0c91ac3c418f8d7161c4f8e972270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546600 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
Mike Taylor authored
This is the first of a handful of CLs rewriting the legacy tests in the ported wpt http-state tests. The plan is to continue to refine and refactor and eventually rewrite (or delete) them all. Bug: 1145300 Change-Id: I8a50939f4e2c95c1293ba5423577693ab2a10d9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550362 Commit-Queue: Mike Taylor <miketaylr@chromium.org> Auto-Submit: Mike Taylor <miketaylr@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#830803}
-
Vaibhav Raheja authored
For ARCVM to support APK sideloading, we need to query Sideloading value from Session Manager, and then use it to write the property ro.boot.enable_adb_sideloading while upgrading the ARC. This CL creates a session manager client to first query the sideloading value, and then sets the upgrade parameter appropriately. Companion CL for rvc-arc that starts ADBD - http://ag/13066710. BUG=b:136040493 TEST=Tested with following: 1. Reboot the DUT. 2. Command - stop ui 3. Flip the flag in Dbus using: bootlockboxtool --action=store --key=arc_sideloading_allowed --data=1 4. Command - start ui 5. Login into DUT 6. Command - android-sh -c 'getprop | grep ro.boot.enable_adb_sideloading' should show appropriate value Unit Test: testing/xvfb.py ./out/Debug/components_unittests --gtest_filter="ArcVmClientAdapterTest.*" Change-Id: I24305afa8e144f0e45bd37307c6f1ecefcfae777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525605 Auto-Submit: Vaibhav Raheja <vraheja@chromium.org> Commit-Queue: Vaibhav Raheja <vraheja@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Victor Hsieh <victorhsieh@chromium.org> Cr-Commit-Position: refs/heads/master@{#830802}
-
Tomasz Wiszkowski authored
Bug: 1151850 Change-Id: I01f64377ac2a3e34213697709e9cf7eb68b9b0a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558956Reviewed-by:
-
