- 21 Sep, 2020 40 commits
-
-
Yuki Shiino authored
On Android, malloc, free, etc. are intercepted by using the linker option -Wl,-wrap,FUNC , which means we're intercepting only the symbols undefined at link time. Non-undefined symbols like a call to malloc inside libc are not intercepted. strdup and strndup are such functions that internally call to malloc. However, the return values of strdup/strndup are deallocated with free (= our own free), so we should intercept strdup/strndup to have them use our own malloc. This patch implements wrapper functions for strdup/strndup just like one for malloc. Bug: 1111332 Change-Id: I5747a2c32f19bb63c0380f10f589b9a8f6dd3b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418513Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#808861}
-
Amr Aboelkher authored
Update the expire date with another hallf a year. BUG=chromium:1125828 Change-Id: Id9ff8ea0c365a1aec5edff0552a74af7e4474f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418318Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#808860}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b774d38d3143..4c87d83d0323 2020-09-21 ilnik@webrtc.org Extend I420 frame buffer pool to also create NV12 buffers 2020-09-21 asapersson@webrtc.org Add support so requested resolution alignment also apply to scaled layers. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic7c55e60be09650d82fa34fb26051a81ff1c6cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421538Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808859}
-
Jan Wilken Dörrie authored
This CL is a part of moving PasswordForm class to components/password_manager/core/browser. PasswordForm is used for Profile Import MOJO messages. Instead of removed MOJO definition the IPC definition of PasswordForm is introduced. It contains only needed fields (which is much smaller subset fields). Bug: 1067347 Change-Id: Ief5f302b7cd9500b401cf9ce9d4b022261e560b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190490 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#808858}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/feeee8f4b576..fcd0fd47bdba 2020-09-21 sigurds@chromium.org Update protocol 2020-09-21 tvanderlippe@chromium.org Reland "Reland "Remove support for remote modules"" 2020-09-21 tvanderlippe@chromium.org Typecheck network/BinaryResourceView.js with TypeScript 2020-09-21 tvanderlippe@chromium.org Fix issues for TypeScript 4.1 upgrade If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1051466 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iec2b4aa18c7f6899e8a3cb6cf624f8e0236caa97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421537Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808857}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/48588bd1810d..078776328d3b 2020-09-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 50ae4c5f4427 to 60ce96e2ff10 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I3ee1778f2df6bd1288f1a747f99231a5786e1b23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421534Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808856}
-
Anastasiia N authored
account_reconcilor_delegate_unittest was removed from BUILD.gn by mistake in https://crrev.com/c/1758072. Change-Id: I659ce3583018bd957781d86178f18c620bc100d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421114Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#808855}
-
Saurabh Nijhara authored
This CL is pre-work for extracting ForceInstalledTracker related unit tests from force_installed_metrics_unittest.cc. This CL extracts the common elements in a test base class which could be used for unit tests of both ForceInstalledMetrics and ForceInstalledTracker. Bug: 1086430 Change-Id: I60a190012b640d87f1dc5f8d3e4e19fcc683dd53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416588Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#808854}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/80dc1e80..62f651b1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1a6dcd9be7ef53bc00eff9349fa27f63a605ba5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421868Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808853}
-
Changhao Han authored
In rare cases, DevTools frontend will call getComputedStyleForNode on a node that no longer has an owner document. This CL fixes this case, other it will result in a DCHECK failure in document.cc. Change-Id: I33b023e9ee600294cb8a3e9ea833b48e60bc0827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421668Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Changhao Han <changhaohan@chromium.org> Auto-Submit: Changhao Han <changhaohan@chromium.org> Cr-Commit-Position: refs/heads/master@{#808852}
-
Tim Volodine authored
The test is flaky on multiple bots, see crbug.com/1130550. BUG=1130550 NOTRY=true TBR=xingliu@chromium.org,qinmin@chromium.org Change-Id: If25b96affb01dd87458126cb01a848e9c2ff455c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421370Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#808851}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1600624217-41c1d66e89e64ad55188045c0ed19fbb5037e5e8.profdata to chrome-win32-master-1600678560-73f022cb15ffdf2af0536df3a108de473267405b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I8be9928324d47074ff33f14d9666b60a03542198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421529Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808850}
-
Nektarios Paisios authored
This patch was reverted because it was believed that it had caused a failure on the Linux Ozone bots. However, after running this patch through all the Ozone bots, no failures were detected. Original description: For every editing operation in Blink, this patch exposes to the browser and to automation clients the "type" property of its input event from Blink. The enumeration listing event intents was too long, and it included intents such as paste, type and replace. To make using intents simpler, the list of commands is now trimmed down to a few generic ones, such as insert, delete, format and SetSelection. For intents attached to text changed and text attributes changed events, more information is now provided in the intent's input_type member. Values are provided by a new enumeration that uses the same members as the W3C Input Events Specification. This makes the information more detailed, accurate, as well as standard's based. The TextBoundary and MoveDirection enums were also modified to add the "kNone" member so that event intents such as "kClearSelection" that have no boundary information and no directionality need not use them. Finally, the equivalent struct that is used by WebKit for event intents on Mac was added, as well as a conversion function. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org, dtseng@chromium.org, rsesek@chromium.org Bug: 989156 Change-Id: I7bc25347e51fc18b730aab84ca01a9eddad8d54f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416459Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#808849}
-
Anastasiia N authored
Reland of https://crrev.com/c/2121264, since getAccounts is already implemented. Bug: 1064677, b/123630392 Change-Id: Ic132d1fdfb5ef12a3ef70a6e064319ce904a6965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410858Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#808848}
-
Frédéric Wang authored
math-style was originally implemented in [1] but it was decided with the CSSWG to perform the following changes [2]: - 'display' is renamed 'normal' - 'inline' is renamed 'compact' - the default value becomes 'normal' (instead of 'inline') [1] https://chromium-review.googlesource.com/c/chromium/src/+/2100787 [2] https://github.com/w3c/csswg-drafts/issues/5387 Bug: 6606 Change-Id: I5eb4aa423f434c068ccb02517b086830291fcf55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421110 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#808847}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600667868-1426c4c889ab6f1601c0d673866dfd0987cca740.profdata to chrome-linux-master-1600689096-42a268e21a38ce243e34c88881f4529ac993701d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I250391c24c5cccca1c6019c927816e5008fd7db5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421539Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808846}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/015182971a39..22d5e3c0712d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC elklm@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: elklm@google.com Change-Id: I7edaab20bdce8783c845fdcd1421c13905a939e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421535Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808845}
-
Illia Klimov authored
TBR=timvolodine@chromium.org Bug: 1130533 Change-Id: I353b191f652c1ea39a53300226c6b39526f58686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421731Reviewed-by:
Illia Klimov <elklm@google.com> Commit-Queue: Illia Klimov <elklm@google.com> Commit-Queue: Illia Klimov <elklm@chromium.org> Auto-Submit: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#808844}
-
Henrik Boström authored
This feature has now rolled out to stable, so we change the default of the feature to enabled, allowing us to remove the .gcl file when M87 is promoted to Stable. Because serious/critical thermal signals are so rare (<1% of macOS population) and the impact of this resource is little-to-none, an alternative would be to simply delete the ThermalResource. However, by keeping the code, if the macOS signal is improved in a future release or if the thermal resource becomes available on more platforms (there are WIP CLs on Android and ChromeOS) then having the ThermalResource will automatically make use of these signals. And by having the base::Feature still in here, if changes to OS signals were to cause any regressions, we can use it as a kill-switch. // TBR in place of Evan's +1 (he's not a committer yet). TBR=guidou@chromium.org Bug: chromium:1100336 Change-Id: I03a2a765bd4b8cbbca5a9b618c71d7214b830ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418335Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#808843}
-
Ulan Degenbaev authored
Currently performance.measureMemory invokes v8::Isolate::MeasureMemory directly. This CL decouples that and prepares for the upcoming switch to the implementation based on PerformanceManager. The CL is pure refactoring without observable behavour change. It moves the existing code from Performance::measureMemory and MeasureMemoryDelegate into a new class called MeasureMemoryController. The new class is responsible for starting the measurement and resolving the JavaScript promise upon completion of the measurement. As a drive-by change this removes the code of MeasureMemoryExperiment that is no longer running. Bug: 1085129 Change-Id: I83382405278f8d6013583cd0f6ad79d8e7fc8d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418661 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#808842}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d62add52c69b..5721bfd7a5e6 2020-09-21 treehugger-gerrit@google.com Merge "Always add a "args" dictionary even if empty." 2020-09-21 hjd@google.com Merge "Reland code changes for mithril v2.0" 2020-09-21 fmayer@google.com Merge "Do not crash on missing root for flamegraph." 2020-09-18 fmayer@google.com Merge "Add multi ABI fix to changelog." 2020-09-18 hjd@google.com Revert "Revert "Revert "ui: Upgrade mithril 1.0.2 -> 2.0.3""" 2020-09-17 fmayer@google.com Merge "Make sure we are using the correct stack base." 2020-09-17 primiano@google.com Merge "Docs: minor fix to the benchmark code" 2020-09-17 rslawik@google.com Require core layout for time in state metric 2020-09-17 fmayer@google.com Rename all occurences of client_ext. 2020-09-17 lalitm@google.com Merge "tp: add support for shell on Android" 2020-09-17 fmayer@google.com Merge "Rename client_ext.h to heap_profile.h." 2020-09-17 fmayer@google.com Add missing fields from comparator for AllocMetadata. 2020-09-17 treehugger-gerrit@google.com Merge "perfetto-ui: Fix null keyed fragments" 2020-09-17 treehugger-gerrit@google.com Merge "Allow to write out profiles from HeapprofdEndToEnd." 2020-09-17 treehugger-gerrit@google.com Merge "Exporting flow events to json from flow table" 2020-09-17 fmayer@google.com Merge "Rename com.android.malloc -> libc.malloc." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:168725744 Tbr: perfetto-bugs@google.com Change-Id: Ibdd28b9a90bd917c2818c54785362277c55acee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421533Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808841}
-
Nazerke authored
This CL adds the new flag for the refactoring of the the TabStrip. Bug: 1128251, 1128249. Change-Id: I13a5b6fef21ef5bc414848fcb3ab4bbc3099c5e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410068 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#808840}
-
Carlos Caballero authored
Popups triggered by a different WebContents that then one that actually opens it were being misattributed to the former. This is a partial revert of https://crrev.com/c/2277737 where we thought that source_frame was the frame that opened the popup which is not the case. Added a test to prevent future regressions. Bug: 1128495 Change-Id: I51511716857b0074dad90feee709440c7b5f8795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418324 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#808839}
-
arthursonzogni authored
The RFH::last_http_method must not change after a same-document navigation. The previous code was relying on blink for reporting the correct method name for every navigation. It was hoping blink won't report a different method name for same-document navigation. This patch move setting this value in DidCommitNewDocument(). As a result it can change only after cross-document navigation. This is better, but still not ideal. Ideally, we shouldn't depend on the renderer. We should be able to retrieve this information from the NavigationRequest instead. This will be done as part of: https://docs.google.com/document/d/1oUKSDYIaz1-XMJw2f3KRTvq7yNR5O5IK8Iwgmk8laiw/edit# Bug: None Change-Id: I66d9f3718db2679f8c8df9d9547e0fcd415fc821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418676 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#808838}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1600656338-a4c2e29456479f7c103840465e0fb2a2783db828.profdata to chrome-win64-master-1600678560-d63b2733d2f4bab7a63bfddb4918170486fde26a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I0710052611f83d5c7d707147a6e07d1c0e1a56c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421428Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808837}
-
Alex Rudenko authored
Previously [1], we introduced throttling for painting the inspector overlay to reduce cpu usage on frequently updated pages. With new persistent overlays, this results in a rendering lag when scrolling the page. Therefore, this CL removes throttling to improve performance when scrolling. We will be still looking for better architecture to support smooth scrolling and low CPU usage. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/2202858 Bug: 1062574 Change-Id: I15bec84aaf525f6ede236c82d0a4fe1ffd234317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416294Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#808836}
-
arthursonzogni authored
The RFH::last_http_status_code must not change after a same-document navigation. The previous code was relying on blink for reporting the correct status code for every navigation. It was hoping blink won't report a different status code for same-document navigation. This patch move setting this value in DidCommitNewDocument(). As a result it can change only after cross-document navigation. This is better, but still not ideal. Ideally, we shouldn't depend on the renderer. We should be able to retrieve this information from the NavigationRequest instead. This will be done as part of: https://docs.google.com/document/d/1oUKSDYIaz1-XMJw2f3KRTvq7yNR5O5IK8Iwgmk8laiw/edit# Bug: None Change-Id: I50b42f825046ba76eb509d01373ce60d7087dd0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418957 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#808835}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/14dbf82961c3..b774d38d3143 2020-09-21 tommi@webrtc.org Remove use of AsyncInvoker from SctpDataChannel 2020-09-19 ajohnson@draster.com Fix bug with the sps-pps-idr-in-keyframe fmtp parameter. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3a136490bbe16f382e9519ed18461192b6b456c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421429Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808834}
-
Denis Kuznetsov authored
Bug: 1110790 Change-Id: I84dd699a0a0d891d28e9f4468110b522e006d54c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418677 Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#808833}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I0376420c21e28e4c2a649bad01629955523b532b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421608Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#808832}
-
Maria Kazinova authored
Fixes a crash for a case, when a successful submission is detected on iframe detach and a corresponding PasswordFormManager is moved while iterating through a vector of password form managers. Bug: 1129758 Change-Id: I03d8f41d2ee0dc599389385726e2f7f8c4d4b299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418956 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#808831}
-
Alexander Surkov authored
Bug: 1124366 Change-Id: I2ab34d8aeee10e7598fd0eb05ce9cb294e835d4d AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412452Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#808830}
-
sandromaggi authored
It appears that this flag has lost its meaning. Removing it. Also unsubscribing from further PDM changes once the callback is called. Bug: b/168445878 Change-Id: I0222043e53070fde7a36ba507d6ed95b4d082d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414395 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#808829}
-
Illia Klimov authored
Bug: 1130500 Change-Id: I9354e349132dfda8359d761ff84ed10016d7914b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421492Reviewed-by:
Illia Klimov <elklm@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#808828}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/101b41c4cb7e..feeee8f4b576 2020-09-21 jacktfranklin@chromium.org Add unit test helpers for component DOM mutations 2020-09-21 alexrudenko@chromium.org Extract inline CSS in inspector overlay If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1100925,chromium:1129881 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id3e6223b93dbdea21785d52cc4be648efc716021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421531Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808827}
-
Roman Sorokin authored
Also removed GOOGLE_CHROME_BRANDIND guards for the tests to align more to the real cases. Bug: 1108996, 1032194 Change-Id: I726c7b826c222b879df1da167ba82b8e5245d684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409910 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#808826}
-
Mariam Ali authored
This CL adds new strings that show the number of windows open for guest mode. Design Deck: go/alignmenus Screenshots: https://screenshot.googleplex.com/48G33sBGhnJZFUJ.png Bug: 1105763 Change-Id: Ifb616a042eef5195156ba98353a6af8d182413c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410130 Commit-Queue: Mariam Ali <alimariam@google.com> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#808825}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/431ce7786b0d..015182971a39 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC elklm@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1129493 Tbr: elklm@google.com Change-Id: I8f1c380021f92369c132266cca6de95980b1caf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421269Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808824}
-
Omar Morsi authored
The responsibilities of the current KeyPermissionsManager are moved into KeyPermissionsService, which is a per-Profile KeyedService. Bug: 1127284 Change-Id: Ided34a4397a07bb2112de6704862af3b2df51468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405576 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Edman Anjos <edman@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#808823}
-
Roman Sorokin authored
It's used only when sync does not provide image details. I could not create a browser test for this. Fixed: 1081249 Test: manual Change-Id: I81ba0db7ae2ba79faa0e92318bc9138f7c1c7aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419013Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#808822}
-