- 30 Oct, 2019 40 commits
-
-
Ian Struiksma authored
Several sites were failing on windows autofill tests. The main issue seems to be the resolution on windows bot that causes the sites to sometimes render differently than when they were recorded. One site needs different behavior for a button click on replay so added a new action that will first check for a different element's presence before trying to find the button to click. Updated site recipes for 5 sites, so cipd version was updated: sephora (removed a visibility constraint) indigo (same) newegg (added extra clicks to reset phone/zip fields to verify) rue21 (rerecorded site on smaller resolution and used click fallback) crate_and_barrel (forced payment page load) Bug: 984664 Change-Id: Ic7d11082a2b4af53779281fcd27dce65753bac37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888742 Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#710922}
-
Greg Thompson authored
The ScopedTempDir must outlive anything that holds file(s) open within it; otherwise, it is unable to delete itself. BUG=546640 Change-Id: Ibf96099cd1e14c165f84759f5b92b0de838a6e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890321 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#710921}
-
Francois Doray authored
Tab freezing will ship on all desktop platforms, so the enterprise policy to disable it should be available on all desktop platforms. Bug: 844426 Change-Id: I0e2cfc34a34297ae48fd539d9534d6e11f56fa3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883870Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#710920}
-
Regan Hsu authored
Currently, when you enter and exit the preview mode, the list items (each wallpaper thumbnail in the current collection) lose their tabIndex and aria-label. This CL adds these properties back in so that the user can tab through and the title is read out in chromevox. Bug: 1005633 Change-Id: I60a2b2b5ea714d37bac440e9327d95b4867bc112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888377Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#710919}
-
anthonyvd authored
This reverts commit e26a5125. Reason for revert: Breaks this bot: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/6141 Original change's description: > [WebLayer] Fix crash when top controls view has 0 height > > This happens because the adapter and layer for the top controls is only > created once height and width are > 0. We were assuming this had already > been created in setTopControlsOffset(). > > Change-Id: Idf104f9d5c951c1fa8719fa30661dceae59b4887 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890492 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710897} TBR=sky@chromium.org,cduvall@chromium.org Change-Id: I8304cc6583bdd606a4d52e8bd60cdf5957f7d384 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890795Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#710918}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I5f48430f8789cfa7fc2d2a677970b5293388ae5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890509Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710917}
-
Yang Guo authored
TBR=hkamila@chromium.org Bug: 1018177 Change-Id: I19bd3d7e1ee71899a248c0896a254fb9e2fbeeae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890073Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#710916}
-
Abigail Klein authored
Do not support the IAccessibleText, IAccessibleHypertext, AtkText, and AtkHypertext interfaces for images. This fixes a bug in which an image inside of a contenteditable was announced as just the first letter of its alt text. Bug: 1011837 Change-Id: Ifd128a7cf37a878e350c433f9a5ce96ffdfd3db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876687Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#710915}
-
Yue Li authored
Bug: b/143516594 Test: Manual Test Change-Id: I42251a3b7c97723c7eeb2f0267dbdc72a8fee66c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888651Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#710914}
-
Caleb Raitto authored
Bug: 953995 Change-Id: Id0dd9a4c767ad0c83744c5b10e1735be81ccbd55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883293Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#710913}
-
Regan Hsu authored
The spinner is currently placed in the LTR location for RTL languages. This CL places the spinner in the correct location for either. Bug: 918122 Change-Id: Ie264f0b8e967fdf8abe04573a08c270a32dbc425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888777Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/27bd4e420d28..b43d98bf6484 git log 27bd4e420d28..b43d98bf6484 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 ehmaldonado@chromium.org auth: Fix has_luci_context_local_auth. Created with: gclient setdep -r src/third_party/depot_tools@b43d98bf6484 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1018069 Change-Id: I4ff7f0d978e901da56c7a3715972f805f17c4fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890505Reviewed-by:
-
Tibor Goldschwendt authored
This fixes a bug where modules can miss an ABI and fail the bundle packaging step. This is due to two factors: 1. crrev.com/c/1876975 added an allotment step to each bundle that determined in which module native libs are packaged into. If a module only depends on libs that are also depended on by other modules this module will package no libs even though libs are specified when instantiating the module target. 2. Bundletool requires that all modules support the same set of ABIs. To make modules appear to support the WebView ABI for Monochrome and Trichrome we add placeholder libs for the WebView ABI. We do this in the chrome_feature_module template if we specify real libs for the browser ABI. Given 1. and 2. it can happen that a module is only left with the placeholder lib and appear single ABI, failing packaging. This CL fixes that by telling the packaging step that the module should be multi ABI and the packaging step will add a placeholder lib if necessary. This makes placeholder logic in chrome_feature_module obsolete and therefore it is removed. This new multi ABI logic can likely be reused for other APKs that use lib placeholders simply to make the APK multi ABI. This is a reland of a9dcd64a with a fix for builds where buid_apk_secondary_api is false. The fix is just removing an that turned out to be not useful. TBR: estevenson@chromium.org,cjgrant@chromium.org Bug: 870055 Change-Id: I89766821459bfe62f292a67252a7ef0a2e99b2d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890979Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#710910}
-
Edward Jung authored
Replaced the previous curly ones. Change-Id: I46024a0dcd25cf56189edee18d7d1a62f943053f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871608Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#710909}
-
Nico Weber authored
These macros are used in all of 3 files. Instead of all this magic, maybe the components that need this should define FOO_TEMPLATE_EXPORT_DECLARE and FOO_TEMPLATE_EXPORT_DEFINE in their foo_export.h file instead, and make it expand to the right thing there. That seems a lot simpler and easier to understand. But for now, let's just add a comment. Bug: none Change-Id: I5fd56440a07a4c7ba879af6d809c7e1397d05737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890531 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#710908}
-
Carlos Caballero authored
Change-Id: I0be89fe1fb55a352faeb05989fad1346155a0338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890419Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#710907}
-
Daniel Murphy authored
This change avoids a race condition in IndexedDBContextImpl's Shutdown method. In that method, std::move is used on a variable on the UI, where that variable is supposed to be only accesed or modified on the IDB task runner. Being a race condition, this is really hard to test, and I'm not sure what I would do to test this. It is also not necessarily the fix for the given bug. Bug: 1018741 Change-Id: Ia071e5a053952af8c74aa30e0e5e218c4b97100f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885498Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#710906}
-
Michael Spang authored
The platform_window target is used from multiple components and should therefore be a component itself. This is needed to avoid ODR violations. One ODR problem that currently can happen is the duplication of the global boolean backing UseTestConfigForPlatformWindows(). Bug: 1019015 Change-Id: I935df9a2fb2c6df1fec887c45c332bc833db91b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889293Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#710905}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/76abb20f3770..3abb07fb77e6 git log 76abb20f3770..3abb07fb77e6 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 seanabraham@chromium.org chromeos_config: make tatl and tael critical again Created with: gclient setdep -r src/third_party/chromite@3abb07fb77e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I899a94d99e0752b95bba65608d8406e393af3e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890836Reviewed-by:
-
Chris Lu authored
Disable testPasswordIconIsNotVisibleWhenPasswordStoreEmpty because it is failing in iOS 13.2 Bug: 1019535 Change-Id: Ib285e0019207a8463c52246d4864674c01f54522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891130Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#710903}
-
Kevin Ellis authored
This patch removes PlayStateUpdateScope from NotifyCompositorStartTime and aligns the implementation of NotifyStartTime with the 'pending play task' in the web-animations spec. https://pinpoint-dot-chromeperf.appspot.com/job/11bd74d8220000 Bug: 960944 Change-Id: I5b296e7f67458e362470ef1f151e73f07bf60bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881123 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#710902}
-
Jasper Chapman-Black authored
Plus some JavaScript scaffolding to avoid re-uncompressing the .size file on every buildTree() invocation. Bug: 1011921 Change-Id: I839fb8a8e0ea0b1509620b391a1dd3153a157e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888371 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#710901}
-
Darwin Huang authored
(1) Simplify clipboard_constants code by consistently specifying constants in clipboard_constants (as opposed to clipboard_format_type). (2) Add comments to explain the need for separation between clipboard_constants and clipboard_constants_mac. No intended functional changes. Change-Id: I8c9520341c4d90f1a071c65d22b91e91eca5d410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886112Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium cd0f6a46. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I974773d5cf4c8e083bfa81801d661704bafd2650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890791Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710899}
-
Jared Saul authored
Fixed: 980716 Change-Id: Idcb779085be438c29af233cc805cfe73f7ebd42c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877820 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#710898}
-
Clark DuVall authored
This happens because the adapter and layer for the top controls is only created once height and width are > 0. We were assuming this had already been created in setTopControlsOffset(). Change-Id: Idf104f9d5c951c1fa8719fa30661dceae59b4887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890492 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
Gang Wu authored
Bug: 1018888 Change-Id: Ia548a163261b25f06222916498c7b8ea83fa03d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885211Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#710896}
-
Theresa Wellington authored
Introduce a new CustomViewBinder interface that allows AppMenuPropertiesDelegates to handle binding for custom menu items. This interface is used to provide a custom binder for the update menu item, which relies on UpdateMenuItemHelper methods/classes that will not be moved to the appmenu/ package when its modularized. Bug: 966644 Change-Id: I6c49522775c1f0fca3cd64764a0eba6a5b82f3b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872980Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#710895}
-
Mia Glaese authored
Clicks on the toolbar are currently passed through the url_bar behind it. This leads to unexpected behavior when not user-visible views handle click events. The change makes the toolbar intercept all click events on not user-visible views. Accessibility is unaffected, see here: https://drive.google.com/file/d/1LDGfFfaCkg2meUNPX3211HE2_bIJGJNr/view?usp=sharing Bug: 982018 Change-Id: Ibadba84a8f500cb7cf7aaa5129c91b11f2a5e9e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887150Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#710894}
-
Kurt Horimoto authored
This involved updating the test fixture to use a different mechanism because the execution of the JS script bodies via ChromeEarlGrey injection hangs because of JS execution halts while the dialogs are displayed. Instead, there is now a tappable link on the page that executes the dialog scripts with a timeout so that the script execution can return while the dialog is displayed. Bug: 987646 Change-Id: Ifa90d923360ca03c686d662a7cc34575dff94037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883137 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#710893}
-
Carlos Caballero authored
We were missing a WaitForFirstVisuallyNonEmptyPaint in the test but actually we can simplify it quite a bit as there is no need to put the page in the bfcache to exercise the code under test. Bug: 1019664 Change-Id: I1b714d77a4a4002ba8b3eae08ea881bcaad4b93e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890338Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#710892}
-
David Roger authored
Change-Id: I0681b6feafe06b9434ea0df66ad0724f290aa17b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886897 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#710891}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn files below //base to instead use conditional to include source files only on the platformn where they are used. The conversion was done by using a modified version of gn that display all files filtered by set_sources_assignment_filter() and updating the BUILD.gn files manually to explicitly add the source files only on the platform that used them. Bug: 1018739 Change-Id: I236542d7b8e2b5cba5b633b37791d1f1dbbe8d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879458 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#710890}
-
Sky Malice authored
This reverts commit 5f5c6c4b. Reason for revert: As Boris points out in https://bugs.chromium.org/p/chromium/issues/detail?id=789531#c56 , my original revert was mistaken, it wasn't the offending CL, but rather was fixing the issue. Relanding. Original change's description: > Revert "[Android][Signin] Fix bookmark signin promo dismiss tests" > > This reverts commit 04962c50. > > Reason for revert: Test failures, see https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Tablet%20Tester/14131 > > Original change's description: > > [Android][Signin] Fix bookmark signin promo dismiss tests > > > > This CL fixes the bookmark signin promo tests when the promo is > > dismissed in different scenarios. > > > > Bug: 789531 > > Change-Id: I852e60cb3e56f9db737cb0e03073d36373908f68 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883628 > > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > > Reviewed-by: Theresa <twellington@chromium.org> > > Commit-Queue: Alice Wang <aliceywang@chromium.org> > > Auto-Submit: Alice Wang <aliceywang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#710784} > > TBR=twellington@chromium.org,bsazonov@chromium.org,aliceywang@chromium.org > > Change-Id: I68d849103de344e495520b8c015edfba75fd6388 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 789531 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890506 > Reviewed-by: Sky Malice <skym@chromium.org> > Commit-Queue: Sky Malice <skym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710853} TBR=twellington@chromium.org,skym@chromium.org,bsazonov@chromium.org,aliceywang@chromium.org Change-Id: I43787dce3fd7d0004ef777b1724fec1935db0347 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891230Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#710889}
-
Gavin Williams authored
-Add a flag to cr-searchable-dropdown so we can track whether the user's current text input in the dropdown matches the previously saved value. We use this flag to disable the printer add button if the user typed invalid input into either the Manufacturer or Model dropdown. Fixed: 950887 Change-Id: I1f632b80fd8619718f13f8a5f5332ad7a62eb69e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880181 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#710888}
-
Michael Crouse authored
Bug: 932707 Change-Id: Ieb3cc5571e9e632cb451f317f87a59d912fd232a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887718Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#710887}
-
Greg Thompson authored
BUG=None R=fdoray@chromium.org Change-Id: Ic566ca8d92ddaca27b127099f9437d0e0a4d6e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889973 Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
-
Michael Lippautz authored
This reverts commit b936d5f1. Reason for revert: Flaky crashes on webgl bot; see bug. Original change's description: > css/resolver: Refactor weaknesss in MatchedPropertiesCache > > MatchedPropertiesCache was the single user of custom weakness using > HashTraits. Supporting custom weakness in hash tables is responsible for > a lot of complications in the tracing protocol. > > MatchedPropertiesCache was using weakness to hold alive a cached entry as long > as all of its matched properties are alive. Once a single matched property dies > the entry was removed. > > This can be modeled using a custom weakness callback that performs the same > logic. Cached entry don't have any outgoing edges except for their cached > matched properties, so ephemeron semantic is not required. Using a custom weak > callback is also faster because the callback is only executed once and not part > of the ephemeron fixed point protocol. The cached entry is unlinked using the weak callback and collected on next GC cylce. > > After this conversion, custom weakness can be removed from hash traits. > Weakness should always go through already supported types (e.g. > WeakMember). > > Bug: 1019191 > Change-Id: I52b7b24dcba8a3aaca896f86a351da665667fcf9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886611 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Omer Katz <omerkatz@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710693} TBR=haraken@chromium.org,mlippautz@chromium.org,omerkatz@chromium.org Change-Id: I30c098eb560e7fa62c6f5bd354188fc2a3eb2ab2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1019191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891190Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#710885}
-
Lily Chen authored
This change straightens out some of the convoluted logic in this method, so that hopefully it is simpler and easier to understand. Bug: None Change-Id: I913e98c04c3f9f3a8c6727a25c6c0f4675695c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877664 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#710884}
-
Alex Clarke authored
We'd like to turn off sequence manager anti-starvation logic but we need to change this first to ensure the expected ordering of PostTask and content::BrowserThread::DeleteSoon. The observable difference is BrowserThread::GetCurrentThreadIdentifier now inherits base::TaskPriority where previously it did not which is dangerous. Bug: 1013535, 1019767 Change-Id: I88cf03635b37f680f10b5aefd582afae35474a45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886901Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#710883}
-
