- 22 Jan, 2021 40 commits
-
-
Curt Clemens authored
If the body of a success notification is clicked, then the primary action should be taken instead of doing nothing. Fixed: 1168293 Change-Id: I494bcf53ec1bb1cd615a30e417c95e01877c9431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643856Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#846168}
-
Jesse McKenna authored
This change adds a metric to measure how often a navigation occurs where the target URL matches a RenderProcessHost that was destroyed in the past few seconds. The new metric, "SiteIsolation.ReusePendingOrCommittedSite. TimeSinceReusableProcessDestroyed", emits on every navigation. It records the time (in ms) since a RenderProcessHost with a matching process lock was destroyed, up to 7 seconds. If no matching host was destroyed within the past 7 seconds, it records a sentinel value of 10 seconds. Knowing the most common times since reusable processes were destroyed will inform a broader experiment to potentially delay subframe process shutdown by a few seconds to reduce process churn. Including the sentinel value adds information around how frequently reusable processes are destroyed, i.e., how much opportunity for process reuse exists. Test plan (see "Metrics" section for details on this metric): https://docs.google.com/document/d/11XruVZzYLSkt4se6IV2O4jFOkKs-QbkRB5NMf4mH_hE Bug: 894253 Change-Id: Ic15089d1e3b086480942b6afe32525b3c6461895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575945Reviewed-by:
Oliver Li <olivierli@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#846167}
-
Scott Violet authored
SessionService(FilePath) constructor was only used in one place, and can easily be converted to use the Profile* constructor. This converts to the Profile* constructor and cleans up conditional code. BUG=none TEST=none Change-Id: I3f486ee48db97b8e825df31a66bf276737b76c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644070Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#846166}
-
Adam Ettenberger authored
This CL addresses a Blink Accessibility invalidation gap, when a node's aria-hidden state changes, its blink accessibility subtree must also be invalidated so that the accessibility ignored and invisible states are serialized to the browser process. This is important because we rely on these states being accurate in the browser process, and we need need to receive the state changes through AXEventGenerator in order to send appropriate platform accessibility events, such as structure change events (add/remove child, hide/show, or 'children-changed'). Adding AXObjectCacheImpl::HandleAriaHiddenChangedWithCleanLayout which handles this invalidation, and immediately handles ChildrenChangedWithCleanLayout on the parent of the modified node, and increments |modification_count_| to invalidate AXObject cached values. e.g. AccessibilityIsIgnored(), and IsInertOrAriaHidden(). I needed to also modify BrowserAccessibilityWin::CanFireEvents to allow events to process for the corner case outlined in Bug:1159660. Because the node becoming ignored was the only child, the parent became a leaf node, and the node removed would return false for CanFireEvents because now it "IsChildOfLeaf()". I added a condition to check if the ignored state changed this frame, and if so, allow events to process. BrowserAccessibilityManagerWin filters platform events appropriately for nodes that are ignored. Bug: 1159660 Change-Id: I82e2368c09d4855fdb834600aed7ac61d1883c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612365 Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Jacques Newman <janewman@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#846165}
-
Eugene But authored
Made zhaoyangli and stkhapugin the owners of EG infra. Made zhaoyangli and olivierrobin the owners of test infra. Bug: None Change-Id: Ieedec52a5798353ed3bcf622302fb1ea279b2113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643262 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#846164}
-
Luke Zielinski authored
These two tests were recently blocking wpt import because they have different results for linux-rel vs linux_layout_tests_layout_ng_disabled. Quick fix was to mark these as flaky via TestExpectations, but this CL updates the layout-ng-disabled baselines instead. Bug: 1168130 Change-Id: Ib8f1d05cf53d62486bde4689e05c4c1e70d46118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643359 Auto-Submit: Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#846163}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202101220600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/pNxnip2F8wICOrBjoNUbN_PM0CdfAwj4mNlQSwyP7dgC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/178042652,b/178140249 Tbr: help-app@grotations.appspotmail.com Change-Id: Icfc01440f84af395005efe78961ae28c75c6cd54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643254Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846162}
-
Etienne Bergeron authored
This CL is fixing an inconsistent state that can happen in the TtsPlatformImplWin class. TtsPlatformImplWin has a background worker TtsPlatformImplBackgroundWorkerthat processes asynchronously tasks and sending back notifications. There was a corner case where Pause is called TtsPlatformImplWin::Pause(...) and there was a notification in transit to notify the completion of the current spoke utterance. This was leading to that state: TtsPlatformImplWin::is_speaking_ = false TtsPlatformImplWin::paused_ = true This CL is changing the TtsPlatformImplWin class to handle properly the notifications sent back by the worker. If the notifications clear/stop the utterance and the current state is paused_, a Resume(...) is performed to ensure a valid state. R=dmazzoni@chromium.org Bug: 1167103 Change-Id: I719dca37e08094afc214d469432c7e2541d155f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640753Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#846161}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5093ccefbf2c..28c13893f937 2021-01-22 tvanderlippe@chromium.org Disable flaky Debugger Language Plugins test 2021-01-22 andoli@chromium.org [module.json extensions] web_audio 2021-01-22 tvanderlippe@chromium.org Force add the tooltips for the emulation buttons If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103,chromium:1169688 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iab1d24cd7c426151d8d31a6fa732023c790fc90a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643075Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846160}
-
Igor Ruvinov authored
The metrics reporting policy is automatically downgraded to "recommended" level due to privacy reasons. This change modifies the corresponding policy table message from type Error to type to Info, as it is an informative message to make admins aware of the automatic downgrade. Bug: 1155602 Change-Id: Iebd13bb2d6363cf40daa792f2dcdbe0a023eff33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643061Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org> Cr-Commit-Position: refs/heads/master@{#846159}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c827ccbb58b8..b745f6df8801 2021-01-22 jmadill@chromium.org Capture/Replay tests: Fixes for goma & depot tools. 2021-01-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 22be66d40712 to 9441aea16221 (10 revisions) 2021-01-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f646afdb8929 to a0047c0f6ec8 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I462825347e55a8764979e6bea29ab81d8da44a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643252Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ia82a0793178ff84bb2e0432ce8755bcf5ff696f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644925Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846157}
-
Eugene But authored
Change-Id: I4137602532a9cf92b02bcb762951764f8b375310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643301Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#846156}
-
Ravjit Singh Uppal authored
Bug: 1165795 Change-Id: Iaf59a0dab7da5c7578a79e54d0a3cea9140e2b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624788 Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#846155}
-
Dan McArdle authored
Change-Id: I8bf824819ea496cd3fa50d9b6b82c6085948c3e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625993Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#846154}
-
Rouslan Solomakhin authored
Before this patch, secure payment confirmation was available only on Mac as an origin trial. This patch enables the renderer origin trial on Windows and enables by default the browser feature on Windows, too. After this patch, websites that are running the secure payment confirmation origin trial can enroll and exercise payment credentials on Windows with Windows Hello in addition to the existing support for TouchID on MacOS. The current origin trial runs to M-89, so enabling the origin trial on Windows in M-90 will have no effect until a new origin trial is started. Intent to experiment on MacOS until M-89: https://groups.google.com/a/chromium.org/g/blink-dev/c/9cgsOW3XNw4/m/bBgGYUwACQAJ Bug: 1169045 Change-Id: Ic6f37257571c4b162035c200f6eaa36919215c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642404 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#846153}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a3545e46d238..9c81656e14af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nsatragno@google.com,snijhara@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1148764 Tbr: nsatragno@google.com,snijhara@google.com Change-Id: Id2d30358dfc6d8e021fdb28f616c6fd9f14276e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645024Reviewed-by:
-
Tim Volodine authored
Add "WebViewJavaJsBridgeMojo" feature to enums.xml in order to enable metrics regarding its usage. BUG=1164434 Change-Id: I5ed07a9c81b946c37c0e74cc83a39ec3cc28c0fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644877Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#846151}
-
Stefan Zager authored
Change-Id: I7e169b86c66e8c3ab5f4fd3b96ceed1d01c5a309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643055 Auto-Submit: Stefan Zager <szager@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#846150}
-
Yutaka Hirano authored
With this CL, WritableStreamTransferringOptimizer is actually used when transferring a WritableStream. Bug: 1146396 Change-Id: Ia82176b23e9de6b4e8e54fd1332ade2decabb2f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642640Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#846149}
-
David Maunder authored
Speedup: 20580ms -> 4586ms (78%) Bug: 1169444 Change-Id: I5d4f4015e9ff30a588cb004b62a36be2b6cebd21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644240Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#846148}
-
Tim van der Lippe authored
If users set a large font, the checkbox would no longer be aligned. Therefore, we need to force the alignment of the checkbox with the text, to make sure it works for all font sizes. R=yangguo@chromium.org Fixed: 1168996 Change-Id: I526e9e3a623594ef5a1547fd133b54e17d866c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643725 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#846147}
-
Sylvain Defresne authored
Those file were just forwarding functions from base/ios/ios_util.{h,mm} so change client code to use the //base functions are remove the files. Bug: none Change-Id: Ie39dda86754c9a063a470abb2f323f7ad363c924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642693 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#846146}
-
Yutaka Hirano authored
Bug: 1161996 Change-Id: Iedc79e57787ef9e9c300bd8b9696353a28ba138e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643892Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#846145}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611304267-90669dcf550835de268a2353a6cf5648f5d0af68.profdata to chrome-win64-master-1611316382-2d0f555a9d3aa5811a7e026e1b7c53cee9a9715c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I73ba11f8c44066a2020bd3b24ae3bd79f12d6a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643255Reviewed-by:
-
Eric Seckler authored
This experiment evaluates the impact of a bug fix on power metrics. The bug caused the feed spinner to continue running 60fps animation tasks in the background. It turns out that, when this continues after Chrome goes into the background, it can cause Android to terminate Chrome earlier. Currently, users only enroll into a Finch group when the feed spinner is first shown. This doesn't happen in all browsing sessions. As a result, the Finch data is skewed towards shorter browser process lifetimes in one group. To work around this, this patch checks the feature's flag value after Chrome's native startup, thereby enrolling every user and browsing session into one of the Finch groups. This way, we can draw conclusions on the power impact of this bug for any user, and including any impact on cold starts. Bug: 1151391 Change-Id: I2ca59c9539f1bab7bfafe12ad61e59f0a7a8aae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642628 Auto-Submit: Eric Seckler <eseckler@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ifb9be231a9bc60c39c11c067303d5b9319138430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645046Reviewed-by:
-
Thiabaud Engelbrecht authored
thread Bug: 1169394 Change-Id: Ic6808b5275d954eb0cfef920c2e372e20e0f4f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644456Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Cr-Commit-Position: refs/heads/master@{#846141}
-
Caitlin Fischer authored
The server-side config shows that the study has ended. Bug: 1126640 Change-Id: I76ff1a337b5dad17228ab4c2d2a5b88ca7af37f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632185Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#846140}
-
Evan Stade authored
Bug: 1164069 Change-Id: I0abf13d932f72f3ed2b3f387afe3edc5578c9c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637930 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#846139}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5b2a5204087d..57144c8685d3 2021-01-22 primiano@google.com Merge changes I9f4c2738,Ic66051c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4e2edc264645bfbd1efa8de8fbe1fc09f06f31b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643786Reviewed-by:
-
Findit authored
This reverts commit fb8f8c0d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 846061 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZiOGY4YzBkZDZkZjk1ZGRkZmFkNzkzMzhmODhlZjk5NGUwZTliMWEM Sample Failed Build: https://ci.chromium.org/b/8857394482161435200 Sample Failed Step: browser_tests Original change's description: > Update unrar to 6.0.3 > > https://github.com/aawc/unrar/pull/25 for the corresponding change on Github > > BUG=1166496, 1166497, 1166498, 1166499, 1166500, 1166501, 1166502, 1166503 > > Change-Id: Idece6bd531d55f1b379d0a38fad5f74f64323749 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634824 > Reviewed-by: Daniel Rubery <drubery@chromium.org> > Commit-Queue: Varun Khaneja <vakh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#846061} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=1166496, 1166497, 1166498, 1166499, 1166500, 1166501, 1166502, 1166503 Change-Id: I7a45d79f9eb6f188fabbc99e3fd4ec3643c7fd93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643791 Cr-Commit-Position: refs/heads/master@{#846137}
-
Scott Violet authored
AFAICT it's no longer used. I believe it was orphaned here: https://codereview.chromium.org/1129903008 . BUG=none TEST=none Change-Id: Ib47b4515e139d2ce0175ddb5ef13c5a88e726d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644103Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#846136}
-
Robert Flack authored
Based on the discussion in https://github.com/w3c/csswg-drafts/issues/4953 aspect ratios should be interpolated by the log of their value preserving the same visual speed whether they are wide or narrow. This patch adds a new interpolation type for aspect ratios and uses it for interpolating the CSS aspect-ratio property. Bug: 1156160 Change-Id: I6cbff0abef54290de559a7625e24e3c4e1f1e0e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586234Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#846135}
-
Reilly Grant authored
This change converts callbacks from base::Bind and base::Callback to Once/Repeating in //chrome/browser/chromeos/platform_keys. Bug: 1148570 Change-Id: I05f66512de80ac0fd0ac21cd941a408e17190fd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644074 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#846134}
-
Marc Treib authored
This aligns the name with the native SyncService. Also rename SyncTestUtil.isSyncActive()/waitForSyncActive() to isSyncFeatureActive()/waitForSyncFeatureActive() for consistency. Bug: 985290 Change-Id: I6383e8bd6bdf3b0767fdd7f5e3c3c4b49292d82d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644938 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#846133}
-
Asanka Herath authored
During analysis we may synthesize additional identifiable surfaces. Reserve an `IdentifiableSurface::Type` enum value so that we can represent those surface using the same data type. R=morlovich@chromium.org Bug: 973801 Change-Id: Iac74a97d4ed0bc67fae2f8a4b408c271196a95f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643456 Auto-Submit: Asanka Herath <asanka@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#846132}
-
Peter Wen authored
The invocation to md5_check was complex and it is easy to miss an arg. Since compile_resources is using transitive assetres deps instead of depending on the actual java targets, it is no longer on the critical path and no longer needs md5_check. See below for benchmark stats. Before (r845557): gn args: target_os="android" use_goma=true android_fast_local_dev=true gn gen: 7.0s chrome_java_nosig: 34.3s avg (34.6s, 33.7s, 34.7s, 34.1s) chrome_java_sig: 35.4s avg (35.1s, 35.4s, 35.0s, 36.2s) chrome_java_res: 38.6s avg (38.7s, 38.6s, 38.5s, 38.7s) base_java_nosig: 42.9s avg (42.7s, 42.9s, 43.1s, 43.1s) base_java_sig: 106.5s avg (107.0s, 106.8s, 105.8s, 106.5s) After: gn args: target_os="android" use_goma=true android_fast_local_dev=true gn gen: 6.7s chrome_java_nosig: 33.6s avg (33.3s, 33.9s) chrome_java_sig: 34.8s avg (34.1s, 35.5s) chrome_java_res: 38.9s avg (38.5s, 39.3s) base_java_nosig: 43.3s avg (43.0s, 43.6s) base_java_sig: 106.7s avg (106.0s, 107.5s) Bug: 1066943 Change-Id: I538a2c15ee07cf0beec23b2e0885c84b964273c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643120 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#846131}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/450f8565c7f3..372791761157 2021-01-22 johnstiles@google.com Squelch Metal warnings about unused _globals/_out. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I4b84898849024031c8a8ab1d4d5bf8ba66bf11f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643251Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202101220600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/KoDoxKsUgYmDk8Xbp62-4Mftkzdv-ER37BKn6ELSk8MC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138543581,b/154430508 Tbr: media-app@grotations.appspotmail.com Change-Id: If32432424ccc99ebfd1815ef75dde414502fd250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643253Reviewed-by:
-
