- 28 Oct, 2009 40 commits
-
-
mbelshe@google.com authored
Document the API for FlipDelegate in flip_session.h. Remove the method OnCancel, since it was not needed. Add the method OnBodySent, which is not yet used but will be. FlipNetworkTransaction is a FlipDelegate, so the changes there are just to reflect the new API. BUG=none TEST=none Review URL: http://codereview.chromium.org/339047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30380 0039d316-1c4b-4281-b951-d872f2087c98
-
kuchhal@chromium.org authored
BUG=11971 TEST=No functional change. Make sure first-run/import still works on all three platforms. Review URL: http://codereview.chromium.org/340020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30379 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
Add initial implementation of AutoFill++. This implementation is hidden behind a switch, --enable-new-autofill. So far, we only pop up an infobar asking the user if he'd like to save the form information. I've added a rudimentary icon for the infobar, pulled from the mocks, so we'll probably want a blessed version of this icon at some point. BUG=18201 TEST=none Review URL: http://codereview.chromium.org/339030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30378 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@google.com authored
Change from absolute paths to relative paths to allow tests,etc. to be located in any directory, as long as the directory structure is correct. Original review at: http://codereview.chromium.org/344013. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30377 0039d316-1c4b-4281-b951-d872f2087c98
-
piman@chromium.org authored
Review URL: http://codereview.chromium.org/339040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30376 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
Review URL: http://codereview.chromium.org/347006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30375 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
coding. I can't think of a good reason why we were hard coding it before. BUG=17592 TEST=none Review URL: http://codereview.chromium.org/340009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30373 0039d316-1c4b-4281-b951-d872f2087c98
-
scherkus@chromium.org authored
TBR=maruel BUG=25952 Review URL: http://codereview.chromium.org/345015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30372 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/342021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30371 0039d316-1c4b-4281-b951-d872f2087c98
-
japhet@chromium.org authored
Add in some flaky tests and remove a bunch of plugin tests that are now passing on MAC. BUG=25880 BUG=20748 BUG=20438 BUG=11613 BUG=10438 BUG=10374 BUG=10354 BUG=10667 BUG=10351 BUG=10673 BUG=6735 TEST=layout test bots still green Review URL: http://codereview.chromium.org/345010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30370 0039d316-1c4b-4281-b951-d872f2087c98
-
jorlow@chromium.org authored
TBR=rolandsteiner TEST=none BUG=none Review URL: http://codereview.chromium.org/341021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30369 0039d316-1c4b-4281-b951-d872f2087c98
-
kathyw@google.com authored
TEST=none BUG=none TBR=aa Review URL: http://codereview.chromium.org/340021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30367 0039d316-1c4b-4281-b951-d872f2087c98
-
robertshield@chromium.org authored
Remove a DCHECK that happens on every exit of IE. We appear to be leaking automation proxies, which I maintain is a bad thing. BUG=Start IE with debug CF installed, navigate to a chrome frame page, exit IE, see the DCHECK. Review URL: http://codereview.chromium.org/342018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30366 0039d316-1c4b-4281-b951-d872f2087c98
-
gman@google.com authored
and specific commands. Common are things like Noop, SetToken, Jump, Gosub, return. Specific are O3D etc... Review URL: http://codereview.chromium.org/329046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30365 0039d316-1c4b-4281-b951-d872f2087c98
-
jorlow@chromium.org authored
TBR=japhet BUG=none TEST=none Review URL: http://codereview.chromium.org/338066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30364 0039d316-1c4b-4281-b951-d872f2087c98
-
cevans@chromium.org authored
start==0 and end==9223372036854775807, i.e. the full positive range of a 64-bit signed int. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/346003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30363 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@google.com authored
Revert 30359 - Change from absolute paths to relative paths to allow tests,etc. to be located in any directory, as long as the directory structure is maintained. Review URL: http://codereview.chromium.org/344013 TBR=kkania@google.com Review URL: http://codereview.chromium.org/345013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30362 0039d316-1c4b-4281-b951-d872f2087c98
-
victorw@chromium.org authored
R=ojan BUG=25858 TEST=rebaseline tool Review URL: http://codereview.chromium.org/345008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30361 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
TEST=Covered by net_unittests. BUG=25520 TBR=eroman Review URL: http://codereview.chromium.org/344015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30360 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@google.com authored
Change from absolute paths to relative paths to allow tests,etc. to be located in any directory, as long as the directory structure is maintained. Review URL: http://codereview.chromium.org/344013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30359 0039d316-1c4b-4281-b951-d872f2087c98
-
nsylvain@chromium.org authored
just windows. see http://build.chromium.org/buildbot/waterfall/builders/Linux%20Tests%20(dbg)(2)/builds/3796/steps/ui_tests/logs/CloseTab BUG:14774 Review URL: http://codereview.chromium.org/346005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30358 0039d316-1c4b-4281-b951-d872f2087c98
-
jorlow@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/339048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30357 0039d316-1c4b-4281-b951-d872f2087c98
-
finnur@chromium.org authored
The test is only failing on Mac, so lets just disabled it for Mac specifically so as to not lose test coverage on other platforms. TBR=aa BUG=26035 TEST=None Review URL: http://codereview.chromium.org/343019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30356 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
them. BUG=none TEST=none Review URL: http://codereview.chromium.org/343018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30355 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
Added parser for "ls" listing style, and tests. This is not yet used by the browser (will do that in a following CL). TEST=Covered by net_unittests. BUG=25520 Review URL: http://codereview.chromium.org/244008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30354 0039d316-1c4b-4281-b951-d872f2087c98
-
vangelis@google.com authored
Review URL: http://codereview.chromium.org/342009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30353 0039d316-1c4b-4281-b951-d872f2087c98
-
jorlow@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/337058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30351 0039d316-1c4b-4281-b951-d872f2087c98
-
ager@chromium.org authored
Will investigate tomorrow. TBR=sgjesse@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/343020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30350 0039d316-1c4b-4281-b951-d872f2087c98
-
erikkay@chromium.org authored
Also, fix some glitches in sizing the popups. BUG=25214 TEST=ExtensionApiTest.BrowserActionPopup Review URL: http://codereview.chromium.org/295051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30346 0039d316-1c4b-4281-b951-d872f2087c98
-
ager@chromium.org authored
This version contains a number of bug fixes and better heap profiling support. Review URL: http://codereview.chromium.org/339044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30343 0039d316-1c4b-4281-b951-d872f2087c98
-
mbelshe@google.com authored
as the FLIP client reads. Then, enable the use of the CONTROL_FLAG_FIN on a request which has no data. Added a new test for a POST. The test passes today, but I will make it stronger with my next pass at fully implementing POST. POST uploads are still not complete BUG=none TEST=none Review URL: http://codereview.chromium.org/338055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30342 0039d316-1c4b-4281-b951-d872f2087c98
-
skerner@chromium.org authored
BUG=21729 TEST= Manually tested that onUpdated sends all tab info. Updated unit tests. Review URL: http://codereview.chromium.org/289006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30341 0039d316-1c4b-4281-b951-d872f2087c98
-
nsylvain@chromium.org authored
bug:26035 Review URL: http://codereview.chromium.org/338064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30339 0039d316-1c4b-4281-b951-d872f2087c98
-
nsylvain@chromium.org authored
covers the issue. Review URL: http://codereview.chromium.org/343017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30338 0039d316-1c4b-4281-b951-d872f2087c98
-
thomasvl@chromium.org authored
TEST=flag on browser causes logging from renderers. BUG=none Review URL: http://codereview.chromium.org/342017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30337 0039d316-1c4b-4281-b951-d872f2087c98
-
nsylvain@chromium.org authored
often both on Linux and Windows. BUG:14774 Review URL: http://codereview.chromium.org/347003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30336 0039d316-1c4b-4281-b951-d872f2087c98
-
mark@chromium.org authored
CFRunLoopTimers are implemented in terms of kernel ticks, a time base which is suspended while the system is sleeping. In order to properly perform delayed work at the proper initially-scheduled time (or at system wake if the scheduled time passed while the system was asleep), the associated timer needs to be reset to the most recently scheduled next-fire time on wake from sleep. BUG=22508 TEST= - Make Chrome the active application. - Close all Chrome windows. - Close the laptop lid. - Wait for it to begin sleeping, indicated by the pulsing light. NOTE: wait until the light actually begins pulsing, not just until it turns on. The disk and fans should all be stopped. - Reopen the laptop. If needed, authenticate to the screen saver. - Click the Chrome icon in the dock. A new window should open on the New Tab page. - Quickly type "google.com/" into the omnibox. - The page should load, its favicon should be visible, and the tab title should read "Google". This should happen as instantly as a normal page load. The tab title should not "stick" on "New Tab" and the icon load should not be delayed for any amount of time. Review URL: http://codereview.chromium.org/342011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30335 0039d316-1c4b-4281-b951-d872f2087c98
-
mad@chromium.org authored
To resolve the problem of '..' parent references as well as symbolic links on POSIX platforms, we can simply use the file_util::AbsolutePath() function. This has the drawback of having a different behavior on Windows and POSIX platforms, in the way that it can return a canonical path that doesn't exists when ran on Windows, but it will return an empty path (or false) when run on a POSIX platform. So we need to add an extra PathExists() call to unify the behavior. BUG=25681,25131 Review URL: http://codereview.chromium.org/343003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30334 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
the Chrome frame network tests for whether the current thread is the UI thread. We need to invoke the correct constructor. The other fix is in our com_util::IDispatchImpl class where we end up crashing if we fail to find the type information for the passed in interface. Strangely this is failing for the IChromeFrame interface which is an IDispatch derivative and seems to be correctly registered. It also fails with the ATL IDispatchImpl classes though. However we should not crash here :) I also removed the NOTREACHED as it keeps firing on debug test runs. Will take a look at this closely later. TBR=tommi Review URL: http://codereview.chromium.org/343013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30333 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
Review URL: http://codereview.chromium.org/344009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30332 0039d316-1c4b-4281-b951-d872f2087c98
-