GitLab

This reverts commit 44d3aa82.

Reason for revert: suspect of running into sync protocol violations and the corresponding DCHECK failures.

Original change's description:
> Unify clearing of sync prefs
> 
> SyncPrefs is a thin layer on top of preferences and hosts two groups
> of preferences:
> 1) Actual user-facing settings, such as type-selection, exposed via
>    SyncUserSettings.
> 2) Local "bookkeeping" sync metadata, such the last synced time or the
>    client ID (cache GUID).
> 
> In addition, there are two cases that fall somewhere in the middle,
> whose behavior is changed in this patch:
> a) FirstSetupComplete: which roughly represents the user having
>    consented to sync-the-feature (as opposed to transport-only upon
>    sign-in without explicit user consent).
> b) The encryption-bootstrap-token: which represent an explicit
>    passphrase (usually custom passphrase) entered by the user, that
>    allows decrypting the incoming sync changes and encrypt outgoing
>    ones.
> 
> The last two preferences above fit group 1 better, so this patch stops
> clearing them in SyncPrefs::ClearPreferences(), now renamed to
> SyncPrefs::ClearLocalSyncTransportData().
> 
> With such cleanup, what used to be
> ClearDirectoryConsistencyPreferences() is now merged into a single
> clearing function, ClearLocalSyncTransportData(), and all calling sites
> are unified by directly clearing prefs in ShutdownImpl(DISABLE_SYNC), as
> opposed to individual calling sites.
> 
> This introduces -arguably desirable- behavioral changes because
> codepaths like RESET_LOCAL_SYNC_DATA or STOP_SYNC_FOR_DISABLED_ACCOUNT
> now actually clear all local metadata, which most notably includes
> keystore keys.
> 
> Change-Id: I2c42f98c4e068c7e340580d0b78a5cd5b5c46171
> Bug: 1046237
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023649
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#735841}

TBR=treib@chromium.org,mastiz@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1046237, 1048771
Change-Id: I4ce9e941f12aa58b7b6b286e990e74a1e01dad69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043451
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739374}

The goal is to split up modules_idl_files.gni into smaller .gni files
that are owned by OWNERS of the corresponding module, so top-level
module OWNERS don't need to review every CL that adds a new IDL file.

This patch splits out the build files for IDLs that define
dictionaries.

Bug: 1048907
Change-Id: I1ec3d198ca89a02f69e088d7d739145da820f21e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043770
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739373}

This reverts commit 10646707.

Reason for revert: This is a speculative fix. Two Arc changelists
went into this build...
https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/34691
... and I've already tried reverting the other one, but it didn't
fix the issue. 

If ArcAppDeferredLauncher* tests continue to fail with this revert
then this can be unreverted and the Arc tests need to be disabled.

Original change's description:
> arcvm: Get the board name from the generated prop file instead
> 
> On some boards like nami, CrOS rootfs' build.prop doesn't have the
> complete ro.product.board entry. It's sometimes a template. To always
> get the board name on all boards, ArcDefaultAppList needs to wait
> for ArcSessionManager to generate the board's own build.prop file
> in its stateful partition. This is the same as what arc-setup does
> today.
> 
> This CL also stops special casing ARCVM and does the same for
> ARC too. Also, when calling GetBoardName(), this CL uses
> MayBlock() to make it debug build compatible.
> 
> BUG=b:144199481
> TEST=try, ARCVM still starts
> 
> Change-Id: Ie878d9ffff98ecf3b9dccb837fd6dce1a382a4be
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026668
> Commit-Queue: Yusuke Sato <yusukes@chromium.org>
> Reviewed-by: Yury Khmel <khmel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#739250}

TBR=yusukes@chromium.org,khmel@google.com,khmel@chromium.org

Change-Id: I5a75922a9b101aafb1bb03de86826003a41ce599
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:144199481
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044152Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739372}

This reverts commit caf8eebf.

Reason for revert: suspect of running into sync protocol violations and
the corresponding DCHECK failures.

This CL reverts a preference being introduced without the corresponding
cleanup logic; but we intend to reland this patch anyway.

Original change's description:
> Verify consistency between sync and sign-in account IDs
>
> Local sync metadata belongs to one user account. Due to the distributed
> nature of the locally persisted sync metadata, the cache GUID is used
> as "epoch" to detect mismatched in edge cases like the browser crashing
> during shutdown and before I/O gets flushed.
>
> However, prior to this patch, the cache GUID itself has no safety
> mechanism to detect it maps to the intended account ID. In this patch,
> a new SyncPref is introduced to achieve that, in away that both prefs
> (cache GUID and account ID) are stored atomically.
>
> Because the pref is newly-introduced, migration logic is introduced to
> populate it for the first time if initially empty.
>
> Change-Id: I2cdd9f997077c4acd16e9283df8c025f51d40546
> Bug: 1046237,1021527
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023528
> Reviewed-by: Marc Treib <treib@chromium.org>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#736848}

TBR=msarda@chromium.org,treib@chromium.org,mastiz@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1046237, 1021527, 1048771
Change-Id: Ic9dcaf53780350984c3036f6acdb549f631893f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041669
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739371}

Bug: 1049185
Change-Id: I423a56ae785d00d77f01b243d7fd91670ab4681c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041607
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739370}

This reverts commit 6ed337de.

Reason for revert: The new unit test fails on linux-chromeos-rel.
See build where it was introduced: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/34701

Original change's description:
> Add EDU login flow: EduAccountLoginHandler
> 
> Add EDU account login handler to fetch user's family members and
> getting ReAuthProof token for parent.
> 
> Bug: 1043108
> Change-Id: Icf4b2782a4e6f114f452468baf09d2478db8d58c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033156
> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#739305}

TBR=khorimoto@chromium.org,dpapad@chromium.org,sinhak@chromium.org,anastasiian@chromium.org

Change-Id: I469bd5e3ed648880df75e49093610a8031cc313e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1043108
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043838Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739369}

This CL automate the packing of the enterprise platform keys test
extension such that running
google-chrome-stable --pack-extension=<test_extension_path>
--pack-extension-key=<test_extension_private_key_path>
to update the crx file after changing tests is not needed as the
crx file will automatically be created before the tests run in
the SetUp() function.

reflected while running the tests without manually regenerating the crx
file.

Bug: chromium:716027
Test: Manual. Made some changes in the tests and made sure they are
Change-Id: I3309b54d717d112ab41ee8cac6db78aa4a11cf78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035898
Commit-Queue: Omar Morsi <omorsi@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739368}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome

BUG=762641
TBR=chrome-os-gardeners@google.com

Change-Id: Ib4ce040e0cde7e321f6a4e51b0da881fe33cc703
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043930Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#739367}

RequestAccessToken() has several calling sides and in the old
implementation any call would bypass the exponential backoff.

The fix is to just exit early if access token request is backed off.

This CL also adds test for repeating access token request on failure,
which ensures that access token requested again after backoff time and
UpdateSubscribedTopics() call doesn't lead to backoff bypassing.

Bug: 1020117
Change-Id: I6cd8db430ce32ae54eca60ad2fad321ffb5119a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043835Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#739366}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c43516c5f8a8..537ed8164e47

git log c43516c5f8a8..537ed8164e47 --date=short --first-parent --format='%ad %ae %s'
2020-02-07 tvanderlippe@chromium.org Add click options to click helper
2020-02-07 tvanderlippe@chromium.org Add $$ helper
2020-02-07 aerotwist@chromium.org Updates 403 message in Hosted Mode server

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@537ed8164e47

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1044632
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I0cfe7b1f1957ec56e57340dd483296277b89a817
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043911Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#739365}

This reverts commit 4c8e6831.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 739264 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzRjOGU2ODMxM2M4Y2RhYzc2ZDQwYWM1YjU0MGFiOGQ4YTVkNzBlNDEM

Sample Failed Build: https://ci.chromium.org/b/8889134545144502000

Sample Failed Step: interactive_ui_tests

Original change's description:
> [CrOS Settings] Add OS-specific "path visited" metric
> 
> Before this CL, navigating to a settings subpage on browser and OS
> settings emitted to the same histogram. This caused issues, since some
> separate subpages have the same name in each settings surface. For
> example, the "/printing" subpage means a completely different thing in
> OS vs. browser settings.
> 
> Bug: 1049417, 1026353
> Change-Id: Ifbe15866c61377a8da0413694b8578228401a6fd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040951
> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#739264}


Change-Id: I1339475cc39696627dc2f14c796fb93f7d798620
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1049417, 1026353
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043915
Cr-Commit-Position: refs/heads/master@{#739364}

This refactors the `CallClientFunction` helper method into a new helper
method `CallClientMethod`, which takes separate object and method name,
and the arguments (as base::Values), with the intention of sending that
information to the renderer in a second step, instead of generating a
string with all the above embedded in it, which is then send to V8 as a
new script.

The motivation is that sending every single protocol message as a new
script causes a lot of churn on the renderer, not only regarding the
runtime performance, but also trashing the memory and resulting in
fragmentation that can be avoided.

Drive-by-refactoring: Reduce friction around the variable number of
parameters passed to `CallClientMethod` and avoid the need to pass
base::Value as pointers. This improves code readability a bit.

Bug: chromium:1029427
Change-Id: I5ac578e2071d7ba63b9b42dff7e3b137a9908043
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042713
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739363}

We need to tell the observers of ArcInputMethod bounds when the input
method surface is being removed.
Without doing that, the observers can't know whether the input method
surface is still there or not.

      device to clamshell mode.

Bug: 1042549
Test: manual - show Chrome OS VK on an ARC++ app and flipping back the
Change-Id: Ib3e8fed3aa24a856c016ebcf7d3f6af2b2e2e1d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043186
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Auto-Submit: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739362}

https://android.googlesource.com/platform/external/perfetto.git/+log/ea7d67030546..bcd98820a91c

git log ea7d67030546..bcd98820a91c --date=short --first-parent --format='%ad %ae %s'
2020-02-07 hjd@google.com Merge "ui: Grey out counter tracks when thread/proccess dies"
2020-02-07 treehugger-gerrit@google.com Merge "Parse field names with type."
2020-02-07 treehugger-gerrit@google.com Merge "Strip arrays in DeobfuscateDatabase"
2020-02-07 lalitm@google.com Merge "trace_processor: enable json1 in SQLite"

Created with:
  gclient setdep -r src/third_party/perfetto@bcd98820a91c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Id132f14cc2ac32db9ca0dc2aabed631e9ca158af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043910Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#739361}

https://webrtc.googlesource.com/src.git/+log/ecd6fc84cf07..285f83d47bfd

git log ecd6fc84cf07..285f83d47bfd --date=short --first-parent --format='%ad %ae %s'
2020-02-07 jonaso@webrtc.org Add support for injecting VideoBitrateAllocatorFactory also on IOS
2020-02-07 sprang@webrtc.org Reland "Remove PlayoutDelayOracle and make RtpSenderVideo guarantee delivery"

Created with:
  gclient setdep -r src/third_party/webrtc@285f83d47bfd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ib74087c0da7c535437b5c1675a6535bccb231242
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043402Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#739360}

This CL starts treating |request_initiator| that doesn't match
|request_initiator_site_lock| as a bad IPC message and ignoring such
malformed resource requests.

NetworkService.URLLoader.RequestInitiatorOriginLockCompatibility UMA is
non-zero in recent Canary releases.  Therefore it is possible
that this CL will get reverted after gathering sufficient number of
DumpWithoutCrashing reports to understand why the lock doesn't match the
initiator in some real world scenarios.

Bug: 920634
Change-Id: If4fbdb6336703f53784c036ca5d9e408ff223d78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006113
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739359}

https://chromium.googlesource.com/angle/angle.git/+log/55de83afeec7..51fd2958f9a2

git log 55de83afeec7..51fd2958f9a2 --date=short --first-parent --format='%ad %ae %s'
2020-02-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 1f03ac10270a..fe10239f92f4 (1 commits)

Created with:
  gclient setdep -r src/third_party/angle@51fd2958f9a2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: cnorthrop@google.com
Change-Id: I4ea5583552a0eb17a23b1cb100db2638999dadf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043400Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#739358}

This reverts commit ec6127ba.

Reason for revert: Caused flaky test failure on WebKit Linux Leak.

Original change's description:
> Convert WebTestHostMsg_InitiateCaptureDump to Mojo
> 
> This CL migrates the legacy InitiateCaptureDump IPC message
> to the new Mojo defined in WebTestClient interface.
> 
> Bug: 1039247
> Change-Id: Idd38ecf67d10593f3bfc6f3c48d9832514cec595
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032634
> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Reviewed-by: Mike West <mkwst@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#739222}

TBR=dtapuska@chromium.org,mkwst@chromium.org,gyuyoung@igalia.com

Change-Id: Ie0bc76b7d3c8dd67481d67d0ee22b0338d87334f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1039247
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043531Reviewed-by: Gyuyoung Kim <gyuyoung@igalia.com>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#739357}

When we manually install an extension and then add it to force
installed list, it should get updated. If the extension gets corrupted
before the Manifest::Location of the extension is updated, the
extension does not get reinstalled. This was because after updating
the location, the function OnExternalExtensionUpdateUrlFound
return false in each case. It should add the corrupted extension to
pending extensions list instead.

Bug: 1045371
Change-Id: I9af45488b64d6a7ecde89921023bd35941e1ed0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023525Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Swapnil Gupta <swapnilgupta@google.com>
Cr-Commit-Position: refs/heads/master@{#739356}

CRWWebViewScrollViewProxy passes itself to its delegate,
CRWWebViewScrollViewDelegateProxy, and both were keeping strong
pointers to each other.

Change-Id: Icb13eddcbb4cce14a2691c8b25fe5708cde6f699
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041628Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739355}

Now with <script> elements in the HTML namespace. Because reasons.

Change-Id: Ia3eba0f7856f265ed6fa601272a2d7c577b07c1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043450
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739354}

https://chromium.googlesource.com/catapult.git/+log/8052d2973b2a..ea794b87a8c5

git log 8052d2973b2a..ea794b87a8c5 --date=short --first-parent --format='%ad %ae %s'
2020-02-07 phoglund@google.com Teaching histograms to deserialize from protos.

Created with:
  gclient setdep -r src/third_party/catapult@ea794b87a8c5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC nuskos@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1029452
Tbr: nuskos@google.com
Change-Id: Ia0257890aee53e8947bf076c5207d0f0c64ac571
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043397Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#739353}

* Added userActed function to the LoginScreenBehavior
* Migrated existing usages of 'userActed' actions
* Refactored screens with LoginScreenBehavior to use new mechanism

Bug: 1049083
Change-Id: Ie5a8b7cb750008d34c651233a14b696e601d97b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041610Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739352}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/8a7efb5da88a..3fc2c56b0cd5

git log 8a7efb5da88a..3fc2c56b0cd5 --date=short --first-parent --format='%ad %ae %s'
2020-02-06 rharrison@google.com Reduce amount of duplicated code in API implementations (#984)

Created with:
  gclient setdep -r src/third_party/shaderc/src@3fc2c56b0cd5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: radial-bots+chrome-roll@google.com
Change-Id: I2fc334ffae2d48f2bb75564fe87baa82dedf8d0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043401Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#739351}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a7b3e6babed7..716a808922fb


Created with:
  gclient setdep -r src-internal@716a808922fb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Ic7554d408575ac6ff6dd386d700b64880770f6b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043394Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#739350}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6737082f1029..c43516c5f8a8

git log 6737082f1029..c43516c5f8a8 --date=short --first-parent --format='%ad %ae %s'
2020-02-07 leese@chromium.org e2e test for wasm raw debugging

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@c43516c5f8a8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1045573
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ie178d5faa2576c47738c155d7414320ee3e17c89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043392Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#739349}

https://android.googlesource.com/platform/external/perfetto.git/+log/492af9a453f4..ea7d67030546

git log 492af9a453f4..ea7d67030546 --date=short --first-parent --format='%ad %ae %s'
2020-02-07 fmayer@google.com Merge "Use "should" that could be confusing."

Created with:
  gclient setdep -r src/third_party/perfetto@ea7d67030546

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I650cfec1be83b0894939e1749325207c05766875
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043395Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#739348}

Relying on GetWindowAndroid() returning a non-null value causes crashes
in various instances. With this CL, the window is null-checked before
use an creation is deferred to when it's actually used.
If creation doesn't succeed on first try (e.g. because the window isn't
yet attached), a consecutive call might succeed.

This approach also has the advantage that the interface remains clean
and doesn't require handling the rare Android failure explicitly. This
is acceptable since failing to create the surface means, that the UI
isn't ready to show any information anyway or anymore.

Bug: 1049090
Change-Id: Iebc556e33226151cbc4fb8060653290ae0e22dc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037573
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739347}

This adds support for hit-testing by traversing the fragment tree,
rather than traversing the LayoutObject tree.

All behind the LayoutNGFragmentTraversal runtime flag.

Testing: virtual/layout_ng_fragment_traversal/ contain some hit-testing
tests, and will now run with the new code. (Adding fast/events/ to the
virtual testuite would increase coverage by a lot, but the tests there
are so flaky I decided against it.)

Bug: 1043787
Change-Id: Id1e1d524afa071c80098274b2c61a3339c8032e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041597
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739346}

Thread pool is required for correct work of V8.
A new added method is called during initialization.

Check whether pac_resolver is created when proxy request comes.

Bug: 1045049
Change-Id: I5cb2bd6abfb1872b1d73f4f3e7a1daf0a6491682
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038736
Commit-Queue: Richard Coles <torne@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739345}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/730ee40e..ab71334c

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I38a990fc1cd04af8a2bd672665032307f5005453
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043490Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#739344}

options_width_ is updated at the beginning of
ComputeIntrinsicLogicalWidths(), and referred only in it. It doesn't
need to be a data member of LayoutMenuList.

This CL renames UpdateOptionsWidth() to MeasureOptionsWidth(), and it
returns the measured value, and removes LayoutMenuList::options_width_.

This CL has no behavior changes.

Bug: 1040828
Change-Id: Ic33faffa74ede63444e150914541ed4985f70243
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043340Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739343}

ScriptLoader doesn't keep the ScriptResource instances for async scripts
alive, which artificially decreases memory cache hit rates (see the
attached bug for details and analysis).

Add a feature to tie the lifetime of ScriptResource to the one of
ScriptLoader.

Bug: 1043679
Change-Id: I3dc46d778f2c601fbde0daf18aa47b4b1ed2cc56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033260Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739342}

This CL has two goals,
  1. Use To<MouseEvent> and DynamicTo<MouseEvent> as new
   downcast helper
  2. Use IsA<MouseEvent>(element) in place of
   IsMouseEvent(element)

Bug: 891908
Change-Id: I843cc27220eb903eefa01e04c857d19904b26b54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019146
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739341}

This CL moves NativeBackgroundTask to components. The chrome specific
code is moved to a NativeBackgroundTaskDelegate class which will be
injected from a factory.

Bug: 1045765
Change-Id: I53c0e9c73947f9f939e953096d98a2a2412ae4c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024165
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739340}

In js, "enum_value ? x : y;" will get y if enum_value is 0, but x is
what we actually want to get in such a case. The correct code should
be "enum_value != null ? x : y".

BUG=520391

Change-Id: Ibe3771d0dc0ece3cd6659aec298306f694a8f0e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037106
Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#739339}

When the XML parser is paused, we temporarily store pending callbacks to
call the XML parser hooks when the parser resumes. For error reporting
we used the line/column number for the current position of the parser
input which is not correct when handling errors for the invoked
callbacks. This CL adds these source positions to the callbacks to have
correct positions for error reporting.

The test below will fail without this CL when the
BlockHTMLParserOnStyleSheets flag is enabled.

TEST=svg/hixie/error/013.xml

Bug: 891767
Change-Id: Ie3e6c608253dfa355b9947433c79ef21d912cbc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041443Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739338}

This is a reland of f8a4ba13

Original change's description:
> Background task scheduler : Split code into public and internal
>
> This CL separates the public interfaces from the internal code of background
> task scheduler's Java code.
>
> 1 - The public classes/interfaces are left at top level components/background_task_scheduler
>     while the implementation code is moved to internal/
> 2 - Internal code is moved to a separate package as well.
> 3 - The factory will be a separate target that depends on public and internal.
> 4 - Some classes need to be referenced from both chrome/ and internal code,
>   e.g. BackgroundTaskSchedulerFactory, Uma classes, SharedPref. To handle this,
>   have two classes, e.g. BackgroundTaskSchedulerFactory and BackgroundTaskSchedulerFactoryInternal
>
> We should probably move the NativeBackgroundTask as well to components/ which
> will greatly help the dependent code to live in components/. Will think about it in a future CL.
>
> Bug: 1045765
> Change-Id: Idddb3ed33789a735e920f33b7c0f3cb40e5e844a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021857
> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#738560}

TBR=nyquist@chromium.org,dtrainor@chromium.org,shaktisahu@chromium.org

Bug: 1045765
Change-Id: I89e333ec32071458fb76af298b935eb227daac92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040433Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739337}

Roll airmont AFDO profile from 81-4028.0-1580726817-benchmark-81.0.4044.11-r1 to 82-4028.0-1580728925-benchmark-81.0.4044.11-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I429cf7be647af704ba0ac0670f0eb642f458b5d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043399Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#739336}

This CL allows users to enable/disable performance logging in console
via expert mode.

Bug: b/141518806
Test: Run CCA and toggle the button in expert mode and see performance
logs in console.

Change-Id: I67cdc2db8151ea07282b0b5e9891d68cb51bee44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035478
Commit-Queue: Wei Lee <wtlee@chromium.org>
Commit-Queue: Shik Chen <shik@chromium.org>
Reviewed-by: Shik Chen <shik@chromium.org>
Auto-Submit: Wei Lee <wtlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739335}