- 17 Jun, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7d12eb78c7c0..20aa34ea8ddc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ioanap@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1082908 Tbr: ioanap@google.com Change-Id: I3888dd7b4ad297e49b11f4f11f426a1944e5acdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249703Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779308}
-
Cezary Kulakowski authored
With current implementation of notifications on mac clicking on notification created by any active chromium browser will be registered in all the browsers. Additionally clicking in notification's button Settings will open settings page in all browsers. This commit adds new field to the notification: creator's pid which is checked with the pid of current process when the information about notification being clicked is send to the browser process from the NSUserNotificationCenter. If there is no match we do not process the notification. It doesn't solve the problem with the focus (all browsers gets it and the last one which got it will have it) but at least click on the notification is only registered in the proper browser. It also fixes the problem with button Settings. Bug: 1086899 Change-Id: Ia484c03c076f841ba3695b029ebced3c1191e6ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218827 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#779307}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a46fce2194df..ae1892d4e4ce 2020-06-17 terelius@webrtc.org Add simulation of robust throughput estimator to the event log analyzer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I221acd963c4b1519e4e9197a4afc3ef21a9f4dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249706Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779306}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4c47d0ddea16..f5cd604cb9d0 2020-06-17 bsalomon@google.com GrMagnifierEffect uses child for src If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: I3e797c833ccd99b85ab50c5cce58882e46cb3aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249705Reviewed-by:
-
Alice Wang authored
This CL destroys the account picker bottomsheet by registering a BottomSheetObserver object in BottomSheetController. Bug: 1063362 Change-Id: Ibfcc6e27fc8c5438589d49f4e753b76321d5604c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241653 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#779304}
-
Ioana Pandele authored
TBR=rbpotter@chromium.org Bug: 1096016 Change-Id: I7d1fabccb14f55756e7e279938337fd44bf2e0a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248684Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#779303}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I547c30c97738aedf2e3974b8393d148da1c30ddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249719Reviewed-by:
-
Jesse Schettler authored
Now that the method signature of ListScanners() matches that of ListScannersProto(), switch back to using ListScanners(). This allows the temporary ListScannersProto() method to be deleted, which is the last step in changing the method signature of ListScanners(). Bug: b:157577191 Change-Id: I5bec9b6d7f5efb5dee0a50ea594f86148e4e87c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248347 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#779301}
-
Jan Krcal authored
This CL stops combining nigori commits with priority user type commits because nigori cannot get combined with encrypted commits and because we plan to break the guarantee that priority types are not encryptable. Impact of this change on traffic / latencies / etc. is negligible because nigori gets committed very rarely. Bug: 1084969 Change-Id: I2a7bb840a30def87813bb45394881e4a871f69b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247878 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#779300}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592373607-cbb56276e9eec8291c1dfc389a85c83bce237656.profdata to chrome-mac-master-1592394610-7518c1df9a0c2bd855627c235c38489e194d3191.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I119b0376d24373fee369b94627f10c7de6238050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249704Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I4504fd4faa5e25e65093a7b26dca12c022d587b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249718Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779298}
-
Henrik Boström authored
This CL plumbs base::PowerObserver::OnThermalStateChange with mojo from PeerConnectionTrackerHost in content/browser/ to PeerConnectionTracker in blink/renderer/modules/peerconnection/ which informs the RTCPeerConnectionHandler of the event. A mojom typemap for the enum is added to allow passing it and DEPS and audit_non_blink_usage.py is updated to allow the usage of base::PowerObserver::DeviceThermalState from blink. Tests verify that the signal reach the handler, but nothing is done with this signal yet. In a future CL, we will implement a webrtc::Resource to make use of it. Bug: chromium:1094844 Change-Id: I026e04238d89ced2d77672e015f58e7a497336f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246162 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#779297}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I19c04bf6b4fda716fea0af2a05fdb98756614821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249666Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#779296}
-
Benoit Lize authored
https://chromium-review.googlesource.com/c/chromium/src/+/2235695 didn't update the "PartitionAlloc everywhere" config. Fix it here. Bug: 998048 Change-Id: I57c5fe76d4aac50b47967bf9d246f224295e2e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249738Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d76df5326646..8dcbdb8aebf4 2020-06-17 tvanderlippe@chromium.org Remove `npm run start` script 2020-06-17 mathias@chromium.org Fix autofixable CSS lint issues 2020-06-17 yangguo@chromium.org Update and re-organize documentation 2020-06-17 tvanderlippe@chromium.org Default modes to vertical and horizontal orientation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1061037,chromium:1083142,chromium:1095614,chromium:1095988 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I744df89cc8df6b84532f32ced4ccc44179a4dee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249701Reviewed-by:
-
Olesia Marukhno authored
Bug: 1019129 Change-Id: Iaf69dce6cb29849c7dc8554493ecdbea029cde76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246501 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#779293}
-
Jérôme Lebel authored
The sign-in coordinator can be AdvancedSettingsSigninCoordinator, and this coordinator presents GoogleServicesSettingsCoordinator. This method has to stay, since it is needed by the Google services settings coordinator, and sub-coordinator. Bug: 971989 Change-Id: Ia3cc4a2da01c0ca430106e8e364e7a935c258997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247732Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#779292}
-
Denis Kuznetsov authored
Bug: 955194 Change-Id: I1e83b90791fd98c4502a92806b2425665f2fc44f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246565Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#779291}
-
Maciek Slusarczyk authored
We introduce a new policy SamlLockScreenReauthenticationEnabled that will enable online re-authentication of SAML users on the lock screen. With the policy set to true a user can be set through the online flow on the lock screen in order to verify and sync their password. If the policy is set to false or unset we will continue to use only local credentials on lock. Bug: 1090341 Change-Id: Ia24ac44f16abf7d140675a5cdfc0f9c349b85e4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233319 Commit-Queue: Maciek Slusarczyk <mslus@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#779290}
-
Alexander Hendrich authored
Splitting of the refactorings for the enterprise.deviceAttributes from https://crrev.com/c/2197117 into a separate CL. Bug: none Change-Id: I7c99e1e00ff9a1a79787ebbd8acff5dc35e496d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247762 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#779289}
-
Nikita Podguzov authored
There was null-dereference in case of empty policy value. Additional check is added now. Bug: 1092061 Change-Id: I1598709c817e3365f0f9fd596533ee7257145325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247890Reviewed-by:
-
Fredrik Söderqvist authored
These structures are trivially destructible (and constructible), so don't need to use DEFINE_STATIC_LOCAL here (replacing code space with data at a net reduction). Change-Id: I3b23a7daad9cf4e1fdc1db856b89f9ae3e01a021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247888Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#779287}
-
Alexander Hendrich authored
This CL adds permission warnings for these enterprise APIs: * enterprise.deviceAttributes * enterprise.networkingAttributes * enterprise.platformKeys Bug: 1080698 Change-Id: If8444762354f940fd4d592e6808da1bd6daf21c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203056 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
-
Caitlin Fischer authored
In the below comment, it was requested that the corresponding Android test be removed. https://chromium-review.googlesource.com/c/chromium/src/+/1869007/12/chrome/browser/metrics/ukm_browsertest.cc#b646 Bug: 1049736 Change-Id: Iac3ff27fc4d8145bef53d45aecb54efeda5e55f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245049 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#779285}
-
Oriol Brufau authored
This is a reland of a53560e3 The problem in the reverted original patch was that I forgot to clear marker_style_sheet_ in CSSDefaultStyleSheets::PrepareForLeakDetection. Then, when running tests with --enable-leak-detection, it could happen that EnsureDefaultStyleSheetsForPseudoElement would think that the UA rules for ::marker were already in default_pseudo_element_style_. But it would actually be empty, so the ::marker could get no rule, making HasMatchedProperties() be false, so PseudoStyleForElementInternal would return false, and PseudoStyleForElement would return a nullptr style. So there would be no ::marker. Original change's description: > [css-pseudo] Set default ::marker styles in a real UA sheet > > Before this patch, default styles for ::marker were assigned manually > when resolving the style. The problem was that, since the rules didn't > actually exist in any stylesheet, they were not exposed in devtools. > Also, devtools assume that if a pseudo-element exists, it must have some > rule. This could not hold for ::marker, and then trying to add styles > to it would fail. > > This patch fixes that by making the styles actual UA rules. However, > adding a '::marker' selector directly to the UA sheet for elements would > be bad: it would match every single element (even non-list-items) due to > the universal selector, and then it would set an internal bit for the > marker. So HasAnyPseudoElementStyles() would return true, which means > extra work when handling style changes. > > Therefore, this patch adds a new UA sheet just for pseudo-elements. This > sheet is not used for elements, ensuring that HasAnyPseudoElementStyles > is still false if there are no author styles for a pseudo-element. > > The selector parser was treating ::marker as invalid if the runtime flag > CSSMarkerPseudoElement was disabled. But now it's accepted in that case > for UA styles. > > There already was a kHasMarkerPseudoElement counter to track how widely > used is ::marker on the web. Now this counter will only be incremented > for author rules. > > Bug: 457718, 1082377 > > TEST=blink_unittests --gtest_filter=StyleResolverTest.CSSMarkerPseudoElement > TEST=blink_unittests --gtest_filter=UseCounterHelperTest.CSSMarkerPseudoElementUA > TEST=blink_unittests --gtest_filter=UseCounterHelperTest.CSSMarkerPseudoElementAuthor > TEST=http/tests/devtools/elements/styles-2/pseudo-elements.js > > Change-Id: Ib5583dc1952bfec2cce8f33fe8332cc39016c34a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239579 > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Commit-Queue: Oriol Brufau <obrufau@igalia.com> > Cr-Commit-Position: refs/heads/master@{#778303} TBR=mkwst@chromium.org Bug: 457718, 1082377 Change-Id: Ib6a2482ac474a424c3dfeb05fb2e2c00ce29b732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247790Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#779284}
-
Friedrich Horschig authored
This CL simplifies the string to avoid any misconceptions about the generated password and ensures consistency with the well-known button for sync users. Screenshot: https://photos.app.goo.gl/tBgMgFryH3zP9FhR9 Bug: None Change-Id: Ia7d9a5667319e86769f9ee764f9db441f373d11d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248625Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#779283}
-
Morten Stenshorne authored
We were setting the actual block-size of the multicol container correctly, but didn't include the block-end border and padding in the intrinsic block-size, which is stored in the layout result, and used by flex layout in some cases. Bug: 829028 Change-Id: Idae7ac501b35ed24f3d7fbace8378492dc8700d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247827Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#779282}
-
Roman Aleksandrov authored
Time is not guaranteed to always increase, this may cause mistakes in metrics recording. Bug: 1095058 Change-Id: I71e0333be9547c6b99e9e9c081754a5f8b20bb1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247891 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
New version of gn generates a single project file named all.xcodeproj, so fix the script to only look for that file. Also fix it to delete the old projects and workspace from output directory to avoid users opening the wrong project and being confused by the possibly incorrect list of files. Remove the code to wipe the code signing identity since this is now correctly set by gn in the project. Bug: none Change-Id: I4cc6bfd1a3d3be9ed3c8d1a07805b088068852d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248681 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#779280}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6476d0bf02d2..a46fce2194df 2020-06-17 kron@webrtc.org Update rtp_utils to support two-byte RTP header extensions 2020-06-17 nisse@webrtc.org Delete MediaTransportInterface and DatagramTransportInterface If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1ee1d9cce8c5ce2196646cee743551dcf06ad43e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249700Reviewed-by:
-
Yunke Zhou authored
Bug: 1095916 Change-Id: I87ff398744198ddfbe351c4f4b16e8e78bfe3404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240860Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#779278}
-
Luca Hunkeler authored
With this cl it's now possible to specify a list if ElementCondition in the ShowGenericUi action. This will start a WaitForDom that will regularly check the conditions and write the result into the model. Bug: b/156077960 Change-Id: I3fd8b21de50b8eb969a8b5a617ccbe8358b3da34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238827Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#779277}
-
Paul Lewis authored
As per https://web.dev/first-meaningful-paint/, FMP is a deprecated metric. This CL removes FMP from the test expectations ahead of its removal from the implementation. Bug: 1096008 Change-Id: I5eaad8dac97546632414c85105d6e3ce60c54e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247829Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#779276}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/340da1459b4d..9db618ccd9c6 2020-06-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 8cbee4107cf1 to 763957e6b4fc (8 revisions) 2020-06-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 52a5f074e9bb to a7112d544b2e (3 revisions) 2020-06-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 00965b9fa9a8 to 051c6fed884b (5 revisions) 2020-06-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 03d0006b6d5e to 04f0b691eb4c (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I8b20a923efd408c2c6cabbaae7218a6514d78a04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249636Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592318647-7dde799a5671d21565d3d7d630fb811f29f03533.profdata to chrome-win32-master-1592384236-ee91207a6b4e00f77c95555e5c7822ae3e4b8a11.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I267b60fd84821171e9954be0926bc6b815217e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249633Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592351803-4940076c03ac19da5d52d5b5b79c0e1485ea8a61.profdata to chrome-win64-master-1592384236-59c052c5d04aee966d200af8272c6f3b6edf1818.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I95c13e2c468b3ad0d7b8218066048ebd9fb1a386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249634Reviewed-by:
-
Nohemi Fernandez authored
- Removes the SigninInteractionCoordinator class and helpers and moves all relevant sign-in code directly in the SceneController. - Moves all testing code to the authentication/signin directory. This patch is part of a series of migrations to remove the old sign-in architecture as described in go/chrome-ios-signin-migration. Bug: 971989 Change-Id: I4d2b8ae90a1a7666fad0d60cab33f3fc001e3654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238046 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#779272}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I87f5aed54ba38b33ccfa47df2cfef73b0997daff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249585Reviewed-by:
-
Ioana Pandele authored
[Sheriff] Set expectations for flaky http/tests/inspector-protocol/target/target-expose-devtools-protocol.js TBR=hablich@chromium.org Bug: 1092975 Change-Id: I6bcf5986ad93a072cd7eeca4f4a89c6d41d113a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247796Reviewed-by:
-
Jose Dapena Paz authored
Bug: 819294 Change-Id: I0b02f301bfc7fc16ba22e29ba0740d9cd83d708d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246591 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#779269}
-
