- 10 Sep, 2019 40 commits
-
-
Brian Sheedy authored
Adds the option to run tests using Python3 instead of Python2 to allow for tests to be migrated over in preparation for the Python2 deprecation. This can be achieved by adding a "'use_python3': True" entry to the test's gn_isolate_map.pyl entry. Bug: 898348 Change-Id: I675ec068e18cec6bf59ea9d19802bd712f18e87e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769719Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#695232}
-
Erik Språng authored
Remove ios, add android webview. Bug: 1000023 Change-Id: Iace7f258104df5d46f51c20e3ceb19f43120e14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795908 Commit-Queue: Erik Språng <sprang@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Erik Språng <sprang@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#695231}
-
Toni Barzic authored
Allow more aggressive apps container UI scaling down when dealing with extremely restricted vertical space (e.g. full zoom and docked magnifier): * reduce the minimum scale value when scaling the tile size * if minimum scale is not enough (or barely enough), remove item icon top padding. * scale down fade out area * if screen size is < 600, reduce the search box size, and the margin between the search box and suggestion chips container BUG=1001989 Change-Id: I887ba805c99e5882f3f9bbc5a6f48064bff53819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793926 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#695230}
-
Andrew Xu authored
ShelfViewTest::ShouldHideTooltipTest and ShelfViewTest:: ShouldHideTooltipWithAppListWindowTest assumes that home button is still the child view of shelf view. It is incorrect now. This CL fixes these two tests. Bug: 1002576 Change-Id: I8350fa9fab8c21497f3ac24f9bf0a32bde1aaf30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795759Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#695229}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b2d5d40a3393..2ab2ac03d8ee git log b2d5d40a3393..2ab2ac03d8ee --date=short --no-merges --format='%ad %ae %s' 2019-09-10 brianosman@google.com GL: Don't leak shader objects when program linking fails Created with: gclient setdep -r src/third_party/skia@2ab2ac03d8ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: Ie716422697a87d63b73393c9140214b076ae419b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796106Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695228}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 70 histograms that show frequent access in the past 90 days. These are the 80% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-03-08. Change-Id: I0e3f3d4df5a91effbd04caa8427f403d2820afe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795804 Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#695227}
-
Andrew Xu authored
Scrollable shelf should place shelf icons in the center of display when there is sufficient space. That is also the UI behavior of the current shelf view. This CL achieves the UI consistency for scrollable shelf. Bug: 973481 Change-Id: Ifc50e6d62f5508dc84578519c4f6c6522fb845e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789677 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#695226}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chrome/browser/android/download. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=qinmin@chromium.org Bug: 891670 Change-Id: Ifeb9efb0ae6973e97ef9107881387ae2e20cd789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786684 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#695225}
-
Eugene But authored
This change is made because all subdirectories of ios/web/public represent features, while web_state subdirectory is class name. The move proposal was discussed here: https://docs.google.com/document/d/1C2YIU0rDbH5wz2VI6nk0COrktwY3DbF-e7QbMIAKEJc/edit TBR=blundel@chromium.org Bug: 942244 Change-Id: I5227e9a413401e5a599d0d5cbd4758d3eb00aa38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793356Reviewed-by:
Yi Su <mrsuyi@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#695224}
-
Nico Weber authored
The file list in a dSYM bundle never changes, so there isn't really an incremental build issue with dSYM bundles. On the other hand, the file list in a dSYM bundle never changes, so it's easy to just list the files in the dSYM instead of the directory -- it's behavior preserving and it allows removing a bunch of mac-specific (harmless) whitelist entries, so might as well do that. (Removing the whitelist entries for actual bundle contents is more important since that actually affects incremental builds, but it's also harder.) To make sure this does the right thing, I went to an arbitrary swarming shard or a recent run of browser_tests on a recent build on https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29 : $ tools/swarming_client/isolateserver.py download \ -I https://isolateserver.appspot.com --namespace default-gzip \ -s 0bec65143ae103f148e632bae84dcbc44e57caf7 --target foo That isolate happens to have at least one each of - mac_framework_bundle (Chromium Framework.dSYM): $ ls foo/out/Release/Chromium\ Framework.dSYM/Contents/ Info.plist Resources/ $ ls foo/out/Release/Chromium\ Framework.dSYM/Contents/Resources/DWARF/Chromium\ Framework foo/out/Release/Chromium Framework.dSYM/Contents/Resources/DWARF/Chromium Framework - mac_app_bundle (Chromium.dSYM): $ ls foo/out/Release/Chromium.dSYM/Contents/ Info.plist Resources/ $ ls foo/out/Release/Chromium.dSYM/Contents/Resources/DWARF/Chromium foo/out/Release/Chromium.dSYM/Contents/Resources/DWARF/Chromium - mac_plugin_bundle (ppapi_tests.so.dSYM): $ ls foo/out/Release/ppapi_tests.so.dSYM/Contents/ Info.plist Resources/ $ ls foo/out/Release/ppapi_tests.so.dSYM/Contents/Resources/DWARF/ppapi_tests.so foo/out/Release/ppapi_tests.so.dSYM/Contents/Resources/DWARF/ppapi_tests.so Bug: 1000667,1002291 Change-Id: I9433bb05824b4f4b002766c53eee141bd69b4697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795802Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#695223}
-
Brandon Goddard authored
This change scopes down a keydown listener in Profiler panels (Memory and Javascript Profiler tools) so that it only applies to the sidebar tree element that the handler manipulates (selecting which profile to view). Previously, any up/down arrow press that was not handled in the entire panel could result in the change in view. For example, with focus on the toolbar dropdown, pressing the down arrow would change the perspective as desired, but pressing up would move back to the start screen by changing the element selected (shown in the before gif below). Now the arrows navigate to the different snapshots/etc only when the sidebar has focus. Before: https://imgur.com/cWO43Tp After: https://imgur.com/03gReuM Bug: 963183 Change-Id: Ie2337449c064b8e3d690dc2cb0ef07be296c798e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775055Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#695222}
-
Peter Kasting authored
Bug: 1000055 Change-Id: I5da481b05ecf433f987d4f6db381fd20a7062d46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793351 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#695221}
-
Polina Bondarenko authored
Add ArcSmartCardManagerBridge that implements SmartCardManagerHost. ArcSmartCardManagerBridge starts the refresh operation to make smart card certificates available to ARC. Bug: b:119914122 Test: plugin smart card reader to the local device, make sure that the certificate is shown in a client certificate user dialog launched from the test Android app. Test: ./out/Default/unit_tests --gtest_filer=ArcSmartCardManagerBridgeTest.* Change-Id: I175b8863e5f590a2e3d85d9ea6917908b336349b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724072 Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Edman Anjos <edman@chromium.org> Cr-Commit-Position: refs/heads/master@{#695220}
-
Marc Treib authored
Before this CL, UserEventEqualityChecker would modify its |expected_specifics_| in IsExitConditionSatisfied(), which usually gets called multiple times. In the specific situations where it did this, it was actually safe, but this was quite non-obvious. The new version just makes a copy and modifies that. It's slightly more verbose, but much less confusing. Bug: none Change-Id: I44b0220197625b168ff7394ec83ad7682e7b2d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795824 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#695219}
-
Jit Yao Yap authored
Change-Id: Ib0710ad86a9266d5b60a4cceca6abff00b0c20d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795248Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#695218}
-
Sigurdur Asgeirsson authored
This allows users of the public performance manager API, outside the performance_manager directory to use the test fixtures and access the graph implementation for testing only. Bug: 910288 Change-Id: I529f3b54d190f2cae1e3a23bd5d5758f5e973b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790402Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#695217}
-
Peter Kasting authored
Bug: 23697 Change-Id: Id372671eda6800a995fb31ff30213a8276e7b4d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792006Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#695216}
-
Aaron Krajeski authored
For deferred offscreen canvases, it's possible that there are un-drawn, recorded commands at these points. Bug: 1002523 Change-Id: I0b47319ff38aaa4030e9b74f897abd54eeeb4bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779107 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#695215}
-
Corentin Wallez authored
Also implements GPUTextureViewDescriptor.aspect and GPUBindGroupLayoutBinding.textureDimension that were added to Dawn in this roll. https://dawn.googlesource.com/dawn.git/+log/a900ccebcf42..f60522f5a467 $ git log a900ccebc..f60522f5a --date=short --no-merges --format='%ad %ae %s' 2019-09-10 digit [fuchsia] Fix Chromium build. 2019-09-10 digit [fuchsia] Implement external semaphore and memory support. 2019-09-10 cwallez Implement BGLBinding::textureDimension 2019-09-10 cwallez Add TextureViewDescriptor.aspect. 2019-09-10 cwallez Implement debug markers and groups for CommandEncoder 2019-09-09 enga Metal: Support setting bind groups before pipeline to match WebGPU semantics 2019-09-09 enga D3D12: Add IndexBufferTracker 2019-09-09 enga D3D12: Factor SetVertexBuffer tracking to match other tracking classes 2019-09-09 digit [fuchsia] Add headers containing extra vulkan definitions. 2019-09-09 digit Enable Vulkan for Chromium Fuchsia build. 2019-09-09 enga dawn_wire: Fix leak in Server::DoDevicePopErrorScope 2019-09-07 hao.x.li Align the size of Uniform and Storage buffer to 16 bytes in Metal 2019-09-05 bryan.bernhart Resource Management 6: VK support for resource allocation. Created with: roll-dep src/third_party/dawn Change-Id: I631197c99bb2847175731627a1d808fa5b85a840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795762Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#695214}
-
Sam Maier authored
Bug: 992461 Change-Id: I89026c422872e499f8038814a2a98c68e9fa422d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796103 Commit-Queue: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#695213}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c650bce8. With Chromium commits locally applied on WPT: d8d7248d "Move forced colors tests to wpt" 999a3129 "[LayoutNG] Fix line breaking behavior after out-of-flow objects" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools mcasas@chromium.org: external/wpt/geolocation-API mstensho@chromium.org: external/wpt/css/css-multicol timvolodine@chromium.org, reillyg@chromium.org: external/wpt/orientation-event NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ic9dcdc7fe26ebe599ebe30ae1472d2377bb1c54c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795663Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695212}
-
Mandy Chen authored
As per the plan [1] to localize the Audits Panel, this CL adds locale files in the lighthouse repo [2] to audits_worker/lighthouse/locales/. The files are copied to the output folder that's uploaded to the remote server (out/Release/resources/inspector/audits_worker/lighthouse/locales) and they are not bundled into audits_worker_module.js. They are also not bundled with the default (non-remote) devtools (out/Release/gen/devtools). Screenshots: https://imgur.com/a/hZiufh4 [1]: https://docs.google.com/document/d/1jnt3BqKB-4q3AE94UWFA0Gqspx8Sd_jivlB7gQMlmfk/edit?pli=1 [2]: https://github.com/GoogleChrome/lighthouse/tree/master/lighthouse-core/lib/i18n/locales Bug: 941561 Change-Id: I6c6572ceef6f94ebd5ff46cc17a83c21f8708221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784959Reviewed-by:
Erik Luo <luoe@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#695211}
-
Tatiana Buldina authored
Bug: chromedriver:2198 Change-Id: I8e13ec3b88dd7018cb4650fc0ce52d4feb4aed07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793944Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#695210}
-
Roger Tawa authored
The production version of DeviceManagementService::CreateJob() is now always async, so tests should not assume that it works synchronosuly. This CL removes the mock functions that allowed tests to be written in a sync manner and updates the tests to work async. Change-Id: I6b52fb56ef60b2e0e642f9f85d0a1afb2a6662d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642228 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#695209}
-
Aga Wronska authored
Test: ParentAccessViewTest Bug: 999384, 999391 Change-Id: I22f5a4bf109401822bc4492efd55f0e4d77630d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793636Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#695208}
-
Yun Liu authored
FlushingReTrace caused ClassNotFoundException error on bots: e.g. https://chromium-swarm.appspot.com/task?id=472348a61c76df10 Bug: 985581, 968605 Change-Id: I1d1415f68a8426b81a7c549d0419d32d8a2bd7dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790070Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#695207}
-
Nicolas Ouellet-Payeur authored
Bug: 950039 Change-Id: I96c208a9e3f9d75cd56ff04a7c7d97427635cc1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790147 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#695206}
-
Lan Wei authored
These tests are flaky when we send the events asynchronously, now we change to send the last action in one tick synchronously by default. Now the test should not be flaky any more. Bug: 999814, 1000530 Change-Id: I3fbc438b74c1912983c6767e77fc94c386aea256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795745Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#695205}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/45b01c7962da..507f43465b33 git log 45b01c7962da..507f43465b33 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 jakobi@webrtc.org Reland "Make relative arrival delay mode default in NetEq delay manager." 2019-09-10 henrika@webrtc.org Add support for 192kHz input audio sample rate. Created with: gclient setdep -r src/third_party/webrtc@507f43465b33 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I1fbb8bcacdf0c2c8a9e13c693396795bed547106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796122Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695204}
-
Jérôme Lebel authored
Adding -[SigninEarlGreyUI signOutWithManagedAccount:] and removing some calls for TapButtonWithLabelId(). Bug: 684817 Change-Id: Ie99d6c64eb5566e9f423f19e0b856b32c6d8d525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795584Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#695203}
-
Darin Fisher authored
Change-Id: I307a15e13b577db6ab3b728f09fbce65e3e528d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793408 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#695202}
-
Himanshu Jaju authored
Adds illustration to educate user on how to use devices with shared clipboard. Button to open chrome settings page to turn on sync would be a follow up CL. Dark mode - https://drive.google.com/open?id=1bgNYKQIAppVpqDfknpntFderdEzcLkYL Light mode - https://drive.google.com/open?id=106EBilI5KGzpdpPzLgrQUccmgwpFAT5s Bug: 1001102 Change-Id: I48815dc1822657125ca7538b6ab69c3fa8b38886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790202Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#695201}
-
Matt Menke authored
This CL makes HttpServerProperties methods that deal with broken alt services take NetworkIsolationKeys, and wires through through to the BrokenAlternativeServices object it owns. This CL also updates HttpServerPropertiesManager to save/load the NetworkIsolationKey associated with each broken alt service. Bug: 969890 Change-Id: I81909c8a3965d510fe775e7ccadebd4d88e5a7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775260 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#695200}
-
Saman Sami authored
vulkan_content_browsertests does not need an exception to not run on Linux FYI GPU TSAN Release. It's already excluded. Bug: 940723 Change-Id: I58ff26b57f5d5fa60ca54627b320149fe4de3d89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795983Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#695199}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a47836e01af9..b2d5d40a3393 git log a47836e01af9..b2d5d40a3393 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 bsalomon@google.com Adapt GrRectBlur for cases with rect W/H less than six sigma. 2019-09-10 jvanverth@google.com Hook up pinch-zoom and swipe gestures. 2019-09-10 bsalomon@google.com Remove per-format glCheckframebufferStatus checks. Created with: gclient setdep -r src/third_party/skia@b2d5d40a3393 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I7a6344c8dc37b12e5fc9b962cacba850c9ddbb48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796105Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695198}
-
Shivani Sharma authored
top-frame-origin was added to RedirectInfo for splitting the http cache using the top-frame-origin and that had to be updated when navigation requests were redirected. Now split cache uses network isolation key (computed in the browser process) and it is updated on redirect in the URLLoader->FollowRedirect. After these changes the top-frame-origin in RedirectInfo is no longer needed. Navigation resources with split cache are already being tested in existing browser tests and this removal does not break any of those tests. Bug: 978968 Change-Id: I58a69b4799fe3ba567cfe09989890e9af86924be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732794Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#695197}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /content/browser/devtools. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=caseq@chromium.org Bug: 891670 Change-Id: I42f549fef6bf7c3e1da3c6b08fdd64353f741a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786901 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#695196}
-
John Chen authored
Perf test system_health.common_mobile/background:news:nytimes is failing on all Android devices. Disabling it. TBR=crouleau@chromium.org NOTRY=true Bug: 1002546 Change-Id: If54c8c34edace7711c12fbe809044158ea6708b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795753Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#695195}
-
Koji Ishii authored
This patch fixes `vertical-align: top` and `bottom` when they are applied to a box that has children with `text-top` or `text-bottom`. In LayoutNG, `vertical-align` is handled in 3 different timings. 1. `top` and `bottom` are added to the pending list of the line box, or to the nearest ancestor box that has `top` or `bottom`. 2. `text-bop` and `text-bottom` are added to the pending list of the parent box. 3. Other values are computed when the box is closed. When a box has both 1 and 2, this patch changes to compute 1 (`top` and `bottom`) after 2. Before this patch, both 1 and 2 are computed at the same time for each box. 3 test cases out of 20 in this test fails without this patch. Bug: 1001664 Change-Id: I0e7746447f5e401837c2c28e308171f0987eba35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792396Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#695194}
-
Abigail Klein authored
This flag will be used for improvements to the chrome:accessibility page. The page queries for the accessibility tree, which is sensitive code that powers accessibility. Making changes to that code needs to be done carefully and will require its own QA pass, which is what motivates adding this flag. Bug: 785493 Change-Id: I37d57761447ca1ab17a91e410b09547bf7ac4a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790067Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#695193}
-