- 17 Sep, 2020 40 commits
-
-
Ioana Pandele authored
Make sure that tests which were not meant for Safety Check explicitly disable the feature. Bug: 1070620, 1092444 Change-Id: I83ba782b73cff33f6b4b6f5afa0df9d9e4db2fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410866 Auto-Submit: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#807803}
-
Ken Rockot authored
Sources for this target are moved back into //content/common. No behavioral changes. Bug: 977637 Change-Id: I1aed5fb1010b11224cf509e0f3cf3de549bb6193 Tbr: avi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411468 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#807802}
-
Austin Sullivan authored
Makes behavior consistent with MemoryFSW and SandboxFSW Bug: 998913 Change-Id: I543b8136e558a57b7d9b732cb4d4845153efa4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412247 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#807801}
-
Rachel Carpenter authored
Release notes has been launched (enabled by default) for many milestones. Clean up the feature to reduce the complexity of the code. I also removed the function getEnabledReleaseNotes() from the settings about page, as that was only returning the value of this feature, and changing that to `return true` seemed a bit wrong. Change-Id: I85303b3dfe2b286c261d62725cfcfbe034a7757b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409882 Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#807800}
-
My Nguyen authored
When users change device language, if the device language isn't present in Languages for apps and websites section (enabled language list), it should be added and moved to the top. If it's already present, we don't do anything as users might want to keep their original preference if the language is already present because Chrome OS only supports a subset of languages and they might have a different preference for their languages for apps and websites Specified in: http://go/cros-lang-settings-ux-slide#slide=12 Bug: 1113439 Change-Id: Iab64854a68f9abebdee40ce04487bd09c7552970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413711 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This CL converts WidgetMsg_WasShown/WidgetMsg_WasHidden IPCs to blink's Widget mojom and moves some implementation including is_hidden into WidgetBase, and moves ContentToVisibleTimeReporter class to blink. Bug: 1102446 Change-Id: I40bf1444627fdac5a96becef0907f5662a6a45e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377630 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#807798}
-
Kent Tamura authored
crrev.com/806924 missed to add |accumulated_offset| to the LEGEND's offset. So hit-testing didn't work well if the FIELDSET was placed far from the origin. Bug: 1127743 Change-Id: I16c80b8074f9082516a6ecd5bb82407bbe7d3551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413681 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#807797}
-
Istiaque Ahmed authored
This CL ensures PRE_FilteredEventsAfterRestart sees OnRegistrationStored. This CL also packs the extension before loading to avoid extension reload during LoadExtension. This CL reuses (and renames) .pem key from "events_to_stopped_extension" test. Due to crbug.com/1127126, the test still flakes on win bots. Therefore, this CL leaves the test disabled on win. Bug=1003244 Change-Id: I8d27b55899f3b272575ff8c3eef31c57afc439a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405612 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#807796}
-
Hidehiko Abe authored
Currently is_linux is set to true on Chrome OS build, but it is planned to set false. This CL is the preparation to keep the current behavior. Bug: 1110266 Test: Built locally. Change-Id: Ia56a3e5a3ef3db14e4a4a3b2583e4496595263af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413723 Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#807795}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Iea40b9bdb7cd777718e80b77a0d9b8fe71d273d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415003Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807794}
-
Ethan Jimenez authored
1. Implementing virtual methods `IsRangeSpanningIntrinsicTrack` and `IsRangeSpanningFlexTrack` in `NGGridTrackCollectionBase`. These will allow track collections to cache whether a range spans tracks with an intrinsic or flexible sizing functions. 2. Introducing new member variables to `GridItemData` that will be used in following changes, e.g. an item's resolved grid area, flags to cache if an item spans intrinsic or flexible tracks, etc. 3. Implementing an algorithm to cache which grid items contain ranges that span intrinsic/flexible tracks in `NGGridLayoutAlgorithm` (see `DetermineGridItemsSpanningIntrinsicOrFlexTracks`). 4. Adding unit tests for all the introduced caching. Bug: 1045599 Change-Id: I0c9121803aa1703bc38c7b18078a266f33b75156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402967 Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Jacques Newman <janewman@microsoft.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#807793}
-
Palak Agarwal authored
Bug: 1068681 Change-Id: I496affdb20eda7209a66aed25859b04234ec9bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401098Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Palak Agarwal <agpalak@chromium.org> Cr-Commit-Position: refs/heads/master@{#807792}
-
David Munro authored
Change-Id: I6eee3aab74df6c43c4f7db9dd534438dd0957330 Bug: chromium:1121463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413720 Commit-Queue: David Munro <davidmunro@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#807791}
-
Harald Alvestrand authored
Bug: chromium:1127625 Change-Id: I9ac8b6b90f241460ade299914369405363a36403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410407 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#807790}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600204796-8d7865915b9e4398ddfed4089a6b11aaf7991b68.profdata to chrome-mac-master-1600310646-24416ad728deecf44e4a88c788126e2edffee2b4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ib3d0a723914d8093da1701ca9a3e0c8933f4a325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415738Reviewed-by:
-
Morten Stenshorne authored
We usually don't encounter NG objects inside a legacy layout subtree, but this may happen when we have display types that aren't implemented in the legacy engine, e.g. MathML and custom layout. This situation should be rare enough, and the combination of list items and MathML / custom layout doesn't seem like a very common use case. So just don't go there, and instead keep looking for a better candidate to place the list item marker inside. Bug: 1127112 Change-Id: I74c39fae7e5c48d73d5603efca486a05c234a25a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414268Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#807788}
-
Colin Blundell authored
WebLayer was inadvertently stripping out the ssl_error_assistant proto from its resources, meaning that it ended up not using any of the data in the proto (as it also doesn't use the component updater to fetech the proto). This proto has Chrome's list of known captive portal, MITM, and dynamic interstitial certificates. The most concrete consequence of this fact at this time is that WebLayer will not correctly detect known captive portals. This CL fixes the bug and adds a test that fails without the fix. To verify manually, go to captive-portal.badssl.com and check that the captive portal interstitial appears rather than the generic SSL interstitial. Bug: 1128964 Change-Id: Ife74e1c7898b7f57c238871a1fb646eb0ebf677d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414297Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#807787}
-
Joel Hockey authored
Remove map of VmSharingInfo from CrosUsbDeviceInfo since device is only shared with one VM at a time. TBR=khorimoto@chromium.org Bug: 1129266 Change-Id: I2025091bf63eeed538c62d8b39cfbb744339aa64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413716 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Harvey Yang authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/f7f147bf0..9ae272cf7 2020-09-03 chenghaoyang system_api: Rename iioservice constants as mojo_connection_service 2020-08-28 oto system_api: Add error list of cros-disks partition service to dbus 2020-09-08 sidereal vm_tools: Expose VM type in the VmInfo proto 2020-09-09 fletcherw system_api: add method to lorgnette constants BUG=b:162189963 TEST=builds Change-Id: I088303a48f1d93d99884410165acfd83bec36632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413726Reviewed-by:
-
Kenichi Ishibashi authored
Bug: N/A Change-Id: I81070bfe8d016aa795749a04708970aeb22dbf89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413684Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#807784}
-
Takashi Toyoshima authored
This reverts commit 42502d6b. Reason for revert: needed to wait for a while to roll the fix in the internal repos. Original change's description: > Revert "Reland "OOR-CORS: Remove BlinkCORS supporting code outside Blink"" > > This reverts commit 746ea10b. > > Reason for revert: Breaks Chrome OS builds as some internal code (tab_search_browsertest) still refer to kOutOfBlinkCors feature. > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/8532 > > See chrome/browser/resources/tab_search/test... > > Original change's description: > > Reland "OOR-CORS: Remove BlinkCORS supporting code outside Blink" > > > > This reverts commit efd0a0a1. > > > > Reason for revert: The failed internal test was fixed in the internal repos by > > https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3263707 > > > > Original change's description: > > > Revert "OOR-CORS: Remove BlinkCORS supporting code outside Blink" > > > > > > This reverts commit 1047b889. > > > > > > Reason for revert: Build failure on mac-builder-perf: https://ci.chromium.org/p/chrome/builders/ci/mac-builder-perf/220028 > > > > > > Original change's description: > > > > OOR-CORS: Remove BlinkCORS supporting code outside Blink > > > > > > > > As OOR-CORS was fully launched, this patch removes BlinkCORS > > > > supporting code that exists outside Blink. > > > > > > > > We still have some dead code in Blink, and subsequent cleanup > > > > changes will remove them all. > > > > > > > > Bug: 1053866 > > > > Change-Id: Ibe9f913d3cc9f183d6e681516996f1bc6cc58b96 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397458 > > > > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > > > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > > > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > > > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > > > > Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#805644} > > > > > > TBR=falken@chromium.org,sky@chromium.org,kinuko@chromium.org,toyoshim@chromium.org,jam@chromium.org,karandeepb@chromium.org > > > > > > Change-Id: I51b1a274038b33b8db3036fc1a3912c6580c9446 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 1053866 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401467 > > > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > > > Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#805662} > > > > TBR=falken@chromium.org,sky@chromium.org,kinuko@chromium.org,toyoshim@chromium.org,jam@chromium.org,skyostil@chromium.org,karandeepb@chromium.org > > > > # Not skipping CQ checks because this is a reland. > > > > Bug: 1053866, 1126827 > > Change-Id: I9251c658414ff98e3fc35e8a110366edb30b2d74 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405728 > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#806906} > > TBR=falken@chromium.org,sky@chromium.org,kinuko@chromium.org,toyoshim@chromium.org,jam@chromium.org,skyostil@chromium.org,karandeepb@chromium.org > > Change-Id: I19b61821bb75f486cd549741769a47daad08ea48 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1053866 > Bug: 1126827 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410125 > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Commit-Queue: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806944} TBR=falken@chromium.org,sky@chromium.org,kinuko@chromium.org,toyoshim@chromium.org,jam@chromium.org,skyostil@chromium.org,karandeepb@chromium.org,poromov@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1053866 Bug: 1126827 Change-Id: I3ca948489491455ef65f7324bb1043fba37b00c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415752Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#807783}
-
Yoshisato Yanagisawa authored
Bug: crbug.com/1129271 Bug: b/157436234 Change-Id: Idf2321f637af6b58e111e34eaefebd24cab185cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415576 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#807782}
-
Lukasz Anforowicz authored
The new security note explains security-related caveats related to using the GetURLLoaderFactoryForBrowserProcess method. The note suggests using RenderFrameHost::CreateNetworkServiceDefaultFactory instead (the latter factory should enforce setting a non-base::nullopt network::ResourceRequest::request_initiator - see the InitiatorLockCompatibility::kNoInitiator case in CorsURLLoaderFactory::IsValidRequest). Bug: 1128008 Change-Id: I3d30736f5804b97a45e246106463ee6a40e747a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410820 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#807781}
-
James Vecore authored
This adds some more verbose logging for transfer status updates to help track down multiple bugs related to status propagation. Change-Id: I01abee966f21815e2892f8efdba454b1e01e0782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413547 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#807780}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/029801bea6c1..d340f4f1fe05 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yukishiino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:912681 Tbr: yukishiino@google.com Change-Id: I24cdd70737eba1912ae4189d279d3d5b150de999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414663Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807779}
-
Kuo Jen Wei authored
Filter out lagging grunt >=720p preview and video exposed by device. Bug: 1122852 Test: Check resolution settings, no 720p shown on grunt. Test: tast run <grunt> camera.CCAUIRecordVideo Change-Id: Ie994f53c3916716bec8643708d8348c3ad937122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413717 Commit-Queue: Inker Kuo <inker@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#807778}
-
Regan Hsu authored
This CL resolves a crash that will occur when the user toggles on, then toggles off the FakePhoneHubManager in chrome://multidevice-internals. Bug: 1106937 Change-Id: Ibd8732a9941f59a267dbbe852b5e7939e9812e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414927 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ided30e4b5e829c3d3ed70de4aeb5c0d2e924f1c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414661Reviewed-by:
-
Maksim Sisov authored
Wayland may disconnect the client if it hits an unrecoverable error. That is, it prints an error message and client cannot do anything about that after that except shutting itself down. Thus, while watching the display fd, always check for errors. If a protocol error is set, trigger |shutdown_cb| and also stop watching the fd. Bug: 1127278 Change-Id: Ie324af93d455c0c83f8e75cdecfafe2254da1972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404931 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#807775}
-
Mitsuru Oshima authored
Updated per go/cros-ppi-spectrum. [270-310) now uses 2.4 and use 2.2525.. only for Slate which has 3000x2000 panel. No change to ARC++ scale for this range. 2.4 * 1600 produces small error (0.00024). Make sure it's within the epsilon used in cc. (0.001) so that the screenshot size is correct (See DisplayChangeObserverTest.FindDeviceScaleFactor) Bug: 1070828 Test: covered by unittests. manually tested on yoga and nocturne Change-Id: I2899fd774fcbd461231282b97fecead6a308b949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397321 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#807774}
-
My Nguyen authored
xkb:us::eng, xkb:us::ind, xkb:us::fil, xkb:us::msa all shared the same "US keyboard" name. Proposed new name found in http://go/cros-input-methods Rationale: http://go/cros-input-methods-naming Old view: http://screen/9beQv6FzD5KKMwC Current view: http://screen/7RQzmccu2JtQL4F Note: Added a temporary indicator based on languages for now. Bug: 889763 Change-Id: I3d66daab67d4033af9dceb5ddec10d06a8e998ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413968Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#807773}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I43328fcc8de54231122c54fb87437caa8a7217e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415731Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3ee25e942eda..bf66ffbbd4ce 2020-09-16 ethannicholas@google.com Reland "Revert "moved BinaryExpression's data into IRNode"" 2020-09-16 johnstiles@google.com Add support for #pragma settings comments in SkSL. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: If0d85cbda21fc50998d9d7866385493dcbfe090b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414643Reviewed-by:
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Bug: 1018739 Change-Id: I1b4b1c0004c396e6a392fc8dfd4fe6c71f47a4be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414168 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#807770}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600127994-515c383edf0ef93d8562747294461d0f81f3cc39.profdata to chrome-mac-master-1600204796-8d7865915b9e4398ddfed4089a6b11aaf7991b68.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: Ide8ffb7cb5beed595c53c6818d1af4da91cbf53f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412899Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f2c29ad3..2ff41ff5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icc592027c4d70dcd85bb11d780c1f285eeb0898a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415548Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807768}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Iae7196ba7fb37ce04d6660113ba42f872d5fba2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415330Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#807767}
-
Meilin Wang authored
Demo: https://screenshot.googleplex.com/47REAoUwTx7sigJ.png This CL: 1. Introduces |PhoneHubInterstitialView| with a customized layout that can be reused by onboarding, disconnecting/connecting and error state UI. 2. Introduces |OnboardingView| which serves as an entry point for eligible users to set up the Phone Hub feature. Remaining work includes implementing the button click handlers. BUG=1106937,1126208 Change-Id: Ib1b93b47ee1b715c991811b35afdfdc57b2f5c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406662 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
-
Hoch Hochkeppel authored
Removing the check of the size of the shared files from share_service_impl, but leaving the unit tests prepped to cover these cases to validate that the platform-specific implementations check this when they are processing the shared files. The scenario being fixed with this change is sharing native files, easily exercised with the Web Share Test page: https://w3c.github.io/web-share/demos/share-files.html When these files are initially created as blobs they are marked as being of unknown size, and though the navigator_share code does check their size as part of the Share operation, this check does not modify the actual blob, so when it is serialized the recorded size will be the max uint64 value. Matching the Android implementation, this postpones the file size check till the files are actually being processed (in the platform-specific implementations). Bug: 1035527 Change-Id: I59ea9bfadb06205ae155f31947fa04093f06503d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415431Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#807765}
-
Leo Zhang authored
Provide some basic info of the host of the focused text field to system IME via private extension API. With these information, IME will identify some known faulty clients then demote its input.ime APIs (even disable advanced features) to make the typing on these client works basically. Context for the CL: Due to some faulty implementation of their text operations in some clients' text field (e.g. Terminal for Linux, Text app, Android app...) in ChromeOS, they don't work not properly with predefined ChromeOS IME APIs (e.g. chrome.input.ime.deleteSurroundingText, setComposingRange...). Therefore, typing on these client are always difficult with unexpected results. Detailed example can be found in the bugs attached. Tested=Some popular cases in local VM and Kevin device in skylib. Bug: b/162183648,b/163645900 Change-Id: Ib43e9ccba7e9620b7189153d956ef685f80fb29d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405046 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
-
