GitLab

As part of the SplitSettingsSync project we want to use the browser's
first-run sync opt-in flow on Chrome OS. We're trying to align browser
sync with Windows/Mac/Linux. PRD in the bug.

This CL adds SyncConfirmationUI, SyncConfirmationHandler, an existing
unit test and associated dependencies to the build. It also fixes some
minor style guide issues in the code.

Chrome OS does not use the DICE identity model (it has its own account
manager and behaves more like Android/iOS). Some of the dependencies
therefore need BUILDFLAG(ENABLE_DICE_SUPPORT) checks.

There are no user-visible changes yet.

Bug: 1013466
Test: unit_tests
Change-Id: I3b1a5c968279ffe48a32e9f6765bc6f6fe975e2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917742Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720551}

MessageLoop is going away soon.

This CL was uploaded by git cl split.

R=dewittj@chromium.org

Bug: 891670
Change-Id: I23c7baa0f9429ba704a6ebfb356542eeb0cc8ce7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943185
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720550}

The specific notion of overscroll this test is checking for is only
implemented on Aura platforms.

Bug: 1028239
Change-Id: Ic40d5d504e463517cd28fc28b3a6d36a7e5fb8a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946683Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720549}

Intent-to-experiment thread with LGTM:

https://groups.google.com/a/chromium.org/d/msg/blink-dev/exoGLTG8m-c/5EUdD5zYBQAJ

Bug: 1007272
Change-Id: If1ced44cff78c8d957fe5792e47fbe38264b5048
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940137Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720548}

. README added for representative perf tests.
. Update pixel-wrangling instructions to include looking at
  repr_perf_test results.
. Linked the pixel-wrangling doc to the representative perf test's for
  more detail.

Bug: chromium:1000837
Change-Id: Iefe03f7c722ccc9c8d72cf3e5ada7816e240d1cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937848Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720547}

googletest will no longer support empty prefix
for parameterized INSTANTIATE_TEST_SUITE_P.
Adding "All" prefix to existing empty prefix test suites.

This CL was uploaded by git cl split.

R=mpearson@chromium.org

Bug: 1023677
Change-Id: I20d5e41c5adc458b0528d668157687d5bf9e758a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925744
Auto-Submit: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720546}

These metrics were already deprecated in M79.

Bug: 1024570
Test: blink_platform_unittests still pass
Change-Id: Ibf7dbfe93616ccb0ba151841b524a0256ec343bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917521Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Alex Deymo <deymo@google.com>
Cr-Commit-Position: refs/heads/master@{#720545}

Change-Id: Ia2e059473343a5672df601ff3c56b1fb3e6ebf17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946684
Commit-Queue: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720544}

This assert prevents the usage of VectorDrawables in TintedDrawable.

Before this CL, TintedDrawable would fail silently and return an empty
image (which leads to regression like the linked bug).

Bug: 1028925
Change-Id: I65ff97599c8dba5b90a07087335a63a39903c2d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946332
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720543}

Address post-commit comments.

TBR=haraken@chromium.org
CC=hajimehoshi@chromium.org,kouhei@chromium.org
BUG=1004676

Change-Id: Ib017771ca40c2c5a4fabe1057bcae81e88487059
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946192Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720542}

This reverts commit bd94f94a.

Reason for reland: Fixed the crash (by handling null SyncService).
SyncService is null in incognito, so we need to handle that case.
The reland also adds feature checks (which should have been there the
first time around), and while we're here, makes the handling of empty
account IDs more explicit.

Original change's description:
> Revert "Collect user opt-in before enabling account-storage for passwords"
>
> This reverts commit c3c37466.
>
> Reason for revert: canary top crasher; see https://crbug.com/1029631.
>
> Original change's description:
> > Collect user opt-in before enabling account-storage for passwords
> >
> > This CL adds a pref that stores which accounts have opted in to use the
> > Google account storage for passwords. While this pref is false,
> > passwords can not be saved to the account, and passwords in the account
> > are not downloaded.
> > It also adds an entry to the password autofill dropdown that lets the
> > user set the opt-in.
> >
> > Bug: 1024332
> > Change-Id: Iac552c310d0e9f19ee2bb1893e217e60b1114d31
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645294
> > Commit-Queue: Marc Treib <treib@chromium.org>
> > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#720206}
>
> TBR=sdefresne@chromium.org,treib@chromium.org,dvadym@chromium.org,jzw@chromium.org,mamir@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1024332,1029631
> Change-Id: Ib859957d27a898652e001515652cde25a30ed1b3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944497
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Reviewed-by: Greg Thompson <grt@chromium.org>
> Commit-Queue: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#720424}

Bug: 1024332
Change-Id: I57e9ae4c636b9ad6e7d6da83c5eeaf0c7283d970
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946370
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720541}

Since I am removing the NaCl and WebApp references in the remoting
directory, I figured that we may as well remove this too.

Change-Id: Id35f11b8a1ddcaf8d063ba61379b507da818ab58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934647
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720540}

When an arc segment was decomposed into more than one cubic bezier
segment, some "residue" (the length of the first part of the cubic that
was "flat enough") would accumulate from any segments that followed the
one that contained the point. This would make the computed |offset|
incorrect.
Switch to checking, for each bezier segment, if the we've passed the
point (length) that we're querying, and skip adding anything for that
bezier segment.

Bug: 719516
Change-Id: I0c54e1a07be5fb5edddaded542df0ffd5b0a087c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939979
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720539}

This CL has goal to use IsA<SVGStopElement>(element) in place of
IsSVGStopElement(element)

Bug: 891908
Change-Id: Iba08d8b45ee7440957528beccccbea6ad3d4378f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936621Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#720538}

On android web-based payment apps with missing name or icon are not
pre-selectable. This cl is changing the desktop implementation to match
Androud.

Bug: 1029373
Change-Id: Ic496ba7d9e9884615e58c4c8fc00882be51417a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943267
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720537}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4b5276f1ad99..b2efa52611c0

git log 4b5276f1ad99..b2efa52611c0 --date=short --first-parent --format='%ad %ae %s'
2019-12-02 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS.
2019-12-02 tvanderlippe@chromium.org Reland "Remove "Remote Devices" panel"
2019-12-02 aerotwist@chromium.org Fixes string interpolation in exclusive changes dir
2019-12-02 aerotwist@chromium.org Updates node_modules

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@b2efa52611c0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I39eda57accfdfc059da8545a196f634afc178bcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946428Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#720536}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ded19c4711b5..37c0baa6b7b4


Created with:
  gclient setdep -r src-internal@37c0baa6b7b4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:None
Tbr: jbudorick@google.com
Change-Id: I39483948cb45461b94a842aa145fda633a2f84cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945358Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#720535}

This is more of a post-processing effect, and since we already handle
'auto' vs. <angle> in LayoutSVGResourceMarker, we might as well move the
handling of the other 'auto' value there.

Bug: 674797, 633012
Change-Id: I8b06800201b923167cfac5a03f8cd78335b02f6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942334Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#720534}

This reverts commit bac094f7.

The CHECK captures the crash, no longer needed

Original change's description:
> Convert some DCHECK to CHECK to find cases that download file is not
> properly deleted
> 
> 
> BUG=1028666
> 
> Change-Id: I59b60a897a5f2529d4e61d8632aebe421dbc71b3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933738
> Reviewed-by: Xing Liu <xingliu@chromium.org>
> Commit-Queue: Min Qin <qinmin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#719294}

TBR=qinmin@chromium.org,xingliu@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1028666
Change-Id: Ia0cdac36ec67ad41a669b55bf32343a1dd18afba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946430Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720533}

Bug: 1029787
Change-Id: I1f30a649fcaa7deeb62a1f0b168c89e7555dad5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946146
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720532}

CSS images should take Content-DPR into account when calculating their
intrinsic dimensions. They currently don't. This CL fixes that.

Bug: 1029313
Change-Id: Iafb2e5d88c1a0bbf0a13b00ddb46ad643f38c8d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944496
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720531}

The font is no longer used by Chrome on iOS nor any of its dependency
from the internal repository so stop initializing the font loader and
remove the font data from the application binary.

This will reduce the app bundle size by ~ 1.1 Mo (size of the unpacked
fonts data) without any impact on the application since UI lead has
confirmed that the font is not used on iOS.

Bug: 1017165
Change-Id: Ia07c168be58ef30f75bba0f902c0d0e0b8631a63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944477
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720530}

Bug: 1016815
Change-Id: I6c3ab2e1551de2bea9eaacd211c976bf64da66bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942968Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720529}

This CL cleans up |bindings_| from FakePrivilegedHostDeviceSetter
since it's not used.

Bug: 955171
Change-Id: I35ab1100e8732aba2fe904ebb4ac7dcc40c0a0de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939130
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720528}

We're working on splitting up network resources by NIK to prevent
tracking users across browsing contexts for different first parties.
Classes that perform network activity on behalf of a RenderFrame need
that frame's NetworkIsolationKey.

Also update consumers to use the method.

Bug: 997049
Change-Id: I685335d1ec84f858276f89ab6ebb1b114c9bcc4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938029Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720527}

Bug: 959776

Change-Id: I58863e2b625bd55242974283646bfff44bb04fc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944865
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720526}

Mark GpuProcess_feature_status_under_swiftshader as RetryOnFailure

The test has been flaking considerably on Linux.

Bug: 1028974
Change-Id: I355dcbac4e5e06508d049c6592930ab366d15caf
TBR: kbr@chromium.org
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944681Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720525}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/684d2057..6d4b96eb

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I1bd35db1c768dc97d00f62308ebd713e4fea1a7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946625Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#720524}

Move the entries to the Paint section of the file.

Change-Id: I4d0e21a96aefe548ced153665c01ee7866ca0e9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944478Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#720523}

Change-Id: I54bc8d52aca117778519780ca6abce2622910954
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926540
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720522}

Bug: 1028477
Change-Id: Ib5a18c349023f9db77a2325981f20a21d65b8c01
TBR: petermarshall@chromium.org
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944479Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720521}

https://android.googlesource.com/platform/external/perfetto.git/+log/f6ccb0551532..27076e27131f

git log f6ccb0551532..27076e27131f --date=short --first-parent --format='%ad %ae %s'
2019-12-02 hjd@google.com Merge "perfetto-cmd: Reset guardrail state on boot"
2019-12-02 taylori@google.com Merge "Create a reusable thread_state table"

Created with:
  gclient setdep -r src/third_party/perfetto@27076e27131f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I8305af4e15ba912c3298dd9f24e51559a82df312
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945357Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#720520}

+ Adds 'const' to casts where appropriate
+ Fixes an unsafe write through one of these non-const pointers

Bug: 10278398
Change-Id: I6e7b30806143cbf38109de174e799521f7d1a1cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944282
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720519}

Also use srcCompat instead of src to avoid crash on KitKat.

Bug: 1029749, 1029056, 656015
Change-Id: I38cd630dadfc73868dfbca961d0eff0fa4bcce3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944490
Auto-Submit: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720518}

IWYU. Follow-up to commit 376a18cd ("events: ozone: Remove implicit init
from GetKeyboardLayoutEngine"), which broke the non-libc++ non-ozone build:

../../chrome/test/chromedriver/keycode_text_conversion_ozone.cc:34:12: error: no member named 'make_unique' in namespace 'std'
      std::make_unique<ui::StubKeyboardLayoutEngine>();
      ~~~~~^
../../chrome/test/chromedriver/keycode_text_conversion_ozone.cc:34:52: error: expected '(' for function-style cast or type construction
      std::make_unique<ui::StubKeyboardLayoutEngine>();
                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
../../chrome/test/chromedriver/keycode_text_conversion_ozone.cc:34:54: error: expected expression
      std::make_unique<ui::StubKeyboardLayoutEngine>();
                                                     ^

Bug: 957519
Change-Id: I54d132875ffc65495cde651d40b1ea87b5b0b284
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945176
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720517}

This fixes two issues with the discardable memory backing trial unit
tests:

1. The return value of GetDiscardableMemoryBacking() was memoized on
a per-process basis, persisting across tests. This caused the tests to
erroneously fail. Since the function was not heavy in the first place,
remove the memoization.

2. The ScopedFeatureList was mistakenly initialized after querying
trial state, causing the tests to vacuously pass. Move the
initialization before the query.

This change does not affect the field trial behaviour, and only
fixes the unit tests.

Bug: 1014513
Change-Id: I200ddd87e4a8dd52ceba730a9e242f2f7167c029
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944607Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Gordon Guan <gordonguan@google.com>
Cr-Commit-Position: refs/heads/master@{#720516}

For every account available in the account tracker service, both the
Gaia ID and the email are available. The GCM AccountTracker was fetching
again the gaia ID from the server on every start-up and every time a new
account was added to the profile. This CL removes this useless fetch
and changed the GCM AccountTracker to reuse the information already
available in the IdentityManager.

Additional clean-up to completely remove the GCM AccountTracker would
also be good, but I do not know this code well enough to do this cleanup.

Fixed: 1028522

Change-Id: I77790a3203a94ea8c7baf19ca0eb2449b096b630
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944492Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720515}

Due to flakiness, disabling this test on Mac and Linux ASAN/TSAN

Bug: 1029238
Change-Id: I49d27dffff9b54b03308e1586822f148e9044e44
TBR: altimin@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945177
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720514}

A framework bundle does not require public headers, so change the
ios_framework_bundle template to work if public_headers is empty or
undefined.

Bug: none
Change-Id: Ieac39fd98220d23f5ae6bf99908d19112ef2eb0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944476
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720513}

Allow error pages to get a different instance if ProactivelySwapBrowsingInstances
flag is enabled.

R=nasko@chromium.org,alexmos@chromium.org
CC=​arthursonzogni@chromium.org,
BUG=1026101

Change-Id: Ib3332c5040dc2385e7e9adf1d1f0630a2cbc0071
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929033
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720512}