GitLab

The HttpRequestManager class will be used by network diagnostics
routines to make http/s requests.

BUG=chromium:956783
TEST=unit_tests --gtest_filter=HttpRequestManagerTest*

Change-Id: I2b2bd97cfb832fb4dc58ceb3b90da721497c9ee7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377420Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kartik Hegde <khegde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804495}

This barcode scanner (as with many others) works by pretending to be a
keyboard and typing out the barcodes it scans. This prevents the
on-screen keyboard from appearing on devices without an actual keyboard
plugged in.

Bug: 1004645, b:141515578
Test: check scanner works, and that VK appears when appropriate
Change-Id: I0e983035e645b412955bed38307de43ce5ab2ac5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388347Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Harry Cutts <hcutts@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804494}

Adds an UMA metric to time font enumeration time on Windows.

Bug: 1043306
Change-Id: I6e8a3e51ee752f3e62388a08fd05b06456e7ccd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392992Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Olivier Yiptong <oyiptong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804493}

The CUPS resolution field, represented as quality in the print preview
dialog, was previously ignored on Chrome OS machines in favor of the
advanced print quality setting. This commit changes that - when
possible, Chrome will pass the selected resolution on to CUPS so that
print filters can print at the correct resolution.

Bug: 1001398
Test: ./printing_unittests
Change-Id: I3666591da07022d3dd02b2fadaaaf4835ad453b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390967Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Pranav Batra <batrapranav@chromium.org>
Auto-Submit: Pranav Batra <batrapranav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804492}

Currently, ExtensionMessageBubbleBrowserTest inherits from
BrowserActionsBarBrowserTest. Unfortunately, this means that none of
these tests run with the new Extensions Menu UI. Since the
BrowserActionsBar-related tests are going away, we need to migrate these
to be compatible with the new UI.

Instead of inheriting from BrowserActionsBarBrowserTest, inherit from
ExtensionBrowserTest directly. There were relatively few dependencies,
and this paves the way to having these tests run with the new UI.

Bug: 1100412
Change-Id: I43cd5852ddf2e04eaee7c55f1d0b4086e31c59fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392702
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804491}

This CL adds the enable_launch_polish field trial and utility method for
M86 FastPath.

The utility method is added, so we can run the formal equivalence
checking tool.

Bug: 1124835
Change-Id: I7bb0152ebc4138f1023e8a8fe9715cf4524b5a1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392773
Commit-Queue: Mei Liang <meiliang@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804490}

Fix the GN file to avoid the policy_fuzzer compilation errors,
by removing the "proto_in_dir" parameter that was added in r803915.
As per trybot results, it seems that this parameter isn't actually
needed.

The reason why this parameter was causing troubles in policy_fuzzer
is that we're compiling chrome_device_policy.proto twice:

(1) "gen/components/policy/proto/chrome_device_policy.pb.h", which
    is the standard compilation location used for compiling both
    normal Chrome and the fuzzer;
(2) "gen/chrome/browser/chromeos/policy/fuzzer/chrome_device_policy.pb.h",
    which is compiled specifically for fuzzer, with the LITE_RUNTIME
    option suppressed.

Previously, before "proto_in_dir" was introduced in r803915, both of
these header files had the same preprocessor include guard that is
based on the "chrome_device_policy" string:

  #ifndef GOOGLE_PROTOBUF_INCLUDED_chrome_5fdevice_5fpolicy_2eproto
  #define GOOGLE_PROTOBUF_INCLUDED_chrome_5fdevice_5fpolicy_2eproto

The fact that the include guard was the same allowed to include both
of these headers in the same .cc file without any compilation issues.

With "proto_in_dir" introduced in r803915, the include guard for file
#1 changed, because protoc started to consider the full path to the
file:

  #ifndef GOOGLE_PROTOBUF_INCLUDED_components_2fpolicy_2fproto_2fchrome_5fdevice_5fpolicy_2eproto
  #define GOOGLE_PROTOBUF_INCLUDED_components_2fpolicy_2fproto_2fchrome_5fdevice_5fpolicy_2eproto

This caused compilation issues of policy_fuzzer, since the include
guards didn't protect from redefining the contents of
chrome_device_policy.proto twice.

The fix is to remove this "proto_in_dir" directive, which seems to be
unnecessary.

A future long-term fix (potentially also addressing other compilation
issues that we saw in https://crbug.com/1093407) would be to get rid
of double-compilation of the .proto files.

Bug: 1124880,1094675
Change-Id: I3b1ba1c1591940a846a3ec323a9fa16aa01778e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392816
Auto-Submit: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Zach Trudo <zatrudo@google.com>
Commit-Queue: Zach Trudo <zatrudo@google.com>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804489}

Using wpt-import in Chromium b6433401.
With Chromium commits locally applied on WPT:
1d15ab1e "[css-pseudo] Don't inherit 'text-align' to ::marker"
82d112d0 "Fix cert errors on the official WPT test runner."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
drott@chromium.org, kojii@chromium.org:
  external/wpt/css/css-fonts
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
hbos@chromium.org, hta@chromium.org, guidou@chromium.org, philipp.hancke@googlemail.com:
  external/wpt/webrtc
hongchan@chromium.org, rtoy@chromium.org:
  external/wpt/webaudio
rego@igalia.com:
  external/wpt/css/css-grid

NOAUTOREVERT=true
TBR=lpz@google.com

No-Export: true
Change-Id: I59322e6751e18383e5c42ff7cecae06a4f86ecf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390807Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804488}

This is a reland of c02e4409

These EarlGrey tests fail on iOS 12.4. (Presenting the iOS share sheet
crashes the test even without any JS changes.) Update the tests to run
only on iOS 13+.

The feature works in Chrome even on iOS 12.4 without crashing.

Original change's description:
> Restrict web share feature to URLs with http/https protocols
>
> Bug: 1122059
> Change-Id: Id9644b9dff7e9854f20218f09750fbf191d5a318
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378274
> Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#803970}

Bug: 1122059
Change-Id: Ia7c94020287330c918a3a9d50c545fca52306d6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392979
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804487}

Whenever certain record is written generation and its digest are stored
in metadata file, and then all previous metadata file(s) are
asynchronously deleted.
When reopening the StorageQueue, metadata file matching the last
sequencing number is used to restore generation and digest for future
writes.
The code does not handle errors yet - missing or corrupt metadata file,
incomplete data file, etc. In the future we will add code to reset
generation id and eliminate last digest.

MockClient in tests makes sure generation_id is the same for all records.
It also verify records own digest; last record digest is not verified
yet, because the test expects some records to be duplicated.

Bug: b:153364303
Bug: b:153659559
Change-Id: I80d8e7f03097bcc4a510f21e0a546876b3104960
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388716
Commit-Queue: Leonid Baraz <lbaraz@chromium.org>
Reviewed-by: Zach Trudo <zatrudo@google.com>
Cr-Commit-Position: refs/heads/master@{#804486}

The Punctuation Echo Setting has three TTS verbosity levels for speaking punctuation: None, Some, and All.
Before, the user could only change the Punctuation Echo Setting with the Cycle Punctuation Command.
This change allows the user to change the Punctuation Echo Setting from the ChromeVox Options Page.

Bug: 1124445
AX-Relnotes: Add Punctuation Echo Setting to ChromeVox Options Page
Change-Id: I726e43b9dccf23fc12acd83e2430492b042d130d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388402
Commit-Queue: Josiah Krutz <josiahk@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804485}

Check each of crostini and plugin VM before adding buttons on the
notification, and update messages.

Bug: b/150341671
Change-Id: Id9973c27c9355b85bfe5d168ca8828500a7d5156
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389303
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804484}

TBR=benmason@chromium.org

Change-Id: I5581788c390f8da454acb837e967dcc8bf9870fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392944Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804483}

Formerly, the rate, pitch, and volume used a hybrid linear/exponential scale. Convert to linear, with a smaller step-size.

Fixed: 987509
Change-Id: I6eaae207e6fffac08f098750e96d131d08d4217c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388342Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804482}

It is currently cut off but we cannot shrink down
our content any more so we need to increase the
size a little bit.

BUG=1121360

Change-Id: Icdd2ba460f727324c0f5c00426aeb637e4cad35e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393189
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Auto-Submit: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804481}

https://chromium.googlesource.com/angle/angle.git/+log/b6b9cffaf3bc..36b884e6ace1

2020-09-03 sugoi@google.com Fix undefined behavior in minifloat conversion

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: chromium:1117433
Tbr: cwallez@google.com
Change-Id: If9a7e9d7dada7756feedf60420b7857b41641634
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393141Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804480}

A lot of WebCodecs tests are using async_test, which lead to time outs
when there is an error, and potentially missed test failures.

Additionally, a lot of code verifying configs, and which calls are
allowed in which codec state are common to many test files. This CL
extracts some of common elements into its own utils file

Bug: 1094096, 1094182
Change-Id: I7dd6c9ab76959ed6adb86fd2e6bf94d21610838a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389008
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804479}

Raised cosine add less audible artifacts when used as volume slew
curve, compared to linear one.

Recurrent calculation of slew cosine is based on:
https://basesandframes.files.wordpress.com/2016/05/rgreenfastermath_gdc02.pdf

Bug: internal b/167251783
Change-Id: Ia9262700ecc0b9f4ee5e3895cc9864480eabab73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391894Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Auto-Submit: Michael Montvelishsky <mont@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804478}

CopyFileContentsWithOffsetAndSize takes in a max size, but uses the
wrong variable to consider how much is remaining to read, and so ends up
reading the entire file (rather than limiting to size).  Because of
this, there's a size mismatch in the calling function and the blob fails
with kInvalidBlob.

This should fix some of the errors from issue 1114200.  I also see out
of memory errors, but those make more sense than this logic error.

Bug: 1114200
Change-Id: I6d8f371655e38bdd02cc89e9d524de757e1c202a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392987
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804477}

code.google.com redirects no longer work. This CL replaces links in /tools/mb
to source.chromium.org equivalent.
This CL was uploaded by git cl split.

R=machenbach@chromium.org

Change-Id: I61e216806f67737420db18a2a5ab4994919351af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392762
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804476}

https://storage.cloud.google.com/chromium-translation-screenshots/d19d57bea32f7733f7cb337f21c738a13f644992

Bug: b/150341671
Change-Id: I5cc68bb37ebd4ab12340a87edb509d1ee3adfa15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389284
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804475}

Observer interfaces having default-passthrough virtual methods rather
than pure virtual methods allows observers to only override functions
they'd make use of, and not have to override other functions.

This was inspired by: https://chromium-review.googlesource.com/c/chromium/src/+/2341407/33#message-8c9e7fa5cb0118798e3bd2f92bbe1cfe37a85640

Change-Id: I2e4e852204322a4608b4e449e0f7e9ab7e73f870
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382959Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804474}

This CL corrects many more problems found in the localization
data for Pedals, most notably where multiple synonyms were
combined using punctuation like slash or comma. This data
is now tool-checked to be punctuation-free, with only two
exceptions allowed: apostrophe (') and dash (-).

Also manually fixed a few more issues in spreadsheet, like cases
where a synonym is both ignored and required in TRANSLATE Pedal.

Bug: 893183
Change-Id: I43b1f5e27f1f79318cbc96b397fe576faa283a5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393191Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804473}

https://dawn.googlesource.com/dawn.git/+log/b44ca92f1cdd..2cdb9f1ed183

2020-09-03 rharrison@chromium.org Remove SPVC toggles and excise remaining references

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: Ie0903643c81b5bf85e2da7dc51c4cfb181073566
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393142Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804472}

Lookup local() fonts from Android downloadable fonts and the GMS core
provider. Instantiate Mojo connection to the Java side, send IPC
requests for font lookups this way.

Requires
https://chromium-review.googlesource.com/c/chromium/src/+/2347916 and
https://chromium-review.googlesource.com/c/chromium/src/+/2375329.

Bug: 1115064
Change-Id: Ibb0112f9df3f75003a91d880a1476a6f6087a942
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387017Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804471}

This reverts commit e413add4.

Reason for revert: This approach is wrong. A much simpler approach is now being implemented in 
https://chromium-review.googlesource.com/c/chromium/src/+/2391798

Original change's description:
> [ios] Add ScreenTime overlay modality
> 
> This is one of a series of CLs to implement ScreenTime.
> 
> This CL:
> * Adds a new overlay modality above the web content area for the
> ScreenTime blocking view overlay
> * Adds and integrates no-op supported overlay coordinator classes.
> 
> Bug: 1123704
> Change-Id: Idee3417df9dee7cd15b8fcc93e4ee6944a5e530e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386535
> Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
> Commit-Queue: edchin <edchin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#803274}

TBR=michaeldo@chromium.org,edchin@chromium.org,thegreenfrog@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1123704
Change-Id: If19b96825b7788cbdaa77b8e505278d049807814
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390839Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804470}

Storing a purely physical offset was problematic when in vertical-rl
writing-mode, if the viewport size changes.

We were storing the X coordinate relative to the left edge of the
visible contents inside the scrollport. However, in vertical-rl
writing-mode the block-start is at the right side of the scrollport.

If the viewport width changed, the distance from the left edge to the
anchored element would also change, even though the scroll offset
remained exactly the same, and we'd mess up the scroll offset.

Bug: 1124195
Change-Id: Id91a25012da2d0cbd803e543b6cb02ba66eb20e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390380Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804469}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c81f39950ebf..583b1e36f36b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC btolsch@google.com,nicolaso@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1099917,chromium:1101058
Tbr: btolsch@google.com,nicolaso@google.com
Change-Id: I31cc4ea9f57f28de55a11a5a65a1a6bfd339b02f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393052Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804468}

The ScopedResultPtr returned by GetResultAs<> needs to go out of scope before
CheckGLError can be called, when GL_CLIENT_FAIL_GL_ERRORS is set.

Bug: 1120712
Change-Id: I5f5c83ba9deb6cb161e875037a4269b67119ab4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391599Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804467}

See go/chromevox-touch-gestures

R=akihiroota@chromium.org

AX-Relnotes: Adds four finger swipe for ChromeVox to move among on-screen panes (launcher, status tray, web page, etc).
Bug: 1124454
Test: browser_tests --gtest_filter=ChromeVox*.SwipeLeftRight*
Change-Id: Ie8a98c53d456e3a2e632f4307622494f8f82f3e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379458
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804466}

Ensure that the test launcher can run a test multiple times in parallel
to enable us finding flaky tests faster.

Also add documentation for --gtest-repeat and --gtest-break-on-failure.

R=erikchen@chromium.org
BUG=976795

Change-Id: I767a618fda6ad8f7424b43b0bf1a06b5238f127a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667313
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Ilia Samsonov <isamsonov@google.com>
Cr-Commit-Position: refs/heads/master@{#804465}

https://android.googlesource.com/platform/external/perfetto.git/+log/5383c636752f..f39c62ab1284

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I30f877fbbaf600dfb46b64a051a9e6c55e840b5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392627Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804464}

Removes |listener_| from the internal implementation, but still
providing set_listener() that wraps a ButtonListener* in a callback.

Removal of ButtonListener will be piecemeal as there's about 500
references to it, though I intend to continue until it's gone.

Bug: 772945
Change-Id: I9ff386b40a75bee58adba5c4ad9a3304a2c69d4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392436
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804463}

Update PDFiumEngine to use gfx::Rect instead of pp::Rect. Update
callers to expect gfx::Rect as return value instead of pp::Rect.

Noteworthy points:
- In pp::Rect, Subtract() is a utility methods which takes in two
rects and returns the subtracted rect. Whereas in gfx::Rect, Subtract()
is a member method which modifies the rect in-place. All usage of
Subtract() which are replaced in the CL modify the rect in-place.
- In pp::Rect, Intersect() is a utility method which takes in two
rects and returns the intersected rect. The counterpart in gfx::Rect
is IntersectRects() and not Intersect().

Bug: 1101101
Change-Id: Ib071e3a987c2c234b8e2348744700f9cf07edc96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379397Reviewed-by: K. Moon <kmoon@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ankit Kumar 🌪️ <ankk@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#804462}

This reverts commit 590a8d43.

Reason for revert: Suspect cause of inspector-protocol/emulation/set-vision-deficiency.js failures: https://test-results.appspot.com/data/layout_results/linux-bfcache-rel/8184/blink_web_tests/layout-test-results/results.html

Original change's description:
> Set SVGExternalDocumentCache::Entry::document_ eagerly in NotifyFinished()
> 
> Currently, we lazily initialize document the first time it is requested
> *and* all of the data is loaded (https://crbug.com/1107442 fixed a case
> where we would incorrectly initialize the document by creating it before
> all of the data had been received).
> 
> It's much clearer to just initialize the document when all of the data
> is received, and have GetDocument() be a simple getter.
> 
> Change-Id: I830dca5cc953ca8467fd936f5c783db21cfce051
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316415
> Commit-Queue: Nate Chapin <japhet@chromium.org>
> Reviewed-by: Fredrik Söderquist <fs@opera.com>
> Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#804325}

TBR=fs@opera.com,japhet@chromium.org,kouhei@chromium.org

Change-Id: Ib838f8e42475020ceb83f8aa841d1ad077d705bd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393159Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804461}

This change adds ellipsis and a tooltip to the print preview destination
dropdown for long printer names.

http://screen/xgSumv9ZVxHzyEo

Bug: 1059607
Change-Id: Ic1bacba02737a873550817e261be70345ead0c57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391927Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804460}

This bot runs WPT so needs H264 enabled as well.

BUG=chromium:840659,chromium:1103214

Change-Id: I9962b9f7618c9db663a8a4f26b539801c74b8c4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362795Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804459}

This CL is generated with export script.

Bug: internal b/166313191
Test: None
Change-Id: Ib76dd0731824f32ec265234c4e160fefc1195008
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392915Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Guohui Deng <guohuideng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804458}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d86bb475521a..66d4faca55b5

2020-09-03 changhaohan@chromium.org Refactor away externally adding property onto imported object

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I4e74dd01ed40d7f77ec62a4bd0e45966fcdb829d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393140Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#804457}

Attempting to re-enable all WebGL tests associated with fixed ANGLE issues

Bug: chromium:1099961, angleproject:3701, angleproject:2103
Bug: angleproject:2909, angleproject:2722
Bug: angleproject:2915, angleproject:2898, angleproject:3766
Bug: angleproject:2046, angleproject:5014, angleproject:1506
Bug: angleproject:4986, angleproject:5015
Change-Id: I9999eef4f7f15282d0fa8abd3d31de52475a7b65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392980Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804456}