- 12 Nov, 2019 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2c237069. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 15c6f4fb "Add Web Platform Tests for the Split Cache" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dtapuska@chromium.org: external/wpt/uievents foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure hbos@chromium.org, hta@chromium.org: external/wpt/webrtc jochen@chromium.org, estark@chromium.org: external/wpt/referrer-policy jsbell@chromium.org: external/wpt/resources mcasas@chromium.org: external/wpt/mediacapture-record mkwst@chromium.org: external/wpt/mixed-content external/wpt/upgrade-insecure-requests nzolghadr@chromium.org, yosin@chromium.org: external/wpt/input-events rego@igalia.com: external/wpt/css/css-grid skobes@chromium.org: external/wpt/css/css-scroll-anchoring NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I4b58bae1435a1f27fd19e60813dd0ac3da504120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911241Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714396}
-
Carlos Caballero authored
Allocators must return memory that is aligned at least as strictly as std::max_align_t. So make sure we do not ask for more, otherwise we risk getting misaligned memory in heap allocations. For more context, see discussion in https://crrev.com/c/1648176/18/base/task/promise/dependent_list.h#61 Change-Id: I91d69844e9a83899f3a9453f0e060a9779b40028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810960Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#714395}
-
Ian Kilpatrick authored
The first-tier OOF-cache attempts to skip all the OOF sizing and positioning work required, as the other cache simply compares the constraint spaces which can be (relatively) expensive to determine. This first-tier cache works by comparing the available-size given to the OOF-positioned descendant. If equal we can skip the OOF-positioned sizing and positioning steps. This mostly worked, however had an issue where the containing-block may have added/removed a borders/scrollbars, but the available-size given remained the same. This resulted in an incorrectly positioned OOF-positioned node. This fix disallows the first-tier cache when borders/scrollbars are present. This is sufficiently rare that this cache still has a relatively high hit-rate and is still relative cheap to calculate. Bug: 1013866 Change-Id: I71d41d2c4b47bcff6412f395db2deabf2f6f3a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891768 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#714394}
-
Keishi Hattori authored
This reverts commit 3ee16746. Reason for revert: HeapTests are failing crbug.com/1023716 Original change's description: > [Fuchsia] Stop enabling shadow-call-stack explicitly > > shadow-call-stack is enabled by default on Fuchsia now, so we no longer > need to enable it explicitly. > > Bug: 821951 > Change-Id: I221bc557bf93dfd5bf7c1659f7f8dfc32129c6b1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898631 > Commit-Queue: Wez <wez@chromium.org> > Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714312} TBR=wez@chromium.org,sergeyu@chromium.org Change-Id: I7e8467363407c8ce1738ae83f31e7c543d3e9144 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911066Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#714393}
-
Evan Stade authored
Bug: none Change-Id: I2fddbc42b7a42e4c312c30dbd533fe92a6fb7d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910876Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#714392}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I9d4cd05623b53d3499e002de2e51ca9bb88afc87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911640Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714391}
-
Manu Cornet authored
This is used (and will be used more) to give observers updates about the home launcher position (within the animation / drag) and not just updates about what the expected target position is, so the new name is a little more informative. It's hard to predict what the "target" position is anyway, since during a drag the user can easily go back and forth. This is a pure rename (plus some comment updates) and has no expected user-visible impact. Change-Id: I8eb8d039e3cc33a43a4fa9760dcb332e15a83e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910768Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#714390}
-
Ken Rockot authored
This doesn't need to exist anymore; it wraps two separate sequences (one "primary" and one for "commit") yet DOM storage implementation now only uses one of them. It's effectively a thin wrapper around a SequencedTaskRunner which provides no additional functionality. Bug: 1000959 Change-Id: I178a9ee254232cc73b0b89e1ed2c588b23266ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900538 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#714389}
-
Finnur Thorarinsson authored
This will control whether we show contact images in the UI. Later, it will also control whether we pass these images down to the web page. Bug: 1020564, 860467 Change-Id: Idbed174e9d53a1bee591eb50864cd8a571f71b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905986Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#714388}
-
Keishi Hattori authored
This reverts commit 031922a6. Reason for revert: RemoteCopyBrowserTest.ImageUrl is failing crbug.com/1023709 Original change's description: > Add image support to Remote Copy. > > Bug: 1018138, 1018132, 1020582 > Change-Id: I50d131ec34ccee3bf5b76167178eac4728b51bea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903203 > Reviewed-by: Richard Knoll <knollr@chromium.org> > Reviewed-by: Darwin Huang <huangdarwin@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714193} TBR=mvanouwerkerk@chromium.org,mastiz@chromium.org,mkwst@chromium.org,huangdarwin@chromium.org,knollr@chromium.org Change-Id: Ia5f3ffae72f8812b7caf0c678bc17a65e92c89a9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1018138, 1018132, 1020582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911063Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#714387}
-
W. James MacLean authored
When an inner WebContents is fullscreen, and has focus, pressing <esc> causes the keyboard event to be handled by that webcontents. But it should instead be handled by the outermost WebContents so that it can get to the appropriate delegate. Bug: 1013640 Change-Id: I4ff81bea8cd9fa43259dde39b3bc479f6fd06f07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896771Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#714386}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=gbiv@chromium.org Change-Id: I2d4565a1bc8c9a7d8f72812f1ae2905347fd7404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910751Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714385}
-
Manu Cornet authored
Also rename "animation state" to "transition state" since this also represents drag state. Bug: 1012760 Change-Id: Ic890be82ddd4cb713759c07985cc7e4b1210b029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910761Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#714384}
-
Ryan Sturm authored
Add PreconnectOnDidFinishNavigation entry to field trial testing config. The 3 second arm is chosen as it is the most likely to launch. Bug: 1016553 Change-Id: I84250e6d4ef55edc988de2edf2a2c873dd61d22f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900470Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#714383}
-
Tommy Steimel authored
This CL allows the user to click and drag a media notification out of a MediaDialogView and into an always-on-top overlay. This allows the user to continue to control media without having to go back to the dialog. This feature is put behind a disabled-by-default flag. Bug: 1022452 Change-Id: Ifd4b837c5b2407c886a9b16403d15f710e38db0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904158 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#714382}
-
Nick Burris authored
Adds more web platform tests for scroll to text: - Combination of non-text directive and text directive - Scroll second text directive into view if first doesn't match - Matching shadow DOM - Don't scroll to hidden text - Text that requires a horizontal scroll into view - Also fixed non-ASCII test case (and changed to Japanese example) Change-Id: Id7e21a185897267dc565b19adc7bfdfb5fe70974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903624 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#714381}
-
sczs authored
Creates and configuresthe necessary items to populate the SaveCard Modal and adds placeholder methods for their actions. Screenshot: https://drive.google.com/open?id=1VOFTyTGYyOAXp_dI0ZEkiAg6SP-rv8bd Bug: 1014652 Change-Id: I231b19781a5f7142a2c4096f995450aace2f833b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907210Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#714380}
-
Michael Spang authored
Many data members are not const but can be, especially pointers. Make them so. Change-Id: I82a1e3ab26507eaa88e239847eff84b24f7198b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876984Reviewed-by:
Sean O'Brien <seobrien@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#714379}
-
Makoto Shimazu authored
Clients restricted by COEP header should not get opaque responses. Service workers need to respect a COEP value for the client which dispatches a FetchEvent, otherwise the client can fetch opaque responses through a service worker. This CL is to propagate the COEP header to the service worker. Each service worker has connections to the clients, and this CL tries to bundle the Mojo endpoint for subresource fetch events on the service worker side with its COEP header. In a following CL, I'm going to add code to respect the value before responding to the clients. Bug: 999049 Change-Id: Ic92bde114c361e53ddef0951ec0d7224c525e624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895253 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#714378}
-
Livvie Lin authored
Bug: 1008219 Change-Id: If02a36539fe61e71d1434528ec5af31d3914439b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889116 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#714377}
-
Morten Stenshorne authored
And enable fragment painting for multicol containers. Rules are to be painted "just above the border of the multicol container" [1]. At the same time, "the rules need to scroll along with the columns" [1]. Hence, we'll paint it as the first item in the foreground phase, so that we get scroll offsets applied. [1] https://drafts.csswg.org/css-multicol/#column-gaps-and-rules By enabling fragment painting for multicol containers, we break one outline test. The fix is easy, but I'd rather deal with that in a follow-up. Bug: 829028 Change-Id: Ie5e4ac267967f185a588bfc36f1902a2b1659413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899784 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#714376}
-
John Budorick authored
Bug: 1023475 Change-Id: I7df21c024c5459d8fc615e5d33ade559dd16e70b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910863 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#714375}
-
James Cook authored
This fixes a regression introduced by the split settings project. The window frame menu for settings, when multiple users are logged in, is not supposed to show the "Teleport" menu item. This broke because the WebUI URL for the Settings window content changed. Fix by using SettingsWindowManager to detect if a Browser* is the settings window, which is the canonical way of doing it. Bug: 1023043 Test: added to browser_tests Change-Id: Ib79bcfd6c6206773d12377640f476d3b76652182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910760Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#714374}
-
Simon Que authored
This is currently set to use the RBE backend via the recipe config. Specify it in the builder config instead. Bug: 1022800 Change-Id: I27955c8012682847987c65daec9d2de64898369c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906460 Auto-Submit: Simon Que <sque@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#714373}
-
Noel Gordon authored
Add files20 (20px files-ng) <iron-icon> set. Add external-link icon, and eject icon, as initial members. Bug: 992819 Change-Id: I12f9e228f404bc68cfa8d998feae249a6bfe40cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906459Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#714372}
-
Lambros Lambrou authored
This allows an optional callback to be notified whenever the user completes or cancels the wizard. Bug: 1015201 Change-Id: I93cfa973518b40a840dc20068de5e44636b3806a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907769 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#714371}
-
Lan Wei authored
In Webdriver spec, it has an example: https://www.w3.org/TR/webdriver/#example-11 that the source has a pause action, which means that the source does not have any action at this tick. Currently we only have a pause action for none source type, we should have the pause action for the key and pointer types as well as per web driver spec: https://www.w3.org/TR/webdriver/#dfn-pause For example: let actions = new test_driver.Actions() .addPointer("touchPointer1", "touch") .addPointer("touchPointer2", "touch") .pointerMove(10, 0, {origin: test1, sourceName: "touchPointer2"}) .pointerMove(0, 0, {origin: test1, sourceName: "touchPointer1"}) .pointerDown({sourceName: "touchPointer1"}) .pointerDown({sourceName: "touchPointer2"}) .pause(0, "pointer", {sourceName: "touchPointer1"}) .pointerMove(0, 10, {origin: test1, sourceName: "touchPointer2"}) .pointerUp({sourceName: "touchPointer1"}) .pointerUp({sourceName: "touchPointer2"}); Bug: 1020674 Change-Id: Iacd2811a91bc26d273cd9589a96e0a377941d79c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900650Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#714370}
-
Xiaohan Wang authored
Currently we have PipelineImplTest.NoMessageDuringTearDownFromError test which is supposed to test the case where after OnError(), new calls to PipelineImpl won't post tasks to the media thread. However, in the implementation an error during pending seek won't call OnError(), so the action that does this check isn't triggered at all. This has been indicated by test coverage bot and pointed out by liberato@ during code review (Thanks!). The fact that we use On_CALL instead of EXPECT_CALL hides this problem. After fixing the test by actually triggering this check after Stop() caused by the seek error, the test is still failing, because we actually didn't prevent posting tasks to the media thread in SetPlaybackRate() and SeVolume(), which is the expected behavior after discussion. We could try to call Seek() again and check that it doesn't post a task, but that's partially covered by the existing SeekAfterError test. Also, we probably shouldn't test whether a task is posted or not, which is purely implementation detail. With that, this CL removes the NoMessageDuringTearDownFromError test. It also updates other related tests to make sure SetPlaybackRate() and SetVolume() are allowed to be called before Start(). Bug: 1018372 Test: Fix and remove existing tests. Change-Id: I6e42cc8f7e3a187c31713423adb9b5a2501214a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906755Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#714369}
-
rbpotter authored
Change the bookmarks Web UI to use a browser proxy for communication with C++. Also update tests to use a test version of the proxy instead of registering test message handlers in C++. Bug: 1022213 Change-Id: I7a824d51e1fdaa02e57baa44c555c634f8e230b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906959 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#714368}
-
Scott Violet authored
BUG=none TEST=none Change-Id: I6136929a4d056884650ded2e715d2109314ca97c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903621 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#714367}
-
Aleks Totic authored
Legacy table algorithm looks at the surrounding table. It assumed surrounding table was legacy too, which does not hold in TablesNG. It is only called by Legacy code, and will not be used once TablesNG is done. Because of this, instead of implementing IsLogicalWidthAuto on TableInterface, I just inlined it at call site. LayoutTable: :IsLogicalWidthAuto method belonged to LayoutTable. Change-Id: Ie4e174aeb01e8b6c51587dc8b77819fee4eb981c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906124 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#714366}
-
meacer authored
A previous CL disallowed these characters when surrounded by non-CJK characters on both sides (crrev.com/1659678). This CL prevents more spoofs by not allowing these characters to mix with non-CJK. Change-Id: I126bf57d797593013b2bf421032c5642e42f2c2f Bug: 990428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910762Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#714365}
-
Keishi Hattori authored
This reverts commit 76367552. Reason for revert: Suspecting HeapGraphWalkerTest.AllGraphs failure crbug.com/1023685 Original change's description: > Roll src/third_party/perfetto 7980e5ea3e34..51516f076308 (4 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/7980e5ea3e34..51516f076308 > > git log 7980e5ea3e34..51516f076308 --date=short --no-merges --format='%ad %ae %s' > 2019-11-11 fmayer@google.com Merge "Do not count roots as unique_retained." > 2019-11-11 rsavitski@google.com Merge "compact_sched: remove "unstable" notices" > 2019-11-11 rsavitski@google.com Merge "compact sched_waking: event decoding in trace_processor" > 2019-11-11 rsavitski@google.com Merge "compact sched_waking: writer (traced_probes)" > > Created with: > gclient setdep -r src/third_party/perfetto@51516f076308 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > TBR=perfetto-bugs@google.com > > Bug: None > Change-Id: I85e20b4475481af1fd2c2c1eaca3b224e6cbba8e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910168 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#714258} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: Idd397943cbe6966334287367966081845b1ba2b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910980Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#714364}
-
George Burgess IV authored
This CL hooks up Tricium to our clang-tidy Tricium bot. This is intended to be a nop for ~everything, since our current clang-tidy recipe does nothing if `author != gbiv || !is_special_commit_message()`. Bug: 633856 Change-Id: I0f3e782c50e5284cbfc2b02bb226e58153c192d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896035Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#714363}
-
Kent Tamura authored
wpt-importer doesn't work well now. TBR=rakina@chromium.org Bug: 985637 Change-Id: I4aeedb0fcb5c144e8dc4fb1b8856af1fe9a7d942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910979 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#714362}
-
Koji Ishii authored
Following bot results are included. 234 235 236 237 238 243 248 249 251 8 lines were removed and 3 lines were deflaked by consecutive results since 225. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Id5c91e469f2e4491ac83ac22ea569ab7cb536cc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909047Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#714361}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f18ff947360d..e33c1582b4bc git log f18ff947360d..e33c1582b4bc --date=short --no-merges --format='%ad %ae %s' 2019-11-11 shrekshao@google.com Fix EXT_texture_norm16 2019-11-11 jmadill@chromium.org Windows: Use Job handle in LaunchProcess. Created with: gclient setdep -r src/third_party/angle@e33c1582b4bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: chromium:1000354 Change-Id: Ic112129a3b66a3bd14f1b70e5cd318f1aed1a085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909811Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714360}
-
Andrew Luo authored
Bug: 1021665 Change-Id: I6de2e17733078cb0f433ecc20b42f11c0e2cb521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902768Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#714359}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/3c086a0c2e1d..cfc9c6e322f4 git log 3c086a0c2e1d..cfc9c6e322f4 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 enga@chromium.org Make perf test tracing thread-safe 2019-11-11 yunchao.he@intel.com Implement readonly storage buffer - validation at shader side 2019-11-11 yunchao.he@intel.com Tiny fixes for BindGroup/BindGroupLayout tests 2019-11-11 rharrison@chromium.org Another spvc API migration Created with: gclient setdep -r src/third_party/dawn@cfc9c6e322f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I819bf88462f4408c6246beb3540f150a54f6361b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909817Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714358}
-
Martin Barbella authored
Bounds was previously disabled due to an UBSan bug that caused problems in yasm, but this no longer reproduces. Change-Id: I3e06cea5ce51ff44ecc2171c05ceea29a40ec83b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906905 Commit-Queue: Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#714357}
-