- 12 Dec, 2019 40 commits
-
-
Peter Kasting authored
Bug: 621004 Change-Id: Ifd6d657ad51f67f4cf7f3714ac9f3fbd58fe2e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939840 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#724096}
-
Michael Liao authored
DevTools [Common - Data Grids - Test Fixes]: temporarily disabling tests to check in data grid naming change Disabling tests to check in this CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1891652 Re-enabling and fixing tests in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1894036 Bug: 963183 Change-Id: If06f87d8b7b8349ce561d1acc06f8561c091baab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894472Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Michael Liao <michael.liao@microsoft.com> Cr-Commit-Position: refs/heads/master@{#724095}
-
Oriol Brufau authored
If an element has some styles for its ::marker pseudo-element, expose them in the Styles panel when the element is inspected. Bug: 1876407 TEST=http/tests/devtools/elements/elements-panel-styles.js Change-Id: I56ab2703925966535beb71e0e47ab814c7ee07a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932447Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#724094}
-
Natalie Chouinard authored
The ChromeBrowserInitializer.OnNewVersionAvailableCallback interface is unused. Clean it up. Change-Id: Ieeccd9d194b1fa34a8fb6b8db83bd5e79d84a2ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959374Reviewed-by:
Gang Wu <gangwu@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#724093}
-
Julie Jeongeun Kim authored
This is a part of effort for using [RaisesException] when synchronously rejecting a promise. It uses ExceptionState instead of using ScriptPromise::RejectWithDOMException from //third_party/blink/renderer/modules/push_messaging. Bug: 1001114 Change-Id: I869b7d465b9f0c2db70dc8a02171a04d8ec7950c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960086Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#724092}
-
Alan Cutter authored
This CL enables PWAs to check for and perform updates to their manifest given differences in site manifest data on user navigation. This was shipped on Chrome OS in M79 and is now being shipped for Linux, Mac and Windows for M81. Bug: 926083 Change-Id: I33da3ddbeaa70d05d99aa704fca7b1888867426a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961354Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#724091}
-
Carlos Knippschild authored
Change-Id: Ia05d04a3fcc5b4f24ecda9354835fb625ac6cdfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962995 Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#724090}
-
gogerald authored
Closes the current tab and shows the start surface if the tab is created from the start surface via omnibox or mv tiles and has no navigation history. Note that tabs created via menu are still behave the same as before. Screenshots: https://drive.google.com/a/google.com/file/d/1VtTZ7d2PkgvTnlgoWPBOYHZ6qizm081c/view?usp=sharing Bug: 1005928 Change-Id: I02f595b96b1727007110c3e84d18f8aeea7400d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957126Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#724089}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/49135f689abd..3c75d244d6f9 git log 49135f689abd..3c75d244d6f9 --date=short --first-parent --format='%ad %ae %s' 2019-12-11 ynovikov@chromium.org Suppress more dEQP-GLES31.functional.shaders.helper_invocation.* tests 2019-12-11 jdarpinian@chromium.org Presubmit check forbidding tab characters in source files. Created with: gclient setdep -r src/third_party/angle@3c75d244d6f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliot@google.com Change-Id: I62c1f6885c9a74ea219b00c4e76ba9332ba6190a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963143Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#724088}
-
Robert Kroeger authored
TBR=ynovikov@chromium.org Bug: https://crbug.com/1026468 Change-Id: Idad969bdaed496e954e0d0e2885757e8ef439699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962604Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#724087}
-
Oystein Eftevaag authored
The writer would always end up being initialized in WriteBytes regardless, but this prevents ClusterFuzz from throwing up false alarms due to non-zero offsets being applied to a null pointer. R=eseckler@chromium.org Bug: 1031563 Change-Id: I3c938bc388194889fa7b7562c30c7d156000fce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962982Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#724086}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/812a14697dd6..8b34eb4d1e76 git log 812a14697dd6..8b34eb4d1e76 --date=short --first-parent --format='%ad %ae %s' 2019-12-11 iannucci@chromium.org [goma_ctl] Use vpython to call goma_ctl.py. Created with: gclient setdep -r src/third_party/depot_tools@8b34eb4d1e76 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1033106 Tbr: agable@chromium.org Change-Id: Ie64083fec9c1d24229efef11bc609a2e3a48cedd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963146Reviewed-by:
-
Khushal authored
Remove all non shared image mailbox handling in AcceleratedStaticBitmapImage and associated classes, since we can assume that it should only be created with shared image mailboxes. R=kbr@chromium.org Bug: 962630 Change-Id: Ie6ce6fcd21b724580d7b40a3f2188ed46cd8ec17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963221 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#724084}
-
Julie Jeongeun Kim authored
This is a part of effort for using [RaisesException] when synchronously rejecting a promise. It uses [RaisesException] for //third_party/blink/renderer/modules/background_sync. Bug: 1001114 Change-Id: I6146006633aa4147f8682b73e2e268ee5b11b63c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958555Reviewed-by:
-
kylechar authored
The VizDisplayCompositor feature is now launched on all platforms and the display compositor will no longer run in the browser UI thread. Most of content/browser/compositor/ can be removed as a result. Bug: 1016916 Change-Id: I85b5392034cc4f4ee523bf1fb0974635b8b5f58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962305 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#724082}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1159fec7d02e..ca272f22c8a6 Created with: gclient setdep -r src-internal@ca272f22c8a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:984162 Tbr: jbudorick@google.com Change-Id: I1c4cb2585793ee2f982f3fabecbb15a03a1429e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963145Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#724081}
-
Julie Jeongeun Kim authored
This CL partially converts arc::mojom::PrinterDiscoverySessionHost and arc::mojom::PrintJobHost to new Mojo types using PendingReceiver and Receiver. It still keeps CreateDiscoverySessionCallback and PrintCallback with InterfacePtr from //components/arc/mojom/print.mojom with since arc mojom files are shared with other repo and it doesn't have new Mojo types yet. Bug: 955171 Change-Id: I7e41271540b5bbdd14d2d5de76accac0891f9223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955895Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#724080}
-
Chris Hall authored
R=akihiroota,dmazzoni Change-Id: Ic0df79abe512032783523f66d31b6afbeec560d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959908Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#724079}
-
Ben Pastene authored
This arg never changes among all supported CrOS device builds of Chrome. By giving it a proper default val in those builds, we can reduce the amount of inputs needed when building for CrOS (ie: simple chrome & chromeos-chrome ebuild). Bug: 937821 Change-Id: If383391938d84d4f584854ceb7c44428c3aa094b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962796Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#724078}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/280b96ea8de3..af094e6a88d0 git log 280b96ea8de3..af094e6a88d0 --date=short --first-parent --format='%ad %ae %s' 2019-12-11 sarahmashay@google.com Adding SPVC fuzzers 2019-12-11 bryan.bernhart@intel.com D3D12: Fix 64-bit overflow for large buffers and return OOM. Created with: gclient setdep -r src/third_party/dawn@af094e6a88d0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Iec3f6ab6fb03ac0ae92363bfc5f14239c6a26dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963140Reviewed-by:
-
Mason Freed authored
Prior to this CL, any feature marked "test" in runtime_enabled_features.json5 could not be disabled for web_tests without extra work. This includes attempting to disable via command line flags passed into run_web_tests, or more seriously, through a VirtualTestSuite that attempts to disable the feature for testing. The problem was that renderer features were enabled first for command line flags, and then enabled for any features marked "test". Therefore, any command line flag that tries to disable a "test" feature will get overridden, and the feature will be left enabled for testing. In this CL, the order of those two initializations is reversed: first enable any "test" features, and then handle command line flags. Note that in two cases (portals and ARIA) the command line flags were set to kUseFeatureState, which meant that those "test" features would be re-disabled if the explicit command line flag was not present. As both flags are named "EnableXyz" they should likely use kEnableOnly instead. Change-Id: I50a0f498b93520fd23e7c5bcd6d1e19680006236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960985Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Ken Rockot authored
This is a reland of 008b7265 Was reverted for breaking ARC boot by breaking access to display configuration information. The re-land fixes initialization order between ArcServiceLauncher and ash::Shell, as this CL requires the latter to be initialized first now. Original change's description: > Move Ash off Service Manager > > This removes all dependences on the Service Manager from within Ash and > clients of Ash. The "Ash Service" is deleted, and the few interfaces > which the browser bound through it are now bound through a handful of > public helper functions that route through Shell. > > The only service interfaces used from within Ash are from the > Device Service, and those are now acquired through ShellDelegate. > > Bug: 977637 > Change-Id: Ia117241f4adddd14303176af78075d0df6c5b563 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956160 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#723475} Bug: 977637 Change-Id: I508db8acedc45792a947a4b015f47e1caeb08ace No-Presubmit: true Tbr: sky@chromium.org Tbr: tsepez@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961273Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#724075}
-
Peter Kasting authored
This is mostly to shorten code I was touching anyway or reduce diffs in the later patch. There is one behavior change here; the code to ignore custom theme NTP background colors in incognito was also bypassing the GTK theme, which doesn't appear to have been the intent. Limited this case to just custom themes. The custom tab bar code changes from NativeTheme::GetInstanceForNativeUi() to GetNativeTheme(), but since this is happening in the constructor, those will always return the same thing. Bug: none Change-Id: Ie9d490669c9bff474484294a630f0f6b37d25d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961012Reviewed-by:
-
Livvie Lin authored
This reverts commit b5a5de57. Reason for revert: The issue addressed by this CL should be addressed with a different approach. Original change's description: > [Desktop/Android] Prevent security icon downgrade to triangle on URL load > > Bug: 1031532 > Change-Id: I3bb24e86c146ee86f5eb6d4795b0b5397542d100 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959412 > Reviewed-by: Tommy Li <tommycli@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Livvie Lin <livvielin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#723472} TBR=mthiesse@chromium.org,tommycli@chromium.org,livvielin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1031532 Change-Id: I416e7a7fd718437747679edafd2b5eb165fe2cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962601 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#724073}
-
Ben Pastene authored
This arg never changes among all supported CrOS device builds of Chrome. By giving it a proper default val in those builds, we can reduce the amount of inputs needed when building for CrOS (ie: simple chrome & chromeos-chrome ebuild). Bug: 937821 Change-Id: I8191fe2a2a6d910ceeec8fba90c43f199a753ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963135Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#724072}
-
Melissa Zhang authored
This reverts commit cf8da83e. Reason for revert: Suspected to be causing https://ci.chromium.org/p/chrome/builders/ci/mac-chrome/35 Original change's description: > Convert //chrome ObjC Instance Variable Names From Trailing to Leading Underscore > > Clang-Tidy performed all of the transformations in this change. > > BUG=1030028 > > Change-Id: Icdf3d24e4c7add6718227db0e112b3f374ce8a35 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959394 > Commit-Queue: Robert Liao <robliao@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#724037} TBR=thakis@chromium.org,robliao@chromium.org Change-Id: I42c1972e2ed3e50892698b39d3a054838dabae5b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1030028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961868Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#724071}
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_partyb/blink/renderer/modules/speech only when it meets the policy of removing Create(). Then, this CL makes all callers use MakeGarbageCollected<Foo> instead. This CL removes below factory functions, - SpeechRecognitionController::Create - SpeechSynthesisVoice::Create - SpeechRecognitionAlternative::Create Bug: 939691 Change-Id: Ieb586730ca358e01e50105cf3f2b5987ea256b8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961288Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3517aa7b14ad..a5909925e3a8 git log 3517aa7b14ad..a5909925e3a8 --date=short --first-parent --format='%ad %ae %s' 2019-12-11 herb@google.com Remove unused buffer call for SkGlyphRunPaint 2019-12-11 mtklein@google.com roll clang to 9.0 Created with: gclient setdep -r src/third_party/skia@a5909925e3a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: I8df1ca9a5de3df24c328e22b999d63683be57f67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963142Reviewed-by:
-
Xiaocheng Hu authored
When re-serializing sanitized clipboard markup, not all elements need an inline style. For example, SVG <foreignObject>. We should not try to strip UA style from their inline styles as otherwise it crashes. Bug: 1032389 Change-Id: Idedc98a09fd5503281dd6c7354b4df78368a8e0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962977 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
Removes debug messages that accidentally made their ways into repository. Change-Id: I70580672bf215d0feb1d5c2072c19cf2e68d1302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959198Reviewed-by:
-
tby authored
This makes all OWNERS of search_result_ranker/ also OWNERS of: - drive_quick_access_provider* - drive_quick_access_result* - zero_state_file_provider* - zero_state_file_result* Change-Id: Ib76b25974c874367e0e94d27847d03e142a657b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961447Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#724066}
-
Esmael El-Moslimany authored
I change the value for testing and submitted the change. https://chromium-review.googlesource.com/c/chromium/src/+/1935930 Bug: 1030181 Change-Id: I3c1f4e83bf9acc84ebfce32564b6568a361526bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963199 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#724065}
-
Ben Pastene authored
This arg never changes among all supported CrOS device builds of Chrome. By giving it a proper default val in those builds, we can reduce the amount of inputs needed when building for CrOS (ie: simple chrome & chromeos-chrome ebuild). Bug: 937821 Change-Id: If370ec73383201f80efc9a7e97c73f07739ddcb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963097Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#724064}
-
Ayu Ishii authored
This changes the ownership of SmsProvider from BrowserMainLoop to SmsFetcher. This infrastructure change that will help with implementation of the autofill version of sms receiver. Bug: 1026373 Change-Id: I0f50f90a3d4b7a72443b0a6639d7d12d25ffaeb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960068Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#724063}
-
Natalie Chouinard authored
Rename several XML resources from "preferences" to "settings" to adhere to the naming conventions decided in go/clank-preferences-refactor. Note that resources related to individual settings screens are not being renamed in this CL, and will instead be renamed with each preference fragment refactor. Bug: 1029146 Change-Id: I26cbeb868a6691f616583df14cc8c1e017638505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947810Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#724062}
-
sczs authored
TBR=rohitrao@chromium.org Bug: 1033214 Change-Id: I616339bdcd8a9a1995861475eace70081ef4598d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962603Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#724061}
-
Tom Anderson authored
On environments that do not have GTK settings for the cursor theme/size such as KDE, we would set the cursor theme name to "", and the cursor size to 0. The theme would be fine, but the cursor could appear too small on HiDpi environments. The solution is to avoid making any XcursorSet* calls if the settings are not present. BUG=1021819 R=sky Change-Id: I993e356358981abe22649faa673f234c526ff654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962710 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Tommy Li authored
Currently, clock icon matches are not given any particular preference during de-duplication. This can cause the clock icon to disappear as the user types, if say, a higher search-what-you-typed entry comes in later with a higher relevance score. This can also cause user confusing, as the user may wonder: Huh, I thought I already searched that, why doesn't it have a clock icon? Or - why can I delete a plain search match? This CL gives the final match the specialized search history type. Bug: 1033109 Change-Id: Ie9adaf6345d74d234dd9e1b02a01b10b343b52fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962909 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#724059}
-
Melissa Zhang authored
This reverts commit 2898ec18. Reason for revert: likely causing https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29 and https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29 Original change's description: > viz: Split OverlayProcessor into Windows and Mac Subclass. > > OverlayProcessor class is used for both Windows and Mac, and the only > difference is in it uses different overlay candidate validator classes. > The validator classes implementation are simple, and achieve the same > effect with splitting OverlayProcessor into Mac and Windows subclass. > > This allows us to delete OverlayCandidateValidator and its Mac subclass > and its Windows subclass. > > This is CL 6/? of overlay processor refactor. > > R=rjkroege > TBR=kylechar > > Bug: 963597 > Change-Id: I78265a8941720daa32cbd672ef85c7a547938b8d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953824 > Reviewed-by: weiliangc <weiliangc@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Commit-Queue: weiliangc <weiliangc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#723971} TBR=rjkroege@chromium.org,weiliangc@chromium.org,kylechar@chromium.org Change-Id: I7f97902903f14d9822ab464923679be1c14aee9c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 963597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962134Reviewed-by:
-
Kyle Horimoto authored
This CL: (1) Causes the UI to expand to the width of the container when in small-screen mode. Previously, it was constrainted to a smaller width. (2) Reduces padding in some places to line up with mocks provided by elizabethchiu@. (3) Moves the "features vary" footnote slightly higher to reduce the overall height of the setup flow UI so that it fits within OOBE on small-screen devices in landscape mode. Screenshots: Small screen, dialog, portrait: https://screenshot.googleplex.com/jMgbFewcrAH Small screen, dialog, landscape: https://screenshot.googleplex.com/QyiVuuCOY4s Small screen, OOBE, portrait: https://screenshot.googleplex.com/OcOyX5hPeec Small screen, OOBE, landscape: https://screenshot.googleplex.com/Kfjnav01j5V Large screen, dialog: https://screenshot.googleplex.com/vLnHTPWRie0 Large screen, OOBE: https://screenshot.googleplex.com/0eGWJaoLzO7 Bug: 1012295 Change-Id: I28cc765b11fde3bc3c319056dd74b876a85fdcbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951270 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#724057}
-
