- 24 May, 2019 40 commits
-
-
oysteine authored
This reverts commit da3002fb. Reason for revert: Relanding after https://chromium-review.googlesource.com/c/chromium/src/+/1626991 which should fix the test. Original change's description: > [go/perfbot-sheriff] disable a memory.desktop story. > > TBR=perezju@chromium.org > > Bug: 965066 > Change-Id: Ie2c498aeec8d96f14402a99e7984817eaedec9c2 > NOTRY: True > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620125 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#661396} TBR=perezju@chromium.org,crouleau@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 965066 Change-Id: Id650e8d0296a63eacdf2870a1b258177669ffd15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628009Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#663179}
-
Natalie Chouinard authored
Change-Id: I8ff2b0ab1d17c516f31476e8798544271b27804a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628934 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#663178}
-
Francois Doray authored
ThreadPolicy determines at which thread priority a task may run. Combining ThreadPolicy::MUST_USE_FOREGROUND and TaskPriority::BEST_EFFORT is useful to avoid priority inversions when a resource is shared between tasks of different priorities. Change-Id: I10a36a531cb2a230abcdaca090c4e109a3f05200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625907Reviewed-by:
-
Erik Chen authored
The dialog was only implemented on macOS. The dialog has been broken since at least 10.13.6, possibly earlier [it never shows]. The dialog will show if the implementation of PlatformCreateDialog passes the window [NSApp mainWindow], but doing so causes the dialog to hit use after free. The UI for the dialog will sometimes outlive the ShellLoginDialog instance. Rather than attempting to fix this clearly unused, broken path on macOS, I simply removed the logic. Bug: 965663 Change-Id: I9a1620d87965199361712bfa401ae63c51413cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627702 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#663176}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d9b4f3330fdb..039a7146abff git log d9b4f3330fdb..039a7146abff --date=short --no-merges --format='%ad %ae %s' 2019-05-24 ilnik@webrtc.org VP9 screenshare: drop base layer separately Created with: gclient setdep -r src/third_party/webrtc@039a7146abff The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1865013f638974fe773b0924dfc1bc4164de30e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628948Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663175}
-
Rohit Rao authored
BUG=922813 Change-Id: If16aeb9020ccca4c7d79e9519934bf163906a4ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628831Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#663174}
-
Elly Fong-Jones authored
This change causes the desktop media picker not to use TabbedPane unless there are multiple source types to switch between - otherwise it presents an odd single-tab TabbedPane. Specifically, this change: 1) Renames the pane_ member of DesktopMediaPickerDialogView and makes it optional; 2) Refactors the constructor of that class to add the created views children of the TabbedPane only when there are >1, and otherwise as direct children of the DialogView itself; 3) Overrides GetClassName on that class to aid debugging/inspection; 4) Adds new strings (from discussion with UX) for the dialog title when showing only a single source type; 5) Has DesktopMediaPickerDialogView::GetWindowTitle() use those new strings when appropriate; 6) Makes DesktopMediaPickerViewsBrowserTest's InvokeUi test fill itself with some test data, as an aid to screenshots; 7) Adds a new InvokeUi test to that suite, named "tabs", which shows the UI with only a single source; 8) Adds a new test to that suite, SingleSourceTypeChangesTitle, which validates the changes from (4) & (5); 9) Overrides DesktopMediaTabList::GetHeightForWidth, which is required for it to lay out properly when contained in a BoxLayout directly rather than a TabbedPane; To test this change, use the same steps as CL 1626010, or use InvokeUi. Bug: 964332 Change-Id: I0ba7f47613cfbd76152e7ecbdad34b91230b603c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627919 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#663173}
-
Alexei Filippov authored
BUG=878604 Change-Id: I0321b48834ccf85db9e72cb5942d2c53f8af3aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628109Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#663172}
-
John Budorick authored
This reverts commit 4a0113c6. Reason for revert: needs a downstream recipe roll. Original change's description: > Switch cros_download_vm DEPS hook to use gclient tuple support. > > Slightly cleaner this way. > > Bug: 947531 > Change-Id: I9dcc66d92562ddae8adcbf58b7e0bf9a2ffdc481 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625812 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#663149} TBR=dpranke@chromium.org,bpastene@chromium.org,jbudorick@chromium.org Change-Id: I4970238858b649f884e3f6afecc8a008be25f2d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 947531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628479Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#663171}
-
Mario Bianucci authored
Adding a UseCounter to collect metrics on how often an event listener is registered for a touch* event. Change-Id: I890cdaff039e427f2cb0b915b1a1d30032ddcc76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625825 Commit-Queue: Mario Bianucci <mabian@microsoft.com> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#663170}
-
Bryan McQuade authored
This metric will be used for a time to first byte metric in Chrome User Experience Report. UKM collection review: https://docs.google.com/document/d/1U0gT3RalytZqPW9t-4lBweBwLaamXYdJaO4ETsuvCdU/edit#heading=h.k5jx6iluw4yt Change-Id: Ie311d28f98b90f4361845e10843fa50f066c32b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628048Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#663169}
-
Wei Li authored
This CL uses template to generalize support on base::Optional types. BUG=938501,957270 Change-Id: Ib776ea0dce2d44b3954bb5976f8432edc9c583a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627915 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
-
Brian Sheedy authored
Adds a pixel ratio override for Pixel 2 devices in the GPU pixel tests. The ratio reported by the device was larger than it should be, causing the tests to compare larger portions of the image than it should. Bug: 966069 Change-Id: Ic1ec2d65762170d5f62f4570cff6e96ac2aa0f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627916Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#663167}
-
Taylor Bergquist authored
It implements a tab insertion animation and the bookkeeping necessary to keep it in sync with tabstrip changes. Not yet used by the tabstrip; that is in forthcoming CLs. Bug: 958173 Change-Id: Ib1d056c416de4147171597f2eab9982260887213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611865Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#663166}
-
Scott Violet authored
It's no longer called anywhere. BUG=none TEST=none Change-Id: I5246e40efb680f4b4188b7874bf18bee8b3cec1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628868Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#663165}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3c59c438c0f7..dcad518a0c4c Created with: gclient setdep -r src-internal@dcad518a0c4c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=yukishiino@google.com,lgrey@google.com,masonfreed@google.com,rsorokin@google.com Change-Id: I023a1e87768e1ed221b5db91d7b8e7f68fc39058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626186Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663164}
-
Andrew Grieve authored
These types of changes often break cronet, so the bots should run! Bug: 966720 Change-Id: I6714fe8aff9e1d77bc76582eb0fa19f931729a9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627564 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Alex Oldemeier authored
This removes a resolved TODO. base::Files are closed on destruction if valid and the passed FD is closed by concierge. Bug: 947014 Change-Id: I55301ee3e8b258b881f364b50b6b349cede973c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628716Reviewed-by:
Olya Kalitova <okalitova@chromium.org> Commit-Queue: Alex Oldemeier <aoldemeier@chromium.org> Cr-Commit-Position: refs/heads/master@{#663162}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7d1300b89ab7..7c93846385bd git log 7d1300b89ab7..7c93846385bd --date=short --no-merges --format='%ad %ae %s' 2019-05-24 raul@tambre.ee Convert except statements to be Python 3 compatible Created with: gclient setdep -r src/third_party/depot_tools@7c93846385bd The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:942522 TBR=agable@chromium.org Change-Id: Ifaa514f2636366bcafd679fb069c3b48397d49fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626184Reviewed-by:
-
Lucas Tenório authored
With this change we are rendering the webview at the correct size, removing hardcoded strings and showing a "Please wait..." message while we load the webview. Bug: 958995 Change-Id: Iaf4c71398d29fdc73daa06cba18e001b9d70e3dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622986Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Cr-Commit-Position: refs/heads/master@{#663160}
-
Chris Hamilton authored
The BrowsingInstance ByTime metric will allow us to determine how often sites are alone in a browsing instance, while the PageTime variant will allow us to estimate how much more impact freezing can have when browing instance data is explicitly taken into account. The FrameSiteInstanceProcessRelationship metrics are for estimating possible impact of Blink Isolates. The ByProcess metric will let us estimate how many processes will end up having to host multiple frames in one isolate, when the ByTime metric allows us to estimate the percentage of time a process spends hosting frames with a shared site instance. BUG=960924 Change-Id: Ia53cf5eddc74c8c2d7a825c49fe9b50a1685e147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603767 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
Ben Pastene authored
Daisy is kill. Need new arm bot on the CQ. R=jbudorick Bug: 966656 Change-Id: If2ba8d231e35cb81a43929b68fc992543d62907c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628873 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Saman Sami authored
A call to glBindImageTextureEXT is failing. Call glGetError afterwards so that future calls to glGetError don't return an error. The reason for this error will be investigated. Bug: 938597 Change-Id: I476a179cf79d970871ec405e3652c693a399d274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628546Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#663157}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/de15ed370d53..40757b28bdc8 git log de15ed370d53..40757b28bdc8 --date=short --no-merges --format='%ad %ae %s' 2019-05-24 spang@chromium.org Use ConvertToGLBoolean instead of ternary operator in Context Created with: gclient setdep -r src/third_party/angle@40757b28bdc8 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Change-Id: I6e2909d73051c98e6d5248c2f173364164b5787b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626185Reviewed-by:
-
Lindsay Pasricha authored
Change-Id: I97cd43a160e26046d1710df1b430e6bb3fd93b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626582Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#663155}
-
Kyle Horimoto authored
(1) Make the destructor virtual and override base class destructors. (2) Remove extraneous #endif from the .cc file. These issues were caught by vkuzkokov@ on https://chromium-review.googlesource.com/c/chromium/src/+/1604213 Change-Id: I1f82c04139c57880a46acfe904a528853f589fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628938 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#663154}
-
Luigi Semenzato authored
Platform.MeminfoProcessDataTotal is Active(anon) + Inactive(anon) + SwapUsed. Platform.MeminfoFileTotal is Active(file) + Inactive(file). The corresponding metrics_daemon change is at https://crrev.com/c/1614751 BUG=none TEST=none Change-Id: Ic563f32ffc2365f76841648f4ebcab477f4c195d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628001Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Luigi Semenzato <semenzato@chromium.org> Cr-Commit-Position: refs/heads/master@{#663153}
-
Mason Freed authored
http/tests/devtools/a11y-axe-core/elements/main-tool-test.js failing since: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Trusty%20MSAN/14679 TBR=masonfreed@chromium.org NOTRY=true Bug: 966932 Change-Id: Id7001fdb2ff59498256c6297f696f33c9d456692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628029Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#663152}
-
Dave Tapuska authored
The execution context state was never adjusted when a page was frozen. ContextStateChangedListeners fire when the state of execution context changes. This adds a number of things that are desirable for background tab freezing: - Workers being frozen as well - Mojo channels are appropriately dropped for IPCs while in the frozen state Add PauseExecutionContextOnBackgroundFreeze feature to control this and enable feature experimentally for now. Added a content feature kill switch for this as well. The desire is that bfcache, iframe freezing, sync event calls (window.print()) and background tab freezing all will share the same code paths for task scheduling adjustment. Intent to Implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/KwDF6Eavfek/Qb48J5ceAwAJ BUG=957589 Change-Id: Ic5b94ed971f4fe0883c39039534efd64ffd290f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588158Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#663151}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8207b641f56e..8da1e6560222 git log 8207b641f56e..8da1e6560222 --date=short --no-merges --format='%ad %ae %s' 2019-05-24 ethannicholas@google.com restructured SkSL include files 2019-05-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 1578d6b6f5dd..622c42a2cf22 (1 commits) 2019-05-24 halcanary@google.com add SkNamedTransferFn::kRec2020 2019-05-24 bsalomon@google.com Enable GL by default if GPU enabled and no backend selected. 2019-05-24 halcanary@google.com replace SkFont::glyphsToUnichars with SkFontPriv::GlyphsToUnichars 2019-05-24 fmalita@chromium.org [skottie] Add kBottom text alignment extension 2019-05-24 bsalomon@google.com Reland "Allow swapping out of GrBackendTexture used by SkSurface" Created with: gclient setdep -r src/third_party/skia@8da1e6560222 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Change-Id: I6d7e4456e77229da5fb06a7c115743d7470aa6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628660Reviewed-by:
-
Ben Pastene authored
Slightly cleaner this way. Bug: 947531 Change-Id: I9dcc66d92562ddae8adcbf58b7e0bf9a2ffdc481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625812Reviewed-by:
-
Annie Sullivan authored
Bug: 966921 Change-Id: I9308c3171f2c20df9dbca70853094fd5847dca12 TBR: crouleau@chromium.org NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627565Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#663148}
-
arthursonzogni authored
RenderFrameHostManager::GetOuterRenderWidgetHostForKeyboardInput() is no more used. Remove it. Bug: None. Change-Id: I552ae9a4f54370463bc44919ad4064229e65d8f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626413Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#663147}
-
Jonathan Backer authored
Currently there are only a couple of ways to create a SharedImage from pixel data: (a) using and SharedImageBackingFactoryGLTexture or (b) using WrappedSkImageFactory We prefer WrappedSkImageFactory when using SkiaRenderer for potential performance benefit. This CL changes the logic inside InProcessCommandBuffer to enable_wrapped_sk_image if (a) is not possible. This supports running viz_unittests with --enable-vulkan. Bug: 966016 Change-Id: I84a77802653b689da92f8697cf2394b429e59d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627938 Commit-Queue: Jonathan Backer <backer@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#663146}
-
Eric Karl authored
MomentumScrollJankTracker logic assumed that a kGestureScrollUpdate would always occur betweek kGestureScrollBegin / kGestureScrollEnd. It seems like we can hit a kGestureScrollUpdate in other cases, leading to a crash where we tried to use a null object. We now handle this case. Bug: 965422 Change-Id: I5538f52ff410e22334e0c0affcea5e987aa00803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625822 Commit-Queue: David Bokan <bokan@chromium.org> Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
-
Lindsay Pasricha authored
Bug: 939373 Change-Id: Ib8c3827399238e3cce7ea307a37923f76f7832e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628033Reviewed-by:
-
Aaron Gable authored
The android, win, and win32 release archive bots (and all of the debug archive bots) have been using minimal_symbols since the very beginning of the switch to GN. I'm not aware of any reason to continue producing these extra symbols on these bots, and it's causing disk-space issues (see bug below), so we might as well make the configs more unified. Bug: 966293 Change-Id: I663af34e11e6ea3f9979563b2bedf0d124b476c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625847Reviewed-by:
-
Annie Sullivan authored
Bug: 966913 Change-Id: I2d5e1ff11a7762ec69b56c1e07873f101394fd93 TBR: crouleau@chromium.org NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628933Reviewed-by:
-
Ken Rockot authored
This removes content_packaged_services entirely, switching instead to a direct delegate interface on Service Manager, allowing the Content layer to directly field service process launching requests. Follow-up CLs will further simplify in- and out-of-process service configuration, and this is ultimately a step towards migrating process launch out of Content and into Service Manager and removing other things like content::ServiceManagerConnection. Bug: 781334,895615 Change-Id: I9243eb24b0152c2b353909718d8d3de223a6af9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604203 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
-
Rohit Rao authored
This reverts commit daad88b5. Reason for revert: Breaks internal compile. Original change's description: > Create //ios/web/public/security/BUILD.gn. > > This CL creates //ios/web/public/security/BUILD.gn and removes the > temporary header //ios/web/public/certificate_policy_cache.h > > Bug: 956511,942244 > Change-Id: I7f70539cb2ce2d504e058a94a585124d265e12a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624809 > Reviewed-by: Christopher Thompson <cthomp@chromium.org> > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Yi Su <mrsuyi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#663093} TBR=marq@chromium.org,eugenebut@chromium.org,mahmadi@chromium.org,cthomp@chromium.org,mrsuyi@chromium.org Change-Id: I370fafb2a873946e396fac17344c163b44a763d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 956511, 942244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626491Reviewed-by:
-
