- 26 Nov, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ie5ed5f32b996259108ae4ee712048dc38700a003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561449Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831234}
-
Darren Shen authored
Some of the code from crrev/2537516 uses JS style rather than C++ style. Bug: b/172527471 Change-Id: Iee01a5eccc83b6c7060cb7c32aa51981cda09f6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557702 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#831233}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f4a615fc8f0e..28a1c2ec8223 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mxcai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1127088 Tbr: mxcai@google.com Change-Id: I115081c7e0aa45a7705813e17b1b27db86538dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561820Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831232}
-
Michael Hansen authored
This updates the color of the "learn more" link on the discovery page to a slightly darker shade of blue to increase contrast against the background. This is done to meet the accessibility guideline of having a contrast ratio of 4.5 or more. (Final value is 4.52.) Screenshot: https://screenshot.googleplex.com/BYV2XhaZPCs4dPj.png Bug: 1148969 Change-Id: Ib0875cfca544fc1b7ea5c8337771fe37878a42eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561858Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#831231}
-
Andrew Grieve authored
TBR=agrieve # Minor docs change Change-Id: I1b85dfff5aee660768c15f4ea031b1f854bbbd77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561049Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#831230}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606327120-481ff93b7112a13bdcf1248f3441d3a11742a301.profdata to chrome-linux-master-1606348564-f9ad4c8126c0686f48279a254d0d8ff9696d692f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I263fbd81cbb3c4964131a759fdbf5adabe56a90a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561047Reviewed-by:
-
Maggie Cai authored
This reverts commit 5aea6042. Reason for revert: This CL is likely the cause of build failure for Linux ChromiumOS MSan Tests and Linux Chromium OS ASan LSan Tests (1) First occurance: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21455 and https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38935 Failed tests: GetCurrentBrowsingContextMediaDialogTest.DefaultAudioSelection GetCurrentBrowsingContextMediaDialogTest.DoneCallbackCalledWhenWindowClosed GetCurrentBrowsingContextMediaDialogTest.DoneCallbackCalledWhenWindowClosedWithoutCheckboxTicked GetCurrentBrowsingContextMediaDialogTest.DoneCallbackCalledWithAudioShare GetCurrentBrowsingContextMediaDialogTest.DoneCallbackCalledWithAudioShareFalse GetCurrentBrowsingContextMediaDialogTest.DoneCallbackCalledWithNoAudioShare GetCurrentBrowsingContextMediaDialogTest.DoubleTapOnShare GetCurrentBrowsingContextMediaDialogTest.ShareButtonAccepts Original change's description: > Implement the confirmation-box for getCurrentBrowsingContextMedia API. > > Rebased on top of https://chromium-review.googlesource.com/c/chromium/src/+/2502628 > > UI without audio capture: https://drive.google.com/file/d/1SA9vuDOkQjnioBfmAaiOjqoXGBUmVw22/view?usp=sharing > UI with audio capture: https://drive.google.com/file/d/1jcncgHsF6L_o3D5Jc3UJ6pkjwQAKtoVl/view?usp=sharing > > This change relates to the UI code that is added to support the new getCurrentBrowsingContextMedia API. > > This is an API for capturing the current tab. > > Design doc: > go/get-current-browsing-context-media > > Intent-to-Prototype: > https://groups.google.com/u/3/a/chromium.org/g/blink-dev/c/NYVbRRBlABI/m/MJEzcyEUCQAJ > > PR against spec: > https://github.com/w3c/mediacapture-screen-share/pull/148 > > > Bug: 1136942 > > Change-Id: I8e72023d944df3d7e996ad3acea7527c34569868 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489991 > Commit-Queue: Palak Agarwal <agpalak@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Peter Boström <pbos@chromium.org> > Reviewed-by: Elad Alon <eladalon@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#831017} TBR=ellyjones@chromium.org,pbos@chromium.org,guidou@chromium.org,eladalon@chromium.org,agpalak@chromium.org Change-Id: I25b9e79d7eb61b5e43961df61999fd8c20954c8f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1136942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560358Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#831228}
-
Michael Hansen authored
This gives the content container of the receive dialog an aria-live attribute so that when we change from the receive page to the confirm page ChromeVox will begin reading the contents of the confirm page. Fixed: 1149743 Change-Id: I58a6aeec0d99e0f4a9da67d68483f014b2ee4864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561649Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#831227}
-
Nicholas Hollingum authored
The IsOpenedInBrowser method is used to exclude windows managed by browser controllers from being handled by the app service. This method special-cased unmatched crostini windows, whose app type is unknown and therefore would be conservatively assumed to be broswer-based. We use a better case, by excluding all exo-originating windows. This not only catches all the unmatched crostini cases, but also it handles all arc, larcos and pluginvm windows here, instead of needing to check the AppType of their app id against the proxy. Further, it allows us to exclude all anonymous apps (see go/anonymous-apps). Bug: b/172979315 Change-Id: Ic8f109a5fe0d3aa5049ba244aba9e22a8bcdd7b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560442Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#831226}
-
Kenichi Ishibashi authored
Adds a specialized InflightCall sub class for the method because some parameters of ServiceWorkerStorageControl::StoreRegistration() are move-only and we need to clone them for each method call. Bug: 1133143 Change-Id: I5842f32a7b2d88786d6a04a7eae06e18e5c2d1a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550962 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#831225}
-
Nasko Oskov authored
Change-Id: I691139bf9141760cfb54f50cc5b3b48108f52852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561859Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#831224}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2b606e9297e0..9175f00eec91 2020-11-26 enga@chromium.org Update WGSL vertex_idx i32 -> u32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: Ic10ef602461f17f3e9f980ee9c45f20592a2c953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561143Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606327120-e32add9932b9917c7d02c6e60e2518fc762f03e2.profdata to chrome-mac-master-1606348564-46558a518073e70dc3e85439edab882c7abb26f5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Icedd4fd5b2c4118fb5d1dada33d81b4c53c1a6f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561819Reviewed-by:
-
Jérémie Boulic authored
When trying to mount a ZIP archive with an invalid path, cros_disks sends back a signal to the browser with source_type=MOUNT_TYPE_INVALID. The observing VolumeManager doesn't handle this source/mount_type, and the archive mounting request initiated from the UI is never resolved. Fix this by removing the distinction between MOUNT_TYPE_INVALID and the other mount error types. Bug: 1136329 Change-Id: If807a854ef7a13635ded29a38e76ee54e057bfc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560443Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#831221}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606293619-712b869bfc91985e78185bbfc14de73d07d8077a.profdata to chrome-win64-master-1606316157-945260897cb0815b47df3e1edecdf8b6cf6cb896.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie34e22b48a13bcb1ec8edd96817ae360097e104b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561280Reviewed-by:
-
Thomas Guilbert authored
VideoEncoder and DecoderTemplate share some common logic around the lifetime management of MediaLogs. This CL abstracts away the logic into a CodecLogger, and updates MediaLog uses through out the code. This CL also makes sure not to report the media::Status messages in JS exceptions, to avoid leaking security sensitive information. Bug: 1148541 Change-Id: I483ee7be7aa52a7996c91cef7d781ba80b516855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538964Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#831219}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d6c1c090774f..140364ea8c33 2020-11-25 nigi@chromium.org Enable FPDFProgressiveRenderEmbedderTest.RenderHighlightWithColorScheme for SkiaPaths. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1500 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I7c46d1e139684e15c910ebb1fbcab8f4dfe22b74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560407Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/420a9ba7b5e9..8d78da910e45 2020-11-25 mtklein@google.com more arm64 ops If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: Ia8a4f325ce405701ba41bdef8360954ed1ada518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561744Reviewed-by:
-
Willie Koomson authored
This change fixes ArcVmClientAdapterTest.ChromeOsChannel{Stable,Unknown} by adding a call to base::SysInfo::ResetChromeOSVersionInfoForTest(). This fixes a crash in base::SysInfo::SetChromeOSVersionInfoForTest that happens when it is called twice without being reset. BUG=b:174186047 TEST=ArcVmClientAdapterTest unittests Change-Id: I5ba40f3efe5ddd44fbcf9ec7ec56711678c50248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559533 Auto-Submit: Willie Koomson <wvk@google.com> Reviewed-by:Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#831216}
-
Yoichi Osato authored
Root cause is DataElementDataView::ReadBuf(BigBufferView&) is not working on fulfilling DataElement::length property. Since this is a stable blocker, let me quick-fix. Bug: 1151865, 1152664 Change-Id: I0c24c17d7063b3effb4ec5c52a30f87bf39b15f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558082Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#831215}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0db3396646aa..b6b599fc588e 2020-11-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a100f65b..81d25031 (831018:831145) 2020-11-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8f4e430a..a100f65b (830890:831018) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iafa1b99a73ff127c605af39dcefc25d370141c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561136Reviewed-by:
-
Austin Sullivan authored
- Comment updated to reflect change to PathInfo from base::FilePath Bug: N/A Change-Id: I5a57fdec71f0b69548a7b4763b38109a3e57a838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556458 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#831213}
-
Joey Arhar authored
This patch makes the color picker popup for <input type=color> accept saturation and luminance values without the trailing % as well as hex values without the leading # when they are typed in by the user. The % and # characters will be automatically added by the popup. Bug: 1147506 Change-Id: Icf406a6c9439433910e90a7be82309e72e4b4d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560659Reviewed-by:
Sanket Joshi <sajos@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#831212}
-
Wenbin Zhang authored
Adding unit tests which is missing for results_merger.py. Bug: chromium:1140389 Change-Id: Id12e952db5e90adb0343effee0d427ae6481a825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561640Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#831211}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b8bd12af..fe46597d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8a04b240e426b977cd7797f836471a93c9a3a063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560837Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831210}
-
Mason Freed authored
Enabling line-wrapping on the view-source page causes a performance problem in layout for very large documents. However, removing line wrapping causes developer pain, especially for pages with minified code or very long lines. This CL adds a "Line wrap" checkbox to the top of the view source page, which defaults to unchecked (for speed). When checked, it adds line wrapping to the source table. Fixed: 920571 Change-Id: Ie2610016bca7f2225c102b181e80f9972e7ce686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558920Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#831209}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bc82325e3445..4dba276776bd 2020-11-25 syoussefi@chromium.org Vulkan: Enable OES_shader_multisample_interpolation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: I6dd06a01e5ca75549ef71b03ab0e93974d1ee355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561129Reviewed-by:
-
Gavin Williams authored
The toast will pop up and show for 5 seconds or be removed immediately if the scan button is clicked again. http://screen/9bUx9VbiapdgKrC Bug: 1059779 Change-Id: Ifc0b44f79920b0f2daa167a5355ecdf9e1500b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559254 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#831207}
-
zhiyuancai authored
TBR=yusufo@chromium.org Bug: 1152925 Change-Id: I77763d3bda3ebedc0636dad3f97ba53348a5b43d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561658 Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#831206}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/31df00826801..f4a615fc8f0e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mxcai@google.com,ramyan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1127088 Tbr: mxcai@google.com,ramyan@google.com Change-Id: Ieeecfd88a3555d82c643b3e224bea06805c7dcb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561130Reviewed-by:
-
Xida Chen authored
This CL follows the pattern of: https://chromium-review.googlesource.com/c/chromium/src/+/1715906 That is, in order to change the viewport style propagation logic for overscroll behavior, we want to add use counters to understand the potential breakage. Bug: 954423 Change-Id: I410aa665873167ffe523911a823e9b47cd117018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560396 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#831204}
-
Ben Reich authored
CL:2559234 introduced changes to disable $i18n{} template replacement when the --devtools-code-coverage command line flag is passed and only for the ChromeOS Files app extension in-test. Identify when the files app searchHidingViaTab test is in code coverage mode and use the $i18n{} label instead of the replaced string. --devtools-code-coverage Bug: 1152612 Test: browser_tests --gtest_filter="*searchHidingViaTab*" Test: browser_tests --gtest_filter="*searchHidingViaTab*" Change-Id: I6c869e9d6a7bdec0737ede2d2ee67478bf3ba150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558819Reviewed-by:Noel Gordon <noel@chromium.org> Commit-Queue: Ben Reich <benreich@chromium.org> Cr-Commit-Position: refs/heads/master@{#831203}
-
Bao-Duy Tran authored
Bug: 1134465 Change-Id: I32cb2d5d67e6bd102f17578d824028527d1c9bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551869 Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#831202}
-
Ben Reich authored
CL:2559234 introduced changes to disable $i18n{} template replacement when the --devtools-code-coverage command line flag is passed and only for the ChromeOS Files app extension in-test. Introduce a helper to identify when a files app Providers test is in code coverage mode and use the $i18n{} label instead of the replaced string. --devtools-code-coverage Bug: 1152612 Test: browser_tests --gtest_filter="Providers/*" Test: browser_tests --gtest_filter="Providers/*" Change-Id: I7eb906895f21912e96d18b488e3ca239a9d26dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558818Reviewed-by: -
Luciano Pacheco authored
The issue was introduced by CL:2258897. Similar fix has been applied to <cr-dialog> CL:2538530. QuickView seems to be the only use of <dialog> in our code base, Code Search query: "<dialog file:^ui/file_manager/". Test: Checked visually running linux-chromeos locally. Change-Id: I87f5b0a230dc738159d4fb6d47508a2f3ed30669 Fixed: 1152913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560701 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Mason Freed authored
This was an old test, so this updates it to use testharness.js. It also fixes a few issues with the test, primarily the fact that it used to copy and paste from the same control, and errors in copying or pasting would leave the existing markup in place. Along with this update, I added testing of both "normal" template elements in copied content, in addition to declarative Shadow DOM. And a test that <template shadowroot=open> doesn't get round-tripped back into a declarative Shadow Root. Note that one "flaw" is baked into this test: ABC<div><template></template></div>DEF will get left as ABC<div></div>DEF, rather than just ABCDEF. Bug: 1042130 Change-Id: I870d4a518d722c6f10a9ca2d20aab0d6334b8589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561273 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#831199}
-
Bao-Duy Tran authored
Six InputMethodManagerImpl tests are failing in specific environments due to mixed usage of test data and CrOS prod configs. Partly caused by inconsistent usage of MockComponentExtensionIMEDelegateManager. In particular, parts of Setup() are run without this mock injected. The fix here ensures the mock and its test data are consistently used throughout. With this we manage to un-fail 4 out of 6 tests, but another new test starts failing! It's unsurprising because these tests still indirectly depend on deprecated input_methods.txt configs (remnant from before the migration to extension-based input methods circa 2011). This issue will be addressed in the next steps. Bug: 970790 Change-Id: I3e76708e34f2b4e021f763654714d157f48a3925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550152 Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
John Palmer <jopalmer@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3c1923fb. With Chromium commits locally applied on WPT: e03565a0 "Simulate user inputs in css/selectors/focus-visible-012.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I8a47c727e2fdcac38ed4d176d6db26309e80c2fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561223Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831197}
-
Noel Gordon authored
CL:2559234 introduced changes to disable $i18n{} JS template replacement when the --devtools-code-coverage command line flag is enabled, and only for the ChromeOS Files app extension while in-test. Update the files app QuickView integration tests to work with or without the --devtools-code-coverage flag. Add helper i18nQuickViewLabelText for extracting the expected QuickView item text (JS code coverage flag on or flag off). Minor: update getQuickViewMetadataBoxField with hidden option to support callers wanting to check that a metadata box field is hidden. Also, some changes for uniformity in "Check: the thing should happen" comments. --devtools-code-coverage Test: browser_tests --gtest_filter="QuickView/FilesApp*" Test: browser_tests --gtest_filter="QuickView/FilesApp*" Bug: 1152612 Change-Id: Ie59f11d85038d91e4519551b144ea1f51f555533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560017Reviewed-by:Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#831196}
-
Michael Bai authored
This patch moves AutofillDownloadManager::Observer to AutofillHandlder No function change. Bug: 1151542 Change-Id: I7a290f72d4b51d9362c9cdec44ab74f4ae443a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553185Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#831195}
-
