- 16 Apr, 2020 40 commits
-
-
Victor Hugo Vianna Silva authored
The value for the access point is now set in the PasswordAutofillManager and plumbed up to the ShowDiceAddAccountTab call. With this change, this value can now also be verified in a unit test for that class. Bug: None Change-Id: I2efa2b4a39d4f565609650583f5a2e1666042d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148750Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#759598}
-
Victor Hugo Vianna Silva authored
Before this CL, every caller of the PasswordManagerClient's reauth API used to set the opt-in pref upon success. Now this is taken care by the AccountStorageAuthHelper. Bug: 1070944 Change-Id: I354e10516ac759aa52ee07a8d8a130c7087bbc58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149655Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Miyoung Shin authored
CL migrates clip-path-transform-mutated.html to external/wpt/css/css-masking/clip-path/, adding links to the relevant specs and a test assertion describing its purpose, renaming it to clip-path-transform-mutated-002.html. BUG=1063749 Change-Id: I1639669d37fdd01893a7bbaaadab07a8e4abc692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145389 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#759596}
-
Miyoung Shin authored
CL migrates grid-baseline-must-respect-grid-order.html to external/wpt/css/css-grid/alignment, adding links to the relevant specs and a test assertion describing its purpose, renaming it to grid-baseline-004.html. BUG=1063749, 767015 Change-Id: Ie0427d83993ec9b5e67b33652bc25b1bca32e1d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147759 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#759595}
-
Abhijeet Kandalkar authored
Migrate this test out of t_p/blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. This test verifies that repeat(auto-fit, ) syntax works as expected inside grid layout. Bug: 1063749 Change-Id: I8230eb65c8c143c2dc5b51fd6178a525f6523564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148913 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#759594}
-
Michael Lippautz authored
Existing work found a new home in V8 as cppgc. Bug: chromium:1056170 Change-Id: Ic7f159a6432792787d552f0fc53eca8b3fffef0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151588Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#759593}
-
Side Yilmaz authored
|Profile#getLastUsedProfile| is depreciated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates ChromeAppModule class. While ChromeAppModule generates |ChromeAppModule_ProvideLastUsedProfileFactory| class to deliver regular profile with dependency injection, with this change it will generate |ChromeAppModule_ProvideLastUsedRegularProfileFactory| for the same purpose to reduce the naming confusion. Bug: 1041781 Change-Id: I27e1e9e8e19a5b0cf5326539a624261ef3fe0901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149323Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#759592}
-
Gauthier Ambard authored
This CL adds a test to make sure we don't display the NTP if the loaded page is an interstitial page. Fixed: 1067250 Change-Id: If0b28650148acee4f1379028826ca1cc603834f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151451 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#759591}
-
Mugdha Lakhani authored
PageInfoController no longer depends on InstantAppsHandler and VrModuleProvider, and instead gets this info from ChromePageInfoControllerDelegate. Bug: 1052375 Change-Id: I7050f105b10d6e78873f185e5516c2df318c8936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144016 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#759590}
-
Alex Rudenko authored
The inspect mode does not work if there is a highlighted frame. With this change, the inspect tool gets reset from the frame highlighting to the default tool once the mouse moves. The new behavior affects NodeHighlightTool only. Fixed: chromium:999440 Change-Id: I6bfe1f5587fea18b1aa23c389812231ac52b3b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150430Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#759589}
-
Rainhard Findling authored
* For non-Google-based browsers, |VersionUpdater| returns a "updates disabled" state. Until now, safety check displayed this as a generic error. * This CL adds a "unknown" updates status, which displays the current version of the browser in the safety check update status. * This CL updates the JS side. The C++ side is updated in crrev.com/c/2144038. Bug: 1015841 Change-Id: Ied9d8cc1b07ba6f12494b2e253a8f7f90e4f3375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148778Reviewed-by:
Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#759588}
-
Gauthier Ambard authored
This CL makes sure that we don't display the NTP if the loaded page is an interstitial page. Fixed: 1067250 Change-Id: Ic4e2dccc1e6e5c34e1f8eadee32b0182d0846a45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148772 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c018fc6ae667..61b7de3c39f0 git log c018fc6ae667..61b7de3c39f0 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 stevenperron@google.com Remove unreachable code. (#3304) 2020-04-15 afdx@google.com spirv-fuzz: Fix to outliner (#3302) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@61b7de3c39f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,timvp@google.com Change-Id: I014b7f784c0e83bf79741f3c865a51b1d2abadae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152425Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759586}
-
chromium-autoroll authored
fuchsia/third_party/aemu/linux-amd64/+log/b4mdc.....Eheze... Created with: gclient setdep -r src/third_party/aemu-linux-x64@Eheze... If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: chonggu@google.com Change-Id: I39970cda14024a233a7f0c936e4074a910d361d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151639Reviewed-by:
-
Alex Ilin authored
https://crrev.com/c/2144200 introduced a regression that broke the javascript bridge in the remote consent flow. "inject.js" should be injected in all pages within the consent window. A recent change made webview.executeScript() execute only once, after the first page is loaded. This CL modifies 'loadstop' listener so the script is injected for all pages but the window is shown only once. Bug: 1026237 Change-Id: I9f70d99f9cda7c4c6dd7194630a5b2fa1ede5d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151865 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Auto-Submit: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759584}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I8b0881035d4ca718c2f973276bf4411356dbfbcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143888Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#759583}
-
Kenichi Ishibashi authored
This is a reland of 6d769734. Difference from the original CL is to rebase after 85a40bf3. Original change's description: > Add ServiceWorkerStorageControl::UpdateLastUpdateCheckTime() > > This is a wrapper of ServiceWorkerStorage::UpdateLastUpdateCheckTime(). > > Bug: 1055677 > Change-Id: I3bf89d2c227d5b6f0a1c41e108843ae1d51a778b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147435 > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759541} Tbr: shimazu@chromium.org, kinuko@chromium.org Change-Id: Id03cd5f3afa0c7338f924e8569f7d01cb50acb1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152327Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#759582}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a887423b..d7247aad Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iee6720fc9fffba7793e7d025b9ee0dfdb86b402a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151549Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759581}
-
Viktor Semeniuk authored
This change fixes the bug when Compromised passwords are not displayed in passwords section if check was not finished successfully e.g. Canceled although some number of compromised passwords were found. Bug: 1070897 Change-Id: I73068029f0c02979520bc7caddabc7d72e7b1faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148323Reviewed-by:
-
Gyuyoung Kim authored
This CL migrates flex-item-grid-container-percentage-rows [-expected].html from fast/css-grid-layout to external/wpt/css/css-grid/grid-items with WPT styles, adding links to the relevant specs, and test description. Additionally, this test is renamed to flex-item-grid-container-percentage-rows-001[-ref].html to be align with existing tests. Bug: 1063749 Change-Id: I2959664d4f110190f87ba66416e46df747257cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147762 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I1f8fca66a8d0e6561dae79058171fa1243aecee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152219Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759578}
-
Kenichi Ishibashi authored
This is a reland of d69aec62. Difference from the original CL is to rebase after 85a40bf3. Original change's description: > This is a wrapper of ServiceWorkerStorage::UpdateToActiveState(). > > Bug: 1055677 > Change-Id: I1444227429fd4c4647198702db79b0d414514571 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147983 > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759540} Tbr: shimazu@chromium.org, kinuko@chromium.org Change-Id: I045b9beefe73ed004075f70ebd7aff092675e635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152054Reviewed-by:
-
Javier Ernesto Flores Robles authored
Bug: N/A Change-Id: Iacb1ae872d38e57df2bee90e3dba9583a334877c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148748Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#759576}
-
Kuo-Hsin Yang authored
The mem_usage and chrome_user_log log items in feedback reports contain tab titles which may include SPII, these tab titles should be removed. Individual items in Feedback could be excluded based on dialog input. Added a new log item mem_usage_with_title that will be send with user consent. BUG=chromium:1070935 TEST=check mem_usage in chrome:://system Change-Id: I8f2ee0b21181ddd194e18009f68e5805f6ad2c0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149741 Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#759575}
-
Ewann authored
This CL removes the top separtor of the Cookies tableView. Bug: 1064961 Change-Id: I4a91b8ee567642d838c93034b57bbba87e41d1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149654Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#759574}
-
Guido Urdaneta authored
This test has been timing out on several bots. Bug: 1071329 Change-Id: I3c85843fa202f2adf1f1965f96931ccc6f180881 No-Try: true TBR: hta@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151867Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#759573}
-
edchin authored
This CL corrects the behavior of managed bookmarks in the following ways: 1) Long press is enabled for managed bookmarks and folders. But the 'edit' and 'move' options are disabled. This is also fixed in search results. 2) Fixes a bug where swiping managed nodes was possible in search results. 3) In editing mode in search results, 'regular' bookmarks can be selected/checked into an editing set. But managed bookmarks cannot. This CL also adds EG tests for these behaviors. Bug: 1065187 Change-Id: I4d5d47e3f8b884407fce31ceccc9bc2eab7ea8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148230 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#759572}
-
Armando Miraglia authored
Fixed: 1066041, 1066040, 1066039 Change-Id: I2b82a25199621cc42acfb53c230d0940c0a75afe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145885Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#759571}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8c22240b1a04..a6fbe4e685f0 git log 8c22240b1a04..a6fbe4e685f0 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-04-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6e0d718a48d8..49ad8eaae192 (9 commits) 2020-04-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src cddb357f..59d22330 (395 commits) 2020-04-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 81e08df29531..2430d665d3f2 (4 commits) Created with: gclient setdep -r src/third_party/skia@a6fbe4e685f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I1037582f3570e0d0b1f2f02931f580571b1ade95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152347Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/953cd08e70a0..159f3561ccfa git log 953cd08e70a0..159f3561ccfa --date=short --first-parent --format='%ad %ae %s' 2020-04-16 dberris@chromium.org Pinpoint: Do not double-cache Isolate entities 2020-04-16 fancl@chromium.org Add group_report for AlertGroup Created with: gclient setdep -r src/third_party/catapult@159f3561ccfa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1064955,chromium:1070753 Tbr: skyostil@google.com Change-Id: I40b55e42c50ac3ef83e4ce34923a649a18901417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151063Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bf0cc7170286..157451f9900a git log bf0cc7170286..157451f9900a --date=short --first-parent --format='%ad %ae %s' 2020-04-16 sigurds@chromium.org [issues] Make types more precise Created with: gclient setdep -r src/third_party/devtools-frontend/src@157451f9900a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I346e72163dc23813fd45be0be730525d5d66ef4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152350Reviewed-by:
-
Mike Dougherty authored
Returning a PolicyDecision which was created with CancelAndDisplayError from ShouldAllowRequest will cancel the request and display the error to the user. This can be used to display to the user why a request was cancelled. Bug: 1065161 Change-Id: I4418cb099aa7fab01a3bca6fa08d3c5e67fce986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140958 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#759567}
-
tby authored
Link the OS settings search provider with the settings SearchHandler, by querying it for results on each search. These results: - Set their metadata from the returned SearchResultPtr. - Launch the settings app via chrome::SettingsWindowManager::ShowOSSettings. Bug: 1068851 Change-Id: I2f7236fcec3401c14f54934dee03302c3fbf7ce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147132Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#759566}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6364c48eb481a4d8d289e7506b70d019bda1b90e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152345Reviewed-by:
-
Alice Wang authored
This CL fixes the flaky test testDialogIsDismissedWhenRecreated by replacing the original Activity.recreate() with a blocking call to ensure the execution is blocked till the activity is resumed. Bug: 1054855 Change-Id: I841cbc6668dc0d8df3ccbc9c9005023baebdc07e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144026Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#759564}
-
Anders Hartvoll Ruud authored
I2S: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/tOHolEkBeY8/jX0jvQqkBAAJ Bug: 579788 Change-Id: I7282552f4b8339adc63ffc262cfb59cda2c3f7f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146908Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#759563}
-
Guido Urdaneta authored
This reverts commit b79724f8. Reason for revert: Causing flaky failures in Mac10.14 Tests bot. First failure here: https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/3374 telemetry_perf_unittests on (none) GPU on Mac failed because of: measurements.rasterize_and_record_micro_unittest.RasterizeAndRecordMicroUnitTest.testRasterizeAndRecordMicro Original change's description: > Collect reasons of disallowing LCD text > > (TBR for passive change in tools/perf/measurements/rasterize_and_record_micro.py.) > TBR=wangxianzhu@chromium.org > R=pdr@chromium.org > > Bug: 642885 > Change-Id: Ia5c8313ea9e34139e06ff11fcc5d751ff0768c75 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149914 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759474} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: Ic25a88c23e6f504461d3100fbf3bc8f8429c81f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 642885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151450Reviewed-by:
-
Miyoung Shin authored
CL migrates grid-baseline-margins-2.html to external/wpt/css/css-grid/alignment, adding links to the relevant specs and a test assertion describing its purpose, renaming it to grid-baseline-003.html. BUG=1063749, 767015 Change-Id: I24861becfc1be0554f02e3a3491398a07b0f039d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145747 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
-
Miyoung Shin authored
CL migrates grid-baseline-margins-1.html to external/wpt/css/css-grid/alignment, adding links to the relevant specs and a test assertion describing its purpose, renaming it to grid-baseline-002.html. BUG=1063749, 767015 Change-Id: I704b393b1c257c9a79b70903014f13fc5cf54039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143188 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
-
Miyoung Shin authored
CL migrates grid-baseline.html to external/wpt/css/css-grid/alignment, adding links to the relevant specs and a test assertion describing its purpose, renaming it to grid-baseline-001.html. BUG=1063749, 767015 Change-Id: Ia642e5876f5a936f11fc268adf93dd9ddf9479c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147988 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
-
