- 30 Dec, 2020 40 commits
-
-
Abigail Klein authored
Clears caption bubble text after the inactivity timeout. Also, prevents a final transcription received after the bubble has no activity from setting text. This fixes a bug where the bubble disappeared after inactivity, and then the speech service sent a final transcription after several seconds of no audio, which caused the bubble to reappear. Bug: 1055150 Change-Id: I3a0df495c73df0273e925847671f351b61afcd51 AX-Relnotes: N/A (feature not launched) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598622 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Josiah Krutz <josiahk@google.com> Cr-Commit-Position: refs/heads/master@{#839812}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I2c3f99d21972a0196720753a8dcfa53e9a4aef86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607583Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839811}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I61fb15a4906ca7700cb3dde4e15babbd81575907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605879Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839810}
-
Curt Clemens authored
The contact visibility page was updating the visibility pref and making an api request to sync the allowed contacts list every time the controls on the page were pressed/toggled. This CL instead saves the page state once when the page closes. Fixed: 1131269 Change-Id: Iaf6e5138b029450df083179994cba7f67ee0f5c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606716 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#839809}
-
Christopher Cameron authored
Add comments clarify the reason that the DrawQuadList is not cleared by the CALayer overlay processor (the RenderPassDrawQuads are sill referenced). Add a TODO for the place to add the underlay processor. Bug: 1152849 Change-Id: Iaf58b2c4ebbadf29c40ed76660069f9d0932a995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587949 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#839808}
-
Clark DuVall authored
This reverts commit c2bd53d8. Reason for revert: This seems to have caused the crash in crbug.com/1143321 to happen again. Original change's description: > Remove custom library resolver for feed libraries > > This was needed because the libraries were in the feed module, but have > now been moved to the base module. This will hopefully fix a crash > loading the libs on some devices. > > Bug: 1160654 > Change-Id: Ie33114d6f5963325c096dea9f60e029d7d40e19e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606187 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#839654} TBR=agrieve@chromium.org,cduvall@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I2f8353a58a6200c9a8ee5475c3b1798c5b4e0f22 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1160654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607672Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#839807}
-
Sky Malice authored
This change removes the default [re]seting of This change is needed because CCTs with policy CCTToSDialogEnabled skips the FRE. This flow doesn't accept the ToS, and doesn't overwrite to the PRIVACY_METRICS_REPORTING pref. But very early in the FRE startup/flow, this pref is blindly written with the default (true), and that value is persisted forward for the CCT skip, when really we want the value to be false. The theory here is that we didn't actually need to set this pref. It seems to have been initially written to seed the checkbox state, see https://crrev.com/978653002 , but that changed when the default flipped in https://crrev.com/2275513003 . See associated bug for more details. This change also removes the temporary hack added in https://crrev.com/c/2416885 to support CCTs that skip the ToS. Bug: 1128955 Change-Id: I9cbb9e3db2eeb9278519759b955c7976584c0e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416932Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#839806}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I0fbca7753d75bc685b1dd5da33ebcc54590adbd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607582Reviewed-by:
-
Maggie Chen authored
The Boolean result of this function was accidentally reversed in https://chromium-review.googlesource.com/c/chromium/src/+/2597637. This CL corrects the logic. For some reason, this wrong AllowTearing flag prevents hardware overlay promotions on Surface Book while the other laptop like Blazer is fine. These two are the only devices I checked. Bug: 43611 Change-Id: Ib6f27d74d55e0977df840e1f10001ccc01ca5227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606292Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#839804}
-
Lily Chen authored
To assess compatibility impact of fixing behavior for year 69 (i.e. change it from current behavior, 1969, to 2069, as described by the spec). Bug: 907610 Change-Id: Ia4639d34ca02144915aed47db4859aa545fae9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605353Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#839803}
-
David Bokan authored
This CL converts MessagingDelegate::QueryIncognitoConnectability to OnceCallback. This requires some work inside the IncognitoConnectability class to make it work on OnceCallback. This class tracks whether an extension or app can be connected with an origin and returns the reply in a callback, since the request may involve user interaction and is async. Since this is a completion callback, it is semantically a OnceCallback. Inspection shows that the stored callbacks are always removed from the callbacks list after being invoked so this should be a safe conversion. This change required some minor changes to the TabContext subclass to ensure it cannot (and currently isn't) copied, since it holds a collection of move-only OnceCallback objects. Bug: 1152268 Change-Id: I47d29c55abd6cc04f4f05dfa9f7dfee46ab81a07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600391 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#839802}
-
Josiah K authored
Adding: https://screenshot.googleplex.com/8s6KD8T8eYsJsdy Removing: https://screenshot.googleplex.com/8koetbZZpVrfz4H Fixed: 1161124 AX-Relnotes: N/A. Change-Id: I4d9f54ebea6496d3e67a7173047c23e577de2ee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600143 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#839801}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4ef108e6d17a..6d4577bc5208 2020-12-30 westont@google.com [fuzzing] Add first pass SkParagraph fuzzing. 2020-12-30 brianosman@google.com Revert "SkRuntimeEffect: Test matrix inverse() intrinsic" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: djsollen@google.com Change-Id: Ie85488be6d7f53a9777444dfea23cf0399a18309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607577Reviewed-by:
-
Josiah K authored
Update strings to match go/switch-access-setup-strings-doc Fixed: 1161112 AX-Relnotes: N/a. Change-Id: If86c68a5ee341ed9d207c3f10240fc4d44d561c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599389 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9a38e5b60dcc..86980018b3f2 2020-12-30 shrekshao@google.com Invalidate sampler with maxAnisotropy = 0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: Iea8ac123928b466f4407beec1c134520288dd067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607575Reviewed-by:
-
Abigail Klein authored
Bug: 1055150, 1161040 Change-Id: I128a2fccdc671a5aab0ad15c3a9e5089ae797168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605352Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/167ecc9bc53f..f86cf4c2de2f 2020-12-30 perkj@webrtc.org Add support for VideoLayersAllocation for Vp9 scv/ksvc and none scalable If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I60804f001a154608be8b92537a1845e113a4705e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607573Reviewed-by:
-
Wenyu Fu authored
Fix the issue when accepting ToS before native initialized caused UMA reporting to be disabled. Change-Id: Ifc05b8acbdf2da88952297f191f3afb2545374be Bug: 1162308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606602 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#839795}
-
Weiliang Chen authored
This CL fixes two things: it removes the perf metrics HUD in iframes, and it stops flashing of metrics in some cases. R=sadrul Change-Id: I0b6603600c48bffbe6229a11f8798b0bb6ec31d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601218Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#839794}
-
Austin Sullivan authored
Bug: N/A Change-Id: I533db48d7d38b194549a9b283c5a4ce9da51ae0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601636 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Auto-Submit: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#839793}
-
Theo Johnson-kanu authored
Screenshot: https://screenshot.googleplex.com/W2Ko9uaQrXotXvJ.png Bug: 1093185 Change-Id: Icd5dfbb0e3d67e6afedc7707940e3c9cec89f3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606709 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#839792}
-
danakj authored
Currently we have WebContentsImpl and RenderViewHost share responsibility for initializing the RenderWidgetHost that is for a main frame RenderFrameHost, as the logical "ownership" of RenderWidgetHost used to be from the RenderViewHost. While the pointer is still owned there, now each local root RenderFrameHost is responsible for its RenderWidgetHost, and the main frame one should be likewise. This makes RenderFrameCreated() initialize the RenderWidgetHost before calling the delegate. The code used to work in the wrong order because WebContents was also initializing the RenderWidgetHost and/or marking the RenderViewHost as live. Now RenderViewHost will only mark the top-level RenderWidgetHost as live if it will not have a local main frame, in which case the RenderViewHost is still responsible for the very unfortunate semi- dead RenderWidgetHost. We split off a RenderWidgetHostImpl::Init() as InitForPopup() and only call that from WebContents if its a popup widget. We also eliminate branches in RenderWidgetHostImpl that handled its initialize paths being called in multiple orders and for both popups and frames. And we remove the notification back to RenderViewHost that the widget was initialized. The RenderViewHost will call PostRenderViewReady() when the RenderView is created already, and the notice from RenderWidgetHost initialization was causing two calls out to WebContentsObservers. The RenderWidgetHost was notifying the RenderView due to the RenderWidgetHost being "live" is what also marks the RenderViewHost as "live". But since RenderViewHost will either a) call RenderFrameCreated() which will initialize the RenderWdigetHost, or b) set the RenderWidgetHost as live when there is no main frame, we know that the RenderWidgetHost/RenderViewHost are considered "live" when RenderViewCreated() is done, so its PostRenderViewReady() is sufficient. We add plumbing for RenderWidgetHostImpl that mirrors the main frame RenderFrameHostImpl to set a waiting_for_init_ flag, which delays WasShown, SynchronizeVisualProperties, and SendScreenRects IPCs. Once Init() is called on the main frame RenderFrameHost it will also Init() the RenderWidgetHost and unblock those IPCs. We drop code in BackgroundContents saying that we're waiting for the renderer to show the window before we Init(). We were then promptly calling Init() while creating the WebContents, so the whole thing was not doing much. This way we don't try to Init() the WebContents, pretending to be the renderer, before we have created the renderer-side frame/widget objects. This was not possible before, as seen by the CL https://chromium-review.googlesource.com/c/chromium/src/+/2606521, but it is with these changes to sort out the order of Init() for the widget. R=nasko@chromium.org Bug: 1158869 Change-Id: I7d0943a4df20caeedecc8b165aeb1d196b3331a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597851 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#839791}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609329117-c3020fc1a675822543105a1cb9c7edc2d0728727.profdata to chrome-mac-master-1609351142-4bcda9a45834f5931e4d67a63f18aec167e5f993.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1cf28e932f623d51c1fc217cb0bb30516a143754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607571Reviewed-by:
-
Regan Hsu authored
When there is no reception (including no sim), still show the "Enable Hotspot" button, but disable it instead. Provide context to user via tooltip and sublabel the button as "Not Available". This was tested by disabling Google Fi on my dev phone. Screenshot: No service: http://go/tscreen/fdb1d2ad6dd867d78bbd82b81cfd20cf7da69ac6 No SIM: https://screenshot.googleplex.com/Acq4YtHx2tjWfWp Bug: 1159847, 1106937 Change-Id: Ib5dfc852d79e1b3a6be8153e31eced2c20e5e263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606670 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Michael Ludwig authored
The public read functions for different enums followed identical patterns. Within the reader implementation, the paint filters used inconsistent approaches to reading enums (ReadSimple, Read(int), and only sometimes actually checked against a max value). This CL uses ReadEnum to implement the existing public enum functions as one-liners. The paint filter-related enum deserialization is also updated to all use ReadEnum directly (since they are one-offs). These enums have been updated to use the kMaxValue name to take advantage of ReadEnum's default argument. Change-Id: I96326d30aa1ac769ffbc43b93893660bad87887c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606464Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1cc5b3357d2f..ff29e249d317 2020-12-30 srisser@google.com Add support for Vulkan12Properties If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ie94554e3a5c681aba59fe904f60119643c247968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607454Reviewed-by:
-
Stefan Zager authored
Plugins should always manage contents_opaque for themselves. Bug: 1069546 Change-Id: I1bd78379ed1ad8d2424db38305b204d5996b6302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606809Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#839786}
-
danakj authored
The tests are currently binding the FrameWidget interfaces twice instead of binding both the Widget and FrameWidget (and the host sides). R=dcheng@chromium.org TBR=nasko Bug: 1158869 Change-Id: Ia3b0a711ad38097ab0fb24dfd1ddd4559e79f520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605872 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#839785}
-
danakj authored
This changes the hook-up of mac web tests to resize the top level RenderWidgetHostView as soon as the renderer-side objects are created so that the correct screen rects can be sent to the renderer. Previously it was hooked up to the asynchronous RenderViewReady() which made it race with the renderer running the test, a race it happened to win. Now we do it when a) The main RenderFrame is created (along with its renderer-side widget) b) A new window/webcontents is created, and it already has a renderer- side main frame when it is wrapped in a Shell. This will allow us to change the browser-side code notifying about renderer objects being created without breaking these tests in https://chromium-review.googlesource.com/c/chromium/src/+/2597851 . R=dcheng@chromium.org Bug: 1158869 Change-Id: I645d67c705a9390853c052804edbd07eaea91c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606520 Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
-
Jeremy Roman authored
Change-Id: Ie987f109f3a1c243270246b1f13469c57dac33a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607544 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#839783}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609329117-c9d4a574607cda846dea89f6b247c93e314aec7e.profdata to chrome-linux-master-1609351142-dd1a26699eab924687a810625409dd4ac7df6d3b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id42e1a3f23a94ec9cd64662cd2be397216636080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607569Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4f23dec7427b..4ef108e6d17a 2020-12-30 adlai@google.com Reland "Yank out old reduceOpsTaskSplitting code" 2020-12-30 adlai@google.com Reland "Have DDLs honor the reduceOpsTaskSplittingFlag" 2020-12-30 fmalita@chromium.org [svg] Convert text rendering to RSX form If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1146701 Tbr: djsollen@google.com Change-Id: I8027411698d0223746cb5692fe4a47b5c0957e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607455Reviewed-by:
-
Toni Barzic authored
This is a reland of c52857a9 The original cl missed calls to run_loop.Run() in test methods that wrote to a file, and waited for the write to finish. TBR=dats@chromium.org Original change's description: > Observe file modifications in FileChangeService > > Adds OnFileModified observer interface to FileChangeServiceObserver > called when the file is written, truncated, or copied to. > > Fixes file change service unit tests to verify that mocked observer > methods actually get called. The observers were previously not > getting invoked because the test suite did not set up fake chrome > user manager, so user account IDs were not correctly mapped to the > associated test profile, which is something > ObservableFileSystemOperationImpl depends on to get the > FileChangeService to notify of file changes. > > BUG=1139115 > > Change-Id: I9829db0a496eec301a7f7547ac74f61bc1a18bdf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603467 > Reviewed-by: Sergei Datsenko <dats@chromium.org> > Reviewed-by: David Black <dmblack@google.com> > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#839697} Bug: 1139115 Change-Id: I70e23cd1b11c9168ee99d8ed314942d25bd4a004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607415 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#839780}
-
Abigail Klein authored
Do not show the expand/collapse buttons when there is an error, and set the error state to false if the caption bubble starts receiving text. Bug: 1055150 Change-Id: Id5e8a7b4fd93058643673a7707eda22f94baf5dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598619Reviewed-by:
-
Abigail Klein authored
Rather than override the caption bubble's view accessibility with virtual children, override the label's view accessibility with a different AXNode per line. This allows us to take advantage of the views' visibility and bounds--whereas previously we needed to keep track of whether the error was visible or not. This CL also renames functions and variables from virtual_children to ax_lines. It sets the label role to be kParagraph and each ax_line role to be kStaticText. Bug: 1055150 Change-Id: Ic70187b1e0159d4fa012bc44e1ec40b2357717e8 AX-Relnotes: N/A (Feature has not launched) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602660Reviewed-by:
-
Trent Begin authored
This change adds the network health component to the connectivity diagnostics application. This serves as a short summary of the currently connected networks and details about them. Bug: chromium:1142857 Change-Id: Ibfac37e10bd4badc87f234b8f0fd842667fc8a24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587501 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Thomas Lukaszewicz authored
Bug: 1128033 Change-Id: I23c0817a99bd03ae38087174f09ea1bf3aff6da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606631 Auto-Submit: Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#839776}
-
Ian Barkley-Yeung authored
Add browsertest that if a page is loaded as part of a "Continue where you left off" restore, errors from page load are still reported. BUG=chromium:1121816, chromium:1162353 Change-Id: I3c68c5937000fdb5d42893c8ee27aeedc373856f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606719 Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
-
Sky Malice authored
Bug: 1124503 Change-Id: I6a58d7636b5337073d54ac9d5c00863a3eaf160d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584325 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c439cc34ac23..11c7d845479b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tluk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tluk@google.com Change-Id: I34ac0f3c5849478345febb90050ab0f5d4a3ca0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606660Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839773}
-
