GitLab

BUG=505430

Review URL: https://codereview.chromium.org/1245233002

Cr-Commit-Position: refs/heads/master@{#339769}

BUG=475714

Review URL: https://codereview.chromium.org/1250443002

Cr-Commit-Position: refs/heads/master@{#339768}

The problem was that the UI expected that CONTEXT_KEY_KEYBOARD_STATE key
observer is called before CONTEXT_KEY_KEYBOARD_PINCODE observer. In fact, the
order of notifications was never defined. It have changed at some point, which
lead to regression.

BUG=507896
TEST=OobeWebUITest.HIDDetectionScreenTest browser test

Review URL: https://codereview.chromium.org/1243983002

Cr-Commit-Position: refs/heads/master@{#339767}

Switch RenderFrameHostManager to use RenderProcessHostObserver, remove NOTIFICATION_RENDERER_PROCESS_CLOSING.

BUG=170921
TEST=everything still works

Review URL: https://codereview.chromium.org/1245903004

Cr-Commit-Position: refs/heads/master@{#339766}

This is a warning about signed vs. unsigned values in a comparison.  The code in
question was added entirely by a previous patch, so this simply modifies that
patch, and the results of applying it.

Adding an "(unsigned)" C-style cast is a somewhat ugly fix to one location, but
the alternative would be a potentially-vast change to the APIs in question to
change int to unsigned throughout the transitive closure of places that touch
this.  I didn't seriously investigate doing this.

BUG=398202
TEST=none

Review URL: https://codereview.chromium.org/1248763003

Cr-Commit-Position: refs/heads/master@{#339765}

The existing string refers to a checkbox but the iOS ui uses a switch
component that doesn't look like a checkbox. The CL to actually use this
string is still under development but I'd like to get this in the
translation queue.

BUG=484806

Review URL: https://codereview.chromium.org/1233313010

Cr-Commit-Position: refs/heads/master@{#339764}

A race condition is suspected in which the first setNeedsLayout call happens between a layout and a paint for a webview plugin. This change ensures that setNeedsLayout... is called on the plugin's container at initialization, which occurs during the correct document lifecycle position.

TBR=bauerb@chromium.org,tommycli@chromium.org
BUG=493375

Review URL: https://codereview.chromium.org/1244113003

Cr-Commit-Position: refs/heads/master@{#339763}

For some content (e.g. HLS live streams), attempting to seek will get the
media player stuck in an error state. In
https://codereview.chromium.org/22605013, this was addressed by preventing
seeks if the duration of the video is negative. However, with
https://codereview.chromium.org/617743004, a -1 returned by the Android
MediaPlayer will be converted to media::kInfiniteDuration().

This CL utilizes two seek booleans derived from the Android MediaPlayer to
determine if a seek should be allowed.

BUG=510641
TEST=MediaPlayerBridgeTest.*

Review URL: https://codereview.chromium.org/1234483003

Cr-Commit-Position: refs/heads/master@{#339762}

This makes the behavior match native platforms.

BUG=376384
TEST=On linux - press Alt+F, then Up Arrow key, then Enter.
     Expected: The last item "Exit" was selected and invoked, quitting Chrome.

Review URL: https://codereview.chromium.org/1230163004

Cr-Commit-Position: refs/heads/master@{#339761}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/ae3714f..db0b1e7

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=joshualitt@google.com

Commits in this roll:
db0b1e7 hendrikw@chromium.org ANGLE deps roll
0f38612 ericrk@chromium.org Bilinear optimization for 1D convolution.
e59524d caryclark@google.com make mixedtextblobs gm portable
4c4b84c mtklein@chromium.org Clean up more SkXfermode.cpp dead code.
7e7b5c5 joshualitt@chromium.org adding assert to GrAtlasTextContext
cd1930d mtklein@chromium.org De-templatize Sk4pxXfermode code a bit.
c3dcb67 caryclark@google.com make color emoji gm portable
654ad19 mtklein@google.com Revert of De-templatize Sk4pxXfermode code a bit. (patchset #2 id:20001 of https://codereview.chromium.org/1242743004/)
18c58c7 robertphillips@google.com Possible fix Moto E compilation failure
e617e15 mtklein@chromium.org De-templatize Sk4pxXfermode code a bit.
cf2a6a4 msarett@google.com Reenable yasm for Android x86 and x86-64 on Linux host
259fbf1 joshualitt@chromium.org Add sanity check to GrAtlasTextBlob
f6e092a senorblanco@chromium.org Remove SK_LEGACY_IMAGE_FILTER_CROP_RECT_EDGES code.

Review URL: https://codereview.chromium.org/1248003002

Cr-Commit-Position: refs/heads/master@{#339760}

Revert of Parse HPKP report-uri and persist in TransportSecurityPersister (patchset #11 id:200001 of https://codereview.chromium.org/1211363005/)

Reason for revert:
Causes Win7 to hang

Original issue's description:
> Parse HPKP report-uri and persist in TransportSecurityPersister
>
> This CL parses the report-uri attribute on HPKP headers and stores them
> in TransportSecurityPersister.
>
> This is CL #1.
> CL #2: crrev.com/1212973002 (add net::CertificateReportSender)
> CL #3: crrev.com/1212613004 (add net::TransportSecurityReporter)
> CL #4: crrev.com/1213783005 (send HPKP reports)
>
> BUG=445793
>
> Committed: https://crrev.com/1320e36d908427d615357df1630348bfb38cb5c4
> Cr-Commit-Position: refs/heads/master@{#339667}

TBR=davidben@chromium.org,eroman@chromium.org,estark@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=445793

Review URL: https://codereview.chromium.org/1249823002

Cr-Commit-Position: refs/heads/master@{#339759}

BUG=426577

Review URL: https://codereview.chromium.org/1246103003

Cr-Commit-Position: refs/heads/master@{#339758}

- Rewrite it a bit to clean it up and get it working properly again
- The script tracks memory on processes on an Android device

BUG=

Review URL: https://codereview.chromium.org/1228393009

Cr-Commit-Position: refs/heads/master@{#339757}

net::QuicPacket::FecProtectedData.

The following CL handles QuicFramer::BuildDataPacket returning
a nullptr.

  https://codereview.chromium.org/1246793002/

BUG=479880,512446
R=rch@chromium.org

Review URL: https://codereview.chromium.org/1247563002

Cr-Commit-Position: refs/heads/master@{#339756}

In customtabstoolbar we set the left margin of location bar to be the
same size of the security icon. However it the security icon is not
visible, this margin should be reset.

BUG=512161

Review URL: https://codereview.chromium.org/1247513002

Cr-Commit-Position: refs/heads/master@{#339755}

handling_input_event_ needs to be set in RenderWidget::OnImeSetComposition,
otherwise RenderView::DidChangeSelection will skip sending the selection
change message the the browser, even though it was correctly set on the
renderer side.

Also fix incorrectly set selectedRange_ in -setMarkedText,
|newSelRange| is relative to the marked text while selectedRange_ is
relative to the entire text storage.

BUG=500376

Review URL: https://codereview.chromium.org/1240943002

Cr-Commit-Position: refs/heads/master@{#339754}

In many places that iterated over the results, the code was changed to use a range-based for loop over the result of the SplitStirng call.

Review URL: https://codereview.chromium.org/1240183002

Cr-Commit-Position: refs/heads/master@{#339753}

Use PageTransition.LINK when "open image" or "open image in new tab"
is selected from the context menu.

BUG=505430

Review URL: https://codereview.chromium.org/1241263004

Cr-Commit-Position: refs/heads/master@{#339752}

This CL makes InstallerDelegateTest an instrumentation test and moves it to
ChromePublicTest.

BUG=505040
TEST=None
TBR=dfalcantara

Review URL: https://codereview.chromium.org/1228353007

Cr-Commit-Position: refs/heads/master@{#339751}

This change adds some helpers to help readability of these tests,
addressing a review comment from
https://codereview.chromium.org/1235793005/.
It also moves some test statics into an unnamed namespace for style.

R=xhwang@chromium.org

Review URL: https://codereview.chromium.org/1242943003

Cr-Commit-Position: refs/heads/master@{#339750}

Some of the GN tryservers are not yet part of the default
CQ set of bots, but we should be sure to run them anyway
on deps rolls that pull in new GN binaries.

R=brettw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1239943003

Cr-Commit-Position: refs/heads/master@{#339749}

The experiment gave mixed results and is being dropped. Remove the code
supporting it.

BUG=none

Review URL: https://codereview.chromium.org/1247063004

Cr-Commit-Position: refs/heads/master@{#339748}

This patch just adds one DCHECK in order to help diagnose a crash that
seems to happen when we create a resource_pool with a null resource
provider.

R=enne
BUG=419086
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1243773003

Cr-Commit-Position: refs/heads/master@{#339747}

GpuChannel currently calculates current memory usage by iterating over
all stubs and summing their individual memory usage. This results in
double counting as a given stub may share its memory tracker with other
stubs, if they are in a share group.

To avoid double counting, we now iterate over stubs to collect a set of
unique MemoryTrackers, then sum the memory usage of each unique tracker.

BUG=512535

Review URL: https://codereview.chromium.org/1244843004

Cr-Commit-Position: refs/heads/master@{#339746}

To avoid confusion with the ones in mandoline I'm renaming the
html_viewer to be prefixed with html_.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1246053003

Cr-Commit-Position: refs/heads/master@{#339745}

For resources not provided by the native theme (i.e. GTK2UI), fall
back to desktop (not ash) resources by calling MapThemeImage in this
case.

BUG=383711
R=erg@chromium.org
TEST=The shadow running along the top edge of the address bar to the
right of the tabs is visible again, especially when using a bright GTK
theme like Adwaita or Radiance. (see crbug.com/383711)

Review URL: https://codereview.chromium.org/1243513002

Cr-Commit-Position: refs/heads/master@{#339744}

BUG=None

Review URL: https://codereview.chromium.org/1245083005

Cr-Commit-Position: refs/heads/master@{#339743}

Revert of [Andorid] Migrate to ClipDrawable progress bar. (patchset #35 id:670001 of https://codereview.chromium.org/1170843002/)

Reason for revert:
Chrome Shell tests flaky. http://build.chromium.org/p/chromium.linux/builders/Android%20Tests

I think I know where I made a mistake and it should be a simple few line fix but to make sure...

Original issue's description:
> [Andorid] Migrate to ClipDrawable progress bar.
>
> Using ClipDrawable progress bar helps future changes for
> http://crbug.com/461148 as we only need pass to color parameters.
>
> Also it has minor performance benefit.
>
> BUG=466140, 455891, 461148
>
> Committed: https://crrev.com/ee231168bb231ee117485ecd1e7cb16a1f632bae
> Cr-Commit-Position: refs/heads/master@{#339598}

TBR=tedchoc@chromium.org,dtrainor@chromium.org,newt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=466140, 455891, 461148

Review URL: https://codereview.chromium.org/1249793003

Cr-Commit-Position: refs/heads/master@{#339742}

This was accidentally missed in https://chromium.googlesource.com/chromium/src/+/a23713b67ee741e5bb026d99e86b8c97cc9ab84d

BUG=

Review URL: https://codereview.chromium.org/1238623003

Cr-Commit-Position: refs/heads/master@{#339741}

Instead of making a series of calls to it, keep the model in variable
and reuse it.

BUG=None
TEST=unit_tests --gtest_filter=BookmarkBarViewTest.*
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1246833004

Cr-Commit-Position: refs/heads/master@{#339740}

BUG=170921
TEST=everything still works

Review URL: https://codereview.chromium.org/1242953004

Cr-Commit-Position: refs/heads/master@{#339739}

* Defend against SecurityException in AlarmManager (allow retries in Clank to drive to completion when under quota again)
* Misc. code cleanup: removing deprecated fields, removing unused fields, standard template type names, deterministic member order for generated proto code
* Manifest cleanup

BUG=483695

Review URL: https://codereview.chromium.org/1246033002

Cr-Commit-Position: refs/heads/master@{#339738}

The new implementation (CombinedHostListApi) attempts to keep the two
directories in sync and present a merged view of the contents of the
directories.

BUG=503790

Review URL: https://codereview.chromium.org/1217643002

Cr-Commit-Position: refs/heads/master@{#339737}

https://chromium.googlesource.com/angle/angle.git/+log/02df796..01c796a

BUG=483282,510822

TEST=bots

Review URL: https://codereview.chromium.org/1248863002

Cr-Commit-Position: refs/heads/master@{#339736}

The condition wasn't necessary, and can cause problems if server created
nodes don't set the time properly.

BUG=512197

Review URL: https://codereview.chromium.org/1250503002

Cr-Commit-Position: refs/heads/master@{#339735}

BUG=389343

Review URL: https://codereview.chromium.org/1250723002

Cr-Commit-Position: refs/heads/master@{#339734}

BUG=None

Review URL: https://codereview.chromium.org/1249713004

Cr-Commit-Position: refs/heads/master@{#339733}

Most functionality should be in cast_shell_common target for things like
cast_service_unittests to run.

R=slan@chromium.org,halliwell@chromium.org
BUG=internal b/22465963

Review URL: https://codereview.chromium.org/1232313008

Cr-Commit-Position: refs/heads/master@{#339732}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/0278197..ae3714f

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=joshualitt@google.com

Commits in this roll:
ae3714f caryclark@google.com make varied_text* gm portable

Review URL: https://codereview.chromium.org/1250703002

Cr-Commit-Position: refs/heads/master@{#339731}

ConstructWithoutDefaultAdapter, and ConstructFakeAdapter tests
now pass on Mac as well as Android.

BUG=511008

Review URL: https://codereview.chromium.org/1232613004

Cr-Commit-Position: refs/heads/master@{#339730}