GitLab

Make ExecuteSetAlertText() return kInvalidArgument according W3C standard

Bug: chromedriver:2003
Change-Id: Ibd65e8861f0a3f17bb21b54b0d031b88de7dc05c
Reviewed-on: https://chromium-review.googlesource.com/1226794Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591428}

Removed the fixed height of the blue button and corrected the icon
alignment.


Bug: 883316
Change-Id: I2928b0c45e4f4d7873105cddc9fa6b2a1aff6b7d
Reviewed-on: https://chromium-review.googlesource.com/1222727Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Edward Jung <edwardjung@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591427}

In DistillerTest.DistillMultiplePages, the images were added in an
incorrect way, so that there were actually no images in the distilled
results. Therefore, the image data matching in function
VerifyArticleProtoMatchesMultipageData() were never executed.

This was discovered when working on https://crbug.com/864015, and the
lack of coverage was identified here:
https://chromium-coverage.appspot.com/reports/590937/linux/chromium/src/components/dom_distiller/core/distiller_unittest.cc.html

This CL fixes this by constructing the expected distillation
correctly in CreateMultipageDistillerDataWithImages().

Bug: None
Change-Id: Iaf6a1fc81ac956f362ee584d691b066dcde2dab7
Reviewed-on: https://chromium-review.googlesource.com/1226517Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591426}

It's more efficient (avoids a copy), as confirmed by inspecting the
generated assembly.

R=eae@chromium.org,ikilpatrick@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I55a0d9edded65545b2e7404e941f776a3e9978da
Reviewed-on: https://chromium-review.googlesource.com/1226306
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591425}

Bug: 877493
Change-Id: I359348731dfac3a6c952966ef27b23973d40c8b6
Reviewed-on: https://chromium-review.googlesource.com/1225999Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591424}

TBR=kmarshall@chromium.org

Bug: 884260
Change-Id: I47a407077b9ee38a0db8a6710f827cb111d4ab07
Reviewed-on: https://chromium-review.googlesource.com/1227210Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591423}

This test was fixed and is passing as of
https://crrev.com/c/adc4e84b405bdf17be6f602c450586e5a5a9a8ab

Bug: 875097
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I60e11d3a79f087eb255e4144e08f4eb9caa362a8
Reviewed-on: https://chromium-review.googlesource.com/1227145Reviewed-by: Jianpeng Chao <chaopeng@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591422}

There's no pretty way to do this with field trial args and this will
make it much easier to do local testing.

Bug: 864635
Change-Id: I9deeef643291d36733763767eea4cbc2f65a0a3c
Reviewed-on: https://chromium-review.googlesource.com/1226353Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591421}

Target.exposeDevToolsProtocol implementation was attaching the
same client to multiple agent hosts. In fact, we assume there's
a single client per session.

R=dgozman

Change-Id: I780abc7d86612cef977999e6f6319f00722cee1a
Reviewed-on: https://chromium-review.googlesource.com/1221726
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591420}

When the navigation bar is shown we weren't applying the immersive
sticky flag and we really should.

BUG=881738

Change-Id: Ie53918846a5f528b825d9818c574b46b9a61a3d1
Reviewed-on: https://chromium-review.googlesource.com/1227133
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591419}

Add karandeepb@ to extensions API owners, and also add a quick explainer
at the top of the file.

Bug: None
Change-Id: Id03313864c7f3f7e6c4f77a39785eefa283f67b5
Reviewed-on: https://chromium-review.googlesource.com/1226078Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591418}

JavaScript can only be executed on a WebFrame which represents a main frame or an iframe with an encryption key as signified by |CanCallJavaScriptFunction|.

Bug: 881816
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I3831f353b664f8ec8ce80fb47b55660ec6868daa
Reviewed-on: https://chromium-review.googlesource.com/1214803Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591417}

Messages from cross origin iframes are validated using the corresponding frame ids instead of the web state global window id. This allows features the ability to support cross origin iframes instead of only the main frame and same origin iframes.

Bug: 851636
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Idd092efaa4e18ae699a91043f37b304e500f4238
Reviewed-on: https://chromium-review.googlesource.com/1227137
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591416}

no-over-optimization-on-uniform-array-06 is failing consistently.

Bug: 884210
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2cbead8a26e4883b221be9f873f711ba3aeb84ef
Tbr: kbr@chromium.org
No-try: True
Reviewed-on: https://chromium-review.googlesource.com/1226308Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591415}

The previous code would layout each View to be the full
height of the suggestion container and then move them around
at draw time.

BUG=883143

Change-Id: I2d25293042395d75608f2b7cc55399edf8518e57
Reviewed-on: https://chromium-review.googlesource.com/1225215Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591414}

TBR=pdr@chromium.org

Bug: 884239,884240
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iafece0358cf595c3055c481ac7af7368dde110f7
Reviewed-on: https://chromium-review.googlesource.com/1226354
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591413}

This patch marks these new values as "stable" in
runtime_enabled_features.json5.

Intent to ship thread:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/gXXMY1grZ-o/b0y3ENIaCQAJ

Bug: 313888, 854091
Change-Id: I2cb4174e644d338163ad5162c7574aaee75d3abd
Reviewed-on: https://chromium-review.googlesource.com/1226485Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591412}

Because the "homecher" view is now always enabled in tablet mode, it
doesn't make any sense to show a highlight behind the app list button
(which would always be there). Never showing the highlight in tablet
mode is the recommended solution from UX (see linked bug).

Bug: 878957
Change-Id: I0c5de178b6c9a3ad24d3390b645f5f91d034ed0e
Reviewed-on: https://chromium-review.googlesource.com/1226491
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591411}

- cc::TransformNode::flattens_inherited_transform

- ccLayerId and ccContentsLayerId in GraphicsLayerAsJSON for matching
  blink and cc layers

TBR=chrishtr@chromium.org # for trivial change in cc

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I03ce50e44bca724a2d5b6b9a88ce38bc7d2d2835
Reviewed-on: https://chromium-review.googlesource.com/1225871
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591410}

AudioOutputStreamFuchsia was relying on AudioOut::Play() to calculate
stream reference time. When the stream was previously paused Play()
doesn't take into account the current media position, as result
reference_time wasn't calculated correctly (see MTWN-164). Updated the
code to calculate reference_time_ explicitly instead of relying on
AudioOut::Play().

Also added DiscardAllPackets() call in Stop() to discard all buffered
data to avoid playing it when the stream is restarted.

Bug: 882983
Change-Id: I216fd41bfdb3479ea4c8db6523c7e66ce91552cf
Reviewed-on: https://chromium-review.googlesource.com/1220704Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591409}

kEnableReferrers is removed from incognito persistent preferences list
as it is not exposed to UI and cannot be changed from incognito mode.
The tests checking its former behavior are also updated.

Bug: 861722
Change-Id: I357e81482efa41c6436b7ed79c0b84e4e55cfc0b
Reviewed-on: https://chromium-review.googlesource.com/1219609Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591408}

Restore the changes that was incautiously overridden in a refactor cl.
The change initially come from the file assistant_optin_handler.cc in the cl
https://chromium-review.googlesource.com/c/chromium/src/+/1198002.

Bug: None
Test: Manual Test
Change-Id: I5505875c916cbe7de3260a63db232d491228eba4
Reviewed-on: https://chromium-review.googlesource.com/1226611Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591407}

This CL finishes the video thumbnail pipeline for most codec except
vp8, vp9. Now it's ready to hook to the UI frontend. It does following:

1. Render the video frame with existing media toolkit, which can read
back pixel data from a texture in GPU process.

2. Plumbs a few metadata fields and thumbnail bitmap to Java layer.

Bug: 826021
Change-Id: Id6635975726f4b12ab51e01cb6b3e78a198632f4
Reviewed-on: https://chromium-review.googlesource.com/1222694Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591406}

Change-Id: Id68c456d354ecae820de360d6c7a4b9ba8754eb7
Reviewed-on: https://chromium-review.googlesource.com/1226622Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591405}

P2P sockets destroy themselves on errors, but there were some cases when
they would still access themselves after an error has occured. Some, but
not all of these issues were addressed in crrev.com/590539. This CL
addresses remaining problems. Particularly errors from
P2PSocketTcpBase::OnPacket() were not handled properly.

Also updated unittests to destroy sockets, to make it possible to catch
these issues in tests in the future.

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I9cae97c5715f199c3f6dbccd3fbcd687e276a325
Bug: 884242
Reviewed-on: https://chromium-review.googlesource.com/1220676
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Oskar Sundbom <ossu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591404}

The removed code was originally used to make shelf remain transparent
for fullscreen backdrop window [1]. Now the shelf is no longer
transparent, it should be removed.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/606706

Bug: b/79201599
Change-Id: Ic5b214cc714a7699d8ea4fda1a059a7d03104f6c
Reviewed-on: https://chromium-review.googlesource.com/1224640Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591403}

Blacklist this flaky test for single_process_mash_browser_test.
Keyboard overlay is slated to be removed soon.

Bug: 884216
Test: verify filter file locally
Change-Id: I48c7cc0de3648c9a5445d502f3fe08f436631605
Reviewed-on: https://chromium-review.googlesource.com/1227139Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591402}

Bug: 813631
Change-Id: Ib179df82faf2052e86a7c1a26994eff4d9f0ab45
Reviewed-on: https://chromium-review.googlesource.com/1226355Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591401}

This was a premature optimization.  We don't need to guard it, because
the TRACE_EVENT_* macros are smart enough to avoid evaluating their args
if we're not actually tracing.

It will be good if we can use canary builds to capture traces with jank
regions.

Bug: 581518
Change-Id: I320eff45154c2d156c9c64e9877e40358b779d9d
Reviewed-on: https://chromium-review.googlesource.com/1224463Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591400}

https://pdfium.googlesource.com/pdfium.git/+log/7a956edb6b53..7557e7b0efc0


git log 7a956edb6b53..7557e7b0efc0 --date=short --no-merges --format='%ad %ae %s'
2018-09-14 thestig@chromium.org Add basic tests for some annotation APIs.


Created with:
  gclient setdep -r src/third_party/pdfium@7557e7b0efc0

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I27c5ea6c41c0bedb620ee1abff24d50e25195d83
Reviewed-on: https://chromium-review.googlesource.com/1226385Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#591399}

This patch adds a missing call to onUpdateAnimation.

Bug: 884111
Change-Id: Ib0da2dd284348970b98a166abaa7b7e7a8bc471b
Reviewed-on: https://chromium-review.googlesource.com/1226919Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591398}

This is a temporary fix to ensure that there will be no crash at
TouchActionFilter::ReportTouchAction when the |scrolling_touch_action_|
has no value.

TBR=nzolghadr@chromium.org

Bug: 879511
Change-Id: I007efc418c6169bc4ca91e9ac3d8e1627a8f2a4c
Reviewed-on: https://chromium-review.googlesource.com/1226823Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591397}

Using wpt-import in Chromium 97a91779.
With Chromium commits locally applied on WPT:
eebc4d85 "DOMWindowTimers::setTimeout and setInterval modified to accept Trusted Types."
f8019d26 "Amend pointerevent tests so they are stable while the test is executing"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24695

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=markdittmer

No-Export: true
Change-Id: Ibb35b458568baa966a19d694c7e5d9fb06bbf6f6
Reviewed-on: https://chromium-review.googlesource.com/1226102
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591396}

This accidentally disappeared in crrev.com/c/1224115 :)

Bug: 867421
Change-Id: Ib77fc096ffd4bd98f134107180a020d9f829db7f
Reviewed-on: https://chromium-review.googlesource.com/1225763Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591395}

Regular upgrade to current VR keyboard release version.

TBR=bajones@chromuim.org

Change-Id: I02cd2e6dbdc316387461c1f2c0ae3380051ee1dc
Reviewed-on: https://chromium-review.googlesource.com/1226356Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591394}

The CSS scanning optimization has been removed, so these metrics
aren't being recorded anymore.

Bug: None
Change-Id: I4f10216e45962c4c75c440518a1f13721e684361
Reviewed-on: https://chromium-review.googlesource.com/1222626Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591393}

Regular upgrade to the current release version of ArCore.

TBR=vollick@chromium.org

Change-Id: I48dcf2c0cacbc0e09384c412889a898d852fcf88
Reviewed-on: https://chromium-review.googlesource.com/1226359Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591392}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8f8f600c..dba95ab0

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I7daaa30a2ef2d2b0a257d9cc1f17816bb1f559dc
Reviewed-on: https://chromium-review.googlesource.com/1226016Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#591391}

Main motivation here is to have dex method counts easy to see.

Change-Id: I51291bc77c233a0c3115b07bc99579ba2489d4eb
Reviewed-on: https://chromium-review.googlesource.com/1226525
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591390}

Adds the ability for the native and Java versions of EmbeddedTestServer
to be started using a specified port instead of always using an auto
selected one.

The use case that prompted this is pixel tests in VR, which need to use
the test server (instead of file URLs) in order to grant permissions to
pages, but need the URL to remain constant so that captured images
don't differ between test runs.

Bug: 883940
Change-Id: I7c0fa1a86cdf15d0e3271de6722d315a0191327a
Reviewed-on: https://chromium-review.googlesource.com/1225304Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591389}